5130-arc_counter #2

Merged
alexm merged 5 commits from 5130-arc_counter into dev 2023-02-06 08:59:03 +00:00
4 changed files with 18 additions and 10 deletions
Showing only changes of commit 00262e5dd0 - Show all commits

View File

@ -1,13 +1,12 @@
import con from '../db/connect.js';
import counter from './counter.js';
import t from '../util/translator.js';
export default async(rfids, arcId) => {
console.logger.info('PRINTING...');
console.log([Array.from(rfids), arcId, null]);
await con.query(`CALL vn.expeditionPallet_build(JSON_ARRAY(?), ?, ?, @palletId);`, [Array.from(rfids), arcId, null]);
const [[{palletId}]] = await con.query(`SELECT @palletId as palletId;`);
await counter(null, arcId);
alexm marked this conversation as resolved Outdated
Outdated
Review

Que traduzca el error tambien

Que traduzca el error tambien
if (!palletId)
console.logger.error({error: 'ERROR_CREATING_PALLET', expeditions: rfids});
try {
await con.query(`CALL vn.expeditionPallet_build(JSON_ARRAY(?), ?, ?, @palletId);`, [Array.from(rfids), arcId, null]);
await counter(null, arcId);
alexm marked this conversation as resolved Outdated
Outdated
Review

No fa falta seleccionar el id pallet per saber si ha donat error, deuría de ficarse un try { } catch ... en la crida a vn.expeditionPallet_build

No fa falta seleccionar el id pallet per saber si ha donat error, deuría de ficarse un `try { } catch ...` en la crida a `vn.expeditionPallet_build`
} catch (error) {
await con.query(`UPDATE vn.arcRead SET error = ?, counter = NULL WHERE id = ?;`, [t(error.sqlMessage), arcId]);
}
};
alexm marked this conversation as resolved Outdated
Outdated
Review

Ficar dins del catch anterior

Ficar dins del catch anterior

View File

@ -16,7 +16,7 @@ export default async(conf, cb) => {
stream
.on('data', async value => {
const parsed = await rfidParser(value);
console.log(parsed.codes);
alexm marked this conversation as resolved Outdated
Outdated
Review

Has oblidat llevar este console.log? Plenara el log del servidor de ruido

Has oblidat llevar este console.log? Plenara el log del servidor de ruido
if (!parsed.codes.size) return;
rfidbuffer = new Set([...rfidbuffer, ...parsed.codes]);
rfidbufferExtend = rfidbufferExtend.concat(parsed.extended);
@ -37,7 +37,7 @@ export default async(conf, cb) => {
});
function createPallet() {
clearTimeout(interval); // try remove
clearTimeout(interval);
newPallet(rfidbuffer, conf.arcId);

1
util/locale/es.yml Normal file
View File

@ -0,0 +1 @@
TRUCK_NOT_AVAILABLE: No hay un camión disponible

8
util/translator.js Normal file
View File

@ -0,0 +1,8 @@
import yml from 'require-yml';
import path from 'path';
export default function t(expression) {
const {pathname: root} = new URL('./locale', import.meta.url);
let es = yml(path.join(root, 'es.yml')) || {};
return es[expression] || expression;
}