From 1889aa85b5bb755aa5d88a7c3abd72531d6f2b6d Mon Sep 17 00:00:00 2001
From: Jon <jon@verdnatura.es>
Date: Wed, 4 Sep 2024 11:49:49 +0200
Subject: [PATCH] refactor: refs #7553 deleted expedition code and slot in
 VnTable

---
 src/components/VnTable/VnTable.vue         |  5 +++--
 src/pages/Ticket/Card/TicketExpedition.vue | 18 +-----------------
 src/pages/Ticket/locale/en.yml             |  3 ++-
 src/pages/Ticket/locale/es.yml             |  5 +++--
 4 files changed, 9 insertions(+), 22 deletions(-)

diff --git a/src/components/VnTable/VnTable.vue b/src/components/VnTable/VnTable.vue
index 9a5b748ba..5367ce4c9 100644
--- a/src/components/VnTable/VnTable.vue
+++ b/src/components/VnTable/VnTable.vue
@@ -408,11 +408,12 @@ defineExpose({
                         @click="stateStore.toggleRightDrawer()"
                     />
                 </template>
-                <template #top>
+                <!--TODO: este slot se carga los botones de mostrar tabla/card y columnas visibles-->
+                <!-- <template #top>
                     <div class="full-width-slot">
                         <slot name="before-header" />
                     </div>
-                </template>
+                </template> -->
                 <template #header-cell="{ col }">
                     <QTh v-if="col.visible ?? true">
                         <div
diff --git a/src/pages/Ticket/Card/TicketExpedition.vue b/src/pages/Ticket/Card/TicketExpedition.vue
index cbbbfdee1..4becb3db3 100644
--- a/src/pages/Ticket/Card/TicketExpedition.vue
+++ b/src/pages/Ticket/Card/TicketExpedition.vue
@@ -4,7 +4,6 @@ import { useI18n } from 'vue-i18n';
 import { useRoute } from 'vue-router';
 
 import ItemDescriptorProxy from 'src/pages/Item/Card/ItemDescriptorProxy.vue';
-import TableVisibleColumns from 'src/components/common/TableVisibleColumns.vue';
 import VnSubToolbar from 'src/components/ui/VnSubToolbar.vue';
 import ExpeditionNewTicket from './ExpeditionNewTicket.vue';
 import WorkerDescriptorProxy from 'src/pages/Worker/Card/WorkerDescriptorProxy.vue';
@@ -28,7 +27,6 @@ const tableRef = ref();
 const expeditionsLogsData = ref([]);
 const selectedExpeditions = ref([]);
 const allColumnNames = ref([]);
-const visibleColumns = ref([]);
 const newTicketWithRoute = ref(false);
 const selectedRows = ref([]);
 const hasSelectedRows = computed(() => selectedRows.value.length > 0);
@@ -245,14 +243,6 @@ onUnmounted(() => (stateStore.rightDrawer = false));
 
 <template>
     <VnSubToolbar>
-        <template #st-data>
-            <TableVisibleColumns
-                :all-columns="allColumnNames"
-                table-code="expeditionIndex"
-                labels-traductions-path="expedition"
-                @on-config-saved="visibleColumns = [...$event, 'history']"
-            />
-        </template>
         <template #st-actions>
             <QBtnGroup push class="q-gutter-x-sm" flat>
                 <QBtnDropdown
@@ -303,7 +293,7 @@ onUnmounted(() => (stateStore.rightDrawer = false));
                         )
                     "
                 >
-                    <QTooltip>{{ t('Delete expedition') }}</QTooltip>
+                    <QTooltip>{{ t('expedition.removeExpedition') }}</QTooltip>
                 </QBtn>
             </QBtnGroup>
         </template>
@@ -320,7 +310,6 @@ onUnmounted(() => (stateStore.rightDrawer = false));
             'row-key': 'id',
             selection: 'multiple',
         }"
-        default-mode="table"
         auto-load
         order="created DESC"
     >
@@ -366,8 +355,3 @@ onUnmounted(() => (stateStore.rightDrawer = false));
         </QTable>
     </QDialog>
 </template>
-
-<i18n>
-es:
-    Delete expedition: Eliminar expedición
-</i18n>
diff --git a/src/pages/Ticket/locale/en.yml b/src/pages/Ticket/locale/en.yml
index b2626faa3..7629633c8 100644
--- a/src/pages/Ticket/locale/en.yml
+++ b/src/pages/Ticket/locale/en.yml
@@ -106,7 +106,7 @@ expedition:
     name: Name
     packageType: Package type
     counter: Counter
-    externalId: externalId
+    externalId: external Id
     created: Created
     state: State
     historyAction: Status log
@@ -122,6 +122,7 @@ expedition:
     isScanned: Is scanned
     yes: Yes
     no: No
+    removeExpedition: Delete expedition
 basicData:
     next: Next
     back: Back
diff --git a/src/pages/Ticket/locale/es.yml b/src/pages/Ticket/locale/es.yml
index 879870b78..2e7dc4d1c 100644
--- a/src/pages/Ticket/locale/es.yml
+++ b/src/pages/Ticket/locale/es.yml
@@ -193,9 +193,9 @@ expedition:
     id: Expedición
     item: Artículo
     name: Nombre
-    packageType: Package type
+    packageType: Embalaje
     counter: Contador
-    externalId: externalId
+    externalId: ID externo
     created: Fecha creación
     state: Estado
     historyAction: Historial de estados
@@ -211,6 +211,7 @@ expedition:
     isScanned: Escaneado
     yes: Sí
     no: No
+    removeExpedition: Eliminar expedición
 package:
     package: Embalaje
     quantity: Cantidad