From 1e1032b3da746e0ad3fa3728ad18d67b4d020e98 Mon Sep 17 00:00:00 2001
From: Jon <jon@verdnatura.es>
Date: Thu, 5 Dec 2024 11:00:40 +0100
Subject: [PATCH] refactor: refs #8194 structure changes in component and
 related files

---
 src/components/common/VnSelectWorker.vue      | 75 ++++++-------------
 src/pages/Customer/Card/CustomerBasicData.vue | 18 +----
 src/pages/Customer/CustomerFilter.vue         |  5 --
 src/pages/Customer/CustomerList.vue           |  7 +-
 .../Department/Card/DepartmentBasicData.vue   |  4 -
 src/pages/Item/ItemRequestFilter.vue          |  7 +-
 .../Monitor/Ticket/MonitorTicketFilter.vue    | 20 +++--
 src/pages/Order/Card/OrderFilter.vue          |  5 --
 src/pages/Route/Card/RouteFilter.vue          |  5 --
 src/pages/Route/Card/RouteForm.vue            | 10 +--
 src/pages/Supplier/Card/SupplierBasicData.vue |  5 --
 .../Ticket/Card/TicketCreateTracking.vue      | 10 +--
 src/pages/Worker/WorkerCreate.vue             |  4 -
 src/pages/Worker/WorkerList.vue               |  6 +-
 14 files changed, 44 insertions(+), 137 deletions(-)

diff --git a/src/components/common/VnSelectWorker.vue b/src/components/common/VnSelectWorker.vue
index 26406b47a..208e8924a 100644
--- a/src/components/common/VnSelectWorker.vue
+++ b/src/components/common/VnSelectWorker.vue
@@ -1,48 +1,10 @@
 <script setup>
 import { computed } from 'vue';
-import { useI18n } from 'vue-i18n';
 import VnSelect from 'components/common/VnSelect.vue';
 import VnAvatar from 'src/components/ui/VnAvatar.vue';
 
-const { t } = useI18n();
 const emit = defineEmits(['update:modelValue']);
 const $props = defineProps({
-    modelValue: {
-        type: [String, Number, Object],
-        default: null,
-    },
-    label: {
-        type: String,
-        required: true,
-    },
-    url: {
-        type: String,
-        required: true,
-    },
-    optionValue: {
-        type: String,
-        default: 'id',
-    },
-    optionLabel: {
-        type: String,
-        default: 'name',
-    },
-    fields: {
-        type: Array,
-        default: null,
-    },
-    params: {
-        type: Object,
-        default: null,
-    },
-    sortBy: {
-        type: String,
-        default: null,
-    },
-    exprBuilder: {
-        type: Function,
-        default: null,
-    },
     hasAvatar: {
         type: Boolean,
         default: false,
@@ -51,9 +13,13 @@ const $props = defineProps({
         type: Boolean,
         default: false,
     },
-    noOne: {
-        type: Boolean,
-        default: false,
+    modelValue: {
+        type: [String, Number, Object],
+        default: null,
+    },
+    params: {
+        type: Object,
+        default: null,
     },
 });
 
@@ -69,24 +35,27 @@ const value = computed({
 
 <template>
     <VnSelect
-        :label="t($props.label)"
+        v-bind="$attrs"
         v-model="value"
-        :url="$props.url"
-        :option-value="$props.optionValue"
-        :option-label="$props.optionLabel"
-        :fields="$props.fields"
+        :url="
+            $props.params
+                ? `Workers/search?departmentCodes=${JSON.stringify(
+                      $props.params.departmentCodes
+                  )}`
+                : 'Workers/search'
+        "
+        option-value="id"
+        option-label="nickname"
+        :fields="['id', 'name', 'nickname', 'code']"
+        sort-by="name ASC"
         :params="$props.params"
-        :sort-by="$props.sortBy"
-        :expr-builder="$props.exprBuilder"
-        :no-one="$props.noOne"
-        hide-selected
     >
-        <template #prepend v-if="hasAvatar">
+        <template #prepend v-if="$props.hasAvatar">
             <VnAvatar :worker-id="value" color="primary" :title="title" />
         </template>
-        <template #append v-if="hasInfo">
+        <template #append v-if="$props.hasInfo">
             <QIcon name="info" class="cursor-pointer">
-                <QTooltip>{{ t('Responsible for approving invoices') }}</QTooltip>
+                <QTooltip>{{ $t('Responsible for approving invoices') }}</QTooltip>
             </QIcon>
         </template>
         <template #option="scope">
diff --git a/src/pages/Customer/Card/CustomerBasicData.vue b/src/pages/Customer/Card/CustomerBasicData.vue
index e7c03bf5c..80e8f5b35 100644
--- a/src/pages/Customer/Card/CustomerBasicData.vue
+++ b/src/pages/Customer/Card/CustomerBasicData.vue
@@ -8,7 +8,6 @@ import FormModel from 'components/FormModel.vue';
 import VnRow from 'components/ui/VnRow.vue';
 import VnInput from 'src/components/common/VnInput.vue';
 import VnSelect from 'src/components/common/VnSelect.vue';
-import VnAvatar from 'src/components/ui/VnAvatar.vue';
 import VnSelectWorker from 'src/components/common/VnSelectWorker.vue';
 
 const route = useRoute();
@@ -16,7 +15,6 @@ const { t } = useI18n();
 
 const businessTypes = ref([]);
 const contactChannels = ref([]);
-const title = ref();
 const handleSalesModelValue = (val) => ({
     or: [
         { id: val },
@@ -107,28 +105,14 @@ const exprBuilder = (param, value) => {
                 <VnSelectWorker
                     :label="t('customer.summary.salesPerson')"
                     v-model="data.salesPersonFk"
-                    :url="'Workers/search'"
-                    :option-value="'id'"
-                    :option-label="'nickname'"
-                    :fields="['id', 'name', 'nickname']"
                     :params="{
                         departmentCodes: ['VT', 'shopping'],
                     }"
-                    :sort-by="'nickname ASC'"
                     :has-avatar="true"
                     :rules="validate('client.salesPersonFk')"
                     :expr-builder="exprBuilder"
                     emit-value
-                    auto-load
-                >
-                    <template #prepend>
-                        <VnAvatar
-                            :worker-id="data.salesPersonFk"
-                            color="primary"
-                            :title="title"
-                        />
-                    </template>
-                </VnSelectWorker>
+                />
                 <VnSelect
                     v-model="data.contactChannelFk"
                     :options="contactChannels"
diff --git a/src/pages/Customer/CustomerFilter.vue b/src/pages/Customer/CustomerFilter.vue
index 765a718cd..2b74a659b 100644
--- a/src/pages/Customer/CustomerFilter.vue
+++ b/src/pages/Customer/CustomerFilter.vue
@@ -69,14 +69,9 @@ const exprBuilder = (param, value) => {
                     <VnSelectWorker
                         :label="t('Salesperson')"
                         v-model="params.salesPersonFk"
-                        :url="'Workers/search'"
-                        :option-value="'id'"
-                        :option-label="'name'"
-                        :fields="['id', 'name', 'nickname']"
                         :params="{
                             departmentCodes: ['VT'],
                         }"
-                        :sort-by="'nickname ASC'"
                         :expr-builder="exprBuilder"
                         @update:model-value="searchFn()"
                         emit-value
diff --git a/src/pages/Customer/CustomerList.vue b/src/pages/Customer/CustomerList.vue
index af73e6554..6d6599b9c 100644
--- a/src/pages/Customer/CustomerList.vue
+++ b/src/pages/Customer/CustomerList.vue
@@ -424,17 +424,14 @@ function handleLocation(data, location) {
             <VnSelectWorker
                 :label="t('customer.summary.salesPerson')"
                 v-model="data.salesPersonFk"
-                :url="'Workers/search'"
-                :option-value="'id'"
-                :option-label="'nickname'"
-                :fields="['id', 'name', 'nickname']"
                 :params="{
                     departmentCodes: ['VT', 'shopping'],
                 }"
-                :sort-by="'nickname ASC'"
                 :has-avatar="true"
+                :id-value="data.salesPersonFk"
                 emit-value
                 auto-load
+                option-label="nickname"
             />
             <VnLocation
                 :acls="[{ model: 'Province', props: '*', accessType: 'WRITE' }]"
diff --git a/src/pages/Department/Card/DepartmentBasicData.vue b/src/pages/Department/Card/DepartmentBasicData.vue
index 314a9f2fe..22ce06821 100644
--- a/src/pages/Department/Card/DepartmentBasicData.vue
+++ b/src/pages/Department/Card/DepartmentBasicData.vue
@@ -52,10 +52,6 @@ const { t } = useI18n();
                 <VnSelectWorker
                     :label="t('department.bossDepartment')"
                     v-model="data.workerFk"
-                    :url="'Workers/search'"
-                    :option-value="'id'"
-                    :option-label="'name'"
-                    :fields="['id', 'name', 'nickname']"
                     :rules="validate('department.workerFk')"
                 />
                 <VnSelect
diff --git a/src/pages/Item/ItemRequestFilter.vue b/src/pages/Item/ItemRequestFilter.vue
index db9316277..83758fd79 100644
--- a/src/pages/Item/ItemRequestFilter.vue
+++ b/src/pages/Item/ItemRequestFilter.vue
@@ -148,13 +148,8 @@ const decrement = (paramsObj, key) => {
                 <QItemSection>
                     <VnSelectWorker
                         :label="t('params.requesterFk')"
-                        v-model="params.requesterFkk"
-                        :url="'Workers/search'"
-                        :option-value="'id'"
-                        :option-label="'name'"
-                        :fields="['id', 'name', 'nickname']"
+                        v-model="params.requesterFk"
                         @update:model-value="searchFn()"
-                        :sort-by="'name ASC'"
                         :params="{ departmentCodes: ['VT'] }"
                         dense
                         outlined
diff --git a/src/pages/Monitor/Ticket/MonitorTicketFilter.vue b/src/pages/Monitor/Ticket/MonitorTicketFilter.vue
index 7f232426d..3d8fd1174 100644
--- a/src/pages/Monitor/Ticket/MonitorTicketFilter.vue
+++ b/src/pages/Monitor/Ticket/MonitorTicketFilter.vue
@@ -115,13 +115,23 @@ const getLocale = (label) => {
                         rounded
                         :label="t('globals.params.salesPersonFk')"
                         v-model="params.salesPersonFk"
-                        :url="'Workers/search'"
-                        :option-value="'id'"
-                        :option-label="'name'"
-                        :fields="['id', 'name', 'nickname']"
                         :params="{ departmentCodes: ['VT'] }"
                         :no-one="true"
-                    />
+                    >
+                        <template #option="{ opt, itemProps }">
+                            <QItem v-bind="itemProps">
+                                <QItemSection>
+                                    <QItemLabel>{{ opt.name }}</QItemLabel>
+                                    <QItemLabel
+                                        v-if="opt.code"
+                                        class="text-grey text-caption"
+                                    >
+                                        {{ `${opt.nickname}, ${opt.code}` }}
+                                    </QItemLabel>
+                                </QItemSection>
+                            </QItem>
+                        </template>
+                    </VnSelectWorker>
                 </QItemSection>
             </QItem>
             <QItem>
diff --git a/src/pages/Order/Card/OrderFilter.vue b/src/pages/Order/Card/OrderFilter.vue
index 42359febe..66de9eaa1 100644
--- a/src/pages/Order/Card/OrderFilter.vue
+++ b/src/pages/Order/Card/OrderFilter.vue
@@ -65,11 +65,6 @@ const sourceList = ref([]);
                 <VnSelectWorker
                     :label="t('globals.salesPerson')"
                     v-model="params.workerFk"
-                    :url="'Workers/search'"
-                    :option-value="'id'"
-                    :option-label="'nickname'"
-                    :fields="['id', 'name', 'nickname']"
-                    :sort-by="'nickname ASC'"
                     dense
                     outlined
                     rounded
diff --git a/src/pages/Route/Card/RouteFilter.vue b/src/pages/Route/Card/RouteFilter.vue
index 94e4570a3..2e429aba8 100644
--- a/src/pages/Route/Card/RouteFilter.vue
+++ b/src/pages/Route/Card/RouteFilter.vue
@@ -35,11 +35,6 @@ const emit = defineEmits(['search']);
                     <VnSelectWorker
                         :label="t('Worker')"
                         v-model="params.workerFk"
-                        :url="'Workers/search'"
-                        :option-value="'id'"
-                        :option-label="'nickname'"
-                        :fields="['id', 'name', 'nickname']"
-                        :sort-by="'nickname ASC'"
                         dense
                         outlined
                         rounded
diff --git a/src/pages/Route/Card/RouteForm.vue b/src/pages/Route/Card/RouteForm.vue
index dfbfdc788..f323ccc3b 100644
--- a/src/pages/Route/Card/RouteForm.vue
+++ b/src/pages/Route/Card/RouteForm.vue
@@ -95,15 +95,7 @@ const onSave = (data, response) => {
     >
         <template #form="{ data }">
             <VnRow>
-                <VnSelectWorker
-                    :label="t('worker')"
-                    v-model="data.workerFk"
-                    :url="'Workers/search'"
-                    :option-value="'id'"
-                    :option-label="'nickname'"
-                    :fields="['id', 'name', 'nickname']"
-                    :sort-by="'nickname ASC'"
-                />
+                <VnSelectWorker :label="t('worker')" v-model="data.workerFk" />
                 <VnSelect
                     :label="t('Vehicle')"
                     v-model="data.vehicleFk"
diff --git a/src/pages/Supplier/Card/SupplierBasicData.vue b/src/pages/Supplier/Card/SupplierBasicData.vue
index afd888c54..d74510eff 100644
--- a/src/pages/Supplier/Card/SupplierBasicData.vue
+++ b/src/pages/Supplier/Card/SupplierBasicData.vue
@@ -34,11 +34,6 @@ const companySizes = [
                 <VnSelectWorker
                     :label="t('supplier.basicData.workerFk')"
                     v-model="data.workerFk"
-                    :url="'Workers/search'"
-                    :option-value="'id'"
-                    :option-label="'name'"
-                    :fields="['id', 'name', 'nickname']"
-                    :sort-by="'nickname ASC'"
                     :has-info="true"
                     :rules="validate('supplier.workerFk')"
                 />
diff --git a/src/pages/Ticket/Card/TicketCreateTracking.vue b/src/pages/Ticket/Card/TicketCreateTracking.vue
index afcc42653..74fbfa4a8 100644
--- a/src/pages/Ticket/Card/TicketCreateTracking.vue
+++ b/src/pages/Ticket/Card/TicketCreateTracking.vue
@@ -47,15 +47,7 @@ const onStateFkChange = (formData) => (formData.userFk = user.value.id);
                     option-label="name"
                     option-value="id"
                 />
-                <VnSelectWorker
-                    :label="t('expedition.worker')"
-                    v-model="data.userFk"
-                    :url="'Workers/search'"
-                    :option-value="'id'"
-                    :option-label="'name'"
-                    :fields="['id', 'name', 'nickname']"
-                    :sort-by="'name ASC'"
-                />
+                <VnSelectWorker :label="t('expedition.worker')" v-model="data.userFk" />
             </VnRow>
         </template>
     </FormModelPopup>
diff --git a/src/pages/Worker/WorkerCreate.vue b/src/pages/Worker/WorkerCreate.vue
index e9b6b2060..a4c6c2a06 100644
--- a/src/pages/Worker/WorkerCreate.vue
+++ b/src/pages/Worker/WorkerCreate.vue
@@ -153,10 +153,6 @@ async function autofillBic(worker) {
                     <VnSelectWorker
                         :label="t('worker.summary.boss')"
                         v-model="data.bossFk"
-                        :url="'Workers/search'"
-                        :option-value="'id'"
-                        :option-label="'name'"
-                        :fields="['id', 'name', 'nickname']"
                         :rules="validate('Worker.boss')"
                     />
                 </VnRow>
diff --git a/src/pages/Worker/WorkerList.vue b/src/pages/Worker/WorkerList.vue
index d7ef805e4..907d50298 100644
--- a/src/pages/Worker/WorkerList.vue
+++ b/src/pages/Worker/WorkerList.vue
@@ -15,10 +15,10 @@ import VnSelectDialog from 'src/components/common/VnSelectDialog.vue';
 import CreateBankEntityForm from 'src/components/CreateBankEntityForm.vue';
 import FetchData from 'src/components/FetchData.vue';
 import RightMenu from 'src/components/common/RightMenu.vue';
-import VnSelectWorker from 'src/components/common/VnSelectWorker.vue';
 import WorkerFilter from './WorkerFilter.vue';
 import { useState } from 'src/composables/useState';
 import axios from 'axios';
+import VnSelectWorker from 'src/components/common/VnSelectWorker.vue';
 
 const { t } = useI18n();
 const tableRef = ref();
@@ -264,10 +264,6 @@ async function autofillBic(worker) {
                     <VnSelectWorker
                         :label="t('worker.summary.boss')"
                         v-model="data.bossFk"
-                        :url="'Workers/search'"
-                        :option-value="'id'"
-                        :option-label="'name'"
-                        :fields="['id', 'name', 'nickname']"
                     />
                 </VnRow>
                 <VnRow>