From 24c62b453362385231f89e20ad820d8af857c335 Mon Sep 17 00:00:00 2001
From: Javier Segarra <jsegarra@verdnatura.es>
Date: Sun, 26 Jan 2025 03:16:25 +0100
Subject: [PATCH] perf: refs #7826 improve condition

---
 src/boot/quasar.js        |  6 +-----
 src/components/NavBar.vue |  3 ++-
 src/router/index.js       | 31 +++++++++----------------------
 3 files changed, 12 insertions(+), 28 deletions(-)

diff --git a/src/boot/quasar.js b/src/boot/quasar.js
index 5a3e8bb296b..54751768235 100644
--- a/src/boot/quasar.js
+++ b/src/boot/quasar.js
@@ -10,11 +10,7 @@ import { useCau } from 'src/composables/useCau';
 export default boot(({ app }) => {
     QForm.mixins = [qFormMixin];
     QLayout.mixins = [mainShortcutMixin];
-    const metaVersion = process.env.BUILD_VERSION;
-    const storedVersion = localStorage.getItem('appVersion');
-    if (metaVersion !== storedVersion) {
-        localStorage.setItem('appVersion', metaVersion);
-    }
+
     app.directive('shortcut', keyShortcut);
     app.config.errorHandler = async (error) => {
         let message;
diff --git a/src/components/NavBar.vue b/src/components/NavBar.vue
index 153f2f4da39..c6f2375cf79 100644
--- a/src/components/NavBar.vue
+++ b/src/components/NavBar.vue
@@ -20,6 +20,7 @@ const appName = 'Lilium';
 const pinnedModulesRef = ref();
 
 onMounted(() => stateStore.setMounted());
+const refresh = () => window.location.reload();
 </script>
 <template>
     <QHeader color="white" elevated>
@@ -71,7 +72,7 @@ onMounted(() => stateStore.setMounted());
                     size="md"
                     color="red"
                     v-if="state.get('error')"
-                    @click="() => window.location.reload()"
+                    @click="refresh"
                 />
                 <QBtn
                     :class="{ 'q-pa-none': quasar.platform.is.mobile }"
diff --git a/src/router/index.js b/src/router/index.js
index 9d56c96c6b6..ce231406575 100644
--- a/src/router/index.js
+++ b/src/router/index.js
@@ -14,8 +14,6 @@ import { useTokenConfig } from 'src/composables/useTokenConfig';
 import { useAcl } from 'src/composables/useAcl';
 import { isLoggedIn } from 'src/utils/session';
 import { useSession } from 'src/composables/useSession';
-import { Notify } from 'quasar';
-import { useStateStore } from 'stores/useStateStore';
 
 let session = null;
 const { t, te } = i18n.global;
@@ -101,29 +99,18 @@ export default defineRouter(function (/* { store, ssrContext } */) {
 
             title += builtTitle;
         }
-        setTimeout(() => {
-            state.set('error', true);
-        }, 1000);
         document.title = title;
     });
 
-    Router.onError((error, to) => {
-        if (
-            error.message.includes('Failed to fetch dynamically imported module') ||
-            error.message.includes('Importing a module script failed')
-        ) {
-            state.set('error', {
-                message: t('globals.errorLoadingPage'),
-                timeout: 5000,
-                type: 'negative',
-            });
-            Notify.create({
-                message: t('globals.noSelectedRows'),
-                type: 'negative',
-                timeout: 5000,
-                progress: true,
-            });
-        }
+    Router.onError((error) => {
+        const errorMessages = [
+            'Failed to fetch dynamically imported module',
+            'Importing a module script failed',
+        ];
+        state.set(
+            'error',
+            errorMessages.some((msg) => error.message.includes(msg)),
+        );
     });
     return Router;
 });