From 3d5807463b55065b053d6235452927eb1fe3263e Mon Sep 17 00:00:00 2001
From: jgallego <jgallego@verdnatura.es>
Date: Wed, 21 Aug 2024 13:46:19 +0200
Subject: [PATCH] feat: refs #7346 refactor

---
 src/pages/InvoiceOut/InvoiceOutGlobalForm.vue | 38 ++++++++++---------
 src/pages/Item/Card/ItemBasicData.vue         |  1 -
 2 files changed, 20 insertions(+), 19 deletions(-)

diff --git a/src/pages/InvoiceOut/InvoiceOutGlobalForm.vue b/src/pages/InvoiceOut/InvoiceOutGlobalForm.vue
index 88d55b09325..3dc34dc15be 100644
--- a/src/pages/InvoiceOut/InvoiceOutGlobalForm.vue
+++ b/src/pages/InvoiceOut/InvoiceOutGlobalForm.vue
@@ -24,15 +24,28 @@ const companiesOptions = ref([]);
 const printersOptions = ref([]);
 const clientsOptions = ref([]);
 const serialTypesOptions = ref([]);
+
+const handleInvoiceOutSerialsFetch = (data) => {
+    const uniqueTypes = new Set();
+    serialTypesOptions.value = data.filter((item) => {
+        if (item.type === null || uniqueTypes.has(item.type)) {
+            return false;
+        }
+        uniqueTypes.add(item.type);
+        return true;
+    });
+};
+
 const formData = ref({});
 
 const optionsInitialData = computed(() => {
-    return (
-        companiesOptions.value.length > 0 &&
-        printersOptions.value.length > 0 &&
-        clientsOptions.value.length > 0 &&
-        serialTypesOptions.value.length > 0
-    );
+    const optionsArrays = [
+        companiesOptions.value,
+        printersOptions.value,
+        clientsOptions.value,
+        serialTypesOptions.value,
+    ];
+    return optionsArrays.every((arr) => arr.length > 0);
 });
 
 const getStatus = computed({
@@ -60,18 +73,7 @@ onMounted(async () => {
     <FetchData url="Clients" @on-fetch="(data) => (clientsOptions = data)" auto-load />
     <FetchData
         url="invoiceOutSerials"
-        @on-fetch="
-            (data) => {
-                const uniqueTypes = new Set();
-                serialTypesOptions = data.filter((item) => {
-                    if (item.type === null || uniqueTypes.has(item.type)) {
-                        return false;
-                    }
-                    uniqueTypes.add(item.type);
-                    return true;
-                });
-            }
-        "
+        @on-fetch="handleInvoiceOutSerialsFetch"
         auto-load
     />
     <QForm
diff --git a/src/pages/Item/Card/ItemBasicData.vue b/src/pages/Item/Card/ItemBasicData.vue
index 89c88329575..ae9e45983b6 100644
--- a/src/pages/Item/Card/ItemBasicData.vue
+++ b/src/pages/Item/Card/ItemBasicData.vue
@@ -16,7 +16,6 @@ const route = useRoute();
 const { t } = useI18n();
 
 const itemTypesOptions = ref([]);
-const itemsWithNameOptions = ref([]);
 const intrastatsOptions = ref([]);
 const expensesOptions = ref([]);