From 6fe6cd79e876a86a40636bfdbc3b885ba64d7730 Mon Sep 17 00:00:00 2001
From: Javier Segarra <jsegarra@verdnatura.es>
Date: Wed, 31 Jan 2024 08:41:02 +0100
Subject: [PATCH 1/7] refs #5834 feat: add tooltip for iban input

---
 src/pages/Customer/Card/CustomerBillingData.vue | 11 ++++++++++-
 src/pages/Supplier/Card/SupplierAccounts.vue    | 13 +++++++++----
 src/pages/Worker/WorkerCreate.vue               | 10 +++++++++-
 3 files changed, 28 insertions(+), 6 deletions(-)

diff --git a/src/pages/Customer/Card/CustomerBillingData.vue b/src/pages/Customer/Card/CustomerBillingData.vue
index 1543eac7a..195783824 100644
--- a/src/pages/Customer/Card/CustomerBillingData.vue
+++ b/src/pages/Customer/Card/CustomerBillingData.vue
@@ -70,7 +70,16 @@ const getBankEntities = () => {
 
             <VnRow class="row q-gutter-md q-mb-md">
                 <div class="col">
-                    <VnInput :label="t('IBAN')" v-model="data.iban" />
+                    <QIcon name="info" class="cursor-info">
+                        <QTooltip> asd</QTooltip>
+                    </QIcon>
+                    <VnInput :label="t('IBAN')" v-model="data.iban">
+                        <template #append>
+                            <QIcon name="info" class="cursor-info">
+                                <QTooltip>{{ t('components.iban_tooltip') }}</QTooltip>
+                            </QIcon>
+                        </template></VnInput
+                    >
                 </div>
                 <div class="col">
                     <VnSelectCreate
diff --git a/src/pages/Supplier/Card/SupplierAccounts.vue b/src/pages/Supplier/Card/SupplierAccounts.vue
index 30edfb2fd..eec958e00 100644
--- a/src/pages/Supplier/Card/SupplierAccounts.vue
+++ b/src/pages/Supplier/Card/SupplierAccounts.vue
@@ -99,10 +99,15 @@ onMounted(() => {
                     class="row q-gutter-md q-mb-md"
                 >
                     <div class="col">
-                        <VnInput
-                            :label="t('supplier.accounts.iban')"
-                            v-model="row.iban"
-                        />
+                        <VnInput :label="t('supplier.accounts.iban')" v-model="row.iban">
+                            <template #append>
+                                <QIcon name="info" class="cursor-info">
+                                    <QTooltip>{{
+                                        t('components.iban_tooltip')
+                                    }}</QTooltip>
+                                </QIcon>
+                            </template></VnInput
+                        >
                     </div>
                     <div class="col">
                         <VnSelectCreate
diff --git a/src/pages/Worker/WorkerCreate.vue b/src/pages/Worker/WorkerCreate.vue
index 3ded85584..34fc26445 100644
--- a/src/pages/Worker/WorkerCreate.vue
+++ b/src/pages/Worker/WorkerCreate.vue
@@ -248,7 +248,15 @@ onMounted(async () => {
                             v-model="data.iban"
                             :label="t('worker.create.iban')"
                             :rules="validate('Worker.iban')"
-                        />
+                        >
+                            <template #append>
+                                <QIcon name="info" class="cursor-info">
+                                    <QTooltip>{{
+                                        t('components.iban_tooltip')
+                                    }}</QTooltip>
+                                </QIcon>
+                            </template>
+                        </VnInput>
                     </div>
                     <VnSelectCreate
                         :label="t('worker.create.bankEntity')"

From 40fb0c4533cfb05ce6da66bbf8650b1836a97399 Mon Sep 17 00:00:00 2001
From: Javier Segarra <jsegarra@verdnatura.es>
Date: Wed, 31 Jan 2024 08:41:21 +0100
Subject: [PATCH 2/7] refs #5834 feat: add required for country

---
 src/components/CreateBankEntityForm.vue | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/components/CreateBankEntityForm.vue b/src/components/CreateBankEntityForm.vue
index 2a1385945..00a540a6f 100644
--- a/src/components/CreateBankEntityForm.vue
+++ b/src/components/CreateBankEntityForm.vue
@@ -77,6 +77,7 @@ const onDataSaved = (data) => {
                         option-value="id"
                         option-label="country"
                         hide-selected
+                        :required="true"
                         :rules="validate('bankEntity.countryFk')"
                     />
                 </div>

From f3e7d8ceb19babfd3c15bdfb8f30f626f082770b Mon Sep 17 00:00:00 2001
From: Javier Segarra <jsegarra@verdnatura.es>
Date: Wed, 31 Jan 2024 08:54:49 +0100
Subject: [PATCH 3/7] refs #5834 feat: i18n

---
 src/components/common/VnLocation.vue | 6 ++++--
 src/i18n/en/index.js                 | 1 +
 src/i18n/es/index.js                 | 1 +
 3 files changed, 6 insertions(+), 2 deletions(-)

diff --git a/src/components/common/VnLocation.vue b/src/components/common/VnLocation.vue
index 0b30faaa7..17dd3d37b 100644
--- a/src/components/common/VnLocation.vue
+++ b/src/components/common/VnLocation.vue
@@ -94,7 +94,7 @@ function handleFetch( data) {
         :options="postcodesOptions"
         :label="t('Location')"
         :option-label="showLabel"
-        :placeholder="t('Search by postalCode, town, province or country')"
+        :placeholder="t('search_by_postalcode')"
         @input-value="locationFilter"
         :default-filter="false"
         :input-debounce="300"
@@ -129,7 +129,9 @@ function handleFetch( data) {
 </style>
 
 <i18n>
+en:
+    search_by_postalcode: Search by postalcode, town, province or country
 es:
     Location: Ubicación
-    Search by postalcode, town, province or country: Buscar por código postal, ciudad o país
+    search_by_postalcode: Buscar por código postal, ciudad o país
 </i18n>
diff --git a/src/i18n/en/index.js b/src/i18n/en/index.js
index 2eb445680..7e3e7fe3b 100644
--- a/src/i18n/en/index.js
+++ b/src/i18n/en/index.js
@@ -1087,5 +1087,6 @@ export default {
         VnLv: {
             copyText: '{copyValue} has been copied to the clipboard',
         },
+        iban_tooltip: 'IBAN: ES21 1234 5678 90 0123456789',
     },
 };
diff --git a/src/i18n/es/index.js b/src/i18n/es/index.js
index 2a9bcd615..82a24893b 100644
--- a/src/i18n/es/index.js
+++ b/src/i18n/es/index.js
@@ -1086,5 +1086,6 @@ export default {
         VnLv: {
             copyText: '{copyValue} se ha copiado al portapepeles',
         },
+        iban_tooltip: 'IBAN: ES21 1234 5678 90 0123456789',
     },
 };

From 0287ec4932b242c4eb9c2e54b742ee4e62bcc5f9 Mon Sep 17 00:00:00 2001
From: Javier Segarra <jsegarra@verdnatura.es>
Date: Wed, 31 Jan 2024 08:57:05 +0100
Subject: [PATCH 4/7] refs #5834 feat: add required for code

---
 src/components/CreateBankEntityForm.vue | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/components/CreateBankEntityForm.vue b/src/components/CreateBankEntityForm.vue
index 00a540a6f..270a79d93 100644
--- a/src/components/CreateBankEntityForm.vue
+++ b/src/components/CreateBankEntityForm.vue
@@ -82,7 +82,7 @@ const onDataSaved = (data) => {
                     />
                 </div>
                 <div v-if="showEntityField" class="col">
-                    <QInput :label="t('id')" v-model="data.id" />
+                    <QInput :label="t('id')" v-model="data.id"/>
                 </div>
             </VnRow>
         </template>
@@ -96,12 +96,12 @@ en:
     name: Name *
     swift: Swift *
     country: Country
-    id: Entity code
+    id: Entity code *
 es:
     title: Nueva entidad bancaria
     subtitle: ¡Por favor, asegúrate de poner los datos correctos!
     name: Nombre *
     swift: Swift *
     country: País
-    id: Código de la entidad
+    id: Código de la entidad *
 </i18n>

From fea618b2133f096d3b3f4826795141cc133591ba Mon Sep 17 00:00:00 2001
From: Javier Segarra <jsegarra@verdnatura.es>
Date: Wed, 31 Jan 2024 09:00:48 +0100
Subject: [PATCH 5/7] refs #5834 feat: replace QInput by VnInput

---
 src/components/CreateBankEntityForm.vue | 26 ++++++++++++++++---------
 1 file changed, 17 insertions(+), 9 deletions(-)

diff --git a/src/components/CreateBankEntityForm.vue b/src/components/CreateBankEntityForm.vue
index 270a79d93..106dbec3a 100644
--- a/src/components/CreateBankEntityForm.vue
+++ b/src/components/CreateBankEntityForm.vue
@@ -1,6 +1,7 @@
 <script setup>
 import { reactive, ref } from 'vue';
 import { useI18n } from 'vue-i18n';
+import VnInput from 'src/components/common/VnInput.vue';
 
 import VnSelectFilter from 'src/components/common/VnSelectFilter.vue';
 import FetchData from 'components/FetchData.vue';
@@ -54,16 +55,18 @@ const onDataSaved = (data) => {
         <template #form-inputs="{ data, validate }">
             <VnRow class="row q-gutter-md q-mb-md">
                 <div class="col">
-                    <QInput
+                    <VnInput
                         :label="t('name')"
                         v-model="data.name"
+                        :required="true"
                         :rules="validate('bankEntity.name')"
                     />
                 </div>
                 <div class="col">
-                    <QInput
+                    <VnInput
                         :label="t('swift')"
                         v-model="data.bic"
+                        :required="true"
                         :rules="validate('bankEntity.bic')"
                     />
                 </div>
@@ -82,7 +85,12 @@ const onDataSaved = (data) => {
                     />
                 </div>
                 <div v-if="showEntityField" class="col">
-                    <QInput :label="t('id')" v-model="data.id"/>
+                    <VnInput
+                        :label="t('id')"
+                        v-model="data.id"
+                        :required="true"
+                        :rules="validate('city.name')"
+                    />
                 </div>
             </VnRow>
         </template>
@@ -93,15 +101,15 @@ const onDataSaved = (data) => {
 en:
     title: New bank entity
     subtitle: Please, ensure you put the correct data!
-    name: Name *
-    swift: Swift *
+    name: Name
+    swift: Swift
     country: Country
-    id: Entity code *
+    id: Entity code
 es:
     title: Nueva entidad bancaria
     subtitle: ¡Por favor, asegúrate de poner los datos correctos!
-    name: Nombre *
-    swift: Swift *
+    name: Nombre
+    swift: Swift
     country: País
-    id: Código de la entidad *
+    id: Código de la entidad
 </i18n>

From c42d8169dc069c4e2407c8f5ba05267cfb06fe7b Mon Sep 17 00:00:00 2001
From: Javier Segarra <jsegarra@verdnatura.es>
Date: Wed, 31 Jan 2024 09:03:44 +0100
Subject: [PATCH 6/7] refs #5834 perf: remove bad tag

---
 src/pages/Customer/Card/CustomerBillingData.vue | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/src/pages/Customer/Card/CustomerBillingData.vue b/src/pages/Customer/Card/CustomerBillingData.vue
index 195783824..a528775d8 100644
--- a/src/pages/Customer/Card/CustomerBillingData.vue
+++ b/src/pages/Customer/Card/CustomerBillingData.vue
@@ -70,9 +70,6 @@ const getBankEntities = () => {
 
             <VnRow class="row q-gutter-md q-mb-md">
                 <div class="col">
-                    <QIcon name="info" class="cursor-info">
-                        <QTooltip> asd</QTooltip>
-                    </QIcon>
                     <VnInput :label="t('IBAN')" v-model="data.iban">
                         <template #append>
                             <QIcon name="info" class="cursor-info">

From 27bfd009cf2bbc6029d4ffb171bb1430703aae2e Mon Sep 17 00:00:00 2001
From: Javier Segarra <jsegarra@verdnatura.es>
Date: Wed, 31 Jan 2024 09:05:21 +0100
Subject: [PATCH 7/7] refs #5834 perf: fix bad lint

---
 src/pages/Customer/Card/CustomerBillingData.vue | 4 ++--
 src/pages/Supplier/Card/SupplierAccounts.vue    | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/pages/Customer/Card/CustomerBillingData.vue b/src/pages/Customer/Card/CustomerBillingData.vue
index a528775d8..925cdd534 100644
--- a/src/pages/Customer/Card/CustomerBillingData.vue
+++ b/src/pages/Customer/Card/CustomerBillingData.vue
@@ -75,8 +75,8 @@ const getBankEntities = () => {
                             <QIcon name="info" class="cursor-info">
                                 <QTooltip>{{ t('components.iban_tooltip') }}</QTooltip>
                             </QIcon>
-                        </template></VnInput
-                    >
+                        </template>
+                    </VnInput>
                 </div>
                 <div class="col">
                     <VnSelectCreate
diff --git a/src/pages/Supplier/Card/SupplierAccounts.vue b/src/pages/Supplier/Card/SupplierAccounts.vue
index eec958e00..e7aff1e04 100644
--- a/src/pages/Supplier/Card/SupplierAccounts.vue
+++ b/src/pages/Supplier/Card/SupplierAccounts.vue
@@ -106,8 +106,8 @@ onMounted(() => {
                                         t('components.iban_tooltip')
                                     }}</QTooltip>
                                 </QIcon>
-                            </template></VnInput
-                        >
+                            </template>
+                        </VnInput>
                     </div>
                     <div class="col">
                         <VnSelectCreate