From 854e72fe5191e0a5e8917647e5d292d4297ec65e Mon Sep 17 00:00:00 2001
From: Javier Segarra <jsegarra@verdnatura.es>
Date: Tue, 10 Dec 2024 13:17:31 +0100
Subject: [PATCH] perf: emit options from VnSelectProvince

---
 src/components/CreateNewPostcodeForm.vue | 18 +++++-------------
 src/components/VnSelectProvince.vue      |  3 ++-
 2 files changed, 7 insertions(+), 14 deletions(-)

diff --git a/src/components/CreateNewPostcodeForm.vue b/src/components/CreateNewPostcodeForm.vue
index d3d6708f0..c656fcb2f 100644
--- a/src/components/CreateNewPostcodeForm.vue
+++ b/src/components/CreateNewPostcodeForm.vue
@@ -25,7 +25,6 @@ const townsFetchDataRef = ref(false);
 const townFilter = ref({});
 
 const countriesRef = ref(false);
-const provincesFetchDataRef = ref(false);
 const provincesOptions = ref([]);
 const townsOptions = ref([]);
 const town = ref({});
@@ -71,9 +70,6 @@ async function setProvince(id, data) {
     await fetchTowns();
 }
 async function onProvinceCreated(data) {
-    await provincesFetchDataRef.value.fetch({
-        where: { countryFk: postcodeFormData.countryFk },
-    });
     postcodeFormData.provinceFk = data.id;
 }
 function provinceByCountry(countryFk = postcodeFormData.countryFk) {
@@ -92,7 +88,6 @@ function setTown(newTown, data) {
     data.countryFk = newTown?.province?.countryFk ?? newTown;
 }
 async function onCityCreated(newTown, formData) {
-    await provincesFetchDataRef.value.fetch();
     newTown.province = provincesOptions.value.find(
         (province) => province.id === newTown.provinceFk
     );
@@ -125,14 +120,6 @@ async function filterTowns(name) {
 </script>
 
 <template>
-    <FetchData
-        ref="provincesFetchDataRef"
-        @on-fetch="handleProvinces"
-        :sort-by="['name ASC']"
-        :limit="30"
-        auto-load
-        url="Provinces/location"
-    />
     <FetchData
         ref="townsFetchDataRef"
         :sort-by="['name ASC']"
@@ -205,6 +192,11 @@ async function filterTowns(name) {
                     :country-fk="data.countryFk"
                     :province-selected="data.provinceFk"
                     @update:model-value="(value) => setProvince(value, data)"
+                    @update:options="
+                        (data) => {
+                            provincesOptions = data;
+                        }
+                    "
                     v-model="data.provinceFk"
                     @on-province-created="onProvinceCreated"
                     required
diff --git a/src/components/VnSelectProvince.vue b/src/components/VnSelectProvince.vue
index 7d1297abf..d73ee964e 100644
--- a/src/components/VnSelectProvince.vue
+++ b/src/components/VnSelectProvince.vue
@@ -7,7 +7,7 @@ import VnSelectDialog from 'components/common/VnSelectDialog.vue';
 import FetchData from 'components/FetchData.vue';
 import CreateNewProvinceForm from './CreateNewProvinceForm.vue';
 
-const emit = defineEmits(['onProvinceCreated', 'onProvinceFetched']);
+const emit = defineEmits(['onProvinceCreated', 'onProvinceFetched', 'update:options']);
 const $props = defineProps({
     countryFk: {
         type: Number,
@@ -41,6 +41,7 @@ async function onProvinceCreated(_, data) {
 }
 async function handleProvinces(data) {
     provincesOptions.value = data;
+    emit('update:options', data);
 }
 
 watch(