From 3a3ae14dc54153a8a0c3b9836456f323eacd6bf3 Mon Sep 17 00:00:00 2001
From: jorgep <jorgep@verdnatura.es>
Date: Thu, 31 Aug 2023 09:05:21 +0200
Subject: [PATCH 1/5] ref #6175 VnLinkPhone and MicroSIP icon created

---
 src/components/ui/VnLinkPhone.vue           | 36 +++++++++++++++
 src/i18n/en/index.js                        |  1 +
 src/i18n/es/index.js                        |  1 +
 src/pages/Customer/Card/CustomerSummary.vue | 23 +++++++++-
 src/pages/Customer/CustomerList.vue         | 10 ++++-
 src/pages/Ticket/Card/TicketDescriptor.vue  |  1 +
 src/pages/Ticket/Card/TicketSummary.vue     | 49 ++++++++++++++-------
 src/pages/Worker/Card/WorkerDescriptor.vue  | 25 ++++++++++-
 src/pages/Worker/Card/WorkerSummary.vue     | 40 +++++++++++------
 9 files changed, 152 insertions(+), 34 deletions(-)
 create mode 100644 src/components/ui/VnLinkPhone.vue

diff --git a/src/components/ui/VnLinkPhone.vue b/src/components/ui/VnLinkPhone.vue
new file mode 100644
index 000000000..e17ffb158
--- /dev/null
+++ b/src/components/ui/VnLinkPhone.vue
@@ -0,0 +1,36 @@
+<script setup>
+import { useI18n } from 'vue-i18n';
+const props = defineProps({
+    phoneNumber: { type: [String, Number], default: null },
+    icon: { type: Boolean, default: true },
+    showNumber: { type: Boolean, default: true },
+    schemeUrl: { type: String, default: 'tel' },
+});
+const { t } = useI18n();
+</script>
+<template>
+    <div v-if="props.phoneNumber">
+        <span v-if="props.icon">
+            <span v-if="props.showNumber">
+                {{ props.phoneNumber }}
+            </span>
+            <QBtn
+                flat
+                round
+                :icon="'phone'"
+                size="sm"
+                class="q-ml-xs"
+                color="primary"
+                padding="none"
+                :href="`${props.schemeUrl}:${props.phoneNumber}`"
+                :title="t('globals.microsip')"
+                @click.stop
+            />
+        </span>
+        <a v-else :href="`tel:${props.phoneNumber}`" class="link">
+            {{ props.phoneNumber }}
+        </a>
+    </div>
+    <span v-else>-</span>
+</template>
+<style scoped></style>
diff --git a/src/i18n/en/index.js b/src/i18n/en/index.js
index d7519ba53..022c2eed1 100644
--- a/src/i18n/en/index.js
+++ b/src/i18n/en/index.js
@@ -36,6 +36,7 @@ export default {
         summary: {
             basicData: 'Basic data',
         },
+        microsip: 'Open in MicroSIP',
     },
     errors: {
         statusUnauthorized: 'Access denied',
diff --git a/src/i18n/es/index.js b/src/i18n/es/index.js
index fc2c80f55..3e9dc5177 100644
--- a/src/i18n/es/index.js
+++ b/src/i18n/es/index.js
@@ -36,6 +36,7 @@ export default {
         summary: {
             basicData: 'Datos básicos',
         },
+        microsip: 'Abrir en MicroSIP',
     },
     errors: {
         statusUnauthorized: 'Acceso denegado',
diff --git a/src/pages/Customer/Card/CustomerSummary.vue b/src/pages/Customer/Card/CustomerSummary.vue
index 081bdd157..e1b8fe4be 100644
--- a/src/pages/Customer/Card/CustomerSummary.vue
+++ b/src/pages/Customer/Card/CustomerSummary.vue
@@ -6,6 +6,7 @@ import { toCurrency, toPercentage, toDate } from 'src/filters';
 import CardSummary from 'components/ui/CardSummary.vue';
 import { getUrl } from 'src/composables/getUrl';
 import VnLv from 'src/components/ui/VnLv.vue';
+import VnLinkPhone from 'src/components/ui/VnLinkPhone.vue';
 
 const route = useRoute();
 const { t } = useI18n();
@@ -68,8 +69,26 @@ const creditWarning = computed(() => {
                 <VnLv :label="t('customer.summary.customerId')" :value="entity.id" />
                 <VnLv :label="t('customer.summary.name')" :value="entity.name" />
                 <VnLv :label="t('customer.summary.contact')" :value="entity.contact" />
-                <VnLv :label="t('customer.summary.phone')" :value="entity.phone" />
-                <VnLv :label="t('customer.summary.mobile')" :value="entity.mobile" />
+                <VnLv :value="entity.phone">
+                    <template #label>
+                        {{ t('customer.summary.phone') }}
+                        <VnLinkPhone
+                            :phone-number="entity.phone"
+                            scheme-url="sip"
+                            :show-number="false"
+                        />
+                    </template>
+                </VnLv>
+                <VnLv :value="entity.mobile">
+                    <template #label>
+                        {{ t('customer.summary.mobile') }}
+                        <VnLinkPhone
+                            :phone-number="entity.mobile"
+                            scheme-url="sip"
+                            :show-number="false"
+                        />
+                    </template>
+                </VnLv>
                 <VnLv :label="t('customer.summary.email')" :value="entity.email" />
                 <VnLv
                     :label="t('customer.summary.salesPerson')"
diff --git a/src/pages/Customer/CustomerList.vue b/src/pages/Customer/CustomerList.vue
index 219ef0be3..83f11f184 100644
--- a/src/pages/Customer/CustomerList.vue
+++ b/src/pages/Customer/CustomerList.vue
@@ -9,6 +9,7 @@ import VnSearchbar from 'src/components/ui/VnSearchbar.vue';
 import CustomerFilter from './CustomerFilter.vue';
 import VnLv from 'src/components/ui/VnLv.vue';
 import CardList from 'src/components/ui/CardList.vue';
+import VnLinkPhone from 'src/components/ui/VnLinkPhone.vue';
 
 const stateStore = useStateStore();
 const router = useRouter();
@@ -77,7 +78,14 @@ function viewSummary(id) {
                         <template #list-items>
                             <VnLv label="ID" :value="row.id" />
                             <VnLv :label="t('customer.list.email')" :value="row.email" />
-                            <VnLv :label="t('customer.list.phone')" :value="row.phone" />
+                            <VnLv :label="t('customer.list.phone')">
+                                <template #value>
+                                    <VnLinkPhone
+                                        :phone-number="row.phone"
+                                        scheme-url="sip"
+                                    />
+                                </template>
+                            </VnLv>
                         </template>
                         <template #actions>
                             <QBtn
diff --git a/src/pages/Ticket/Card/TicketDescriptor.vue b/src/pages/Ticket/Card/TicketDescriptor.vue
index 25c9dfb1c..641ffee0c 100644
--- a/src/pages/Ticket/Card/TicketDescriptor.vue
+++ b/src/pages/Ticket/Card/TicketDescriptor.vue
@@ -8,6 +8,7 @@ import CardDescriptor from 'components/ui/CardDescriptor.vue';
 import TicketDescriptorMenu from './TicketDescriptorMenu.vue';
 import VnLv from 'src/components/ui/VnLv.vue';
 import useCardDescription from 'src/composables/useCardDescription';
+import WorkerDescriptorProxy from 'src/pages/Worker/Card/WorkerDescriptorProxy.vue';
 
 const $props = defineProps({
     id: {
diff --git a/src/pages/Ticket/Card/TicketSummary.vue b/src/pages/Ticket/Card/TicketSummary.vue
index ce46d1d47..7e322d7a2 100644
--- a/src/pages/Ticket/Card/TicketSummary.vue
+++ b/src/pages/Ticket/Card/TicketSummary.vue
@@ -10,6 +10,7 @@ import FetchedTags from 'components/ui/FetchedTags.vue';
 import InvoiceOutDescriptorProxy from 'pages/InvoiceOut/Card/InvoiceOutDescriptorProxy.vue';
 import WorkerDescriptorProxy from 'pages/Worker/Card/WorkerDescriptorProxy.vue';
 import VnLv from 'src/components/ui/VnLv.vue';
+import VnLinkPhone from 'src/components/ui/VnLinkPhone.vue';
 import { getUrl } from 'src/composables/getUrl';
 
 onUpdated(() => summaryRef.value.fetch());
@@ -208,22 +209,38 @@ async function changeState(value) {
                     :value="toDate(ticket.landed)"
                 />
                 <VnLv :label="t('ticket.summary.packages')" :value="ticket.packages" />
-                <VnLv
-                    :label="t('ticket.summary.consigneePhone')"
-                    :value="ticket.address.phone"
-                />
-                <VnLv
-                    :label="t('ticket.summary.consigneeMobile')"
-                    :value="ticket.address.mobile"
-                />
-                <VnLv
-                    :label="t('ticket.summary.clientPhone')"
-                    :value="ticket.client.phone"
-                />
-                <VnLv
-                    :label="t('ticket.summary.clientMobile')"
-                    :value="ticket.client.mobile"
-                />
+                <VnLv :label="t('ticket.summary.consigneePhone')">
+                    <template #value>
+                        <VnLinkPhone
+                            :phone-number="ticket.address.phone"
+                            scheme-url="sip"
+                        />
+                    </template>
+                </VnLv>
+                <VnLv :label="t('ticket.summary.consigneeMobile')">
+                    <template #value>
+                        <VnLinkPhone
+                            :phone-number="ticket.address.mobile"
+                            scheme-url="sip"
+                        />
+                    </template>
+                </VnLv>
+                <VnLv :label="t('ticket.summary.clientPhone')">
+                    <template #value>
+                        <VnLinkPhone
+                            :phone-number="ticket.client.phone"
+                            scheme-url="sip"
+                        />
+                    </template>
+                </VnLv>
+                <VnLv :label="t('ticket.summary.clientMobile')">
+                    <template #value>
+                        <VnLinkPhone
+                            :phone-number="ticket.client.mobile"
+                            scheme-url="sip"
+                        />
+                    </template>
+                </VnLv>
                 <VnLv
                     :label="t('ticket.summary.consignee')"
                     :value="formattedAddress()"
diff --git a/src/pages/Worker/Card/WorkerDescriptor.vue b/src/pages/Worker/Card/WorkerDescriptor.vue
index ba64a5abb..912d2f6fc 100644
--- a/src/pages/Worker/Card/WorkerDescriptor.vue
+++ b/src/pages/Worker/Card/WorkerDescriptor.vue
@@ -5,7 +5,9 @@ import { useI18n } from 'vue-i18n';
 import { useSession } from 'src/composables/useSession';
 import CardDescriptor from 'src/components/ui/CardDescriptor.vue';
 import VnLv from 'src/components/ui/VnLv.vue';
+import VnLinkPhone from 'src/components/ui/VnLinkPhone.vue';
 import useCardDescription from 'src/composables/useCardDescription';
+
 const $props = defineProps({
     id: {
         type: Number,
@@ -96,8 +98,27 @@ const setData = (entity) =>
                 :label="t('worker.list.department')"
                 :value="entity.department ? entity.department.department.name : null"
             />
-            <VnLv :label="t('worker.card.phone')" :value="entity.phone" />
-            <VnLv :label="t('worker.summary.sipExtension')" :value="sip" />
+            <VnLv :value="entity.phone">
+                <template #label>
+                    {{ t('worker.card.phone') }}
+                    <VnLinkPhone
+                        :phone-number="entity.phone"
+                        scheme-url="sip"
+                        :show-number="false"
+                    />
+                </template>
+            </VnLv>
+            <VnLv :value="sip">
+                <template #label>
+                    {{ t('worker.summary.sipExtension') }}
+                    <VnLinkPhone
+                        v-if="sip"
+                        :phone-number="sip"
+                        scheme-url="sip"
+                        :show-number="false"
+                    />
+                </template>
+            </VnLv>
         </template>
     </CardDescriptor>
 </template>
diff --git a/src/pages/Worker/Card/WorkerSummary.vue b/src/pages/Worker/Card/WorkerSummary.vue
index 05ccdc373..3badfcd35 100644
--- a/src/pages/Worker/Card/WorkerSummary.vue
+++ b/src/pages/Worker/Card/WorkerSummary.vue
@@ -8,6 +8,7 @@ import { getUrl } from 'src/composables/getUrl';
 import VnLv from 'src/components/ui/VnLv.vue';
 import WorkerDescriptorProxy from './WorkerDescriptorProxy.vue';
 import { dashIfEmpty } from 'src/filters';
+import VnLinkPhone from 'src/components/ui/VnLinkPhone.vue';
 
 const route = useRoute();
 const { t } = useI18n();
@@ -92,15 +93,27 @@ const filter = {
                         </span>
                     </template>
                 </VnLv>
-                <VnLv
-                    :label="t('worker.summary.phoneExtension')"
-                    :value="worker.mobileExtension"
-                />
-                <VnLv :label="t('worker.summary.entPhone')" :value="worker.phone" />
-                <VnLv
-                    :label="t('worker.summary.personalPhone')"
-                    :value="worker.client.phone"
-                />
+                <VnLv :label="t('worker.summary.phoneExtension')">
+                    <template #value>
+                        <VnLinkPhone
+                            :phone-number="worker.mobileExtension"
+                            scheme-url="sip"
+                        />
+                    </template>
+                </VnLv>
+                <VnLv :label="t('worker.summary.entPhone')">
+                    <template #value>
+                        <VnLinkPhone :phone-number="worker.phone" scheme-url="sip" />
+                    </template>
+                </VnLv>
+                <VnLv :label="t('worker.summary.personalPhone')">
+                    <template #value>
+                        <VnLinkPhone
+                            :phone-number="worker.client.phone"
+                            scheme-url="sip"
+                        />
+                    </template>
+                </VnLv>
                 <VnLv :label="t('worker.summary.locker')" :value="worker.locker" />
             </QCard>
             <QCard class="vn-one">
@@ -110,10 +123,11 @@ const filter = {
                 <VnLv :label="t('worker.summary.userId')" :value="worker.user.id" />
                 <VnLv :label="t('worker.card.name')" :value="worker.user.nickname" />
                 <VnLv :label="t('worker.summary.role')" :value="worker.user.role.name" />
-                <VnLv
-                    :label="t('worker.summary.sipExtension')"
-                    :value="worker?.sip?.extension"
-                />
+                <VnLv :label="t('worker.summary.sipExtension')">
+                    <template #value>
+                        <VnLinkPhone :phone-number="worker?.sip?.extension" />
+                    </template>
+                </VnLv>
             </QCard>
         </template>
     </CardSummary>

From 48b4fd96e5c2f8a9f0f0f92bab1888770a58cb09 Mon Sep 17 00:00:00 2001
From: jorgep <jorgep@verdnatura.es>
Date: Wed, 6 Sep 2023 14:40:26 +0200
Subject: [PATCH 2/5] ref #6175 scheme url removed

---
 src/components/ui/VnLinkPhone.vue           |  3 +--
 src/pages/Customer/Card/CustomerSummary.vue | 12 ++----------
 src/pages/Customer/CustomerList.vue         |  5 +----
 src/pages/Ticket/Card/TicketSummary.vue     | 20 ++++----------------
 src/pages/Worker/Card/WorkerDescriptor.vue  | 13 ++-----------
 src/pages/Worker/Card/WorkerSummary.vue     | 12 +++---------
 6 files changed, 13 insertions(+), 52 deletions(-)

diff --git a/src/components/ui/VnLinkPhone.vue b/src/components/ui/VnLinkPhone.vue
index e17ffb158..712aaafc5 100644
--- a/src/components/ui/VnLinkPhone.vue
+++ b/src/components/ui/VnLinkPhone.vue
@@ -4,7 +4,6 @@ const props = defineProps({
     phoneNumber: { type: [String, Number], default: null },
     icon: { type: Boolean, default: true },
     showNumber: { type: Boolean, default: true },
-    schemeUrl: { type: String, default: 'tel' },
 });
 const { t } = useI18n();
 </script>
@@ -22,7 +21,7 @@ const { t } = useI18n();
                 class="q-ml-xs"
                 color="primary"
                 padding="none"
-                :href="`${props.schemeUrl}:${props.phoneNumber}`"
+                :href="`sip:${props.phoneNumber}`"
                 :title="t('globals.microsip')"
                 @click.stop
             />
diff --git a/src/pages/Customer/Card/CustomerSummary.vue b/src/pages/Customer/Card/CustomerSummary.vue
index e1b8fe4be..6b718932f 100644
--- a/src/pages/Customer/Card/CustomerSummary.vue
+++ b/src/pages/Customer/Card/CustomerSummary.vue
@@ -72,21 +72,13 @@ const creditWarning = computed(() => {
                 <VnLv :value="entity.phone">
                     <template #label>
                         {{ t('customer.summary.phone') }}
-                        <VnLinkPhone
-                            :phone-number="entity.phone"
-                            scheme-url="sip"
-                            :show-number="false"
-                        />
+                        <VnLinkPhone :phone-number="entity.phone" :show-number="false" />
                     </template>
                 </VnLv>
                 <VnLv :value="entity.mobile">
                     <template #label>
                         {{ t('customer.summary.mobile') }}
-                        <VnLinkPhone
-                            :phone-number="entity.mobile"
-                            scheme-url="sip"
-                            :show-number="false"
-                        />
+                        <VnLinkPhone :phone-number="entity.mobile" :show-number="false" />
                     </template>
                 </VnLv>
                 <VnLv :label="t('customer.summary.email')" :value="entity.email" />
diff --git a/src/pages/Customer/CustomerList.vue b/src/pages/Customer/CustomerList.vue
index 83f11f184..35734b5da 100644
--- a/src/pages/Customer/CustomerList.vue
+++ b/src/pages/Customer/CustomerList.vue
@@ -80,10 +80,7 @@ function viewSummary(id) {
                             <VnLv :label="t('customer.list.email')" :value="row.email" />
                             <VnLv :label="t('customer.list.phone')">
                                 <template #value>
-                                    <VnLinkPhone
-                                        :phone-number="row.phone"
-                                        scheme-url="sip"
-                                    />
+                                    <VnLinkPhone :phone-number="row.phone" />
                                 </template>
                             </VnLv>
                         </template>
diff --git a/src/pages/Ticket/Card/TicketSummary.vue b/src/pages/Ticket/Card/TicketSummary.vue
index 7e322d7a2..997a26343 100644
--- a/src/pages/Ticket/Card/TicketSummary.vue
+++ b/src/pages/Ticket/Card/TicketSummary.vue
@@ -211,34 +211,22 @@ async function changeState(value) {
                 <VnLv :label="t('ticket.summary.packages')" :value="ticket.packages" />
                 <VnLv :label="t('ticket.summary.consigneePhone')">
                     <template #value>
-                        <VnLinkPhone
-                            :phone-number="ticket.address.phone"
-                            scheme-url="sip"
-                        />
+                        <VnLinkPhone :phone-number="ticket.address.phone" />
                     </template>
                 </VnLv>
                 <VnLv :label="t('ticket.summary.consigneeMobile')">
                     <template #value>
-                        <VnLinkPhone
-                            :phone-number="ticket.address.mobile"
-                            scheme-url="sip"
-                        />
+                        <VnLinkPhone :phone-number="ticket.address.mobile" />
                     </template>
                 </VnLv>
                 <VnLv :label="t('ticket.summary.clientPhone')">
                     <template #value>
-                        <VnLinkPhone
-                            :phone-number="ticket.client.phone"
-                            scheme-url="sip"
-                        />
+                        <VnLinkPhone :phone-number="ticket.client.phone" />
                     </template>
                 </VnLv>
                 <VnLv :label="t('ticket.summary.clientMobile')">
                     <template #value>
-                        <VnLinkPhone
-                            :phone-number="ticket.client.mobile"
-                            scheme-url="sip"
-                        />
+                        <VnLinkPhone :phone-number="ticket.client.mobile" />
                     </template>
                 </VnLv>
                 <VnLv
diff --git a/src/pages/Worker/Card/WorkerDescriptor.vue b/src/pages/Worker/Card/WorkerDescriptor.vue
index 912d2f6fc..e7ae4607d 100644
--- a/src/pages/Worker/Card/WorkerDescriptor.vue
+++ b/src/pages/Worker/Card/WorkerDescriptor.vue
@@ -101,22 +101,13 @@ const setData = (entity) =>
             <VnLv :value="entity.phone">
                 <template #label>
                     {{ t('worker.card.phone') }}
-                    <VnLinkPhone
-                        :phone-number="entity.phone"
-                        scheme-url="sip"
-                        :show-number="false"
-                    />
+                    <VnLinkPhone :phone-number="entity.phone" :show-number="false" />
                 </template>
             </VnLv>
             <VnLv :value="sip">
                 <template #label>
                     {{ t('worker.summary.sipExtension') }}
-                    <VnLinkPhone
-                        v-if="sip"
-                        :phone-number="sip"
-                        scheme-url="sip"
-                        :show-number="false"
-                    />
+                    <VnLinkPhone v-if="sip" :phone-number="sip" :show-number="false" />
                 </template>
             </VnLv>
         </template>
diff --git a/src/pages/Worker/Card/WorkerSummary.vue b/src/pages/Worker/Card/WorkerSummary.vue
index 3badfcd35..95bbe2f6e 100644
--- a/src/pages/Worker/Card/WorkerSummary.vue
+++ b/src/pages/Worker/Card/WorkerSummary.vue
@@ -95,23 +95,17 @@ const filter = {
                 </VnLv>
                 <VnLv :label="t('worker.summary.phoneExtension')">
                     <template #value>
-                        <VnLinkPhone
-                            :phone-number="worker.mobileExtension"
-                            scheme-url="sip"
-                        />
+                        <VnLinkPhone :phone-number="worker.mobileExtension" />
                     </template>
                 </VnLv>
                 <VnLv :label="t('worker.summary.entPhone')">
                     <template #value>
-                        <VnLinkPhone :phone-number="worker.phone" scheme-url="sip" />
+                        <VnLinkPhone :phone-number="worker.phone" />
                     </template>
                 </VnLv>
                 <VnLv :label="t('worker.summary.personalPhone')">
                     <template #value>
-                        <VnLinkPhone
-                            :phone-number="worker.client.phone"
-                            scheme-url="sip"
-                        />
+                        <VnLinkPhone :phone-number="worker.client.phone" />
                     </template>
                 </VnLv>
                 <VnLv :label="t('worker.summary.locker')" :value="worker.locker" />

From e4efffb33686e18b6112dac7ac11aaedecbcd943 Mon Sep 17 00:00:00 2001
From: jorgep <jorgep@verdnatura.es>
Date: Thu, 7 Sep 2023 08:23:55 +0200
Subject: [PATCH 3/5] ref #6175 simplify the component

---
 src/components/ui/VnLinkPhone.vue           | 37 +++++++--------------
 src/pages/Customer/Card/CustomerSummary.vue |  4 +--
 src/pages/Customer/CustomerList.vue         |  2 ++
 src/pages/Ticket/Card/TicketSummary.vue     |  6 +++-
 src/pages/Worker/Card/WorkerDescriptor.vue  |  4 +--
 src/pages/Worker/Card/WorkerSummary.vue     |  4 +++
 6 files changed, 27 insertions(+), 30 deletions(-)

diff --git a/src/components/ui/VnLinkPhone.vue b/src/components/ui/VnLinkPhone.vue
index 712aaafc5..ca005107b 100644
--- a/src/components/ui/VnLinkPhone.vue
+++ b/src/components/ui/VnLinkPhone.vue
@@ -2,34 +2,21 @@
 import { useI18n } from 'vue-i18n';
 const props = defineProps({
     phoneNumber: { type: [String, Number], default: null },
-    icon: { type: Boolean, default: true },
-    showNumber: { type: Boolean, default: true },
 });
 const { t } = useI18n();
 </script>
 <template>
-    <div v-if="props.phoneNumber">
-        <span v-if="props.icon">
-            <span v-if="props.showNumber">
-                {{ props.phoneNumber }}
-            </span>
-            <QBtn
-                flat
-                round
-                :icon="'phone'"
-                size="sm"
-                class="q-ml-xs"
-                color="primary"
-                padding="none"
-                :href="`sip:${props.phoneNumber}`"
-                :title="t('globals.microsip')"
-                @click.stop
-            />
-        </span>
-        <a v-else :href="`tel:${props.phoneNumber}`" class="link">
-            {{ props.phoneNumber }}
-        </a>
-    </div>
-    <span v-else>-</span>
+    <QBtn
+        v-if="props.phoneNumber"
+        flat
+        round
+        icon="phone"
+        size="sm"
+        color="primary"
+        padding="xs"
+        :href="`sip:${props.phoneNumber}`"
+        :title="t('globals.microsip')"
+        @click.stop
+    />
 </template>
 <style scoped></style>
diff --git a/src/pages/Customer/Card/CustomerSummary.vue b/src/pages/Customer/Card/CustomerSummary.vue
index 6b718932f..6693274ac 100644
--- a/src/pages/Customer/Card/CustomerSummary.vue
+++ b/src/pages/Customer/Card/CustomerSummary.vue
@@ -72,13 +72,13 @@ const creditWarning = computed(() => {
                 <VnLv :value="entity.phone">
                     <template #label>
                         {{ t('customer.summary.phone') }}
-                        <VnLinkPhone :phone-number="entity.phone" :show-number="false" />
+                        <VnLinkPhone :phone-number="entity.phone" />
                     </template>
                 </VnLv>
                 <VnLv :value="entity.mobile">
                     <template #label>
                         {{ t('customer.summary.mobile') }}
-                        <VnLinkPhone :phone-number="entity.mobile" :show-number="false" />
+                        <VnLinkPhone :phone-number="entity.mobile" />
                     </template>
                 </VnLv>
                 <VnLv :label="t('customer.summary.email')" :value="entity.email" />
diff --git a/src/pages/Customer/CustomerList.vue b/src/pages/Customer/CustomerList.vue
index 35734b5da..286b659c5 100644
--- a/src/pages/Customer/CustomerList.vue
+++ b/src/pages/Customer/CustomerList.vue
@@ -10,6 +10,7 @@ import CustomerFilter from './CustomerFilter.vue';
 import VnLv from 'src/components/ui/VnLv.vue';
 import CardList from 'src/components/ui/CardList.vue';
 import VnLinkPhone from 'src/components/ui/VnLinkPhone.vue';
+import { dashIfEmpty } from 'src/filters';
 
 const stateStore = useStateStore();
 const router = useRouter();
@@ -80,6 +81,7 @@ function viewSummary(id) {
                             <VnLv :label="t('customer.list.email')" :value="row.email" />
                             <VnLv :label="t('customer.list.phone')">
                                 <template #value>
+                                    {{ dashIfEmpty(row.phone) }}
                                     <VnLinkPhone :phone-number="row.phone" />
                                 </template>
                             </VnLv>
diff --git a/src/pages/Ticket/Card/TicketSummary.vue b/src/pages/Ticket/Card/TicketSummary.vue
index 997a26343..4d1fa4318 100644
--- a/src/pages/Ticket/Card/TicketSummary.vue
+++ b/src/pages/Ticket/Card/TicketSummary.vue
@@ -181,7 +181,7 @@ async function changeState(value) {
                 <VnLv :label="t('ticket.summary.route')" :value="ticket.routeFk" />
                 <VnLv :label="t('ticket.summary.invoice')">
                     <template #value>
-                        <span class="link">
+                        <span :class="{ link: ticket.refFk }">
                             {{ dashIfEmpty(ticket.refFk) }}
                             <InvoiceOutDescriptorProxy
                                 :id="ticket.id"
@@ -211,21 +211,25 @@ async function changeState(value) {
                 <VnLv :label="t('ticket.summary.packages')" :value="ticket.packages" />
                 <VnLv :label="t('ticket.summary.consigneePhone')">
                     <template #value>
+                        {{ dashIfEmpty(ticket.address.phone) }}
                         <VnLinkPhone :phone-number="ticket.address.phone" />
                     </template>
                 </VnLv>
                 <VnLv :label="t('ticket.summary.consigneeMobile')">
                     <template #value>
+                        {{ dashIfEmpty(ticket.address.mobile) }}
                         <VnLinkPhone :phone-number="ticket.address.mobile" />
                     </template>
                 </VnLv>
                 <VnLv :label="t('ticket.summary.clientPhone')">
                     <template #value>
+                        {{ dashIfEmpty(ticket.client.phone) }}
                         <VnLinkPhone :phone-number="ticket.client.phone" />
                     </template>
                 </VnLv>
                 <VnLv :label="t('ticket.summary.clientMobile')">
                     <template #value>
+                        {{ dashIfEmpty(ticket.client.mobile) }}
                         <VnLinkPhone :phone-number="ticket.client.mobile" />
                     </template>
                 </VnLv>
diff --git a/src/pages/Worker/Card/WorkerDescriptor.vue b/src/pages/Worker/Card/WorkerDescriptor.vue
index e7ae4607d..ea88b1b8f 100644
--- a/src/pages/Worker/Card/WorkerDescriptor.vue
+++ b/src/pages/Worker/Card/WorkerDescriptor.vue
@@ -101,13 +101,13 @@ const setData = (entity) =>
             <VnLv :value="entity.phone">
                 <template #label>
                     {{ t('worker.card.phone') }}
-                    <VnLinkPhone :phone-number="entity.phone" :show-number="false" />
+                    <VnLinkPhone :phone-number="entity.phone" />
                 </template>
             </VnLv>
             <VnLv :value="sip">
                 <template #label>
                     {{ t('worker.summary.sipExtension') }}
-                    <VnLinkPhone v-if="sip" :phone-number="sip" :show-number="false" />
+                    <VnLinkPhone v-if="sip" :phone-number="sip" />
                 </template>
             </VnLv>
         </template>
diff --git a/src/pages/Worker/Card/WorkerSummary.vue b/src/pages/Worker/Card/WorkerSummary.vue
index 95bbe2f6e..f16835636 100644
--- a/src/pages/Worker/Card/WorkerSummary.vue
+++ b/src/pages/Worker/Card/WorkerSummary.vue
@@ -95,16 +95,19 @@ const filter = {
                 </VnLv>
                 <VnLv :label="t('worker.summary.phoneExtension')">
                     <template #value>
+                        {{ dashIfEmpty(worker.mobileExtension) }}
                         <VnLinkPhone :phone-number="worker.mobileExtension" />
                     </template>
                 </VnLv>
                 <VnLv :label="t('worker.summary.entPhone')">
                     <template #value>
+                        {{ dashIfEmpty(worker.phone) }}
                         <VnLinkPhone :phone-number="worker.phone" />
                     </template>
                 </VnLv>
                 <VnLv :label="t('worker.summary.personalPhone')">
                     <template #value>
+                        {{ dashIfEmpty(worker.client.phone) }}
                         <VnLinkPhone :phone-number="worker.client.phone" />
                     </template>
                 </VnLv>
@@ -119,6 +122,7 @@ const filter = {
                 <VnLv :label="t('worker.summary.role')" :value="worker.user.role.name" />
                 <VnLv :label="t('worker.summary.sipExtension')">
                     <template #value>
+                        {{ dashIfEmpty(worker?.sip?.extension) }}
                         <VnLinkPhone :phone-number="worker?.sip?.extension" />
                     </template>
                 </VnLv>

From 71d3f0c4c6c3f1c7d68758c8c4ca33309b39d875 Mon Sep 17 00:00:00 2001
From: jorgep <jorgep@verdnatura.es>
Date: Thu, 7 Sep 2023 08:42:39 +0200
Subject: [PATCH 4/5] ref #6175 tests fixed

---
 test/cypress/integration/ClaimNotes.spec.js |  2 +-
 test/cypress/integration/workerList.spec.js | 10 +++++-----
 2 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/test/cypress/integration/ClaimNotes.spec.js b/test/cypress/integration/ClaimNotes.spec.js
index 5b52dd339..0a0f28fe7 100644
--- a/test/cypress/integration/ClaimNotes.spec.js
+++ b/test/cypress/integration/ClaimNotes.spec.js
@@ -7,7 +7,7 @@ describe('ClaimNotes', () => {
 
     it('should add a new note', () => {
         const message = 'This is a new message.';
-        cy.get('.q-page-sticky button').click();
+        cy.get('.q-page-sticky > div > button').click();
         cy.get('.q-dialog .q-card__section:nth-child(2)').type(message);
         cy.get('.q-card__actions button:nth-child(2)').click();
         cy.get('.q-card .q-card__section:nth-child(2)')
diff --git a/test/cypress/integration/workerList.spec.js b/test/cypress/integration/workerList.spec.js
index d76958367..219633263 100644
--- a/test/cypress/integration/workerList.spec.js
+++ b/test/cypress/integration/workerList.spec.js
@@ -8,18 +8,18 @@ describe('WorkerList', () => {
     it('should load workers', () => {
         cy.get('.card-list-body > .list-items > :nth-child(2) > .value > span')
             .eq(0)
-            .should('have.text', 'victorvd');
-        cy.get('.card-list-body > .list-items > :nth-child(2) > .value > span')
-            .eq(1)
             .should('have.text', 'JessicaJones');
         cy.get('.card-list-body > .list-items > :nth-child(2) > .value > span')
-            .eq(2)
+            .eq(1)
             .should('have.text', 'BruceBanner');
+        cy.get('.card-list-body > .list-items > :nth-child(2) > .value > span')
+            .eq(2)
+            .should('have.text', 'CharlesXavier');
     });
 
     it('should open the worker summary', () => {
         cy.get('.card-list-body .actions .q-btn:nth-child(2)').eq(1).click();
-        cy.get('.summaryHeader div').should('have.text', '1110 - Jessica Jones');
+        cy.get('.summaryHeader div').should('have.text', '1109 - Bruce Banner');
         cy.get('.summary .header').eq(0).invoke('text').should('include', 'Basic data');
         cy.get('.summary .header').eq(1).should('have.text', 'User data');
     });

From a4a62c8e3b0c80d59a7bb4bb464c37219247c65d Mon Sep 17 00:00:00 2001
From: jorgep <jorgep@verdnatura.es>
Date: Thu, 7 Sep 2023 09:27:23 +0200
Subject: [PATCH 5/5] ref #6175 match linkPhone

---
 src/components/ui/CardList.vue          |  2 +-
 src/components/ui/VnLinkPhone.vue       |  2 +-
 src/pages/Customer/CustomerList.vue     |  7 +++----
 src/pages/Ticket/Card/TicketSummary.vue | 24 ++++++++++++------------
 src/pages/Worker/Card/WorkerSummary.vue | 24 ++++++++++++------------
 5 files changed, 29 insertions(+), 30 deletions(-)

diff --git a/src/components/ui/CardList.vue b/src/components/ui/CardList.vue
index ed1df7668..af2398ebd 100644
--- a/src/components/ui/CardList.vue
+++ b/src/components/ui/CardList.vue
@@ -32,7 +32,7 @@ const $props = defineProps({
         gap: 2%;
         width: 50%;
         .label {
-            width: 30%;
+            width: 35%;
             color: var(--vn-label);
             overflow: hidden;
             text-overflow: ellipsis;
diff --git a/src/components/ui/VnLinkPhone.vue b/src/components/ui/VnLinkPhone.vue
index ca005107b..4445b99c9 100644
--- a/src/components/ui/VnLinkPhone.vue
+++ b/src/components/ui/VnLinkPhone.vue
@@ -13,7 +13,7 @@ const { t } = useI18n();
         icon="phone"
         size="sm"
         color="primary"
-        padding="xs"
+        padding="none"
         :href="`sip:${props.phoneNumber}`"
         :title="t('globals.microsip')"
         @click.stop
diff --git a/src/pages/Customer/CustomerList.vue b/src/pages/Customer/CustomerList.vue
index 286b659c5..41512d12f 100644
--- a/src/pages/Customer/CustomerList.vue
+++ b/src/pages/Customer/CustomerList.vue
@@ -10,7 +10,6 @@ import CustomerFilter from './CustomerFilter.vue';
 import VnLv from 'src/components/ui/VnLv.vue';
 import CardList from 'src/components/ui/CardList.vue';
 import VnLinkPhone from 'src/components/ui/VnLinkPhone.vue';
-import { dashIfEmpty } from 'src/filters';
 
 const stateStore = useStateStore();
 const router = useRouter();
@@ -79,9 +78,9 @@ function viewSummary(id) {
                         <template #list-items>
                             <VnLv label="ID" :value="row.id" />
                             <VnLv :label="t('customer.list.email')" :value="row.email" />
-                            <VnLv :label="t('customer.list.phone')">
-                                <template #value>
-                                    {{ dashIfEmpty(row.phone) }}
+                            <VnLv :value="row.phone">
+                                <template #label>
+                                    {{ t('customer.list.phone') }}
                                     <VnLinkPhone :phone-number="row.phone" />
                                 </template>
                             </VnLv>
diff --git a/src/pages/Ticket/Card/TicketSummary.vue b/src/pages/Ticket/Card/TicketSummary.vue
index 4d1fa4318..578cd9439 100644
--- a/src/pages/Ticket/Card/TicketSummary.vue
+++ b/src/pages/Ticket/Card/TicketSummary.vue
@@ -209,27 +209,27 @@ async function changeState(value) {
                     :value="toDate(ticket.landed)"
                 />
                 <VnLv :label="t('ticket.summary.packages')" :value="ticket.packages" />
-                <VnLv :label="t('ticket.summary.consigneePhone')">
-                    <template #value>
-                        {{ dashIfEmpty(ticket.address.phone) }}
+                <VnLv :value="ticket.address.phone">
+                    <template #label>
+                        {{ t('ticket.summary.consigneePhone') }}
                         <VnLinkPhone :phone-number="ticket.address.phone" />
                     </template>
                 </VnLv>
-                <VnLv :label="t('ticket.summary.consigneeMobile')">
-                    <template #value>
-                        {{ dashIfEmpty(ticket.address.mobile) }}
+                <VnLv :value="ticket.address.mobile">
+                    <template #label>
+                        {{ t('ticket.summary.consigneeMobile') }}
                         <VnLinkPhone :phone-number="ticket.address.mobile" />
                     </template>
                 </VnLv>
-                <VnLv :label="t('ticket.summary.clientPhone')">
-                    <template #value>
-                        {{ dashIfEmpty(ticket.client.phone) }}
+                <VnLv :value="ticket.client.phone">
+                    <template #label>
+                        {{ t('ticket.summary.clientPhone') }}
                         <VnLinkPhone :phone-number="ticket.client.phone" />
                     </template>
                 </VnLv>
-                <VnLv :label="t('ticket.summary.clientMobile')">
-                    <template #value>
-                        {{ dashIfEmpty(ticket.client.mobile) }}
+                <VnLv :value="ticket.client.mobile">
+                    <template #label>
+                        {{ t('ticket.summary.clientMobile') }}
                         <VnLinkPhone :phone-number="ticket.client.mobile" />
                     </template>
                 </VnLv>
diff --git a/src/pages/Worker/Card/WorkerSummary.vue b/src/pages/Worker/Card/WorkerSummary.vue
index f16835636..c4378d07a 100644
--- a/src/pages/Worker/Card/WorkerSummary.vue
+++ b/src/pages/Worker/Card/WorkerSummary.vue
@@ -93,21 +93,21 @@ const filter = {
                         </span>
                     </template>
                 </VnLv>
-                <VnLv :label="t('worker.summary.phoneExtension')">
-                    <template #value>
-                        {{ dashIfEmpty(worker.mobileExtension) }}
+                <VnLv :value="worker.mobileExtension">
+                    <template #label>
+                        {{ t('worker.summary.phoneExtension') }}
                         <VnLinkPhone :phone-number="worker.mobileExtension" />
                     </template>
                 </VnLv>
-                <VnLv :label="t('worker.summary.entPhone')">
-                    <template #value>
-                        {{ dashIfEmpty(worker.phone) }}
+                <VnLv :value="worker.phone">
+                    <template #label>
+                        {{ t('worker.summary.entPhone') }}
                         <VnLinkPhone :phone-number="worker.phone" />
                     </template>
                 </VnLv>
-                <VnLv :label="t('worker.summary.personalPhone')">
-                    <template #value>
-                        {{ dashIfEmpty(worker.client.phone) }}
+                <VnLv :value="worker.client.phone">
+                    <template #label>
+                        {{ t('worker.summary.personalPhone') }}
                         <VnLinkPhone :phone-number="worker.client.phone" />
                     </template>
                 </VnLv>
@@ -120,9 +120,9 @@ const filter = {
                 <VnLv :label="t('worker.summary.userId')" :value="worker.user.id" />
                 <VnLv :label="t('worker.card.name')" :value="worker.user.nickname" />
                 <VnLv :label="t('worker.summary.role')" :value="worker.user.role.name" />
-                <VnLv :label="t('worker.summary.sipExtension')">
-                    <template #value>
-                        {{ dashIfEmpty(worker?.sip?.extension) }}
+                <VnLv :value="worker?.sip?.extension">
+                    <template #label>
+                        {{ t('worker.summary.sipExtension') }}
                         <VnLinkPhone :phone-number="worker?.sip?.extension" />
                     </template>
                 </VnLv>