From bd2fa374507a0ebfcdb5f600a4178b313239c7f5 Mon Sep 17 00:00:00 2001
From: jgallego <jgallego@verdnatura.es>
Date: Wed, 25 Sep 2024 13:34:43 +0200
Subject: [PATCH 1/2] feat: maxTemperature and minTemperature

---
 src/components/CreateThermographForm.vue      |   2 +-
 src/components/common/VnSelectDialog.vue      |   2 +-
 src/i18n/locale/en.yml                        |   2 +
 src/i18n/locale/es.yml                        |   2 +
 src/pages/Travel/Card/TravelThermographs.vue  |  24 ++-
 .../Travel/Card/TravelThermographsForm.vue    | 175 +++++++++---------
 6 files changed, 107 insertions(+), 100 deletions(-)

diff --git a/src/components/CreateThermographForm.vue b/src/components/CreateThermographForm.vue
index 65a1c2679..0b7e4c5c6 100644
--- a/src/components/CreateThermographForm.vue
+++ b/src/components/CreateThermographForm.vue
@@ -50,7 +50,7 @@ const onDataSaved = (dataSaved) => {
         model="thermograph"
         :title="t('New thermograph')"
         :form-initial-data="thermographFormData"
-        @on-data-saved="onDataSaved($event)"
+        @on-data-saved="(_, response) => onDataSaved(response)"
     >
         <template #form-inputs="{ data, validate }">
             <VnRow>
diff --git a/src/components/common/VnSelectDialog.vue b/src/components/common/VnSelectDialog.vue
index 17f893255..350aa9272 100644
--- a/src/components/common/VnSelectDialog.vue
+++ b/src/components/common/VnSelectDialog.vue
@@ -1,5 +1,5 @@
 <script setup>
-import { ref, computed } from 'vue';
+import { computed } from 'vue';
 import { useRole } from 'src/composables/useRole';
 import { useAcl } from 'src/composables/useAcl';
 
diff --git a/src/i18n/locale/en.yml b/src/i18n/locale/en.yml
index 2e2365f7b..5d5bc9c90 100644
--- a/src/i18n/locale/en.yml
+++ b/src/i18n/locale/en.yml
@@ -288,6 +288,8 @@ globals:
     createInvoiceIn: Create invoice in
     myAccount: My account
     noOne: No one
+    maxTemperature: Maximum Temperature
+    minTemperature: Minimum Temperatura
     params:
         clientFk: Client id
         salesPersonFk: Sales person
diff --git a/src/i18n/locale/es.yml b/src/i18n/locale/es.yml
index 53b487e9f..52ef51475 100644
--- a/src/i18n/locale/es.yml
+++ b/src/i18n/locale/es.yml
@@ -291,6 +291,8 @@ globals:
     createInvoiceIn: Crear factura recibida
     myAccount: Mi cuenta
     noOne: Nadie
+    maxTemperature: Temperatura máxima
+    minTemperature: Temperatura mínima
     params:
         clientFk: Id cliente
         salesPersonFk: Comercial
diff --git a/src/pages/Travel/Card/TravelThermographs.vue b/src/pages/Travel/Card/TravelThermographs.vue
index 6d83581ee..38b9125b1 100644
--- a/src/pages/Travel/Card/TravelThermographs.vue
+++ b/src/pages/Travel/Card/TravelThermographs.vue
@@ -47,6 +47,18 @@ const TableColumns = computed(() => {
             name: 'temperatureFk',
             align: 'left',
         },
+        {
+            label: t('globals.maxTemperature'),
+            field: 'maxTemperature',
+            name: 'maxTemperature',
+            align: 'left',
+        },
+        {
+            label: t('globals.minTemperature'),
+            field: 'minTemperature',
+            name: 'minTemperature',
+            align: 'left',
+        },
         {
             label: t('travel.thermographs.state'),
             field: 'result',
@@ -92,11 +104,7 @@ const openRemoveDialog = async (id) => {
             },
         })
         .onOk(async () => {
-            try {
-                await removeThermograph(id);
-            } catch (err) {
-                console.error('Error removing thermograph');
-            }
+            await removeThermograph(id);
         });
 };
 
@@ -106,9 +114,7 @@ const redirectToThermographForm = (action, id) => {
     };
 
     if (action === 'edit' && id) {
-        const params = {};
-        params.thermographId = id;
-        routeDetails.params = params;
+        routeDetails.query = { travelThermographFk: id };
     }
     router.push(routeDetails);
 };
@@ -213,4 +219,6 @@ es:
     Thermograph removed: Termógrafo eliminado
     Are you sure you want to remove the thermograph?: ¿Seguro que quieres quitar el termógrafo?
     No results: Sin resultados
+    Max Temperature: Temperatura máxima
+    Min Temperature: Temperatura mínima
 </i18n>
diff --git a/src/pages/Travel/Card/TravelThermographsForm.vue b/src/pages/Travel/Card/TravelThermographsForm.vue
index 7f40873b1..2dc462bb0 100644
--- a/src/pages/Travel/Card/TravelThermographsForm.vue
+++ b/src/pages/Travel/Card/TravelThermographsForm.vue
@@ -1,6 +1,6 @@
 <script setup>
 import { useI18n } from 'vue-i18n';
-import { reactive, ref, onBeforeMount } from 'vue';
+import { ref, onBeforeMount } from 'vue';
 import { useRoute, useRouter } from 'vue-router';
 
 import FetchData from 'components/FetchData.vue';
@@ -14,6 +14,7 @@ import { useState } from 'src/composables/useState';
 import { useStateStore } from 'stores/useStateStore';
 import axios from 'axios';
 import useNotify from 'src/composables/useNotify.js';
+import VnInputNumber from 'src/components/common/VnInputNumber.vue';
 
 const props = defineProps({
     viewAction: {
@@ -30,12 +31,13 @@ const state = useState();
 const { notify } = useNotify();
 
 const thermographFilter = {
-    fields: ['thermographFk'],
+    fields: ['id', 'thermographFk'],
     where: {
-        travelFk: null,
+        or: [{ travelFk: null }, { travelFk: route.params.id }],
     },
     order: 'thermographFk ASC',
 };
+
 const fetchTravelThermographsRef = ref(null);
 const allowedContentTypes = ref('');
 const user = state.getUser();
@@ -43,19 +45,10 @@ const thermographsOptions = ref([]);
 const dmsTypesOptions = ref([]);
 const companiesOptions = ref([]);
 const warehousesOptions = ref([]);
+const temperaturesOptions = ref([]);
+const thermographForm = ref({});
 const inputFileRef = ref(null);
 
-const thermographForm = reactive({
-    thermographId: null,
-    state: null,
-    reference: null,
-    dmsTypeId: null,
-    companyId: null,
-    warehouseId: null,
-    files: [],
-    description: null,
-});
-
 onBeforeMount(async () => {
     if (props.viewAction === 'create') {
         setCreateDefaultParams();
@@ -75,7 +68,7 @@ const fetchDmsTypes = async () => {
     try {
         const params = {
             filter: {
-                where: { code: 'miscellaneous' },
+                where: { code: 'thermograph' },
             },
         };
         const { data } = await axios.get('DmsTypes/findOne', { params });
@@ -87,89 +80,67 @@ const fetchDmsTypes = async () => {
 
 const setCreateDefaultParams = async () => {
     const dataResponse = await fetchDmsTypes();
-    thermographForm.companyId = user.value.companyFk;
-    thermographForm.warehouseId = user.value.warehouseFk;
-    thermographForm.reference = route.params.id;
-    thermographForm.dmsTypeId = dataResponse.id;
-    thermographForm.state = 'Ok';
-    thermographForm.description = t('travel.thermographs.travelFileDescription', {
+    thermographForm.value.companyId = user.value.companyFk;
+    thermographForm.value.warehouseId = user.value.warehouseFk;
+    thermographForm.value.reference = route.params.id;
+    thermographForm.value.dmsTypeId = dataResponse.id;
+    thermographForm.value.state = 'Ok';
+    thermographForm.value.description = t('travel.thermographs.travelFileDescription', {
         travelId: route.params.id,
     }).toUpperCase();
 };
 
 const setEditDefaultParams = async () => {
-    try {
-        const filterObj = { include: { relation: 'dms' } };
-        const filter = encodeURIComponent(JSON.stringify(filterObj));
-        const { data } = await axios.get(
-            `TravelThermographs/${route.params.thermographId}?filter=${filter}`
-        );
+    const filterObj = { include: { relation: 'dms' } };
+    const filter = encodeURIComponent(JSON.stringify(filterObj));
+    const { data } = await axios.get(
+        `TravelThermographs/${route.query.travelThermographFk}?filter=${filter}`
+    );
 
-        if (data) {
-            thermographForm.thermographId = data.thermographFk;
-            thermographForm.state = data.result;
-            thermographForm.reference = data.dms?.reference;
-            thermographForm.warehouseId = data.dms?.warehouseFk;
-            thermographForm.companyId = data.dms?.companyFk;
-            thermographForm.dmsTypeId = data.dms?.dmsTypeFk;
-            thermographForm.description = data.dms?.description || '';
-            thermographForm.hasFile = data.dms?.hasFile;
-            thermographForm.hasFileAttached = false;
-        }
-    } catch (err) {
-        console.error('Error fetching termograph');
+    if (data) {
+        thermographForm.value.thermographFk = data.thermographFk;
+        thermographForm.value.state = data.result;
+        thermographForm.value.reference = data.dms?.reference;
+        thermographForm.value.warehouseId = data.dms?.warehouseFk;
+        thermographForm.value.companyId = data.dms?.companyFk;
+        thermographForm.value.dmsTypeId = data.dms?.dmsTypeFk;
+        thermographForm.value.description = data.dms?.description || '';
+        thermographForm.value.hasFile = data.dms?.hasFile;
+        thermographForm.value.hasFileAttached = false;
+        thermographForm.value.maxTemperature = data.maxTemperature;
+        thermographForm.value.minTemperature = data.minTemperature;
+        thermographForm.value.temperatureFk = data.temperatureFk;
+        thermographForm.value.travelThermographFk = data.id;
     }
 };
 
-const onSubmit = () => {
-    props.viewAction === 'create' ? createThermograph() : updateThermograph();
-};
-
-const createThermograph = async () => {
+const onSubmit = async () => {
     const formData = new FormData();
-
-    thermographForm.files.forEach((file) => {
-        formData.append(file.name, file);
-    });
-
-    try {
-        await axios.post(`/travels/${route.params.id}/createThermograph`, formData, {
-            params: thermographForm,
-            headers: {
-                'Content-Type': 'multipart/form-data',
-            },
+    if (Array.isArray(thermographForm.value.files)) {
+        thermographForm.value.hasFileAttached = true;
+        thermographForm.value.files.forEach((file) => {
+            formData.append(file.name, file);
         });
-        router.push({ name: 'TravelThermographsIndex' });
-        notify(t('Thermograph created'), 'positive');
-    } catch (error) {
-        console.error('Error creating thermograph');
     }
-};
-
-const updateThermograph = async () => {
-    const formData = new FormData();
-
-    thermographForm.files.forEach((file) => {
-        formData.append(file.name, file);
+    delete thermographForm.value.files;
+    await axios.post(`/travels/${route.params.id}/saveThermograph`, formData, {
+        params: thermographForm.value,
+        headers: {
+            'Content-Type': 'multipart/form-data',
+        },
     });
-
-    try {
-        await axios.post(`travels/${route.params.id}/updateThermograph`, formData, {
-            params: thermographForm,
-            headers: {
-                'Content-Type': 'multipart/form-data',
-            },
-        });
-        router.push({ name: 'TravelThermographsIndex' });
-        notify(t('Thermograph created'), 'positive');
-    } catch (error) {
-        console.error('Error creating thermograph');
-    }
+    router.push({ name: 'TravelThermographsIndex' });
+    notify(t('Thermograph created'), 'positive');
 };
 
 const onThermographCreated = async (data) => {
     await fetchTravelThermographsRef.value.fetch();
-    thermographForm.thermographId = data.thermographId;
+    thermographForm.value = {
+        ...thermographForm.value,
+        ...data,
+        travelThermographFk: data.id,
+        warehouseId: data.warehouseFk,
+    };
 };
 </script>
 
@@ -204,6 +175,11 @@ const onThermographCreated = async (data) => {
         :filter="{ order: 'name' }"
         auto-load
     />
+    <FetchData
+        @on-fetch="(data) => (temperaturesOptions = data)"
+        auto-load
+        url="Temperatures"
+    />
     <QPage class="column items-center full-width">
         <QForm
             model="travel"
@@ -238,16 +214,16 @@ const onThermographCreated = async (data) => {
                 <VnRow>
                     <VnSelectDialog
                         :label="t('travel.thermographs.thermograph')"
-                        v-model="thermographForm.thermographId"
+                        v-model="thermographForm.travelThermographFk"
                         :options="thermographsOptions"
-                        option-value="thermographFk"
+                        option-value="id"
                         option-label="thermographFk"
                         :disable="viewAction === 'edit'"
                         :tooltip="t('New thermograph')"
                     >
                         <template #form>
                             <CreateThermographForm
-                                @on-data-saved="onThermographCreated($event, data)"
+                                @on-data-saved="onThermographCreated"
                             />
                         </template>
                     </VnSelectDialog>
@@ -285,6 +261,26 @@ const onThermographCreated = async (data) => {
                         option-label="name"
                     />
                 </VnRow>
+                <VnRow>
+                    <VnSelect
+                        :label="t('travel.thermographs.temperature')"
+                        :options="temperaturesOptions"
+                        hide-selected
+                        option-label="name"
+                        option-value="code"
+                        v-model="thermographForm.temperatureFk"
+                        :required="true"
+                    />
+                    <VnInputNumber
+                        v-model="thermographForm.maxTemperature"
+                        :label="t('globals.maxTemperature')"
+                    />
+                    <VnInputNumber
+                        v-model="thermographForm.minTemperature"
+                        :label="t('globals.minTemperature')"
+                    />
+                </VnRow>
+
                 <VnRow v-if="viewAction === 'edit'" class="row q-gutter-md q-mb-md">
                     <QInput
                         :label="t('globals.description')"
@@ -323,10 +319,9 @@ const onThermographCreated = async (data) => {
         </QForm>
     </QPage>
 </template>
-
 <i18n>
-es:
-    Select files: Selecciona ficheros
-    Thermograph created: Termógrafo creado
-    New thermograph: Nuevo termógrafo
-</i18n>
+    es:
+        Select files: Selecciona ficheros
+        Thermograph created: Termógrafo creado
+        New thermograph: Nuevo termógrafo
+    </i18n>

From dcfdabde3288a9a2e5482a4573ebac64cc1084ef Mon Sep 17 00:00:00 2001
From: jgallego <jgallego@verdnatura.es>
Date: Wed, 25 Sep 2024 14:17:26 +0200
Subject: [PATCH 2/2] feat: tabulation

---
 src/pages/Travel/Card/TravelThermographsForm.vue | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/pages/Travel/Card/TravelThermographsForm.vue b/src/pages/Travel/Card/TravelThermographsForm.vue
index 313c2e56e..1d3410903 100644
--- a/src/pages/Travel/Card/TravelThermographsForm.vue
+++ b/src/pages/Travel/Card/TravelThermographsForm.vue
@@ -322,4 +322,4 @@ const onThermographCreated = async (data) => {
         Select files: Selecciona ficheros
         Thermograph created: Termógrafo creado
         New thermograph: Nuevo termógrafo
-    </i18n>
+</i18n>