From 0e1552f9627fa210625079fa07f1a3ceadb1cf3e Mon Sep 17 00:00:00 2001
From: Javier Segarra <jsegarra@verdnatura.es>
Date: Sat, 30 Nov 2024 01:33:18 +0100
Subject: [PATCH 1/4] fix: scrollInto Item

---
 src/components/ui/CatalogItem.vue     |  2 +-
 src/pages/Order/Card/OrderCatalog.vue | 18 +++++++++++++++++-
 2 files changed, 18 insertions(+), 2 deletions(-)

diff --git a/src/components/ui/CatalogItem.vue b/src/components/ui/CatalogItem.vue
index 7dca19770..74a36ff2e 100644
--- a/src/components/ui/CatalogItem.vue
+++ b/src/components/ui/CatalogItem.vue
@@ -67,7 +67,7 @@ const dialog = ref(null);
                             <QTooltip>{{ t('globals.add') }}</QTooltip>
                             <QPopupProxy ref="dialog">
                                 <OrderCatalogItemDialog
-                                    :prices="item.prices"
+                                    :item="item"
                                     @added="() => dialog.hide()"
                                 />
                             </QPopupProxy>
diff --git a/src/pages/Order/Card/OrderCatalog.vue b/src/pages/Order/Card/OrderCatalog.vue
index 90bce38fd..f3121fb6d 100644
--- a/src/pages/Order/Card/OrderCatalog.vue
+++ b/src/pages/Order/Card/OrderCatalog.vue
@@ -1,7 +1,7 @@
 <script setup>
 import { useStateStore } from 'stores/useStateStore';
 import { useRoute, useRouter } from 'vue-router';
-import { onMounted, onUnmounted, ref, computed, watch } from 'vue';
+import { onMounted, onUnmounted, ref, computed, watch, provide, nextTick } from 'vue';
 import axios from 'axios';
 import { useI18n } from 'vue-i18n';
 import VnPaginate from 'src/components/ui/VnPaginate.vue';
@@ -18,6 +18,7 @@ const dataKey = 'OrderCatalogList';
 const arrayData = useArrayData(dataKey);
 const store = arrayData.store;
 const tags = ref([]);
+const itemRefs = ref({});
 
 let catalogParams = {
     orderFk: route.params.id,
@@ -76,6 +77,20 @@ watch(
     },
     { immediate: true }
 );
+const onItemSaved = (updatedItem) => {
+    scrollToItem(updatedItem.items[0].itemFk);
+};
+
+const scrollToItem = async (id) => {
+    await nextTick();
+    setTimeout(() => {
+        const element = itemRefs.value[id]?.$el;
+        if (element) {
+            element.scrollIntoView({ behavior: 'smooth', block: 'center' });
+        }
+    }, 100);
+};
+provide('onItemSaved', onItemSaved);
 </script>
 
 <template>
@@ -115,6 +130,7 @@ watch(
                         <CatalogItem
                             v-for="row in rows"
                             :key="row.id"
+                            :ref="(el) => (itemRefs[row.id] = el)"
                             :item="row"
                             is-catalog
                             class="fill-icon"

From 0f0d906e080c37e983524330195b3e3ba0a121cc Mon Sep 17 00:00:00 2001
From: Javier Segarra <jsegarra@verdnatura.es>
Date: Sat, 30 Nov 2024 01:35:25 +0100
Subject: [PATCH 2/4] fix: #6896 OrderCatalogItem actions

---
 .../Order/Card/OrderCatalogItemDialog.vue     | 53 ++++++++++++-------
 1 file changed, 34 insertions(+), 19 deletions(-)

diff --git a/src/pages/Order/Card/OrderCatalogItemDialog.vue b/src/pages/Order/Card/OrderCatalogItemDialog.vue
index 09a25fcb8..41d22fbfe 100644
--- a/src/pages/Order/Card/OrderCatalogItemDialog.vue
+++ b/src/pages/Order/Card/OrderCatalogItemDialog.vue
@@ -1,41 +1,53 @@
 <script setup>
 import toCurrency from '../../../filters/toCurrency';
-import { ref } from 'vue';
+import { inject, ref } from 'vue';
 import { useI18n } from 'vue-i18n';
 import axios from 'axios';
 import { useRoute } from 'vue-router';
 import useNotify from 'composables/useNotify';
 import { useArrayData } from 'composables/useArrayData';
+import VnInputNumber from 'src/components/common/VnInputNumber.vue';
 
 const { t } = useI18n();
 const { notify } = useNotify();
 const emit = defineEmits(['added']);
 const route = useRoute();
 const props = defineProps({
-    prices: {
+    item: {
         type: Array,
         required: true,
     },
 });
-
-const fields = ref((props.prices || []).map((item) => ({ ...item, quantity: 0 })));
+const onItemSaved = inject('onItemSaved');
+const prices = ref((props.item.prices || []).map((item) => ({ ...item, quantity: 0 })));
 const descriptorData = useArrayData('orderData');
 const isLoading = ref(false);
 const addToOrder = async () => {
     if (isLoading.value) return;
     isLoading.value = true;
-    const items = (fields.value || []).filter((item) => Number(item.quantity) > 0);
+    const items = (prices.value || []).filter((item) => Number(item.quantity) > 0);
     await axios.post('/OrderRows/addToOrder', {
         items,
         orderFk: Number(route.params.id),
     });
     notify(t('globals.dataSaved'), 'positive');
-    emit('added');
-    descriptorData.fetch({});
+    await descriptorData.fetch({});
+    onItemSaved({ ...props, items, saved: true });
+    emit('added', items);
     isLoading.value = false;
 };
 const canAddToOrder = () => {
-    return (fields.value || []).some((item) => Number(item.quantity) > 0);
+    let canAddToOrder = (prices.value || []).some((price) => Number(price.quantity) > 0);
+    if (canAddToOrder) {
+        const excedQuantity = prices.value.reduce(
+            (acc, { quantity }) => acc + quantity,
+            0
+        );
+        if (excedQuantity > props.item.available) {
+            canAddToOrder = false;
+        }
+    }
+    return canAddToOrder;
 };
 </script>
 
@@ -44,30 +56,33 @@ const canAddToOrder = () => {
         <QForm @submit="addToOrder">
             <QMarkupTable class="shadow-0">
                 <tbody>
-                    <tr v-for="item in fields" :key="item.warehouse">
+                    <tr v-for="price in prices" :key="price.warehouse">
                         <td class="text-bold q-pr-md td" style="width: 35%">
-                            {{ item.warehouse }}
+                            {{ price.warehouse }}
                         </td>
                         <td class="text-right" style="width: 35%">
                             <span
                                 class="link"
-                                @click="
+                                @click.shift="
                                     () => {
-                                        item.quantity += item.grouping;
+                                        price.quantity -= price.grouping;
+                                    }
+                                "
+                                @click.exact="
+                                    () => {
+                                        price.quantity += price.grouping;
                                     }
                                 "
                             >
-                                {{ item.grouping }}
+                                {{ price.grouping }}
                             </span>
-                            x {{ toCurrency(item.price) }}
+                            x {{ toCurrency(price.price) }}
                         </td>
                         <td class="text-right">
-                            <QInput
-                                v-model.number="item.quantity"
-                                type="number"
-                                :step="item.grouping"
+                            <VnInputNumber
+                                v-model.number="price.quantity"
+                                :step="price.grouping"
                                 min="0"
-                                dense
                             />
                         </td>
                     </tr>

From 66221352712d63c5c7e26f0ff6e005984c4d3356 Mon Sep 17 00:00:00 2001
From: Javier Segarra <jsegarra@verdnatura.es>
Date: Sat, 30 Nov 2024 01:38:12 +0100
Subject: [PATCH 3/4] perf: #6896 change path import

---
 src/pages/Order/Card/OrderCatalogItemDialog.vue | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/pages/Order/Card/OrderCatalogItemDialog.vue b/src/pages/Order/Card/OrderCatalogItemDialog.vue
index 41d22fbfe..b1cd8ed6b 100644
--- a/src/pages/Order/Card/OrderCatalogItemDialog.vue
+++ b/src/pages/Order/Card/OrderCatalogItemDialog.vue
@@ -1,5 +1,5 @@
 <script setup>
-import toCurrency from '../../../filters/toCurrency';
+import toCurrency from 'src/filters/toCurrency';
 import { inject, ref } from 'vue';
 import { useI18n } from 'vue-i18n';
 import axios from 'axios';

From 98b8124577d8e50830f22b220dd0f5758b6036c6 Mon Sep 17 00:00:00 2001
From: Javier Segarra <jsegarra@verdnatura.es>
Date: Wed, 4 Dec 2024 09:15:02 +0100
Subject: [PATCH 4/4] perf: remove setTimeOut insteaduse  requestAnimationFrame

---
 src/pages/Order/Card/OrderCatalog.vue | 15 +++++++--------
 1 file changed, 7 insertions(+), 8 deletions(-)

diff --git a/src/pages/Order/Card/OrderCatalog.vue b/src/pages/Order/Card/OrderCatalog.vue
index f3121fb6d..948970cc3 100644
--- a/src/pages/Order/Card/OrderCatalog.vue
+++ b/src/pages/Order/Card/OrderCatalog.vue
@@ -78,17 +78,16 @@ watch(
     { immediate: true }
 );
 const onItemSaved = (updatedItem) => {
-    scrollToItem(updatedItem.items[0].itemFk);
+    requestAnimationFrame(() => {
+        scrollToItem(updatedItem.items[0].itemFk);
+    });
 };
 
 const scrollToItem = async (id) => {
-    await nextTick();
-    setTimeout(() => {
-        const element = itemRefs.value[id]?.$el;
-        if (element) {
-            element.scrollIntoView({ behavior: 'smooth', block: 'center' });
-        }
-    }, 100);
+    const element = itemRefs.value[id]?.$el;
+    if (element) {
+        element.scrollIntoView({ behavior: 'smooth', block: 'center' });
+    }
 };
 provide('onItemSaved', onItemSaved);
 </script>