From d4a18e584693d3b7a7e221feb4b34d70d8934abc Mon Sep 17 00:00:00 2001
From: jorgep <jorgep@verdnatura.es>
Date: Tue, 4 Mar 2025 16:08:20 +0100
Subject: [PATCH] refactor(VnAccountNumber): refs #8718 update input handling
 and improve test descriptions

---
 src/components/common/VnAccountNumber.vue     |  1 -
 src/components/common/VnInput.vue             |  2 +-
 .../vnComponent/VnAccountNumber.spec.js       | 68 +++++++++++--------
 3 files changed, 41 insertions(+), 30 deletions(-)

diff --git a/src/components/common/VnAccountNumber.vue b/src/components/common/VnAccountNumber.vue
index 3955da74ca6..56add732994 100644
--- a/src/components/common/VnAccountNumber.vue
+++ b/src/components/common/VnAccountNumber.vue
@@ -29,7 +29,6 @@ async function handleUpdateModel(val) {
     <VnInput
         v-model="model"
         ref="inputRef"
-        v-bind="$attrs"
         :insertable
         @update:model-value="handleUpdateModel"
     />
diff --git a/src/components/common/VnInput.vue b/src/components/common/VnInput.vue
index fb607f0cf4b..9e13f5351fc 100644
--- a/src/components/common/VnInput.vue
+++ b/src/components/common/VnInput.vue
@@ -143,7 +143,7 @@ const handleUppercase = () => {
             :rules="mixinRules"
             :lazy-rules="true"
             hide-bottom-space
-            :data-cy="$attrs.dataCy ?? $attrs.label + '_input'"
+            :data-cy="$attrs['data-cy'] ?? $attrs.label + '_input'"
         >
             <template #prepend v-if="$slots.prepend">
                 <slot name="prepend" />
diff --git a/test/cypress/integration/vnComponent/VnAccountNumber.spec.js b/test/cypress/integration/vnComponent/VnAccountNumber.spec.js
index 000c2151d32..6328fa3953a 100644
--- a/test/cypress/integration/vnComponent/VnAccountNumber.spec.js
+++ b/test/cypress/integration/vnComponent/VnAccountNumber.spec.js
@@ -1,4 +1,4 @@
-describe('VnInput Component', () => {
+describe('VnAccountNumber', () => {
     beforeEach(() => {
         cy.login('developer');
         cy.viewport(1920, 1080);
@@ -6,34 +6,46 @@ describe('VnInput Component', () => {
         cy.domContentLoad();
     });
 
-    it('should replace character at cursor position in insert mode', () => {
-        // Simula escribir en el input
-        cy.dataCy('supplierFiscalDataAccount').clear();
-        cy.dataCy('supplierFiscalDataAccount').type('4100000001');
-        // Coloca el cursor en la posición 0
-        cy.dataCy('supplierFiscalDataAccount').type('{movetostart}');
-        // Escribe un número y verifica que se reemplace correctamente
-        cy.dataCy('supplierFiscalDataAccount').type('999');
-        cy.dataCy('supplierFiscalDataAccount')
-        .should('have.value', '9990000001');
+    describe('VnInput handleInsertMode()', () => {
+        it('should replace character at cursor position in insert mode', () => {
+            cy.get('input[data-cy="supplierFiscalDataAccount"]').type(
+                '{selectall}4100000001',
+            );
+            cy.get('input[data-cy="supplierFiscalDataAccount"]').type('{movetostart}');
+            cy.get('input[data-cy="supplierFiscalDataAccount"]').type('999');
+            cy.get('input[data-cy="supplierFiscalDataAccount"]').should(
+                'have.value',
+                '9990000001',
+            );
+        });
+
+        it('should replace character at cursor position in insert mode', () => {
+            cy.get('input[data-cy="supplierFiscalDataAccount"]').clear();
+            cy.get('input[data-cy="supplierFiscalDataAccount"]').type('4100000001');
+            cy.get('input[data-cy="supplierFiscalDataAccount"]').type('{movetostart}');
+            cy.get('input[data-cy="supplierFiscalDataAccount"]').type('999');
+            cy.get('input[data-cy="supplierFiscalDataAccount"]').should(
+                'have.value',
+                '9990000001',
+            );
+        });
+
+        it('should respect maxlength prop', () => {
+            cy.get('input[data-cy="supplierFiscalDataAccount"]').clear();
+            cy.get('input[data-cy="supplierFiscalDataAccount"]').type('123456789012345');
+            cy.get('input[data-cy="supplierFiscalDataAccount"]').should(
+                'have.value',
+                '1234567890',
+            );
+        });
     });
 
-    it('should replace character at cursor position in insert mode', () => {
-        // Simula escribir en el input
-        cy.dataCy('supplierFiscalDataAccount').clear();
-        cy.dataCy('supplierFiscalDataAccount').type('4100000001');
-        // Coloca el cursor en la posición 0
-        cy.dataCy('supplierFiscalDataAccount').type('{movetostart}');
-        // Escribe un número y verifica que se reemplace correctamente en la posicion incial
-        cy.dataCy('supplierFiscalDataAccount').type('999');
-        cy.dataCy('supplierFiscalDataAccount')
-        .should('have.value', '9990000001');
-    });
-
-    it('should respect maxlength prop', () => {
-        cy.dataCy('supplierFiscalDataAccount').clear();
-        cy.dataCy('supplierFiscalDataAccount').type('123456789012345');
-        cy.dataCy('supplierFiscalDataAccount')
-        .should('have.value', '1234567890'); // asumiendo que maxlength es 10
+    it('should convert short account number to standard format', () => {
+        cy.get('input[data-cy="supplierFiscalDataAccount"]').clear();
+        cy.get('input[data-cy="supplierFiscalDataAccount"]').type('123.');
+        cy.get('input[data-cy="supplierFiscalDataAccount"]').should(
+            'have.value',
+            '1230000000',
+        );
     });
 });