Merge pull request '#6242: Show all ticket problems' (!1331) from 6242-AddHasRoundingField into dev

Reviewed-on: verdnatura/salix-front#1331
Reviewed-by: Alex Moreno <alexm@verdnatura.es>

src/components/TicketProblems.vue

@@ -2,26 +2,9 @@
 defineProps({ row: { type: Object, required: true } });
 </script>
 <template>
-    <span>
+    <span class="q-gutter-x-xs">
         <QIcon
-            v-if="row.isTaxDataChecked === 0"
+            v-if="row?.risk"
-            name="vn:no036"
-            color="primary"
-            size="xs"
-        >
-            <QTooltip>{{ $t('salesTicketsTable.noVerifiedData') }}</QTooltip>
-        </QIcon>
-        <QIcon v-if="row.hasTicketRequest" name="vn:buyrequest" color="primary" size="xs">
-            <QTooltip>{{ $t('salesTicketsTable.purchaseRequest') }}</QTooltip>
-        </QIcon>
-        <QIcon v-if="row.itemShortage" name="vn:unavailable" color="primary" size="xs">
-            <QTooltip>{{ $t('salesTicketsTable.notVisible') }}</QTooltip>
-        </QIcon>
-        <QIcon v-if="row.isFreezed" name="vn:frozen" color="primary" size="xs">
-            <QTooltip>{{ $t('salesTicketsTable.clientFrozen') }}</QTooltip>
-        </QIcon>
-        <QIcon
-            v-if="row.risk"
             name="vn:risk"
             :color="row.hasHighRisk ? 'negative' : 'primary'"
             size="xs"
@@ -30,10 +13,57 @@ defineProps({ row: { type: Object, required: true } });
                 {{ $t('salesTicketsTable.risk') }}: {{ row.risk - row.credit }}
             </QTooltip>
         </QIcon>
-        <QIcon v-if="row.hasComponentLack" name="vn:components" color="primary" size="xs">
+        <QIcon
+            v-if="row?.hasComponentLack"
+            name="vn:components"
+            color="primary"
+            size="xs"
+        >
             <QTooltip>{{ $t('salesTicketsTable.componentLack') }}</QTooltip>
         </QIcon>
-        <QIcon v-if="row.isTooLittle" name="vn:isTooLittle" color="primary" size="xs">
+        <QIcon v-if="row?.hasItemDelay" color="primary" size="xs" name="vn:hasItemDelay">
+            <QTooltip>
+                {{ $t('ticket.summary.hasItemDelay') }}
+            </QTooltip>
+        </QIcon>
+        <QIcon v-if="row?.hasItemLost" color="primary" size="xs" name="vn:hasItemLost">
+            <QTooltip>
+                {{ $t('salesTicketsTable.hasItemLost') }}
+            </QTooltip>
+        </QIcon>
+        <QIcon
+            v-if="row?.hasItemShortage"
+            name="vn:unavailable"
+            color="primary"
+            size="xs"
+        >
+            <QTooltip>{{ $t('salesTicketsTable.notVisible') }}</QTooltip>
+        </QIcon>
+        <QIcon v-if="row?.hasRounding" color="primary" name="sync_problem" size="xs">
+            <QTooltip>
+                {{ $t('ticketList.rounding') }}
+            </QTooltip>
+        </QIcon>
+        <QIcon
+            v-if="row?.hasTicketRequest"
+            name="vn:buyrequest"
+            color="primary"
+            size="xs"
+        >
+            <QTooltip>{{ $t('salesTicketsTable.purchaseRequest') }}</QTooltip>
+        </QIcon>
+        <QIcon
+            v-if="!row?.isTaxDataChecked === 0"
+            name="vn:no036"
+            color="primary"
+            size="xs"
+        >
+            <QTooltip>{{ $t('salesTicketsTable.noVerifiedData') }}</QTooltip>
+        </QIcon>
+        <QIcon v-if="row?.isFreezed" name="vn:frozen" color="primary" size="xs">
+            <QTooltip>{{ $t('salesTicketsTable.clientFrozen') }}</QTooltip>
+        </QIcon>
+        <QIcon v-if="row?.isTooLittle" name="vn:isTooLittle" color="primary" size="xs">
             <QTooltip>{{ $t('salesTicketsTable.tooLittle') }}</QTooltip>
         </QIcon>
     </span>

src/pages/Monitor/locale/en.yml

@@ -38,6 +38,7 @@ salesTicketsTable:
     payMethod: Pay method
     department: Department
     packing: ITP
+    hasItemLost: Item lost
 searchBar:
     label: Search tickets
     info: Search tickets by id or alias

src/pages/Monitor/locale/es.yml

@@ -39,6 +39,7 @@ salesTicketsTable:
     payMethod: Método de pago
     department: Departamento
     packing: ITP
+    hasItemLost: Artículo perdido
 searchBar:
     label: Buscar tickets
     info: Buscar tickets por identificador o alias

src/pages/Ticket/Card/TicketDescriptor.vue

@@ -9,6 +9,8 @@ import VnLv from 'src/components/ui/VnLv.vue';
 import useCardDescription from 'src/composables/useCardDescription';
 import VnUserLink from 'src/components/ui/VnUserLink.vue';
 import { toDateTimeFormat } from 'src/filters/date';
+import FetchData from 'src/components/FetchData.vue';
+import TicketProblems from 'src/components/TicketProblems.vue';
 
 const $props = defineProps({
     id: {
@@ -28,6 +30,7 @@ const { t } = useI18n();
 const entityId = computed(() => {
     return $props.id || route.params.id;
 });
+const problems = ref({});
 
 const filter = {
     include: [
@@ -113,6 +116,11 @@ const setData = (entity) => {
 </script>
 
 <template>
+    <FetchData
+        :url="`Tickets/${entityId}/getTicketProblems`"
+        auto-load
+        @on-fetch="(data) => ([problems] = data)"
+    />
     <CardDescriptor
         module="Ticket"
         :url="`Tickets/${entityId}`"
@@ -167,48 +175,9 @@ const setData = (entity) => {
             <VnLv :label="t('globals.warehouse')" :value="entity.warehouse?.name" />
             <VnLv :label="t('globals.alias')" :value="entity.nickname" />
         </template>
-        <template #icons="{ entity }">
+        <template #icons>
-            <QCardActions class="q-gutter-x-md">
+            <QCardActions class="q-gutter-x-xs">
-                <QIcon
+                <TicketProblems :row="problems" />
-                    v-if="entity.client.isActive == false"
-                    name="vn:disabled"
-                    size="xs"
-                    color="primary"
-                >
-                    <QTooltip>{{ t('Client inactive') }}</QTooltip>
-                </QIcon>
-                <QIcon
-                    v-if="entity.client.isFreezed == true"
-                    name="vn:frozen"
-                    size="xs"
-                    color="primary"
-                >
-                    <QTooltip>{{ t('Client Frozen') }}</QTooltip>
-                </QIcon>
-                <QIcon
-                    v-if="entity?.problem?.includes('hasRisk')"
-                    name="vn:risk"
-                    size="xs"
-                    color="primary"
-                >
-                    <QTooltip>{{ t('Client has debt') }}</QTooltip>
-                </QIcon>
-                <QIcon
-                    v-if="entity.client.isTaxDataChecked == false"
-                    name="vn:no036"
-                    size="xs"
-                    color="primary"
-                >
-                    <QTooltip>{{ t('Client not checked') }}</QTooltip>
-                </QIcon>
-                <QIcon
-                    v-if="entity.isDeleted == true"
-                    name="vn:deletedTicket"
-                    size="xs"
-                    color="primary"
-                >
-                    <QTooltip>{{ t('This ticket is deleted') }}</QTooltip>
-                </QIcon>
             </QCardActions>
         </template>
         <template #actions="{ entity }">

src/pages/Ticket/Card/TicketSale.vue

@@ -24,6 +24,7 @@ import axios from 'axios';
 import VnTable from 'src/components/VnTable/VnTable.vue';
 import VnUsesMana from 'src/components/ui/VnUsesMana.vue';
 import VnConfirm from 'src/components/ui/VnConfirm.vue';
+import TicketProblems from 'src/components/TicketProblems.vue';
 import RightMenu from 'src/components/common/RightMenu.vue';
 
 const route = useRoute();
@@ -56,7 +57,7 @@ const canProceed = ref();
 
 watch(
     () => route.params.id,
-    () => tableRef.value.reload()
+    () => tableRef.value.reload(),
 );
 
 const columns = computed(() => [
@@ -199,7 +200,7 @@ const changeQuantity = async (sale) => {
         await updateQuantity(sale);
     } catch (e) {
         const { quantity } = tableRef.value.CrudModelRef.originalData.find(
-            (s) => s.id === sale.id
+            (s) => s.id === sale.id,
         );
         sale.quantity = quantity;
         throw e;
@@ -503,7 +504,7 @@ async function isSalePrepared(item) {
                         componentProps: {
                             title: t('Item prepared'),
                             message: t(
-                                'This item is already prepared. Do you want to continue?'
+                                'This item is already prepared. Do you want to continue?',
                             ),
                             data: item,
                         },
@@ -525,7 +526,7 @@ watch(
         if (newItemFk) {
             updateItem(newRow.value);
         }
-    }
+    },
 );
 </script>
 
@@ -595,7 +596,7 @@ watch(
                         openConfirmationModal(
                             t('Continue anyway?'),
                             t('You are going to delete lines of the ticket'),
-                            removeSales
+                            removeSales,
                         )
                     "
                 >
@@ -679,53 +680,7 @@ watch(
         :disabled-attr="isTicketEditable"
     >
         <template #column-statusIcons="{ row }">
-            <router-link
+            <TicketProblems :row="row" />
-                v-if="row.claim?.claimFk"
-                :to="{ name: 'ClaimBasicData', params: { id: row.claim?.claimFk } }"
-            >
-                <QIcon color="primary" name="vn:claims" size="xs">
-                    <QTooltip>
-                        {{ t('ticketSale.claim') }}:
-                        {{ row.claim?.claimFk }}
-                    </QTooltip>
-                </QIcon>
-            </router-link>
-            <QIcon v-if="row.visible < 0" color="primary" name="warning" size="xs">
-                <QTooltip>
-                    {{ t('ticketSale.visible') }}: {{ row.visible || 0 }}
-                </QTooltip>
-            </QIcon>
-            <QIcon
-                v-if="row.reserved"
-                color="primary"
-                name="vn:reserva"
-                size="xs"
-                data-cy="ticketSaleReservedIcon"
-            >
-                <QTooltip>
-                    {{ t('ticketSale.reserved') }}
-                </QTooltip>
-            </QIcon>
-            <QIcon
-                v-if="row.itemShortage"
-                color="primary"
-                name="vn:unavailable"
-                size="xs"
-            >
-                <QTooltip>
-                    {{ t('ticketSale.noVisible') }}
-                </QTooltip>
-            </QIcon>
-            <QIcon
-                v-if="row.hasComponentLack"
-                color="primary"
-                name="vn:components"
-                size="xs"
-            >
-                <QTooltip>
-                    {{ t('ticketSale.hasComponentLack') }}
-                </QTooltip>
-            </QIcon>
         </template>
         <template #body-cell-picture="{ row }">
             <QTd>

src/pages/Ticket/Card/TicketSummary.vue

@@ -20,6 +20,7 @@ import ZoneDescriptorProxy from 'src/pages/Zone/Card/ZoneDescriptorProxy.vue';
 import VnSelect from 'src/components/common/VnSelect.vue';
 import VnToSummary from 'src/components/ui/VnToSummary.vue';
 import TicketDescriptorMenu from './TicketDescriptorMenu.vue';
+import TicketProblems from 'src/components/TicketProblems.vue';
 
 const route = useRoute();
 const { notify } = useNotify();
@@ -311,83 +312,7 @@ onMounted(async () => {
                     <template #body="props">
                         <QTr :props="props">
                             <QTd class="q-gutter-x-xs">
-                                <QBtn
+                                <TicketProblems :row="props.row" />
-                                    flat
-                                    round
-                                    icon="vn:claims"
-                                    v-if="props.row.claim"
-                                    color="primary"
-                                    :to="{
-                                        name: 'ClaimCard',
-                                        params: {
-                                            id: props.row.claim.claimFk,
-                                        },
-                                    }"
-                                >
-                                    <QTooltip>
-                                        {{ t('ticket.summary.claim') }}:
-                                        {{ props.row.claim.claimFk }}
-                                    </QTooltip>
-                                </QBtn>
-                                <QBtn
-                                    flat
-                                    round
-                                    icon="vn:claims"
-                                    v-if="props.row.claimBeginning"
-                                    color="primary"
-                                    :to="{
-                                        name: 'ClaimCard',
-                                        params: {
-                                            id: props.row.claimBeginning.claimFk,
-                                        },
-                                    }"
-                                >
-                                    <QTooltip>
-                                        {{ t('ticket.summary.claim') }}:
-                                        {{ props.row.claimBeginning.claimFk }}
-                                    </QTooltip>
-                                </QBtn>
-                                <QIcon
-                                    name="warning"
-                                    v-show="props.row.visible < 0"
-                                    color="primary"
-                                    size="xs"
-                                >
-                                    <QTooltip>
-                                        {{ t('globals.visible') }}:
-                                        {{ props.row.visible }}
-                                    </QTooltip>
-                                </QIcon>
-                                <QIcon
-                                    name="vn:reserved"
-                                    v-show="props.row.reserved"
-                                    color="primary"
-                                    size="xs"
-                                >
-                                    <QTooltip>
-                                        {{ t('ticket.summary.reserved') }}
-                                    </QTooltip>
-                                </QIcon>
-                                <QIcon
-                                    name="vn:unavailable"
-                                    v-show="props.row.itemShortage"
-                                    color="primary"
-                                    size="xs"
-                                >
-                                    <QTooltip>
-                                        {{ t('ticket.summary.itemShortage') }}
-                                    </QTooltip>
-                                </QIcon>
-                                <QIcon
-                                    name="vn:components"
-                                    v-show="props.row.hasComponentLack"
-                                    color="primary"
-                                    size="xs"
-                                >
-                                    <QTooltip>
-                                        {{ t('ticket.summary.hasComponentLack') }}
-                                    </QTooltip>
-                                </QIcon>
                             </QTd>
                             <QTd>
                                 <QBtn class="link" flat>

src/pages/Ticket/locale/en.yml

@@ -208,3 +208,9 @@ ticketList:
     toLines: Go to lines
     addressNickname: Address nickname
     ref: Reference
+    rounding: Rounding
+    noVerifiedData: No verified data
+    purchaseRequest: Purchase request
+    notVisible: Not visible
+    clientFrozen: Client frozen
+    componentLack: Component lack

src/pages/Ticket/locale/es.yml

@@ -213,3 +213,9 @@ ticketList:
     toLines: Ir a lineas
     addressNickname: Alias consignatario
     ref: Referencia
+    rounding: Redondeo
+    noVerifiedData: Sin datos comprobados
+    purchaseRequest: Petición de compra
+    notVisible: No visible
+    clientFrozen: Cliente congelado
+    componentLack: Faltan componentes

test/cypress/integration/ticket/ticketList.spec.js

@@ -53,4 +53,29 @@ describe('TicketList', () => {
         cy.checkNotification('Data created');
         cy.url().should('match', /\/ticket\/\d+\/summary/);
     });
+
+    it('should show the corerct problems', () => {
+        cy.intercept('GET', '**/api/Tickets/filter*', (req) => {
+            req.headers['cache-control'] = 'no-cache';
+            req.headers['pragma'] = 'no-cache';
+            req.headers['expires'] = '0';
+
+            req.on('response', (res) => {
+                delete res.headers['if-none-match'];
+                delete res.headers['if-modified-since'];
+            });
+        }).as('ticket');
+
+        cy.get('[data-cy="Warehouse_select"]').type('Warehouse Five');
+        cy.get('.q-menu .q-item').contains('Warehouse Five').click();
+        cy.wait('@ticket').then((interception) => {
+            const data = interception.response.body[1];
+            expect(data.hasComponentLack).to.equal(1);
+            expect(data.isTooLittle).to.equal(1);
+            expect(data.hasItemShortage).to.equal(1);
+        });
+        cy.get('.icon-components').should('exist');
+        cy.get('.icon-unavailable').should('exist');
+        cy.get('.icon-isTooLittle').should('exist');
+    });
 });