Supasate Choochaisri
94c5c18541
Add test to catch invalid date property
...
Signed-off-by: Supasate Choochaisri <supasate.c@gmail.com>
2016-07-14 17:27:02 +07:00
Ryan Graham
cca14a0230
Update URLs in CONTRIBUTING.md ( #1002 )
2016-07-13 17:53:36 -07:00
Miroslav Bajtoš
06cac9e7d4
Merge pull request #996 from strongloop/fix/order-in-find
...
Ensure stable order of items in DAO.find()
2016-07-13 15:15:44 +02:00
Miroslav Bajtoš
699e0587d1
Ensure stable order of items in DAO.find()
...
When post-processing result of find operation, use "async.map"
instead of "async.each + array.push" to ensure the order of items
is preserved.
2016-07-13 14:55:49 +02:00
Amir-61
f7e2021e93
Merge pull request #989 from strongloop/test_updateOrCreate_non_autogeneratedId
...
Add test for updateOrCreate
2016-07-11 10:23:31 -04:00
Amir Jafarian
9f0c10fdff
Add test for updateOrCreate
...
* Add test for updateOrCreate when id is not autogenerated Id
2016-07-07 12:55:22 -04:00
Rand McKinney
45e14af4a9
Update validations.js
...
Fix API doc per https://github.com/strongloop/loopback/issues/2472
2016-06-29 16:13:44 -07:00
Gunjan Pandya
6bc4441850
Merge pull request #976 from strongloop/compatflag-cleanup
...
[SEMVER-MAJOR] Remove DataSource.registerType()
2016-06-29 13:32:29 -04:00
gunjpan
8076be2db1
Remove DataSource.registerType()
...
Result of compat flag cleanup.
- Current implementation has a wrapper
DataSource.registerType() for
ModelBuilder.registerType(). This removes
the wrapper to encourage use of original
method
2016-06-28 14:45:42 -04:00
RobinBiondi
fbe58f7cf8
give options to validators #984
2016-06-24 14:44:43 -07:00
Gunjan Pandya
e0a68289c5
Merge pull request #947 from strongloop/update-errormsg
...
[SEMVER-MAJOR] Throw Error for property names with dots
2016-06-24 16:50:00 -04:00
Amir-61
73bb418719
Merge pull request #960 from strongloop/fix/connection-err-msg
...
Update datasource.js
2016-06-17 11:29:26 -04:00
Miroslav Bajtoš
058d9d46c0
3.0.0-alpha.5
...
* Give warning if PK is changed in hooks (Amir Jafarian)
* Remove model events (Candy)
* Persist changes on parent for embedsOne (Dimitris Halatsis)
* Fix (Amir Jafarian)
* Fix error message (Amir Jafarian)
* ModelBuilder: add new setting strictEmbeddedModels (Dimitris Halatsis)
* Retun err for UPSERT if the connector returns err (Amir Jafarian)
* fix error handling when applying undefined mixins (Alex Pitigoi)
* Add test's description (Amir Jafarian)
* Fix incompatibility between different connectors (Amir Jafarian)
* travis: add v4, v6, drop io.js (Miroslav Bajtoš)
* fix avoid duplicate record on scope with promise (Alex Pitigoi)
* Document promise support for DAO::find (Sequoia McDowell)
* Set ESLint as devdep (Simon Ho)
* Use mocha instead of Makefile for testing (Simon Ho)
* DAO.create: don't return the instance (Miroslav Bajtoš)
* RELEASE-NOTES: describe 30283291
(Miroslav Bajtoš)
* Implement operation hooks for EmbedsMany methods (Miroslav Bajtoš)
* Implement operation hooks for EmbedsOne methods (Miroslav Bajtoš)
* eslint config 2.0 + remove extra empty lines (Miroslav Bajtoš)
* Test coverages for hashed password (Amir Jafarian)
* Fix `forceId` check for `replaceById` (Amir Jafarian)
* Fix `notify` bugs for `find` (Amir Jafarian)
* test: extract hook-monitor helper (Miroslav Bajtoš)
* test: extract uid-generator helper (Miroslav Bajtoš)
* test: extract context-test-helpers (Miroslav Bajtoš)
* Define `patch` aliases (Amir Jafarian)
2016-06-13 16:31:19 +02:00
gunjpan
8117b0403f
Throw Error for property names with dots
...
Result of Compat Flags Clenup.
Throws an error for property names with dots, instead
of a deprecation warning.
2016-06-09 17:50:59 -04:00
Amir-61
366e93f50b
Merge pull request #952 from strongloop/avoid_changing_PK_when_forceId_is_set
...
Give warning if PK is changed in hooks
2016-06-08 14:53:04 -04:00
Amir Jafarian
7a8803cb38
Give warning if PK is changed in hooks
...
* Give warning if PK is changed in `before save` and `loaded`
operation hooks for replaceById
2016-06-08 11:56:19 -04:00
Candy
a55bf40ee9
Merge pull request #965 from strongloop/remove_events
...
[SEMVER-MAJOR] Remove model events
2016-06-08 11:11:28 -04:00
Candy
3daca1e960
Remove model events
2016-06-08 10:27:05 -04:00
Dimitris Halatsis
ea2266e453
Persist changes on parent for embedsOne
...
Allow direct save of changes on embedded model to be persisted on
parent document.
Person.embedsOne(Address);
Person.findById(someId)
.then(function(p){
var address = p.addressItem();
address.street = 'new street'
// This will now persist changes on parent document
return address.save();
})
[forward-port of #949 ]
2016-06-07 17:24:59 +02:00
Amir-61
b039b51610
Merge pull request #964 from strongloop/fixup-master
...
Fix
2016-06-04 21:23:16 -04:00
Amir Jafarian
8f2077e344
Fix
2016-06-03 18:00:21 -04:00
Ritchie Martori
293a22fd31
Update datasource.js
...
Return a real `Error` message for the default `ping()` method.
2016-06-02 14:02:06 -07:00
Amir-61
6028826826
Merge pull request #953 from strongloop/fix_error_message
...
Fix error message
2016-06-02 08:24:59 -04:00
Amir Jafarian
cae44f0458
Fix error message
...
*Fix error message when PK is changed in `replaceById`
2016-06-01 16:16:35 -04:00
Amir-61
8f347fbacb
Merge pull request #954 from strongloop/callback_err_from_connector_UPSERT
...
Retun err for UPSERT if the connector returns err
2016-06-01 15:51:35 -04:00
Miroslav Bajtoš
0e4af6d453
Merge pull request #955 from strongloop/feature/strictEmbeddedModels
...
ModelBuilder: add new setting strictEmbeddedModels
2016-06-01 13:39:51 +02:00
Dimitris Halatsis
b7ba73f1b1
ModelBuilder: add new setting strictEmbeddedModels
...
The setting controls the strict mode used for embedded property types,
for example the type of "address" property in this model definition:
modelBuilder.define('TestEmbedded', {
name: 'string',
address: {
street: 'string',
},
});
2016-06-01 13:12:50 +02:00
Miroslav Bajtoš
6ec66a7e4a
Merge pull request #950 from strongloop/add_test_description
...
Add test's description
2016-06-01 09:57:53 +02:00
Amir Jafarian
82546fdf47
Retun err for UPSERT if the connector returns err
2016-05-31 22:17:23 -04:00
Alex Pitigoi
5b025075dc
Merge pull request #944 from strongloop/fix-mixin-err-handler
...
[SEMVER-MAJOR] throw error for undefined mixin
2016-05-31 13:10:08 -04:00
Alex Pitigoi
423db34bf3
fix error handling when applying undefined mixins
2016-05-31 12:24:04 -04:00
Amir Jafarian
2b6ced06a1
Add test's description
2016-05-31 11:13:28 -04:00
Amir-61
1f94f63bc1
Merge pull request #938 from strongloop/replace_incompatibility_fix
...
Fix incompatibility between different connectors for replace methods
2016-05-28 09:06:34 -04:00
Amir Jafarian
d9a3f6226a
Fix incompatibility between different connectors
...
* Fix incompatibility for replace methods between different connectors.
2016-05-27 13:45:24 -04:00
Miroslav Bajtoš
795952c182
Merge pull request #943 from strongloop/fix/travis
...
travis: add v4, v6, drop io.js
2016-05-23 11:24:06 +02:00
Miroslav Bajtoš
376ac4649e
travis: add v4, v6, drop io.js
2016-05-23 11:13:40 +02:00
Miroslav Bajtoš
119a1bc6c4
Merge pull request #937 from strongloop/juggler-rel-test
...
fix avoid duplicate record on scope with promise
2016-05-20 14:56:55 +02:00
Alex Pitigoi
0e89a9c837
fix avoid duplicate record on scope with promise
2016-05-19 15:47:31 -04:00
Simon Ho
3113333cb2
Merge pull request #922 from Sequoia/patch-2
...
Document promise support for DAO::find
2016-05-11 16:10:48 -07:00
Sequoia McDowell
ae7a5df47b
Document promise support for DAO::find
...
It was previously completely undocumented. There are additional methods that add promises but I figure accurately documenting some is better than none. :)
2016-05-11 09:58:22 -04:00
Simon Ho
71e7e5b618
Merge pull request #926 from strongloop/refactor/set-eslint-as-devdep
...
Set ESLint as devdep
2016-05-10 13:35:33 -07:00
Simon Ho
dae0bf863e
Set ESLint as devdep
2016-05-10 12:38:30 -07:00
Simon Ho
1d39e41d00
Merge pull request #924 from strongloop/refactor/remove-makefile
...
Use mocha instead of Makefile for testing
2016-05-10 11:59:33 -07:00
Simon Ho
5be2b3f867
Use mocha instead of Makefile for testing
2016-05-10 11:56:35 -07:00
Miroslav Bajtoš
2189b9a746
Merge pull request #918 from strongloop/fix/remove-chaining-in-create
...
[SEMVER-MAJOR] DAO.create: don't return the instance
2016-05-02 13:09:03 +02:00
Miroslav Bajtoš
8ad53a4c0e
DAO.create: don't return the instance
...
Simplify DataAccessObject.create() and stop returning the
instance/array of instances. Users should always use callback (or
returned promise) to get the instance(s) created.
2016-04-29 14:16:06 +02:00
Miroslav Bajtoš
89bf94245b
Merge pull request #917 from strongloop/doc/add-item-to-release-notes
...
RELEASE-NOTES: describe 30283291
2016-04-28 19:10:30 +02:00
Miroslav Bajtoš
41d71c5a5b
RELEASE-NOTES: describe 30283291
...
Add an entry for a breaking change made in 30283291
that was not
described previously.
2016-04-28 13:23:50 +02:00
Miroslav Bajtoš
ca0c3aaa47
Merge pull request #911 from strongloop/feature/hooks-for-embeds-many
...
Implement operation hooks for EmbedsMany methods
2016-04-27 17:05:59 +02:00
Miroslav Bajtoš
9bde8f859b
Implement operation hooks for EmbedsMany methods
...
create() triggers
- before save
- after save
updateById() triggers
- before save
- after save
destroy() triggers
- before delete
- after delete
The implementation here is intentionally left with less features
than the regular DAO methods provide, the goal is to get a partial
(but still useful!) version released soon.
Limitations:
- `before save` & `after save` hooks don't provide `ctx.isNewInstance`
- async validations are not supported yet
- `persist` and `loaded` hooks are not triggered at all
- `before delete` hook does not provide `ctx.where` property and
it's not possible to change the outcome of `destroy()` using this
hook. Note that regular DAO does support this.
- updating embedded instances triggers update of the parent (owning)
model, which is correct and expected. However, the context provided
by `before save` and `after save` hooks on the parent model is sort of
arbitrary and may include wrong/extra data. The same probably applies
to the scenario when deleting embedded instances triggers update of
the parent model.
2016-04-27 11:04:15 +02:00