853ca03491
Use bluebird in utils.js
...
Replace `global.Promise` with `bluebird`
2016-01-07 15:27:33 -05:00
b509c759c4
Merge pull request #796 from strongloop/fix/various
...
Various fixes in operation hooks
2016-01-05 11:08:35 +01:00
5d453b5038
Revert "Correct syntax for should and more"
...
This reverts commit 62de2ed69e
2015-12-23 15:41:16 -08:00
b63133d1d6
Fix test for shouldjs 8.0.2 upgrade
2015-12-22 15:03:50 -08:00
e9899a93cf
Enhance "persist" hook in DAO.updateOrCreate
...
Report `ctx.isNewInstance` when the connector provides this info.
2015-12-18 16:08:38 +01:00
fd9bef4aa7
Enhance "persisted" hook in DAO.updateAttributes
...
Add `isNewInstance:false` to the context reported by
DAO.updateAttributes()
2015-12-18 16:08:01 +01:00
3028329126
"loaded" hook in DAO.find: ctx.data, not instance
...
Fix the implementation od DAO.find to provide "ctx.data" to the
"loaded" hook.
2015-12-18 15:54:35 +01:00
62de2ed69e
Correct syntax for should and more
...
This fixes lots of failures in connectors
2015-12-16 16:24:48 -05:00
9cfda16194
Fix failing test for MongoDB connector
2015-12-09 12:58:21 -08:00
80c3bd9d41
Merge pull request #752 from ernie58/optionalValidation
...
make automatic validation optional
2015-12-04 17:03:28 +01:00
0f3f27af51
Make automatic validation optional
...
Make automatic validation optional on all CRUD methods in a loopback
model. This can be done in 2 ways
- set `automaticValidation` in the model settings
- set `validate` on the options passed when calling the crud methods
The options take precedence on the model setting.
By default the automatic validation remains true to be backwards
compatible
2015-12-03 16:34:25 +01:00
6f7fc5030a
Merge branch 'fix_update_attributes_error' of https://github.com/wpjunior/loopback-datasource-juggler into wpjunior-fix_update_attributes_error
2015-11-26 09:31:40 -08:00
bd314e6a87
Merge branch 'with-simpe-and-fast-hasmany' of https://github.com/wertlex/loopback-datasource-juggler into wertlex-with-simpe-and-fast-hasmany
2015-11-23 15:21:18 -08:00
d8678a1f03
Correction of a regression introduced by commit 632898b: when querying an empty array ([]) with a 'neq' filter, there were no matching.
2015-11-23 17:09:24 +01:00
d7bbd7e215
Fix the typo
2015-11-17 13:27:41 -08:00
c26b857a87
UpdateAttributes: Raises an error if database fails
...
Signed-off-by: Wilson Júnior <wilsonpjunior@gmail.com>
2015-11-17 17:10:11 -02:00
d9918d526a
dropped unused functions and tests fixed
2015-10-30 21:36:50 +06:00
638002bc59
Looks better now
2015-10-30 21:15:48 +06:00
ef7fe45d9c
Rewrite of variable
2015-10-16 18:25:23 +02:00
7c22db6ea7
Filtering relations of a model with an order specified
2015-10-16 18:21:04 +02:00
0864bf7154
with updated map which stores original key and tests for them
2015-10-10 19:21:06 +05:00
94c3f9a432
Ability to define normalization of undefined query
...
Add datasource and model setting `normalizeUndefinedInQuery`
to determine how it will handle undefined values. Options:
- nullify : converts undefined to null
- throw : throw an error on undefined value
- ignore : strip the key where undefined value is found
The default operation is to strip the key.
2015-10-07 09:26:09 -07:00
1e035c657e
Fix the test so that it works across DBs
2015-09-11 11:15:00 -07:00
a6519bb2ca
Fix id comparision in tests so that they work with mongodb object id
2015-09-08 09:53:02 -07:00
207edd5eec
Merge pull request #687 from sklyukin/master
...
primaryKey to hasOne relation
2015-09-08 09:20:42 -07:00
fb11c78be0
Add support for using UUID V4 as defaultFn
2015-09-02 16:39:00 +02:00
d0f9b760f5
primaryKey for hasMany and belongsTo relations
2015-09-01 19:03:02 +05:00
483cd873e7
primaryKey to hasOne relation
2015-09-01 01:31:28 +05:00
cb78c8ef96
Add direct copmarison value for array matching
2015-08-27 23:56:49 -04:00
632898b022
Add support for matching array values à la mongo.
2015-08-27 23:32:53 -04:00
682f6340d3
Optimze automigrate() to cut the test time signicantly
2015-08-27 15:59:58 -07:00
57a9c40e16
Fix primary key checks
2015-08-27 13:59:43 -07:00
fb56915371
Dirty merge. Tests are broken
2015-08-24 16:07:43 +03:00
e585021586
include utils add. Tests ported to should.js
2015-08-24 15:41:04 +03:00
cd71a37bfa
Relax id requirement for basic query operations
2015-08-20 02:57:53 -07:00
0381f6d7e7
Support embedded query in memory connector. Fix memory connector bug
...
Adds support for the ability to query embedsMany models from the parent.
Fix a memory connector bug that could occur when having an "or" or "and"
clause combined with another property. In that case, the and would revert
true for 'Paul McCartney'
```
{name:'John Lennon',and: [{role:'lead'}, {vip:true}]}}
```
2015-08-18 15:56:36 -04:00
d14721656f
Merge pull request #691 from strongloop/do-not-coerce-regexp-to-string
...
Do not coerce RegExp objects to strings
2015-08-14 09:14:05 -07:00
e7e074f97b
Do not coerce RegExp objects to strings
...
Queries like `{where: {name: /John.*/i}}` should work. Notice there is no
`regexp` operator (ie. `{where: {name: {regexp: /John.*/i}}}`).
2015-08-13 16:16:48 -07:00
2120e53f7f
Indicate result of destroyById/protototype.destroy
...
Return `info.count` to the callback to indicate whether the model
instance was deleted or not. When Model's `settings.strictDelete`
is true, return 404 error when the model instance was not found.
2015-08-10 17:38:46 +02:00
90ee9a1af3
fixes issue 673: Include hasMany of relation does not return empty array
2015-07-31 14:47:22 -07:00
6513d9658f
Fix the test case with automigrate
2015-07-30 11:24:47 -07:00
c45bde7ccf
Merge pull request #647 from PradnyaBaviskar/issue-418-discover
...
Promisify all 'discover' methods
2015-07-29 07:43:39 -07:00
ce57234d5e
Merge branch 'issue656-findLoadedAsync' of https://github.com/PradnyaBaviskar/loopback-datasource-juggler into PradnyaBaviskar-issue656-findLoadedAsync
2015-07-29 07:33:21 -07:00
fee103d9d7
Remove test for unused utility function
2015-07-28 17:45:38 -07:00
b2b5a0d920
Merge pull request #665 from strongloop/add-regex-support
...
Add support for RegExp operator
2015-07-28 15:22:02 -07:00
b8f1598723
Add support for regex operator
2015-07-27 15:11:53 -07:00
de0ca3c61f
Async 'loaded' hook for find
2015-07-27 18:58:29 +05:30
c63f3fb6cb
Promisify all 'discover' methods
2015-07-24 12:07:22 +05:30
b08b6dd954
Merge pull request #650 from PradnyaBaviskar/issue-649
...
Fix 'persist' hook for updateAttributes()
2015-07-23 08:27:07 -07:00
8a20e07b3d
Fix 'persist' hook for updateAttributes()
2015-07-23 15:25:50 +05:30
ef97a9037a
Merge pull request #666 from fabien/fix/update-strict
...
Filter attributes when strict: true
2015-07-22 08:18:29 -07:00
c969e48d0c
Make sure done() is called within the callback
2015-07-21 08:07:09 -07:00
c7caa0a7c1
Take strict: validate and throw settings into account
2015-07-21 13:33:42 +02:00
8b06a9d39d
Filter attributes when strict: true
2015-07-20 11:59:07 +02:00
342bc2f782
prevent upsert overwriting default values with applyDefaultValues option
...
Creates a new applyDefaultValues option on the Model constructor
defaulting to true, the current behaviour.
Updates the dao module to pass `{ applyDefaultValues: false }` to the
Model constructor during the updateOrCreate method when we assume an
update is happening.
2015-07-14 09:08:10 -07:00
1066313f3f
use fromDb to deserialize data after save in Memory connector
...
Changes the after `save` callback in the memory connector to use the
`fromDb` method to deserialize the data passed back to upsert and
updateAttributes methods.
2015-07-14 09:08:09 -07:00
6ce47f71b4
Correctly handle validatesUniquenessOf(idName)
2015-07-13 12:56:49 +02:00
6eb18cb2f6
Make sure base property definitions are cloned
...
Sub models sometimes need to customize the properties from the base model.
This change allows each sub model has its own copy of the base property
definition to avoid potential conflicts across multiple sub models of the
same base.
2015-07-10 10:03:51 -07:00
eb20eebe95
Fix the regression for date conversion
2015-07-03 09:29:26 -07:00
5290559a42
Don't cache static scope method results #575
2015-07-03 10:35:26 +02:00
4206088fbc
Fix the regexp value for like/nlike
2015-07-02 23:22:36 -07:00
bcd477358f
Assert the existence of instance
2015-07-02 14:56:46 -07:00
eb6fa410fe
Fix coercion from ObjectID to String
2015-07-01 14:58:14 -07:00
e55469693d
test: fix persistence-hooks failures in MySQL
2015-06-24 18:31:30 +02:00
293240d752
Merge pull request #599 from PradnyaBaviskar/issue-441
...
Add new hook 'loaded'
2015-06-24 16:35:50 +02:00
e7430184a9
Promisify 'autoupdate'
2015-06-23 18:02:08 +05:30
20cf67d798
Add new hook 'loaded'
2015-06-23 12:04:46 +05:30
97f905ff1f
Fix the test case
2015-06-16 13:35:35 -07:00
bbe9cb350c
Merge pull request #626 from walkonsocial/include-issues
...
Fix for issues #622 & #623
2015-06-16 08:55:29 -07:00
ecb8968166
Merge pull request #630 from PradnyaBaviskar/issue-418
...
Promisify 'automigrate'
2015-06-16 10:46:07 +03:00
f4f13a6626
Promisify 'automigrate'
2015-06-16 12:58:21 +05:30
b0f1aae533
Fix the test case as updateAll takes `where` directly
2015-06-15 15:17:47 -07:00
052e22ab43
Fix for issues #622 & #623
...
polymorphic hasOne needs separate handling and hasMany->referencesMany has a unique case which is fixed for MongoDB as suggested by @fabien.
2015-06-12 01:55:25 +05:30
3b0e77cb0a
Add new hook 'persist'
2015-06-10 16:19:13 +05:30
493d98f66b
Dedupe ids args of inq for include
2015-05-29 10:50:37 -07:00
c9d6071485
Fix the test case
2015-05-29 08:57:28 -07:00
b8b4d95e7e
Merge pull request #584 from violet-day/feature/scope-dynamic-query
...
add test suit for scope - dynamic function
2015-05-28 14:45:14 -07:00
e0e6a0cdbb
Merge pull request #588 from mamboer/master
...
fix issue #587
2015-05-28 14:44:11 -07:00
46e6ad2fd6
Merge pull request #602 from strongloop/feature/more-tests-for-observers
...
Enhance the apis and add more tests
2015-05-27 11:08:00 -07:00
621adf5435
Enhance the apis and add more tests
2015-05-26 10:15:39 -07:00
69bd7c1233
Merge remote-tracking branch 'upstream/master'
2015-05-26 12:28:11 +08:00
a028b2644c
Fix for https://github.com/strongloop/loopback/issues/1401
2015-05-22 11:39:37 -07:00
12dea6e1cb
Merge pull request #598 from strongloop/feature/add-connector-hooks
...
Mix in observer apis to the connector
2015-05-21 10:43:32 -07:00
5af6bf54df
Merge pull request #597 from strongloop/feature/enhance-fields-to-array
...
Enhance fieldsToArray to consider strict mode
2015-05-21 09:43:40 -07:00
506223885d
Mix in observer apis to the connector
2015-05-20 15:02:44 -07:00
cbb8d7c789
Remove dep on sinon
2015-05-20 09:13:56 -07:00
966bb56c31
Enhance fieldsToArray to consider strict mode
2015-05-19 22:32:03 -07:00
eac74ad014
Make sure relation scope is applied during include
2015-05-16 11:49:02 -07:00
5ff3798e8e
enhancement on #588
2015-05-14 09:55:54 +08:00
ba68df3ef3
Merge remote-tracking branch 'upstream/master'
2015-05-14 09:26:50 +08:00
f9bd1544f9
Merge branch 'include-db-call-spike' of https://github.com/walkonsocial/loopback-datasource-juggler into walkonsocial-include-db-call-spike
2015-05-13 13:15:46 -07:00
d009557a76
DB Call Optimization in relation includes - Fixes #408 & #166
2015-05-14 00:19:43 +05:30
5ef444e45d
Conditionally pass options to connector CRUD methods
2015-05-13 09:36:45 -07:00
d27b2eb25f
fix issue #587
2015-05-13 13:18:50 +08:00
61dc239bd8
add test suit for scope - dynamic function
2015-05-11 12:05:22 +08:00
df7d221f31
Pass-through options from save to create
2015-05-10 10:44:22 +02:00
128665f1bd
Merge pull request #578 from strongloop/fix/validate-upsert
...
dao: support validateUpsert:false
2015-05-05 17:50:50 +02:00
9bc79d2366
dao: support validateUpsert:false
...
- validateUpsert:true reports validation errors back to the callback
- validateUpsert:false does not call `isValid()` at all
- any other value report validation errors via `console.warn`
2015-05-05 08:24:08 +02:00
f4be88357c
Add unit-test for "array" type
...
Add a unit-test to capture the fact that a property type can be
specified as `type: 'array'`.
2015-05-04 15:00:06 +02:00
33bbd8634c
Fix the test cases
2015-04-24 16:50:15 -07:00
3aa90751be
Merge branch 'merge-inclusion' of https://github.com/walkonsocial/loopback-datasource-juggler into walkonsocial-merge-inclusion
2015-04-24 16:12:38 -07:00
03a34fd086
Merge branch 'hasmanythrough-inconsitency' of https://github.com/walkonsocial/loopback-datasource-juggler into walkonsocial-hasmanythrough-inconsitency
2015-04-24 16:08:08 -07:00
9a7f13ff0f
Add support for merging include filters
2015-04-25 01:59:39 +05:30
7861c08e5a
add test case for hasmanythrough bi-drectional relations
2015-04-25 01:32:33 +05:30
c609b6d7ce
Allow leading slash for `path` in model settings
2015-04-24 08:23:13 -07:00
40eecd98c9
validations: treat `NaN` as a blank value
...
When a required number property is set to NaN, for example as a result
of coersion (`Number([1,2,3])`), the "presence" validation now correctly
reports an error.
2015-04-22 19:57:48 +02:00
c338c2326d
Merge pull request #561 from strongloop/feature/allow-name-mapper-for-discovery
...
Allow custom name mapping for discovered models
2015-04-22 08:43:09 -07:00
1e70678fa7
Allow custom name mapping for discovered models
2015-04-22 08:42:47 -07:00
b642d52fbe
Merge pull request #565 from strongloop/feature/validate-upsert
...
Validate model on updateOrCreate (upsert).
2015-04-17 17:20:55 +02:00
988a929577
Extend findById to accept an optional filter object
2015-04-16 09:06:53 -07:00
3df62444d6
Validate model on updateOrCreate (upsert).
...
Fix the implementation of updateOrCreate (a.k.a. upsert) to validate
the model before calling the connector.
In order to preserve backwards compatibility, validation errors are
only logged via console.warn by default.
The correct behaviour, where validation errors fail the updateOrCreate
operation, can be enabled via new model setting "validateUpsert".
2015-04-16 09:09:54 +02:00
99d4c6aa8d
Add new strict mode "validate"
...
When a model is configured with `strict: 'validate'`,
any dynamic properties not included in the schema trigger
a validation error.
2015-04-14 08:16:10 +02:00
29eb3434c7
Promisify model relation methods
...
When a callback is omitted from a method on a model relation that
supports promises, return that promise. This includes all the standard
DAO methods, as well as any user-defined methods that return promises.
e.g.:
mylist.todos.create({name: 'Item 1'}) // returns Promise
This API will use native ES6 promises if available. If not available,
or to force the use of another Promise library, you must assign the
global.Promise object.
e.g.:
global.Promise = require('bluebird')
Relations affected:
- BelongsTo
- HasOne
- HasMany
- HasManyThrough
- HasAndBelongsToMany
- ReferencesMany
- EmbedsOne
Exceptions:
The EmbedsMany relation has not been promisified, because most of the
methods return synchronous values.
The base relation getter method [e.g.: mylist.todos()] has not been
promisified, due to its default caching behavior.
New Methods:
- getAsync(condition, cb)
A new method "getAsync()" has been added to all relations except
EmbedsMany, which always fetches from the datasource rather than from
the cache. It takes an optional "where" condition (except for HasOne
and BelongsTo) and an optional callback. If the callback is omitted,
a Promise is returned.
2015-04-07 11:41:07 +02:00
16cc870f57
Merge pull request #544 from strongloop/feature/nesting-doc-query
...
Allow nesting properties to be queried for memory connector
2015-04-02 08:47:10 -07:00
cd7bc46efb
Deprecate property names containing a dot
2015-04-02 09:49:04 +02:00
a00b91db79
Fix test for "after save" called on save/CREATE
...
Fix the test to correctly trigger the code path where the connector
decides whether a new record is created or an existing one is updated.
2015-04-01 18:25:45 +02:00
17c8576097
Save parent model of embedded relations
2015-04-01 16:59:21 +02:00
8d1e782199
Merge pull request #546 from fabien/feature/scope-update-all
...
Implement scope.updateAll
2015-03-30 14:35:47 -07:00
44e5ad1fef
Merge pull request #549 from fabien/feature/hookstate-from-options
...
Allow passing in hookState from options
2015-03-30 14:35:34 -07:00
d18fa04ee9
Merge pull request #548 from strongloop/fix/persistUndefinedAsNull-tests-and-SQL
...
Fix persistUndefinedAsNull tests w/ SQL connectors
2015-03-30 19:28:40 +02:00
1ab3d74ab5
Pass options in operation hooks context.
2015-03-30 18:03:42 +02:00
7c7f04955d
Merge pull request #543 from strongloop/feature/fix-test-case
...
Fix the test cases so that they be run with the mssql connector
2015-03-30 08:25:10 -07:00
517ea875ec
Merge pull request #500 from 0angelic0/master
...
Remove and clear Operation Hook observers
2015-03-30 11:26:57 +02:00
b66d9fbc54
Fix persistUndefinedAsNull tests w/ SQL connectors
...
Check whether the connector enables strict mode and don't assert on
dynamic properties in such case.
2015-03-30 10:45:55 +02:00
7e55ef18f8
Implement scope.updateAll
2015-03-28 21:25:24 +01:00
137d096cfb
Allow nesting properties to be queried for memory connector
...
See https://github.com/strongloop/loopback/issues/517
2015-03-27 16:05:12 -07:00
d192b2ea05
Fix the test cases so that they be run with the mssql connector
...
For SQL server, if the PK is an identity, the id cannot be set for
insert.
2015-03-27 14:18:17 -07:00
9fd4c00225
Add model setting "persistUndefinedAsNull"
...
When the setting "persistUndefinedAsNull" is true,
the model will use `null` instead of `undefined` in
all property values.
- Known optional model properties are set to `null` when no value
was provided.
- When setting model properties, `undefined` is always converted
to `null`. This applies to both known (model-defined) properties
and additional (custom, dynamic) properties.
- The instance method `toObject()` converts `undefined` to `null` too.
Because `toJSON()` calls `toObject()` under the hood, the change
applies to `toJSON()` too.
2015-03-27 18:25:26 +01:00
311ab293d2
Clean up delete and update tests
2015-03-24 21:30:40 -07:00
f7540edf8a
Clean up wording in update/delete tests
2015-03-24 12:15:35 -07:00
8467243e63
Fix wording in update test
2015-03-24 11:47:13 -07:00
aa5943f6b0
Properly support embedsMany destroyAll
2015-03-24 15:39:55 +01:00
3f97586455
Clean up update/delete manipulation tests
2015-03-23 14:41:38 -07:00
35b549543d
test: fix test failure in MySQL connector
...
Fix a test using a string Person.id value to use a numeric value
instead, in order to support connectors that use numeric ids by default.
2015-03-23 09:18:46 +01:00
1fbaf4e382
Improve test failure messages
...
Replace
foo.count.should.equal(X)
Uncaught TypeError: Cannot read property 'should' of undefined
with
foo.should.have.property('count', X)`
Uncaught AssertionError: expected 0 to have property count
2015-03-23 08:44:53 +01:00
f7dc6fab90
Fix regression in prototype.save
...
ffcaa4e7
2015-03-23 08:34:21 +01:00
8199767a8a
Implement scope.findOne
2015-03-21 13:44:06 +01:00
5d0b745f31
Merge pull request #520 from fabien/feature/scope-find-by-id
...
Implement scope.findById
2015-03-20 12:00:56 -07:00
2f0561a7a8
Merge pull request #514 from fabien/feature/relation-methods
...
Enable defineMethod for singular relations
2015-03-20 11:57:45 -07:00
4ac227b052
Merge pull request #522 from strongloop/feature/enhance-id-comparison-for-updateAttributes
...
Enhance id comparision for updateAttributes
2015-03-20 11:06:57 -07:00
6a40a8a5e5
Enhance id comparision for updateAttributes
...
string/number and MongoDB ObjectID equality are now allowed.
2015-03-20 11:06:24 -07:00
84d538c1ca
Merge pull request #515 from strongloop/feature/isNewInstance
...
Add ctx.isNewInstance for "save" hooks
2015-03-20 18:33:55 +01:00
54781f376e
Enable custom methods on singular relations
2015-03-20 18:15:58 +01:00
34acc6c50a
Implement scope.findById
2015-03-20 16:37:46 +01:00
04f35b31b4
Memory connector returns updated records count
...
The memory connector now includes the number of updated items in its callback
when updating records.
2015-03-19 15:40:14 -07:00
a8d8556dcc
Merge pull request #499 from clarkorz/fix/merge-mixins
...
fix #429 Multiple Models can't mixin same class
2015-03-19 13:21:22 -07:00
ffcaa4e76e
Add ctx.isNewInstance for "save" hooks
...
"before save" hooks provide "ctx.isNewInstance" whenever "ctx.instance"
is set. Possible values:
- true for all CREATE operations
- false for all UPDATE operations
- undefined for "prototype.save"
"after save" hooks provide "ctx.isNewInstance" whenever "ctx.instance"
is set. Possible values:
- true after all CREATE operations
- false after all UPDATE operations
- undefined after "updateOrCreate" and "save"
Note: both "updateOrCreate" and "prototype.updateAttributes"
don't provide `ctx.instance` to "before save" hooks, therefore
`ctx.isNewInstance` it not provided either.
2015-03-19 18:05:24 +01:00
d731252941
deleteAll returns number of deleted records
...
The number is returned as `data.ctx` to `cb(null, data)`.
2015-03-19 17:54:22 +01:00
ae3dc3cec2
Merge pull request #510 from strongloop/fix/duplicate-create
...
Reject CREATE with a duplicate id
2015-03-19 17:37:01 +01:00
01fb5db550
Merge pull request #509 from dbarbeau/master
...
Enable "between" filter for memory db connector
2015-03-16 10:41:38 -07:00
6f11c2d717
DAO: Fix updateOrCreate to set persisted:true
...
Before this commit, the following code would not work:
Change.updateOrCreate({...}, function(err, ch) {
// somewhere later, modify "ch" and save the changes
ch.save(cb);
});
2015-03-16 18:26:42 +01:00
902772f1af
Reject CREATE with a duplicate id
...
Modify the memory connector to reject requests to create a record
with a duplicate id.
Add a unit-test to verify this behaviour across all connectors.
2015-03-16 18:26:42 +01:00
3de94cb9bd
add tests for between in memory connector
2015-03-16 18:26:33 +01:00
f91399a307
Fix the test case so that at least one property is to be changed
2015-03-16 09:26:03 -07:00
04348a1168
Make sure id properties cannot be changed
2015-03-16 09:25:38 -07:00
befe30f14a
Add abilities to remove and clear observers - Operation Hooks.
2015-03-11 18:08:35 +07:00
8605da3ac6
Improve instance-level operation hooks
...
"before delete" and "after delete" hooks receive `ctx.instance`
when a single model is being deleted.
"before save" hook receives `ctx.currentInstance` when triggered
by `prototype.updateAttributes()`.
Note that "after save" hook triggered by `prototype.updateAttributes()`
already provides `ctx.instance`.
2015-03-11 09:35:46 +01:00
90e169c1a6
fix #429 Multiple Models can't mixin same class
...
Signed-off-by: Clark Wang <clark.wangs@gmail.com>
2015-03-11 16:08:50 +08:00
2a24273b4f
Fix the test case
2015-03-10 21:26:36 -07:00
159be756ac
Merge pull request #494 from strongloop/feature/allow-submodel-to-hide-base-properties
...
Allow submodel to hide base properties
2015-03-09 13:16:09 -07:00
18b58558cc
Reformat notifyObserversOf context argument
2015-03-05 15:53:34 +01:00
f42859f2e5
Implement operation hooks' context
2015-03-05 11:55:04 +01:00
33d3239b44
Allow submodel to hide base properties
2015-03-03 10:27:22 -08:00
8042eeb3b1
Make sure inclusion filter is applied to the target model
...
See https://github.com/strongloop/loopback/issues/1076
2015-02-28 10:53:18 -08:00
1e6c453191
Add Promises to DAO
...
When a callback is omitted from a DAO method, return a Promise that
resolves to the value normally passed to the callback of that method.
If a callback is provided, behave normally.
This API will use native ES6 promises if available. If not available,
or to force the use of another Promise library, you must assign the
global.Promise object.
e.g.:
global.Promise = require('bluebird')
Class methods affected:
- create
- updateOrCreate / upsert
- findOrCreate
- exists
- find
- findOne
- findById
- findByIds
- remove / deleteAll / destroyAll
- removeById / deleteById / destroyById
- count
- update / updateAll
Prototype methods affected:
- save
- delete / remove / destroy
- updateAttribute
- updateAttributes
- reload
Exceptions / edge cases:
- create() used to return the data object that was passed in, even if
no callback was provided. Now, if a callback is provided, it will
return the data object, otherwise it will return a Promise.
- If create() is provided an array of data objects for creation, it
will continue to always return the array. This batch creation mode
does not support promises.
- findOrCreate() has a callback of the form: cb(err, instance, created),
with the extra parameter indicating whether the instance was created
or not. When called with its promise variant, the resolver will
receive a single array parameter: [instance, created]
2015-02-26 13:45:37 -07:00
3953cc3e2f
test for updateAll
2015-02-24 13:56:57 +02:00
9fd3865f32
Make sure models are migrated to avoid conflicts
2015-02-20 21:44:49 -08:00
a42e3b3d30
Add err checks
2015-02-20 21:14:48 -08:00
527d5f7a81
Fix findByIds test cases
2015-02-20 21:14:41 -08:00
195752eaad
Fix the idType so that it works with both MongoDB and RDBs
2015-02-20 16:39:48 -08:00
841f2d8f14
Tidy up tests so that they will work with RDBs
2015-02-20 16:10:25 -08:00
4c99fbabba
Merge pull request #459 from strongloop/feature/fix-test-date
...
Fix createdAt type so that it won't overflow SQL server int
2015-02-20 12:08:07 -08:00
ba0f3c1616
Add a new property option `defaultFn`
...
The property allows developers to specify that the default value
should be retrieved via a named function.
Only two built-in functions are supported at the moment:
"guid", "uuid" - generate a new GUID/UUID
"now" - use the current date and time
Support for custom (user-provided) functions is not implemented yet.
2015-02-20 20:08:25 +01:00
a713f25d61
Fix the null/undefined check
2015-02-20 09:55:09 -08:00
02503e7635
Fix createdAt type so that it won't overflow SQL server int
2015-02-20 09:33:54 -08:00
c939efe1e7
Merge pull request #445 from PradnyaBaviskar/issue292
...
Add $now as shortcut default value for date property
2015-02-17 19:46:05 +01:00
76ebdcb91b
ModelBaseClass: promise mode for notifyObserversOf
...
Support both promise and callback styles in
ModelBaseClass.notifyObserversOf.
When there is no callback supplied, the method returns a promise that
is resolved (or rejected) with the result.
2015-02-17 18:19:21 +01:00
a2836fbb56
ModelBaseClass: support promise-based observers
...
Allow the observer functions passed to `ModelBaseClass.observe`
to return a promise instead of calling the callback.
2015-02-17 17:31:42 +01:00
98fcf6b52c
use lodash to update the findBelongsTo which now returns an array of matches
2015-02-16 15:36:51 -08:00
aba7d0dc10
Add $now as shortcut default value for date property
2015-02-16 11:32:24 +05:30
46ff76dda0
Fix `deleteById(id)` and other test failures
2015-02-13 09:34:40 -08:00
bcbb9c580d
Merge branch 'featrue/support-connector-findOrCreate' of https://github.com/clarkorz/loopback-datasource-juggler into clarkorz-featrue/support-connector-findOrCreate
2015-02-11 20:49:51 -08:00
a8f3d21b65
Merge pull request #436 from strongloop/feature/fix-issue-293
...
Make sure base properties/settings are merged into the submodel
2015-02-11 16:13:00 -08:00
9bac813f59
Merge pull request #435 from strongloop/feature/add-options-to-crud-methods
...
Add an optional `options` argument to all CRUD methods
2015-02-11 10:31:18 -08:00
760ac97902
Add an optional `options` argument to all CRUD methods
2015-02-10 23:57:05 -08:00
32e534732c
Remove workaround for perfomance degradation
2015-02-10 13:28:47 +03:00
919d32c4dc
Change equal to eql to support mongodb ObjectID
2015-02-08 11:14:51 -08:00
ecf84bf802
Enhance the coercion for boolean/date types
...
See https://github.com/strongloop/loopback-connector-mongodb/issues/90
2015-02-08 10:54:42 -08:00
cd2bd34619
Make sure base properties/settings are merged into the submodel
...
See https://github.com/strongloop/loopback-datasource-juggler/issues/293
2015-02-07 11:15:28 -08:00
0bef56efc0
support optimized findOrCreate
...
Signed-off-by: Clark Wang <clark.wangs@gmail.com>
remove undefined for creating data in findOrCreate
Signed-off-by: Clark Wang <clark.wangs@gmail.com>
getLastGeneratedUid instead of force an id
Signed-off-by: Clark Wang <clark.wangs@gmail.com>
2015-02-07 10:23:04 +08:00
e9c966227d
Merge pull request #420 from aol-nnov/fkCustomDbType
...
Create model foreign key matching type of opposite part of relation (even if it has a custom field type)
2015-02-05 10:28:04 -08:00
c9e78f6bd2
Fix the perf around should.not.equal for complex objects
2015-02-05 08:22:17 -08:00
2e2e01cc5c
Merge pull request #430 from PradnyaBaviskar/issue709
...
Return 400 when client provides an incorrect value
2015-02-05 12:42:54 +01:00
be37fb4388
Return 400 when client provides an incorrect value
2015-02-05 16:58:42 +05:30
3ce6a2618f
testcase for #420
2015-02-05 10:12:34 +03:00
04083678c0
Relax "id" checks in test/manipulation.test.js
...
Use `eql` instead of `equal` to support non-scalar id values
used by MongoDB connector.
2015-02-04 19:20:56 +01:00
4889443ed0
Merge pull request #422 from strongloop/feature/fix-mongodb-issue-87
...
Remove undefined properties for create
2015-02-04 19:11:02 +01:00
7a7fcb2e34
test: undefined property values are preserved
2015-02-04 09:08:28 +01:00
3593127ef3
Update to `should` to the latest version 4.6.3
2015-02-03 11:44:15 +01:00
1f0f4b0f02
Relax the id equality test for mongodb object ids
2015-02-02 10:51:41 -08:00
9298919ec0
Merge pull request #418 from strongloop/feature/rename-query-to-access-hook
...
Rename hook "query" to "access"
2015-02-02 19:04:47 +01:00
4793546353
Merge pull request #400 from chrene/protected
...
Add support for protected properties.
2015-02-02 09:04:51 -08:00
bba1ce0768
Merge pull request #405 from clarkorz/fix/id-for-compositeIds
...
fix id property for composite ids
2015-02-02 08:59:40 -08:00
fd97b06bcc
Merge pull request #416 from strongloop/feature/fix-lb-1058
...
Fix id type issue for update
2015-02-02 08:58:10 -08:00
4afb2385a9
Fix id type issue for update
...
https://github.com/strongloop/loopback/issues/1058
2015-02-02 08:44:36 -08:00
fcaf19a1d2
Rename hook "query" to "access"
...
The name "query" creates incorrect assumption that hook handlers
may return the result of a query to bypass database access.
That is far from true, since this hook is called also by methods
like `deleteAll` or `updateAll` that don't perform any SELECT query.
2015-02-02 10:41:18 +01:00
370966df99
Implement intent hook `before delete`
...
Methods `DAO.deleteAll` and `DAO.prototype.delete` now invoke
`before delete` hook too. The hook receives `ctx.where` describing
models to be deleted.
2015-02-02 09:13:31 +01:00
842e543bf7
Merge pull request #415 from strongloop/fix/regression-in-dao-save
...
Fix regression in `.save()` from 1fd6eff
2015-01-30 18:28:10 +01:00
e41b2d9393
Merge pull request #414 from strongloop/feature/fix-hasone-remoting
...
Fix hasOne remoting
2015-01-30 08:23:46 -08:00
5cfbfe3a19
Fix regression in `.save()` from 1fd6eff1
...
The commit 1fd6eff1
2015-01-30 11:31:12 +01:00
e46bd0cdb5
Fix hasOne remoting
2015-01-29 23:26:11 -08:00
7d42202d40
Make sure batch create calls back with correct data
...
See https://github.com/strongloop/loopback/issues/1031
2015-01-29 11:52:39 -08:00
1fd6eff10f
Intent-based hooks for persistence
...
This patch introduces a new API for "intent-based" hooks. These hooks
are not tied to a particular method (e.g. "find" or "update"). Instead,
they are triggered from all methods that execute a particular "intent".
The consumer API is very simple, there is a new method
Model.observe(name, observer), where the observer is function
observer(context, callback).
Observers are inherited by child models and it is possible to register
multiple observers for the same hook.
List of hooks:
- query
- before save
- after save
- after delete
2015-01-29 08:43:52 +01:00
b3d07ebbe8
ModelBaseClass: implement async observe/notify
...
Implement infrastructure for intent-based hooks.
2015-01-29 08:43:50 +01:00
28f3f5d9f8
Fixed nullCheck in validations to correct behavior when dealing with undefined attributes
2015-01-27 22:18:47 +00:00
a08ef823be
Supply target to applyProperties function
2015-01-26 19:09:29 +01:00
2e9e2dd192
fix id property for composite ids
...
Signed-off-by: Clark Wang <clark.wangs@gmail.com>
2015-01-22 10:39:47 +08:00
c37de7f008
fix id properties should sort by its index
...
Signed-off-by: Clark Wang <clark.wangs@gmail.com>
2015-01-21 20:16:34 +08:00
7372fafc97
Fixed typos and logic for protected properties
2015-01-20 21:32:31 +01:00
d39f539413
adds support for protected properties.
2015-01-20 20:58:52 +01:00
83c3a17f87
support embeds data for belongsTo relation
...
Signed-off-by: Clark Wang <clark.wangs@gmail.com>
2015-01-19 22:56:09 +08:00
4aeb831bd5
Merge pull request #358 from clarkorz/fix/beforeCreate-belongsTo
...
fix recursive calls if create belongsTo model in beforeCreate hook
2015-01-14 14:42:29 -08:00
8dfe877639
Remove console.log
2015-01-14 11:51:47 -08:00
f1bdf50e2a
Merge pull request #387 from fabien/fix/coerce
...
Don't coerce nested objects into Model instances
2015-01-14 11:43:38 -08:00
e4fc38788f
Fix Model.prototype.inspect
...
Return the raw object data when running on Node v0.11.14+
That way all `inspect` options are always preserved.
When running on older version:
- Honour the depth argument passed to the custom `inspect` function.
- Disable color output, becase there is now way how to detect whether
colors were enabled or disabled by the top-level caller.
2015-01-12 17:12:18 +01:00
9b759c95ac
Include property value in the error message
...
When building a list of errors for `ValidationError.message`, include
the values of invalid properties too.
In order to keep the message reasonably short, the values are truncated
at approx 32 characters.
2015-01-12 17:12:18 +01:00
a24b222a72
Don't coerce nested objects into Model instances
...
For queries, this is undesirable. It also affects
loopback-connector-mongodb's ability to perform nested queries (it
expects plain objects to work correctly, and to allow $elemMatch for
example).
2015-01-08 15:34:04 +01:00
eac7526e80
Merge pull request #379 from cvette/memory-order-fix
...
fix sorting of undefined values in memory connector
2015-01-06 09:39:49 -08:00
99acd364d2
added test for sorting undefined values
2015-01-05 21:56:17 +01:00
f4c540ca02
Merge pull request #382 from clarkorz/feature/findOrCreate-flag
...
add a flag to callback of findOrCreate to indicate find or create
2015-01-05 11:18:06 -08:00
88b85a7fa2
Fix the floating number comparison
2015-01-05 10:53:26 -08:00
ce2b580ccd
add a flag to callback of findOrCreate to indicate find or create
...
Signed-off-by: Clark Wang <clark.wangs@gmail.com>
2014-12-25 22:19:15 +08:00
efe4601fdb
Merge pull request #370 from simoami/master
...
Fixed the haversine formula to calculate distance between 2 points
2014-12-18 15:08:42 -08:00
e1a60f146e
Added support for inline parameters like: new GeoPoint(-34, 150)
2014-12-18 10:47:06 -05:00
6fa8969912
fix default include in default scope fails findById
...
Signed-off-by: Clark Wang <clark.wangs@gmail.com>
2014-12-11 15:14:35 +08:00
b990afc910
Added test for toString()
2014-12-10 19:43:49 -05:00
beaa97f6f4
Fixed constructor parameters and added bdd tests for constructor validation
2014-12-10 19:36:02 -05:00
87027b49f8
Fixed indentation
2014-12-10 17:47:32 -05:00
62c6ea0ddd
Added mocha tests for GeoPoint
2014-12-10 17:41:49 -05:00
73d022398a
Relax the id comparison
2014-12-08 16:18:42 -08:00
d92905d53e
Merge pull request #360 from clarkorz/fix/embedsOne-errors
...
fix embedsOne error when embed instance is undefined or null
2014-12-03 15:35:18 -08:00
c51d1e9a08
Merge pull request #354 from clarkorz/fix/skip-validation
...
fix skipping async validator will always fail if condition is un-fulfilled
2014-12-03 15:22:57 -08:00
9d2e6516c3
fix embedsOne error when embed instance is undefined or null
...
Signed-off-by: Clark Wang <clark.wangs@gmail.com>
2014-11-28 13:45:47 +08:00
40f03f084b
fix recursive calls if create belongsTo model in beforeCreate hook
...
Signed-off-by: Clark Wang <clark.wangs@gmail.com>
2014-11-24 19:20:38 +08:00
a9cc1c38df
Allow hasOne relation to have a scope option
...
Signed-off-by: Clark Wang <clark.wangs@gmail.com>
2014-11-20 19:27:04 +08:00
973dd33d63
fix skipping async validator will always fail if condition is un-fulfilled
...
If the validator configured with `{async:true}` option and `if/unless`
condition, validator should be skipped when the condition is un-fulfilled,
so the validator should be pass.
But currently, when skipping the validator, it calls `done(true)` which
accepts a `fail` flag as a param, this will fail the entire validation.
Signed-off-by: Clark Wang <clark.wangs@gmail.com>
2014-11-19 21:50:08 +08:00
ba29669e0d
Merge branch 'fix/350-create-batch-hasmany-relation' of github.com:BuddyHOPP/loopback-datasource-juggler into BuddyHOPP-fix/350-create-batch-hasmany-relation
2014-11-13 12:50:21 -08:00
d11eacffc6
handle relationship create with [array]
2014-11-11 14:48:34 -07:00
5c2468c4ef
#350 : Creating a batch via hasMany relation is failing. Added handling of array argument.
2014-11-07 18:01:18 -08:00
f1638e9e4c
#350 : Creating a batch via hasMany relation is failing. Added context 'with scope' to allow individual execution of tests.
2014-11-07 15:21:15 -08:00
14dcfb61be
Add support for multiple includes that use relation syntax
2014-11-04 20:45:25 -08:00
5cd9e88ab2
Merge pull request #334 from pandaiolo/fix/has-one-pk
...
Fix for HasOne relation with non-standard id
2014-10-30 14:26:13 -07:00
11963ea12a
Merge pull request #338 from fabien/fix/fields-vs-defaults
...
Don't apply defaults when fields are specified
2014-10-30 14:11:51 -07:00
833c24a2a3
Tests for non standard id - hasOne and polymorphic
2014-10-29 12:06:05 +01:00
e7a108efdb
Don't apply defaults when fields are specified
2014-10-19 18:47:27 +02:00
455743167a
Fix the automigrate issue
...
See https://github.com/strongloop/loopback-example-relations-basic/issues/6
2014-10-16 12:04:16 -07:00
5662d9f0c2
Merge pull request #329 from fabien/feature/include-scope
...
Enable include scope for belongsTo
2014-10-15 18:08:42 +02:00
55d116ec3f
Enable include scope for belongsTo
2014-10-14 22:47:59 +02:00
07993d2e1f
Merge pull request #324 from fabien/feature/include-scope
...
Include scope
2014-10-13 08:33:26 -07:00
14d178bf69
Don't inherit settings.base when extending a model
...
Fix the bug in `ModelClass.extend` where the `base` option used
in the new class was inherited from ModelClass. As a result
the extended model was incorrectly based on ModelClass's parent.
Modify `modelBuilder.define` to normalize the property name storing
the name of the base model to `settings.base`.
2014-10-10 18:35:18 +02:00
8d6e3adaab
Allow include syntax without scope param
2014-10-10 17:17:36 +02:00
0c28ccedac
Refactored inclusion
...
The syntax is now consistent, regardless of using [] or {} for the
include param.
2014-10-10 14:24:25 +02:00
ca0b3399c8
Implement include scopes
2014-10-10 12:28:39 +02:00
2838158139
Fix failing test
2014-10-09 18:18:04 +02:00
0e49dc94ec
Allow `attributes` as an alias for `properties` (for LDL)
2014-10-09 18:14:04 +02:00
ec05d0b5a8
Cleanup, consistency: allow properties to be a function
...
Also, pass along the current instance, for any instance method as a
context (save, updateAttributes).
2014-10-09 18:14:04 +02:00
beeb7c46c9
applyProperties => properties (object/false)
2014-10-09 18:14:04 +02:00
702796a486
Test default scope with relations
2014-10-09 18:14:04 +02:00
49e2b8b8dc
Allow default scope to be a function
2014-10-09 18:14:04 +02:00
b136a8fce7
Full test CRUD suite for default scope
2014-10-09 18:14:04 +02:00
ad55681d69
Properly reset Memory connector cache on automigrate
2014-10-09 18:13:58 +02:00
8352ed3afc
Implemented collection setting for Memory connector
2014-10-09 18:13:57 +02:00
610866bd7c
Extract mergeQuery and setScopeValuesFromWhere
...
Related to #274 - in preparation of default scope
2014-10-09 18:13:40 +02:00
43e0f0f6fa
Merge pull request #301 from strongloop/feature/allow-base-for-discovery
...
Tidy up model building from data sources
2014-09-23 16:38:17 -07:00
b5cebd75a7
Merge pull request #303 from khashayar/feature/test-improvement
...
Test improvement, shows _targetClass camelCase bug
2014-09-23 16:37:59 -07:00
28a661a81a
Test improvement, shows _targetClass camelCase bug
...
There is an issue where setting _targetClass on hasAndBelongsToMany
relations with a camel-case model name, fails.
Signed-off-by: Khashayar Hajian <me@khashayar.me>
2014-09-17 17:28:40 +02:00
fe74c8019c
Tidy up model building from data sources
...
See https://github.com/strongloop/loopback/issues/560
2014-09-12 14:25:35 -07:00
3655107334
Merge pull request #295 from fabien/fix/embeds-many
...
Various improvements to embedded relations
2014-09-12 10:31:49 -07:00
af40505703
Merge pull request #290 from fabien/feature/enforce-id
...
Enforce id (prevent user-set value), fix isNewRecord
2014-09-12 10:31:10 -07:00
6903253471
Merge pull request #288 from fabien/fix/relation-tests
...
Test sync (cached) relation getters
2014-09-12 10:29:42 -07:00
d1a08ef6b3
Add test case for Numeric ids (with optional forceId)
2014-09-07 20:54:11 +02:00
e441924fa3
Allow embedsOne to use auto-generated id (from connector)
...
If the connector has a `generateId` method - like Transient - it can be
used to set the id (when the property has been set to `generated:
true`).
2014-09-07 13:24:05 +02:00
21e1083e88
Implemented persistent: true option for embedsOne
2014-09-07 13:10:23 +02:00
95764232b9
Introduce embedsMany persistent: true option
...
When set, instead of only embedding the model (on creation) it will be
persisted first, and subsequently embedded.
2014-09-07 12:59:47 +02:00
ef816d490a
More tests for embedsMany with persistent model
2014-09-07 12:44:45 +02:00
4c6f35d23d
Only check id as part of embedsMany relation
2014-09-07 12:17:42 +02:00
a66e612c87
Fix multi-property validation definitions
...
Fixes #291 , as introduced by me ...
https://github.com/strongloop/loopback-datasource-juggler/commit/6fae8c7
27759256157bf7ccd82e04ee372a59088
2014-09-05 18:00:11 +02:00
d8cafd0c84
Tiny fixes
2014-09-05 17:28:50 +02:00
fafe51833b
More fixes/tests
2014-09-05 17:09:23 +02:00
aebf5e9e6b
Enforce id (prevent user-set value), fix isNewRecord
2014-09-05 16:35:01 +02:00
a815ad0c1a
Test .value() method - as used by scope getter
2014-09-04 21:57:18 +02:00
433b89a78a
embedsMany - implement sync scope getter
2014-09-04 21:51:59 +02:00
92a76d3edb
hasAndBelongsToMany - test sync scope getter
2014-09-04 21:30:41 +02:00
80b71438a7
polymorphic hasMany - test sync scope getter
2014-09-04 21:29:21 +02:00
e502bd4459
hasOne - test sync scope getter
2014-09-04 21:27:40 +02:00
98a75103a1
hasMany through - sync scope getter
2014-09-04 21:25:26 +02:00
3efe7ab354
Scope method should return cached relation value (sync)
2014-09-04 21:23:24 +02:00
9a44d11e8e
Merge pull request #266 from strongloop/feature/fix-issue-265
...
Add neq operator support for memory connector
2014-09-04 10:30:08 -07:00
830a3f6f1a
Remove legacy Schema references
2014-09-04 18:01:04 +02:00
7b788a2903
getTransientSchema => getTransientDataSource
2014-09-04 17:56:26 +02:00
Jue Hou
Miroslav Bajtoš
Simon Ho
Amir Jafarian
Bert Casier
Raymond Feng
Michael Diguet
Wilson Júnior
Wert_Lex
mdartic
Ryan Schumacher
Raymond Feng
Bram Borggreve
sklyukin
Laurent Villeneuve
Simon Ho
Fabien Franzen
Kenta Fried
Simon Ho
Pradnya Baviskar
Bryan Clark
Miroslav Bajtoš
Miroslav Bajtoš
ningsuhen
mamboer
Nemo
Partap Davis
Daniel B. Vasquez
0angelic0
Clark Wang
rudzon
Denis Bardadym
Andrey Loukhnov
James Billingham
Christian Enevoldsen
Christian Vette
Ritchie Martori
Simo Moujami
Simo Moujami
bitmage
Alex Voitau
Pandaiolo
Khashayar Hajian