Commit Graph

1992 Commits

Author SHA1 Message Date
박대선 d9ae32429b Fix false emailVerified on user model update
Yesterday, the loopback we are using in our system was upgraded
via npm, and since the upgrade, we noticed that every time
the user model updates, the emailVerified column would change to false.

I took a look and realized there might be an error in
https://github.com/strongloop/loopback/commit/eb640d8

The intent of the commit just mention is to make emailVerified false
when the email gets changed, but notice that ctx.data.email is null
on updates, so the condition is always met and emailVerified always
becomes false.

This commit fixes the issue just mentioned.
2016-12-23 14:04:44 +09:00
Miroslav Bajtoš a21fca6089 Merge pull request #3023 from strongloop/feature/options-from-context-v2
Inject remoting context to options arg
2016-12-22 12:01:02 +01:00
Miroslav Bajtoš 60ea3e96bc Contextify DAO and relation methods
Modify remoting metadata of data-access methods in PersistedModel
and relation method in Model and add an "options" argument to "accepts"
list.
2016-12-22 10:26:09 +01:00
Miroslav Bajtoš 4de3aa77e3 Implement new http arg mapping optionsFromRequest
Define a new Model method "createOptionsFromRemotingContext" that allows
models to define what "options" should be passed to methods invoked
via strong-remoting (e.g. REST).

Define a new http mapping `http: 'optionsFromRequest'` that invokes
`Model.createOptionsFromRemotingContext` to build the value from
remoting context.

This should provide enough infrastructure for components and
applications to implement their own ways of building the "options"
object.
2016-12-22 10:26:01 +01:00
Miroslav Bajtoš 668a9d0ed6 3.1.1
* Update package.json for LB3 release (Simon Ho)
 * Invalidate AccessTokens on password change (Miroslav Bajtoš)
 * Fix registration of operation hooks in User model (Miroslav Bajtoš)
 * Remove "options.template" from Email payload (Miroslav Bajtoš)
 * Upgrade eslint config and grunt-eslint to latest (Miroslav Bajtoš)
 * Update paid support URL (siddhipai)
 * Update paid support URL (Siddhi Pai)
 * Remove duplicate warning in issue template (Siddhi Pai)
2016-12-21 16:05:58 +01:00
Miroslav Bajtoš f71030f8c2 Merge pull request #3044 from strongloop/release/3.x
Prepare for 3.x GA
2016-12-21 10:52:06 +01:00
Simon Ho 92ab09338e Update package.json for LB3 release 2016-12-21 00:54:07 -08:00
Miroslav Bajtoš f27cd2ccfb Merge pull request #3018 from strongloop/fix/session-expiry2
Invalidate AccessTokens on password change
2016-12-12 13:50:15 +01:00
Miroslav Bajtoš 29a17f39d5 Invalidate AccessTokens on password change
Invalidate all existing sessions (delete all access tokens)
after user's password was changed.
2016-12-12 13:30:53 +01:00
Miroslav Bajtoš dac1295ad7 Merge pull request #3016 from strongloop/fix/repeated-user-hooks2
Fix registration of operation hooks in User model (part 2)
2016-12-09 15:06:02 +01:00
Miroslav Bajtoš f476613ab1 Fix registration of operation hooks in User model
Follow-up for 4edce47 which moved only two out of three hooks.
2016-12-09 14:29:30 +01:00
Miroslav Bajtoš 57a053bbf2 Merge pull request #3014 from strongloop/fix/repeated-user-hooks
Fix registration of operation hooks in User model
2016-12-09 14:09:12 +01:00
Miroslav Bajtoš 4edce47b24 Fix registration of operation hooks in User model
Operation hooks are inherited by subclassed models, therefore they must
be registered outside of `Model.setup()` function.

This commit fixes this problem in the built-in User model.

There are not tests verifying this change, as writing a test would be
too cumbersome and not worth the cost IMO.
2016-12-09 13:16:42 +01:00
Miroslav Bajtoš 63beaa21fe Merge pull request #3004 from strongloop/fix/email-template-in-transport
Remove "options.template" from Email payload
2016-12-07 10:53:04 +01:00
Miroslav Bajtoš 7f2cdc106c Merge pull request #3002 from strongloop/eslint-es6
Upgrade eslint config and grunt-eslint to latest
2016-12-07 10:52:52 +01:00
Miroslav Bajtoš 5016703f21 Remove "options.template" from Email payload
Fix User.confirm to exclude "options.template" when sending the
confirmation email. Certain nodemailer transport plugins are rejecting
such requests.
2016-12-06 16:18:19 +01:00
Miroslav Bajtoš acdfb432d0 Upgrade eslint config and grunt-eslint to latest
- disable ES6 because PhantomJS does not support it yet
 - fix linter errors reported after the upgrade.
2016-12-06 16:05:13 +01:00
siddhipai fab5bd4fc5 Update paid support URL
Update paid support URL
2016-12-05 12:38:05 -08:00
Siddhi Pai e4cb2afdb7 Update paid support URL 2016-12-05 12:23:14 -08:00
Siddhi Pai 91970f975a Remove duplicate warning in issue template
* First item is not polite enough

* Second item conveys the same message as the first item
2016-12-05 12:09:19 -08:00
Miroslav Bajtoš 3e1ae2d413 3.1.0
* Fix use-strict issue with connectors after merge (Loay)
 * Fix connector naming in strict mode (ebarault)
 * Add "returnOnlyRoleNames" option to Role.getRoles (Eric)
 * Update translation files (Candy)
 * Fix broken document for `upsertWithWhere` (Amir Jafarian)
 * Fix js doc for deleteAll event (Candy)
 * add allowArray to relations' create remoteMethod (David Cheung)
 * Remove workaround for default value (Loay)
 * Fix remote method example (Amir Jafarian)
 * Remove `example/context` (Amir Jafarian)
 * Turn on "no-unused-expressions" rule for eslint (Miroslav Bajtoš)
 * Update eslint to loopback config v5 (Loay)
 * Fix total calculation in example (Candy)
 * make test individually runable (David Cheung)
 * Add options to bulkUpdate (Kogulan Baskaran)
 * Fix context within listByPrincipalType role method (codyolsen)
 * Add Node v7 to Travis CI platforms (Miroslav Bajtoš)
 * Drop support for Node v0.10 and v0.12 (Miroslav Bajtoš)
 * Add templateFn option to User#verify() (Adrien Kiren)
 * Require verification after email change (Loay)
 * Update doc links (Candy)
 * adding check of string for case insensitive emails (Dhaval Trivedi)
 * Update test confirmation text in PR template (#2897) (Simon Ho)
 * allow batch create for persisted models (David Cheung)
 * Fix PR template to not link all PRs to #49 (#2887) (Miroslav Bajtoš)
 * Need index on principalId for performance. (#2883) (Simon Ho)
 * Remove redundant items in PR template (#2877) (Simon Ho)
 * Refactor PR template based on feedback (#2865) (Simon Ho)
 * Add pull request template (#2843) (Simon Ho)
 * Update README.md (Rand McKinney)
 * Reword ticking checkbox note in issue template (#2854) (Simon Ho)
 * Add how to tick checkbox in issue template (#2851) (Simon Ho)
 * Fix description of updateAll response (Miroslav Bajtoš)
 * Allow tokens with eternal TTL (value -1) (Miroslav Bajtoš)
 * Use GitHub issue templates (#2810) (Simon Ho)
 * Update ja and nl translation files (Candy)
 * Remove 3.0 DEVELOPING & RELEASE-NOTES (Miroslav Bajtoš)
 * Fix support for remote hooks returning a Promise (Tim van der Staaij)
 * Validate non-email property partial update (Loay)
 * Update release notes (Amir Jafarian)
 * Update translation files - round#2 (Candy)
 * Add license text (Candy)
 * Temporarily disable Karma tests on Windows CI (Miroslav Bajtoš)
2016-12-05 10:15:39 +01:00
Loay a34f321d2b Fix use-strict issue with connectors after merge
fixing use-strict issue with connectors after merge #2632
2016-11-30 14:36:51 -05:00
ebarault 94c786f2f7 Fix connector naming in strict mode
In strict mode, creating properties on strings is not allowed.
As a result, creating a new datasource fails with the following
error:

    TypeError: Cannot create data source "db":
    Cannot create property 'name' on string 'mongodb'

In this commit, we fix the code to assign the connector name only
if the connector is an object (not a string).

Add "returnOnlyRoleNames" option to Role.getRoles

Currently the return type of Role.getRoles() method is inconsistent:
role names are returned for smart roles and role ids are returned for
static roles (configured through user-role mapping).

This commit adds a new option to Role.getRoles() allowing the caller
to request role names to be returned for all types of roles.
2016-11-30 14:08:28 -05:00
Miroslav Bajtoš ca3ec134d6 Merge pull request #2975 from ebarault/getRoles-to-return-only-role-names
Add "returnOnlyRoleNames" option to Role.getRoles
2016-11-30 17:00:57 +01:00
Eric b0d6c4a7d2 Add "returnOnlyRoleNames" option to Role.getRoles
Currently the return type of Role.getRoles() method is inconsistent:
role names are returned for smart roles and role ids are returned for
static roles (configured through user-role mapping).

This commit adds a new option to Role.getRoles() allowing the caller
to request role names to be returned for all types of roles.
2016-11-30 16:46:59 +01:00
Loay 3ecb5e1cfe Merge pull request #2974 from strongloop/defaultValue
Remove workaround for default value
2016-11-28 11:07:09 -05:00
Candy 80b0bb8392 Merge pull request #2985 from strongloop/add_translation7
Update translation files
2016-11-25 16:28:18 -05:00
Candy bee157a792 Update translation files 2016-11-25 16:01:46 -05:00
Amirali Jafarian 1d96a678a5 Merge pull request #2983 from strongloop/broken_documemnt
Fix broken document for `upsertWithWhere`
2016-11-24 16:14:55 -05:00
Amir Jafarian d4e0efcab3 Fix broken document for `upsertWithWhere` 2016-11-24 15:58:21 -05:00
David Cheung a673a3884c Merge pull request #2947 from strongloop/related-models-allow-array
add allowArray to relations' create remoteMethod
2016-11-23 14:51:08 -05:00
Amirali Jafarian ea4f3ecb05 Merge pull request #2972 from strongloop/delete_context_example
Remove `example/context`
2016-11-23 13:45:33 -05:00
Candy f3ee41a0bc Merge pull request #2979 from strongloop/fix_jsdoc
Fix js doc for deleteAll event
2016-11-23 13:37:01 -05:00
Candy 5815ca8211 Fix js doc for deleteAll event 2016-11-23 12:02:49 -05:00
David Cheung fa7cb923cd add allowArray to relations' create remoteMethod
this is needed because we added allowArray flag to persisted model's
remoteMethod, but when relations try to rebuild such methods, it does
not carry over such flags
2016-11-23 12:00:18 -05:00
Miroslav Bajtoš d4bee2b764 Merge pull request #2970 from strongloop/fix/remove-unused-expressions
Re-enable "no-unused-expressions" rule for eslint
2016-11-23 10:01:09 +01:00
Loay f72a29671f Remove workaround for default value 2016-11-22 20:58:27 -05:00
Amirali Jafarian 2c1ebdcc2e Merge pull request #2973 from strongloop/remote_method_fix_example
Fix remote method example
2016-11-22 17:55:07 -05:00
Amir Jafarian 9f4e9d8532 Fix remote method example
- callback error and not ignore cartId
2016-11-22 14:24:19 -05:00
Amir Jafarian 17512f6e77 Remove `example/context`
* Remove `example/context` since it is deprecated in LB 3.0
2016-11-22 13:56:46 -05:00
Miroslav Bajtoš 1ec7cf0a37 Turn on "no-unused-expressions" rule for eslint
Fix unit-tests relying on property-based assertions to use function
calls instead, using "dirty-chai" to modify chai's property checkers.
2016-11-22 15:30:04 +01:00
Miroslav Bajtoš c3ab932012 Merge pull request #2632 from strongloop/eslint2
Update eslint infrastructure
2016-11-22 14:20:41 +01:00
Loay 06cb481c3f Update eslint to loopback config v5
Notable side-effects:
 - loopback no longer exports "caller" and "arguments" properties
 - kv-memory connector is now properly added to the connector registry
 - the file "test/support.js" was finally removed
2016-11-22 14:08:02 +01:00
Candy ef0478cc97 Merge pull request #2968 from strongloop/fix_total_calculation
Fix total calculation in example
2016-11-21 13:54:50 -05:00
Candy 308c18b1e0 Fix total calculation in example 2016-11-21 11:49:18 -05:00
David Cheung 61c0c85ab5 Merge pull request #2888 from strongloop/make-test-individually-runable
make test individually runable
2016-11-17 18:29:00 -05:00
David Cheung b3c43b60cd make test individually runable
previously when you do something like mocha test/model.test.js
you would get an error like "assert is not a function"
2016-11-17 18:05:58 -05:00
Miroslav Bajtoš a0bc204159 Merge pull request #2945 from strongloop/feature/bulkupdate-options-3x
Add options to bulkUpdate
2016-11-16 08:57:11 +01:00
Kogulan Baskaran b4f1b2f02c Add options to bulkUpdate 2016-11-15 17:40:44 +01:00
Miroslav Bajtoš 54ee8d8bb5 Merge pull request #2742 from codyolsen/feature/role-context
Fix context within listByPrincipalType role method
2016-11-15 16:05:19 +01:00