verdnatura/myt
verdnatura
/
myt
0
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

6204-fixturesByEnvironment #2

Merged
jgallego merged 7 commits from 6204-fixturesByEnvironment into master 2023-10-30 06:57:37 +00:00
Conversation 1 Commits 7 Files Changed 5 +64 -17
jgallego commented 2023-09-07 07:32:25 +00:00
Owner
Copy Link
No description provided.
jgallego added 2 commits 2023-09-07 07:32:26 +00:00
jgallego requested review from juan 2023-09-07 07:32:35 +00:00
jgallego commented 2023-09-07 07:36:32 +00:00
Author
Owner
Copy Link
console.log(test("00xtx.sql", "vn")); // Debería NO procesar
console.log(test("00-xtx.sql", "vn")); // Debería procesar
console.log(test("00-xx.vn.sql", "vn")); // Debería procesar
console.log(test("00-xx.vn.sql", null)); // Debería NO procesar
console.log(test("00-xx.vn.sql", undefined)); //  Debería NO procesar
console.log(test("00-xx.otroEntorno.sql", "vn")); // Debería NO procesar
console.log(test("00-xx.otroEntorno.sql", null)); // Debería NO procesar
console.log(test("00-xx.otroEntorno.sql", undefined)); // Debería NO procesar
console.log(test("00-xx.sql", null)); // Debería procesar
console.log(test("00-xx.sql", undefined)); // Debería procesar
``` console.log(test("00xtx.sql", "vn")); // Debería NO procesar console.log(test("00-xtx.sql", "vn")); // Debería procesar console.log(test("00-xx.vn.sql", "vn")); // Debería procesar console.log(test("00-xx.vn.sql", null)); // Debería NO procesar console.log(test("00-xx.vn.sql", undefined)); // Debería NO procesar console.log(test("00-xx.otroEntorno.sql", "vn")); // Debería NO procesar console.log(test("00-xx.otroEntorno.sql", null)); // Debería NO procesar console.log(test("00-xx.otroEntorno.sql", undefined)); // Debería NO procesar console.log(test("00-xx.sql", null)); // Debería procesar console.log(test("00-xx.sql", undefined)); // Debería procesar ```
jgallego added 1 commit 2023-09-22 08:25:43 +00:00
juan requested changes 2023-09-26 06:56:49 +00:00
myt-push.js Outdated
@ -151,6 +151,21 @@ class Push extends Command {
function isUndoScript(script) {
return /\.undo\.sql$/.test(script);
}
function isOtherRealmScript(script, realm) {
juan commented 2023-09-26 06:56:45 +00:00
Owner
Copy Link

No es necesario declarar una función, el código solo se utiliza una vez

No es necesario declarar una función, el código solo se utiliza una vez
jgallego commented 2023-09-26 07:58:39 +00:00
Author
Owner
Copy Link

Cierto te paso una propuesta de como queda sin funcion, pero creo que es bastante menos legible

// Reemplazo de la función isOtherRealmScript
const splitScript = script.split('.');
const realmPart = splitScript[splitScript.length - 2];

if (splitScript.length > 2) {
    if (!realm && realmPart) {
        continue;
    }
    
    if (realmPart && realmPart !== realm) {
        continue;
    }
}
Cierto te paso una propuesta de como queda sin funcion, pero creo que es bastante menos legible ``` // Reemplazo de la función isOtherRealmScript const splitScript = script.split('.'); const realmPart = splitScript[splitScript.length - 2]; if (splitScript.length > 2) { if (!realm && realmPart) { continue; } if (realmPart && realmPart !== realm) { continue; } } ```
jgallego marked this conversation as resolved
myt-push.js Outdated
@ -192,6 +207,8 @@ class Push extends Command {
[opts.code, versionNumber]
);
const realm = await myt.fetchDbRealm();
juan commented 2023-09-26 06:54:56 +00:00
Owner
Copy Link

Esta haciendo el SELECT en cada iteración

Esta haciendo el `SELECT` en cada iteración
jgallego marked this conversation as resolved
myt-push.js Outdated
@ -204,3 +221,3 @@
for (const script of scripts) {
if (!/^[0-9]{2}-[a-zA-Z0-9_]+(.undo)?\.sql$/.test(script)) {
if (!/^[0-9]{2}-[a-zA-Z0-9_]+(\..+)?\.sql$/.test(script)) {
juan commented 2023-09-26 06:51:43 +00:00
Owner
Copy Link

/^[0-9]{2}-[a-zA-Z0-9_]+(\.[a-zA-Z0-9_]+)?\.sql$/

`/^[0-9]{2}-[a-zA-Z0-9_]+(\.[a-zA-Z0-9_]+)?\.sql$/`
juan commented 2023-09-27 09:39:21 +00:00
Owner
Copy Link
const match = script.match(/^[0-9]{2}-[a-zA-Z0-9_]+(?:\.(?!undo)([a-zA-Z0-9_]+))?(?:\.undo)?\.sql$/);
const skipRealm = match[1] && match[1] !== realm;
``` const match = script.match(/^[0-9]{2}-[a-zA-Z0-9_]+(?:\.(?!undo)([a-zA-Z0-9_]+))?(?:\.undo)?\.sql$/); const skipRealm = match[1] && match[1] !== realm; ```
jgallego marked this conversation as resolved
myt.js Outdated
@ -326,0 +330,4 @@
FROM versionConfig`
);
return realm?.realm;
}
juan commented 2023-09-26 06:56:01 +00:00
Owner
Copy Link

Debería declararse en el fichero myt-push.js ya que solo se utiliza ahí, no declarar función, solo se utiliza una vez

Debería declararse en el fichero _myt-push.js_ ya que solo se utiliza ahí, no declarar función, solo se utiliza una vez
jgallego marked this conversation as resolved
jgallego added 1 commit 2023-09-28 08:03:16 +00:00
jgallego added 1 commit 2023-09-28 08:05:40 +00:00
jgallego requested review from juan 2023-09-28 08:05:58 +00:00
jgallego added 1 commit 2023-10-05 06:37:09 +00:00
juan approved these changes 2023-10-05 10:04:07 +00:00
jgallego added 1 commit 2023-10-24 05:48:34 +00:00
jgallego merged commit 19b368b219 into master 2023-10-30 06:57:37 +00:00
jgallego deleted branch 6204-fixturesByEnvironment 2023-10-30 06:57:37 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
juan
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/myt#2
No description provided.
Delete Branch "6204-fixturesByEnvironment"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?