verdnatura/myt
verdnatura
/
myt
0
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

feat: refs #7562 deleteDeprecatedObjects #6

Merged
guillermo merged 7 commits from 7562-deleteDeprecatedObjects into master 2024-09-12 08:06:15 +00:00
Conversation 0 Commits 7 Files Changed 9 +132 -15
guillermo commented 2024-09-05 06:18:34 +00:00
Member
Copy Link
No description provided.
guillermo added 3 commits 2024-09-05 06:18:34 +00:00
guillermo changed title from 7562-deleteDeprecatedObjects to feat: refs #7562 deleteDeprecatedObjects 2024-09-05 06:18:43 +00:00
guillermo requested review from juan 2024-09-05 06:21:03 +00:00
juan requested changes 2024-09-05 07:42:52 +00:00
Dismissed
myt-version.js
@ -18,2 +19,3 @@
alias: {
name: 'n'
name: 'n',
deprecate: 'kk'
juan commented 2024-09-05 07:39:30 +00:00
Owner
Copy Link

Los alias solo tienen que tener una letra y hacer referencia a una palabra inglesa, ej: -p

Los alias solo tienen que tener una letra y hacer referencia a una palabra inglesa, ej: `-p`
guillermo marked this conversation as resolved
myt-version.js Outdated
@ -140,0 +153,4 @@
deprecatedMarkRegex,
VN_CURDATE() - INTERVAL daysKeepDeprecatedObjects DAY dated
FROM config
`);
juan commented 2024-09-05 07:42:47 +00:00
Owner
Copy Link

Usar el fichero de configuración de Myt para estos parámetros

Usar el fichero de configuración de Myt para estos parámetros
guillermo marked this conversation as resolved
myt-version.js Outdated
@ -140,0 +205,4 @@
JOIN variables var
WHERE t.TABLE_NAME REGEXP var.markRegex COLLATE utf8mb4_unicode_ci
AND REGEXP_SUBSTR(t.TABLE_COMMENT, var.dateRegex COLLATE utf8mb4_unicode_ci) < var.dated
`, [config.deprecatedMarkRegex, config.dateRegex, config.dated]);
juan commented 2024-09-05 07:40:15 +00:00
Owner
Copy Link
  • Generar el SQL con Javascript en lugar de usar CONCATs SQL
  • Escapar identificadores (nombres de esquemas, tablas, columnas...)
  • Hacer comprobación estricta del patron @deprecated YYYY-MM-DD
- Generar el SQL con Javascript en lugar de usar CONCATs SQL - Escapar identificadores (nombres de esquemas, tablas, columnas...) - Hacer comprobación **estricta** del patron `@deprecated YYYY-MM-DD`
guillermo marked this conversation as resolved
guillermo added 1 commit 2024-09-06 07:46:28 +00:00
guillermo requested review from juan 2024-09-06 07:51:09 +00:00
juan requested changes 2024-09-12 07:12:21 +00:00
Dismissed
.gitignore Outdated
@ -1,2 +1,4 @@
.DS_Store
node_modules
db
myt.config.yml
juan commented 2024-09-12 06:54:02 +00:00
Owner
Copy Link

Porque se añaden al gitignore?

Porque se añaden al gitignore?
guillermo commented 2024-09-12 07:40:19 +00:00
Author
Member
Copy Link

Porque si te lo montas para probarlo en el mismo proyecto, te puede subir sin querer los archivos

Porque si te lo montas para probarlo en el mismo proyecto, te puede subir sin querer los archivos
juan commented 2024-09-12 07:52:50 +00:00
Owner
Copy Link

El proyecto debe probarse desde otro directorio, inicializado con myt init.

El proyecto debe probarse desde otro directorio, inicializado con `myt init`.
juan marked this conversation as resolved
myt-version.js Outdated
@ -38,2 +44,3 @@
console.log(`New version created: ${versionName}`);
}
},
deprecate: 'Generating SQL for deprecate.'
juan commented 2024-09-12 07:11:00 +00:00
Owner
Copy Link

Generating SQL for deprecated objects deletion

_Generating SQL for deprecated objects deletion_
guillermo marked this conversation as resolved
myt-version.js
@ -128,0 +133,4 @@
this.emit('deprecate');
await deprecate(conn, opts, newVersionDir);
}
else
juan commented 2024-09-12 07:11:59 +00:00
Owner
Copy Link

else y } deben estar en la misma linea: } else

`else` y `}` deben estar en la misma linea: `} else`
guillermo marked this conversation as resolved
guillermo added 1 commit 2024-09-12 07:42:13 +00:00
guillermo added 1 commit 2024-09-12 07:47:00 +00:00
guillermo added 1 commit 2024-09-12 07:48:39 +00:00
juan approved these changes 2024-09-12 07:53:59 +00:00
guillermo merged commit 71e8329dfc into master 2024-09-12 08:06:15 +00:00
guillermo deleted branch 7562-deleteDeprecatedObjects 2024-09-12 08:06:15 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
juan
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/myt#6
No description provided.
Delete Branch "7562-deleteDeprecatedObjects"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?