verdnatura/myt
verdnatura
/
myt
0
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

feat: refs #7562 deleteDeprecatedObjects #6

Merged
guillermo merged 7 commits from 7562-deleteDeprecatedObjects into master 2024-09-12 08:06:15 +00:00
Conversation 0 Commits 7 Files Changed 9 +10 -12
1 changed files with 10 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit a38cda0ba3 - Show all commits

22
myt-version.js
View File

@ -42,7 +42,7 @@ class Version extends Command {
versionCreated: function(versionName) { versionCreated: function(versionName) {
console.log(`New version created: ${versionName}`); console.log(`New version created: ${versionName}`);
}, },
deprecate: 'Generating sql.' deprecate: 'Generating SQL for deprecate.'
}; };
guillermo marked this conversation as resolved Outdated
juan commented 2024-09-12 07:11:00 +00:00
Outdated
Review
Copy Link

Generating SQL for deprecated objects deletion

_Generating SQL for deprecated objects deletion_
async run(myt, opts) { async run(myt, opts) {
@ -128,16 +128,11 @@ class Version extends Command {
); );
await fs.mkdir(newVersionDir); await fs.mkdir(newVersionDir);
let content;
if (opts.deprecate) {
this.emit('deprecate');
content = await deprecate();
} else
content = '-- Place your SQL code here\n'
await fs.writeFile( await fs.writeFile(
`${newVersionDir}/00-firstScript.sql`, `${newVersionDir}/00-firstScript.sql`,
content opts.deprecate
? (this.emit('deprecate'), await deprecate(conn))
: '-- Place your SQL code here\n'
); );
guillermo marked this conversation as resolved
juan commented 2024-09-12 07:11:59 +00:00
Review
Copy Link

else y } deben estar en la misma linea: } else

`else` y `}` deben estar en la misma linea: `} else`
this.emit('versionCreated', versionFolder); this.emit('versionCreated', versionFolder);
@ -152,7 +147,7 @@ class Version extends Command {
} }
} }
async function deprecate() { async function deprecate(conn) {
const [[config]] = await conn.query(` const [[config]] = await conn.query(`
SELECT dateRegex, SELECT dateRegex,
deprecatedMarkRegex, deprecatedMarkRegex,
@ -160,11 +155,14 @@ async function deprecate() {
FROM config FROM config
`); `);
guillermo marked this conversation as resolved Outdated
juan commented 2024-09-05 07:42:47 +00:00
Outdated
Review
Copy Link

Usar el fichero de configuración de Myt para estos parámetros

Usar el fichero de configuración de Myt para estos parámetros
const sql = await conn.query(` if (!config || Object.values(config).some(value => value == null || value === ''))
throw new Error('missing configuration variables');
const [sql] = await conn.query(`
WITH variables AS ( WITH variables AS (
SELECT ? markRegex, ? dateRegex, ? dated SELECT ? markRegex, ? dateRegex, ? dated
) )
SELECT CONCAT('ALTER TABLE ', c.TABLE_SCHEMA, '.', c.TABLE_NAME, ' DROP PRIMARY KEY;') sql SELECT CONCAT('ALTER TABLE ', c.TABLE_SCHEMA, '.', c.TABLE_NAME, ' DROP PRIMARY KEY;') "sql"
FROM information_schema.COLUMNS c FROM information_schema.COLUMNS c
LEFT JOIN information_schema.VIEWS v ON v.TABLE_SCHEMA = c.TABLE_SCHEMA LEFT JOIN information_schema.VIEWS v ON v.TABLE_SCHEMA = c.TABLE_SCHEMA
AND v.TABLE_NAME = c.TABLE_NAME AND v.TABLE_NAME = c.TABLE_NAME