#8219 Added InvoiceOut e2e tests #1001

Merged
jon merged 24 commits from 8219-InvoiceOutE2E into dev 2025-01-08 06:41:33 +00:00
Member

Related PR updating "transfer.js" name in data.sql: verdnatura/salix#3274

Related PR updating "transfer.js" name in data.sql: https://gitea.verdnatura.es/verdnatura/salix/pulls/3274
jon added 1 commit 2024-11-26 11:24:33 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
7fb1a9e6b5
feat: refs #8219 added invoice out e2e tests
jon changed title from #8219 Added InvoiceOut e2e tests to WIP: #8219 Added InvoiceOut e2e tests 2024-11-26 11:28:58 +00:00
jon added 2 commits 2024-11-28 12:01:00 +00:00
jon added 1 commit 2024-12-03 11:52:46 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
f9d897cdde
feat: refs #8219 global invoicing e2e
jon changed title from WIP: #8219 Added InvoiceOut e2e tests to #8219 Added InvoiceOut e2e tests 2024-12-03 11:53:35 +00:00
jon requested review from jsegarra 2024-12-03 11:53:46 +00:00
jon added 1 commit 2024-12-03 11:54:41 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
45d1cc6a5d
fix: refs #8219 global e2e
jsegarra requested changes 2024-12-03 11:57:56 +00:00
Dismissed
@ -0,0 +32,4 @@
it('should give an error when manual invoicing a ticket that is already invoiced', () => {
cy.get('[data-cy="vnTableCreateBtn"]').click();
cy.fillInForm(invoiceError);
cy.get('[data-cy="FormModelPopup_save"]').click();
Member

porque aqui está de diferente forma que en la 29?

porque aqui está de diferente forma que en la 29?
jsegarra marked this conversation as resolved
@ -0,0 +38,4 @@
it('should create a manual invoice and enter to its summary', () => {
cy.get('[data-cy="vnTableCreateBtn"]').click();
cy.fillInForm(invoice);
cy.get('[data-cy="FormModelPopup_save"]').click();
Member

porque aqui está de diferente forma que en la 29?

porque aqui está de diferente forma que en la 29?
jsegarra marked this conversation as resolved
@ -0,0 +6,4 @@
cy.viewport(1920, 1080);
cy.login('developer');
cy.visit(`/#/ticket/list`);
cy.get('#searchbar input').type('{enter}');
Member

tienes estilo diferente al anterior test

tienes estilo diferente al anterior test
jon marked this conversation as resolved
@ -0,0 +10,4 @@
});
it('should create an invoice from a ticket and go to that invoice', () => {
cy.get(
Member

Si es VnInput mirate el selector

Si es VnInput mirate el selector
Member

Revisa el archivo commands

Revisa el archivo commands
Member

También se puede usar cy.get('[data-cy="Customer ID_input"]')

También se puede usar cy.get('[data-cy="Customer ID_input"]')
jon marked this conversation as resolved
@ -0,0 +10,4 @@
cy.viewport(1920, 1080);
cy.login('developer');
cy.visit(`/#/invoice-out/list`);
cy.get('#searchbar input').type('{enter}');
Member

Revisalo

Revisalo
jon marked this conversation as resolved
jon added 1 commit 2024-12-04 07:37:26 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
670c089125
refactor: refs #8219 modified e2e tests and fixed some translations
jon added 1 commit 2024-12-04 07:39:07 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
e9fc8b6888
Merge branch 'dev' into 8219-InvoiceOutE2E
jon requested review from jsegarra 2024-12-04 08:17:20 +00:00
jsegarra requested changes 2024-12-04 08:27:04 +00:00
Dismissed
jsegarra left a comment
Member

fallan los tests, añado report

fallan los tests, añado report
jsegarra reviewed 2024-12-04 08:28:13 +00:00
@ -0,0 +15,4 @@
it('should generate the invoice PDF', () => {
cy.get('#searchbar input').type('T1111111{enter}');
cy.get('[data-cy="descriptor-more-opts"] > .q-btn__content > .q-icon').click();
Member

revisate el archivo comands

revisate el archivo comands
jon marked this conversation as resolved
jsegarra requested changes 2024-12-04 08:29:33 +00:00
Dismissed
@ -0,0 +17,4 @@
cy.get('#searchbar input').type('T1111111{enter}');
cy.get('[data-cy="descriptor-more-opts"] > .q-btn__content > .q-icon').click();
cy.get('.q-menu > .q-list > :nth-child(6)').click();
cy.dartaCy('VnConfirm_confirm').click();
Member

Esto me hace pensar que nos has tirado los tests 🚩

Esto me hace pensar que nos has tirado los tests 🚩
jon marked this conversation as resolved
jon added 2 commits 2024-12-04 10:46:59 +00:00
jon added 1 commit 2024-12-04 11:26:11 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
cb1f717fe0
fix: refs #8219 requested changes
jon added 1 commit 2024-12-04 11:33:46 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
a8b7691ab0
fix: refs #8219 forgotten dataCy
jsegarra added 1 commit 2024-12-05 08:52:24 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
c601083f8c
perf: refs #8219 #8219 minor change
jon added 1 commit 2024-12-09 05:18:39 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
5793e7c662
Merge branch 'dev' into 8219-InvoiceOutE2E
Author
Member

image

![image](/attachments/0d6ce636-ac1b-4095-b674-f26da48aab45)
jon requested review from jsegarra 2024-12-12 07:00:53 +00:00
jsegarra requested changes 2024-12-12 08:23:06 +00:00
Dismissed
jsegarra left a comment
Member

Revisar commands.js y aplicar

Revisar commands.js y aplicar
@ -0,0 +21,4 @@
cy.dataCy('vnSearchBar').find('input').type('1{enter}');
cy.get('.q-virtual-scroll__content > :nth-child(2) > :nth-child(7)').click();
cy.get('.header > a.q-btn > .q-btn__content').click();
cy.dataCy('vnSearchBar').find('input').type('{enter}');
Member

🚩

🚩
jsegarra marked this conversation as resolved
@ -0,0 +13,4 @@
':nth-child(7) > .full-width > :nth-child(1) > .column > div.q-px-xs > .q-field > .q-field__inner > .q-field__control'
).type('23{enter}');
cy.get('#subToolbar > .q-btn').click();
cy.get(notification).should('contains.text', 'CSV downloaded successfully');
Member

commands.js

commands.js
jon marked this conversation as resolved
@ -0,0 +29,4 @@
cy.dataCy('descriptor-more-opts').click();
cy.get('.q-menu > .q-list > :nth-child(7)').click();
cy.get('#q-portal--menu--3 > .q-menu > .q-list > :nth-child(2)').click();
cy.get(notification).should(
Member

revisate el archivo commands

revisate el archivo commands
jon marked this conversation as resolved
@ -0,0 +44,4 @@
});
it('should transfer the invoice ', () => {
cy.get('#searchbar input').type('T1111111{enter}');
Member

revisate commands

revisate commands
jon marked this conversation as resolved
@ -0,0 +6,4 @@
cy.visit(`/#/invoice-out/global-invoicing`);
});
it('should invoice the client tickets', () => {
Member

Esto lo haces por evitar usar fillInForm?

Esto lo haces por evitar usar fillInForm?
jon marked this conversation as resolved
Member

Vaya, hay conflictos

Vaya, hay conflictos
jon added 2 commits 2024-12-16 06:45:44 +00:00
jon added 1 commit 2024-12-16 06:46:43 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
a4062f188b
refactor: refs #8219 requested changes
jon added 1 commit 2024-12-27 07:47:50 +00:00
jon requested review from jsegarra 2024-12-27 07:49:57 +00:00
jsegarra requested changes 2024-12-27 08:31:45 +00:00
Dismissed
jsegarra left a comment
Member

Reemplazar cy.get(notification por cy.checkNotification
Como minimo para InvoiceOut*.spec, ya que hay 3 archivos extras que lo tienen mal

Reemplazar cy.get(notification por cy.checkNotification Como minimo para InvoiceOut*.spec, ya que hay 3 archivos extras que lo tienen mal
jon added 1 commit 2024-12-27 08:50:01 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
886c811b79
refactor: refs #8219 use checkNotification command
jon added 1 commit 2024-12-27 08:50:49 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
d6949ea0db
Merge branch 'dev' into 8219-InvoiceOutE2E
jon requested review from jsegarra 2024-12-27 08:51:36 +00:00
jon added 1 commit 2024-12-30 09:11:25 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
edc1ed1a2e
Merge branch 'dev' into 8219-InvoiceOutE2E
jsegarra requested changes 2024-12-30 10:22:02 +00:00
Dismissed
@ -0,0 +1,28 @@
/// <reference types="cypress" />
Member

Este test no pasa nunca.

Puedes confirmarmelo?

Este test no pasa nunca. Puedes confirmarmelo?
jon marked this conversation as resolved
jon added 2 commits 2025-01-02 12:13:55 +00:00
jon requested review from jsegarra 2025-01-02 12:23:38 +00:00
jgallego removed review request for jsegarra 2025-01-02 14:24:33 +00:00
jgallego dismissed jsegarra’s review 2025-01-02 14:24:40 +00:00
Reason:

.

jgallego dismissed jsegarra’s review 2025-01-02 14:24:52 +00:00
Reason:

.

jon requested review from alexm 2025-01-03 06:07:23 +00:00
alexm reviewed 2025-01-07 07:40:39 +00:00
@ -281,3 +281,3 @@
});
Cypress.Commands.add('writeSearchbar', (value) => {
Cypress.Commands.add('typeSearchbar', (value) => {
Member

Si se cambia van fallar varios e2e q lo usan. Revisar antes de subir de haber cambiado donde se use

Si se cambia van fallar varios e2e q lo usan. Revisar antes de subir de haber cambiado donde se use
alexm reviewed 2025-01-07 07:42:41 +00:00
@ -0,0 +32,4 @@
it('should give an error when manual invoicing a ticket that is already invoiced', () => {
cy.dataCy('vnTableCreateBtn').click();
cy.fillInForm(invoiceError);
Member

fillInForm¿?

fillInForm¿?
Member

Esta bien

Esta bien
alexm marked this conversation as resolved
alexm requested changes 2025-01-07 12:44:35 +00:00
Dismissed
alexm left a comment
Member

Del List me falla 1 test

Del List me falla 1 test
alexm requested changes 2025-01-07 13:07:01 +00:00
Dismissed
alexm left a comment
Member

image
Ver si se puede poner el el cypress config la ruta pa q guarde los archivos y poner ese path en el gitignore de cypress

![image](/attachments/ab7928f5-ebf1-4e10-8646-73e1f52dddd9) Ver si se puede poner el el cypress config la ruta pa q guarde los archivos y poner ese path en el gitignore de cypress
6.4 KiB
jon added 1 commit 2025-01-08 06:16:01 +00:00
jon added 1 commit 2025-01-08 06:35:15 +00:00
jon requested review from alexm 2025-01-08 06:36:19 +00:00
alexm approved these changes 2025-01-08 06:37:30 +00:00
jon merged commit 1e8e2aff72 into dev 2025-01-08 06:41:33 +00:00
jon deleted branch 8219-InvoiceOutE2E 2025-01-08 06:41:33 +00:00
Sign in to join this conversation.
No reviewers
No Milestone
No Assignees
4 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix-front#1001
No description provided.