#7936 improve InvoiceIn #1004

Merged
jorgep merged 55 commits from 7936-improveInvoiceIn into dev 2024-12-18 09:22:09 +00:00
Member
No description provided.
jorgep added 2 commits 2024-11-26 12:26:50 +00:00
jorgep added 1 commit 2024-11-26 12:41:30 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
185d4f93a7
fix: refs #7936 serial
jorgep added 1 commit 2024-11-26 13:06:19 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
f5f1cdf0ac
fix: refs #7936 tabulation wip
jorgep added 2 commits 2024-11-26 13:53:58 +00:00
gitea/salix-front/pipeline/pr-dev There was a failure building this commit Details
3f2cd62948
fix: refs #7936 decimal places & locale
jorgep added 1 commit 2024-11-26 15:34:41 +00:00
gitea/salix-front/pipeline/pr-dev There was a failure building this commit Details
aba33a617e
fix: refs #7936 changes
jorgep added 1 commit 2024-11-27 08:55:00 +00:00
gitea/salix-front/pipeline/pr-dev There was a failure building this commit Details
953f6f4af3
refactor: refs #7936 locale
jorgep added 1 commit 2024-11-27 09:24:13 +00:00
gitea/salix-front/pipeline/pr-dev There was a failure building this commit Details
70ca31aa46
feat: refs #7936 add company filter
jorgep added 1 commit 2024-11-27 09:36:06 +00:00
gitea/salix-front/pipeline/pr-dev There was a failure building this commit Details
c55530ad1e
fix: refs #7936 redirection
jorgep added 1 commit 2024-11-27 09:38:25 +00:00
jorgep added 1 commit 2024-11-27 12:26:58 +00:00
gitea/salix-front/pipeline/pr-dev There was a failure building this commit Details
8324c0587d
fix: refs #7936 descriptor & dueday
jorgep added 1 commit 2024-11-27 16:52:49 +00:00
gitea/salix-front/pipeline/pr-dev There was a failure building this commit Details
b5d13904d8
refactor: refs #7936 update label capitalization and replace invoice type options
jorgep added 1 commit 2024-11-28 10:06:29 +00:00
jorgep added 1 commit 2024-11-28 10:41:27 +00:00
gitea/salix-front/pipeline/pr-dev There was a failure building this commit Details
011b5814a7
fix: refs #7936 improve error handling
jorgep added 1 commit 2024-11-28 11:37:34 +00:00
gitea/salix-front/pipeline/pr-dev There was a failure building this commit Details
4037b31948
feat: refs #7936 add row click navigation to InvoiceInSerial
jorgep added 1 commit 2024-11-28 12:28:27 +00:00
jorgep added 1 commit 2024-11-28 13:52:46 +00:00
gitea/salix-front/pipeline/pr-dev There was a failure building this commit Details
8e3d9b2bf3
feat: refs #7936 calculate exchange & update taxable base
jorgep added 1 commit 2024-11-28 14:00:33 +00:00
gitea/salix-front/pipeline/pr-dev There was a failure building this commit Details
50dab045f0
feat: refs #7936 add currency check before fetching
jorgep added 3 commits 2024-11-29 13:19:54 +00:00
jorgep added 1 commit 2024-12-02 16:11:39 +00:00
jorgep added 1 commit 2024-12-04 12:32:25 +00:00
jorgep added 1 commit 2024-12-04 12:46:45 +00:00
gitea/salix-front/pipeline/pr-dev There was a failure building this commit Details
2ab6380f97
feat: refs #7936 use default invoice data
jorgep added 1 commit 2024-12-04 16:40:34 +00:00
gitea/salix-front/pipeline/pr-dev There was a failure building this commit Details
482505b800
feat: refs #7936 add useAccountShortToStandard composable
jorgep added 1 commit 2024-12-05 09:10:16 +00:00
jorgep added 1 commit 2024-12-05 09:40:55 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
d916b47f4c
feat: refs #7936 enhance getTotal fn & add unit tests
jorgep added 1 commit 2024-12-05 11:34:34 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
6a7cf5e8e8
feat: refs #7936 add unit tests
jorgep added 1 commit 2024-12-05 14:55:45 +00:00
jorgep added 1 commit 2024-12-05 15:00:00 +00:00
jorgep added 1 commit 2024-12-05 15:41:36 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
fb1928db7e
feat: refs #7936 simplify optionLabel wip
jorgep requested review from alexm 2024-12-05 15:58:00 +00:00
jorgep reviewed 2024-12-05 15:59:11 +00:00
@ -13,0 +18,4 @@
@input="
(evt) => {
const val = evt.target.value;
if (positive && val < 0) return (model = 0);
Author
Member

Me he dado cuenta de que se podían poner números negativos, esto en la mayoría de casos no se quiere.

Me he dado cuenta de que se podían poner números negativos, esto en la mayoría de casos no se quiere.
Member

Tanto codigo lo sacaria a una funcion en js

Tanto codigo lo sacaria a una funcion en js
jorgep reviewed 2024-12-05 15:59:22 +00:00
@ -267,4 +280,2 @@
defineExpose({ opts: myOptions });
function handleKeyDown(event) {
Author
Member

No hace nada.

No hace nada.
jorgep marked this conversation as resolved
jorgep reviewed 2024-12-05 15:59:38 +00:00
@ -347,6 +337,18 @@ function handleKeyDown(event) {
</div>
<slot v-else :name="slotName" v-bind="slotData ?? {}" :key="slotName" />
</template>
<template #option="{ opt, itemProps }">
Author
Member

Por defecto,

Por defecto,
jorgep reviewed 2024-12-05 15:59:51 +00:00
@ -228,2 +228,4 @@
return params;
}
const getLocale = (label) => {
Author
Member

Se usa en varios sitios

Se usa en varios sitios
jorgep reviewed 2024-12-05 16:00:39 +00:00
@ -0,0 +1,4 @@
export function useAccountShortToStandard(val) {
Author
Member

Sacado de Salix

Sacado de Salix
jorgep reviewed 2024-12-05 16:02:03 +00:00
@ -40,3 +42,3 @@
model: 'expenseFk',
optionValue: 'id',
optionLabel: 'id',
optionLabel: (row) => `${row.id}: ${row.name}`,
Author
Member

Este no funciona al cargar, pone undefined @alexm no consigo encontrar el porque, necesitaría que lo miremos.

Este no funciona al cargar, pone **undefined** @alexm no consigo encontrar el porque, necesitaría que lo miremos.
Member

Vale, pido los cambios hasta este archivo

Vale, pido los cambios hasta este archivo
jorgep reviewed 2024-12-05 16:03:47 +00:00
@ -1,34 +0,0 @@
import { vi, describe, expect, it, beforeAll } from 'vitest';
Author
Member

Pasado a composable

Pasado a composable
jorgep reviewed 2024-12-05 16:03:53 +00:00
@ -1,38 +0,0 @@
import { vi, describe, expect, it, beforeAll } from 'vitest';
Author
Member

Pasado a composable

Pasado a composable
jorgep added 1 commit 2024-12-09 12:49:47 +00:00
jorgep added the
CR / Tests passed
label 2024-12-09 13:21:43 +00:00
jorgep added 1 commit 2024-12-09 15:44:23 +00:00
jorgep added 1 commit 2024-12-09 16:07:16 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
799c78cdff
feat: refs #7936 show id & value
jorgep added 1 commit 2024-12-09 16:27:35 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
43629a3bc3
fix: refs #7936 test
alexm requested changes 2024-12-10 08:24:45 +00:00
Dismissed
@ -267,4 +280,2 @@
defineExpose({ opts: myOptions });
function handleKeyDown(event) {
Member

Esto se quita?? Si es algo nuevo que habian pedido

Esto se quita?? Si es algo nuevo que habian pedido
jorgep marked this conversation as resolved
@ -2,3 +2,3 @@
export function getTotal(rows, key, opts = {}) {
const { currency, cb } = opts;
const { currency, cb, decimalPlaces, int } = opts;
Member

int?

int?
jorgep marked this conversation as resolved
jorgep added 1 commit 2024-12-10 09:35:09 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
2939ddcfb7
fix: refs #7936 rollback
jorgep added 1 commit 2024-12-10 09:38:46 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
cc7432b253
refactor: refs #7936 simplify getTotal fn
jorgep added 1 commit 2024-12-10 15:00:37 +00:00
jorgep added 1 commit 2024-12-11 09:11:05 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
8a1cda6914
feat: refs #7936 add autocomplete on tab fn
jorgep added 1 commit 2024-12-11 16:21:50 +00:00
jorgep added 1 commit 2024-12-11 16:42:35 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
e075e13076
feat: refs #7936 add dueDated field
jorgep added 1 commit 2024-12-12 08:58:34 +00:00
jorgep added 1 commit 2024-12-12 09:56:48 +00:00
gitea/salix-front/pipeline/pr-dev There was a failure building this commit Details
c5f4e8decd
fix: refs #7936 exclude disabled els on tab
jorgep reviewed 2024-12-12 09:58:14 +00:00
@ -288,7 +301,7 @@ function handleKeyDown(event) {
}
const focusableElements = document.querySelectorAll(
'a, button, input, textarea, select, details, [tabindex]:not([tabindex="-1"])'
Author
Member

Si el siguiente elemento está disabled, no tabula al siguiente que si se puede.

Si el siguiente elemento está disabled, no tabula al siguiente que si se puede.
jorgep added 1 commit 2024-12-12 10:20:59 +00:00
gitea/salix-front/pipeline/pr-dev There was a failure building this commit Details
aeee861147
feat: refs #7936 show country code & isVies fields
jorgep requested review from alexm 2024-12-12 10:21:29 +00:00
jorgep added 1 commit 2024-12-12 10:56:01 +00:00
jorgep added 1 commit 2024-12-12 11:09:27 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
965f5fbead
fix: refs #7936 test
jorgep added 1 commit 2024-12-12 11:51:02 +00:00
alexm requested changes 2024-12-16 06:43:47 +00:00
Dismissed
@ -358,6 +371,18 @@ function handleKeyDown(event) {
</div>
<slot v-else :name="slotName" v-bind="slotData ?? {}" :key="slotName" />
</template>
<template #option="{ opt, itemProps }">
Member

Dijimos que con una prop elegir si se quiere o no

Dijimos que con una prop elegir si se quiere o no
jorgep marked this conversation as resolved
jorgep added 1 commit 2024-12-17 09:54:07 +00:00
jorgep added 1 commit 2024-12-17 10:12:27 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
a33cec4a34
feat: refs #7936 add optionCaption
jorgep reviewed 2024-12-17 10:13:45 +00:00
@ -361,0 +385,4 @@
<QItemLabel>
{{ opt[optionLabel] }}
</QItemLabel>
<QItemLabel caption v-if="optionCaption !== false">
Author
Member

Sacado de esta tarea https://redmine.verdnatura.es/issues/8117 . Lo he añadido en esta porque me lo estaban pidiendo ya ... En la tarea que se revise en cada sitio que campos mostrar.

Sacado de esta tarea https://redmine.verdnatura.es/issues/8117 . Lo he añadido en esta porque me lo estaban pidiendo ya ... En la tarea que se revise en cada sitio que campos mostrar.
jorgep added 1 commit 2024-12-17 10:54:17 +00:00
gitea/salix-front/pipeline/pr-dev There was a failure building this commit Details
ad9063704c
feat: refs #7936 enhance downloadFile function to support opening in a new tab
jorgep reviewed 2024-12-17 10:55:44 +00:00
jorgep reviewed 2024-12-17 10:56:43 +00:00
@ -209,2 +208,3 @@
function showPdfInvoice() {
if (isAgricultural()) openReport(`InvoiceIns/${entityId.value}/invoice-in-pdf`);
if (isAgricultural())
openReport(`InvoiceIns/${entityId.value}/invoice-in-pdf`, null, '_blank');
Author
Member

Han pedido que se abra en una nueva ventana.

Han pedido que se abra en una nueva ventana.
jorgep added 1 commit 2024-12-17 10:59:00 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
22daf36c6c
fix: refs #7936 rollback
jorgep requested review from alexm 2024-12-17 11:07:46 +00:00
alexm approved these changes 2024-12-18 09:16:45 +00:00
alexm added 1 commit 2024-12-18 09:18:09 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
c4d11fddbe
Merge branch 'dev' into 7936-improveInvoiceIn
jorgep added 2 commits 2024-12-18 09:18:55 +00:00
jorgep merged commit 01eca1eb0d into dev 2024-12-18 09:22:09 +00:00
jorgep deleted branch 7936-improveInvoiceIn 2024-12-18 09:22:09 +00:00
Sign in to join this conversation.
No reviewers
No Milestone
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix-front#1004
No description provided.