verdnatura/salix-front
verdnatura
/
salix-front
2
3
Fork 1
Code Issues Pull Requests 93 Releases Wiki Activity

#8220 created items e2e #1039

Merged
jon merged 26 commits from 8220-ItemsE2E into dev 2025-01-07 12:50:36 +00:00
Conversation 1 Commits 26 Files Changed 15 +337 -15
jon commented 2024-12-03 12:00:54 +00:00
Member
Copy Link
No description provided.
jon added 1 commit 2024-12-03 12:00:54 +00:00
gitea/salix-front/pipeline/pr-dev There was a failure building this commit Details
8b3a9db781 feat: refs #8220 created items e2e
jon changed title from #8220 created items e2e to WIP: #8220 created items e2e 2024-12-03 12:02:41 +00:00
jon added 1 commit 2024-12-09 12:34:14 +00:00
jon added 2 commits 2024-12-10 06:03:21 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
100ef4b7b9 refactor: refs #8220 added data-cy for e2e tests
jon added 2 commits 2024-12-10 06:11:26 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
c2a09868a1 feat: refs #8220 added barcodes e2e test
jon changed title from WIP: #8220 created items e2e to #8220 created items e2e 2024-12-12 06:27:37 +00:00
jon changed title from #8220 created items e2e to WIP: #8220 created items e2e 2024-12-12 06:27:46 +00:00
jon added 1 commit 2024-12-12 09:18:15 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
292171348c feat: refs #8220 modified create item form and added respective e2e
jon changed title from WIP: #8220 created items e2e to #8220 created items e2e 2024-12-12 09:25:51 +00:00
jon requested review from jsegarra 2024-12-12 09:26:01 +00:00
jon added 1 commit 2024-12-16 09:24:41 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
a2b3a493fd perf: refs #8220 use searchbar selector in e2e tests
jon added 1 commit 2024-12-16 09:25:28 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
e42a2c8bce Merge branch 'dev' into 8220-ItemsE2E
jsegarra requested changes 2024-12-20 09:24:00 +00:00
Dismissed
src/pages/Item/ItemList.vue
@ -23,2 +26,3 @@
const route = useRoute();
const validPriorities = ref([]);
const itemConfigs = (data) => {
jsegarra commented 2024-12-20 09:23:58 +00:00
Member
Copy Link

Se puede simplificar con menos lineas y variables

Se puede simplificar con menos lineas y variables
jon marked this conversation as resolved
src/pages/Item/ItemList.vue Outdated
@ -298,6 +306,7 @@ const columns = computed(() => [
</script>
<template>
<FetchData url="ItemConfigs" @on-fetch="(data) => itemConfigs(data)" auto-load />
jsegarra commented 2024-12-20 09:22:14 +00:00
Member
Copy Link

se puede simplificar el uso de on-fetch

se puede simplificar el uso de on-fetch
jsegarra commented 2024-12-27 08:39:18 +00:00
Member
Copy Link

OK, propuesta para simplificar @on-fetch="([{ validPriorities: data }]) => (validPriorities = data)"

OK, propuesta para simplificar @on-fetch="([{ validPriorities: data }]) => (validPriorities = data)"
jon marked this conversation as resolved
jon added 2 commits 2024-12-27 06:47:44 +00:00
jon added 1 commit 2024-12-27 07:42:01 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
fc5578cb18 perf: refs #8220 on-fetch
jon requested review from jsegarra 2024-12-27 07:46:01 +00:00
jsegarra requested changes 2024-12-27 08:54:22 +00:00
Dismissed
src/pages/Item/ItemList.vue Outdated
@ -316,3 +326,3 @@
:create="{
urlCreate: 'Items',
urlCreate: 'Items/new',
title: t('Create Item'),
jsegarra commented 2024-12-27 08:39:39 +00:00
Member
Copy Link

No hay traduccion

No hay traduccion
jsegarra marked this conversation as resolved
jon added 1 commit 2024-12-27 09:12:20 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
0eedfdee4a perf: refs #8220 on-fetch and added missing translations
jon added 1 commit 2024-12-27 09:16:11 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
d20bdf63c9 perf: refs #8220 translations
jon added 1 commit 2024-12-27 09:17:56 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
42a4672008 Merge branch 'dev' into 8220-ItemsE2E
jon requested review from jsegarra 2024-12-27 09:18:44 +00:00
jon added 1 commit 2024-12-30 09:11:26 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
8e0e15840b Merge branch 'dev' into 8220-ItemsE2E
jsegarra requested changes 2024-12-30 10:00:59 +00:00
Dismissed
src/pages/Item/Card/CreateSpecieForm.vue Outdated
@ -37,6 +37,7 @@ onMounted(async () => {
:label="t('Latin species name')"
v-model="data.name"
:required="true"
data-cy="AddSpeciesInput"
jsegarra commented 2024-12-30 10:00:55 +00:00
Member
Copy Link

Revisate VnInput

Revisate VnInput
jon marked this conversation as resolved
src/pages/Item/ItemListFilter.vue Outdated
@ -199,6 +199,7 @@ onMounted(async () => {
dense
outlined
rounded
data-cy="ItemFilterCategorySelect"
jsegarra commented 2024-12-30 09:59:22 +00:00
Member
Copy Link

Revísate el componente VnSelect porque tiene algo también

Revísate el componente VnSelect porque tiene algo también
jon marked this conversation as resolved
test/cypress/integration/item/itemBarcodes.spec.js Outdated
@ -0,0 +10,4 @@
it('should throw an error if the barcode exists', () => {
cy.get('[href="#/item/1/barcode"]').click();
cy.get('.q-card > .q-btn > .q-btn__content > .q-icon').click();
cy.get(
jsegarra commented 2024-12-30 09:57:52 +00:00
Member
Copy Link

y porque no haces dataCy?
Aquí y en el resto de ocurrencias

y porque no haces dataCy? Aquí y en el resto de ocurrencias
jsegarra commented 2024-12-30 10:14:34 +00:00
Member
Copy Link

Opcion a: cy.dataCy('Code_input').eq(4).type
Opcion b: cy.get('[data-cy="Code_input"]').eq(4).type

Opcion a: cy.dataCy('Code_input').eq(4).type Opcion b: cy.get('[data-cy="Code_input"]').eq(4).type
jon marked this conversation as resolved
test/cypress/integration/item/itemTag.spec.js Outdated
@ -0,0 +15,4 @@
).type('Tallos');
cy.get('.q-menu .q-item').contains('Tallos').click();
cy.get(
':nth-child(8) > [label="Value"] > .q-field > .q-field__inner > .q-field__control > .q-field__control-container > [data-cy="Value_input"]'
jsegarra commented 2024-12-30 09:59:52 +00:00
Member
Copy Link

Usar dataCy?

Usar dataCy?
jon marked this conversation as resolved
test/cypress/integration/item/itemTax.spec.js Outdated
@ -0,0 +10,4 @@
it('should modify the tax for Spain', () => {
cy.get('[href="#/item/1/tax"]').click();
cy.get(
':nth-child(1) > .q-select > .q-field__inner > .q-field__control > .q-field__control-container > .q-field__native > [data-cy="Class_select"]'
jsegarra commented 2024-12-30 10:00:10 +00:00
Member
Copy Link

copy paste de lo anterior

copy paste de lo anterior
jon marked this conversation as resolved
jsegarra commented 2024-12-30 10:13:48 +00:00
Member
Copy Link

Los e2e los has tirado?
Porque me salen errores, por ejemplo commands.js>writeSearchbar command not found

Los e2e los has tirado? Porque me salen errores, por ejemplo commands.js>writeSearchbar command not found
jon added 3 commits 2024-12-31 07:07:55 +00:00
jsegarra added 2 commits 2024-12-31 11:16:15 +00:00
jsegarra requested changes 2024-12-31 11:16:47 +00:00
Dismissed
jsegarra left a comment
Member
Copy Link

Añadir en itemTag la funcionalidad de eliminar

Añadir en itemTag la funcionalidad de eliminar
jon added 1 commit 2025-01-02 12:15:43 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
49198f794c refactor: refs #8220 skip failling test and modifed tag test
jon requested review from jsegarra 2025-01-02 12:23:41 +00:00
jgallego removed review request for jsegarra 2025-01-02 14:24:59 +00:00
jgallego dismissed jsegarra’s review 2025-01-02 14:25:04 +00:00
Reason:

.

jon requested review from alexm 2025-01-03 06:07:26 +00:00
alexm requested changes 2025-01-07 09:16:53 +00:00
Dismissed
src/pages/Item/ItemList.vue Outdated
@ -320,2 +329,4 @@
onDataSaved: ({ id }) => tableRef.redirect(`${id}/basic-data`),
formInitialData: {
editorFk: entityId,
tag: 56,
alexm commented 2025-01-07 09:10:20 +00:00
Member
Copy Link

Los valores por defecto hay que sacarlos de ItemConfigs 0c592946e6/modules/item/front/create/index.js (L13)

Los valores por defecto hay que sacarlos de ItemConfigs https://gitea.verdnatura.es/verdnatura/salix/src/commit/0c592946e6eca3ff918f06ded194ea080d21a2fc/modules/item/front/create/index.js#L13
jon marked this conversation as resolved
test/cypress/integration/item/itemBotanical.spec.js Outdated
@ -0,0 +3,4 @@
beforeEach(() => {
cy.viewport(1920, 1080);
cy.login('developer');
cy.visit(`/#/item/list`);
alexm commented 2025-01-07 09:14:02 +00:00
Member
Copy Link

Pots ficar item/1/botanical i ja no cal posar cy.get('[href="#/item/1/botanical"]').click();

Pots ficar `item/1/botanical` i ja no cal posar cy.get('[href="#/item/1/botanical"]').click();
jon marked this conversation as resolved
test/cypress/integration/item/itemSummary.spec.js Outdated
@ -0,0 +3,4 @@
beforeEach(() => {
cy.viewport(1920, 1080);
cy.login('developer');
cy.visit(`/#/item/list`);
alexm commented 2025-01-07 09:15:20 +00:00
Member
Copy Link

Aci igual pots ficar item/1/summary

Aci igual pots ficar item/1/summary
jon marked this conversation as resolved
test/cypress/integration/item/itemTax.spec.js Outdated
@ -0,0 +3,4 @@
beforeEach(() => {
cy.viewport(1920, 1080);
cy.login('developer');
cy.visit(`/#/item/list`);
alexm commented 2025-01-07 09:15:56 +00:00
Member
Copy Link

aci item/1/tax

aci item/1/tax
jon marked this conversation as resolved
jon added 1 commit 2025-01-07 12:13:28 +00:00
jon added 1 commit 2025-01-07 12:16:13 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
548db113eb refactor: refs #8220 requested changes
jon added 1 commit 2025-01-07 12:22:35 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
ea89cf4062 Merge branch 'dev' into 8220-ItemsE2E
jon requested review from alexm 2025-01-07 12:23:27 +00:00
alexm approved these changes 2025-01-07 12:46:48 +00:00
jon added 1 commit 2025-01-07 12:48:29 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
33ba6d3142 Merge branch 'dev' into 8220-ItemsE2E
jon merged commit c9c0a25ff9 into dev 2025-01-07 12:50:36 +00:00
jon deleted branch 8220-ItemsE2E 2025-01-07 12:50:36 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
alexm
Labels
Clear labels   
bug

Something is not working

  
CR / Tests passed

CR / Tests passed

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
invalid

Something is wrong

  
Missing Tests

Missing Tests

  
wontfix

This won't be fixed

No Label
bug
CR / Tests passed
duplicate
enhancement
invalid
Missing Tests
wontfix
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
4 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix-front#1039
No description provided.
Delete Branch "8220-ItemsE2E"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?