#8220 created items e2e #1039

Merged
jon merged 26 commits from 8220-ItemsE2E into dev 2025-01-07 12:50:36 +00:00
4 changed files with 19 additions and 20 deletions
Showing only changes of commit 548db113eb - Show all commits

View File

@ -1,5 +1,5 @@
<script setup>
import { ref, computed } from 'vue';
import { ref, computed, onBeforeMount } from 'vue';
import { useI18n } from 'vue-i18n';
import { useRoute } from 'vue-router';
import VnImg from 'src/components/ui/VnImg.vue';
@ -17,7 +17,7 @@ import RightMenu from 'src/components/common/RightMenu.vue';
import ItemListFilter from './ItemListFilter.vue';
import VnInput from 'src/components/common/VnInput.vue';
import VnSelect from 'src/components/common/VnSelect.vue';
import FetchData from 'src/components/FetchData.vue';
import axios from 'axios';
const entityId = computed(() => route.params.id);
const { openCloneDialog } = cloneItem();
@ -26,6 +26,8 @@ const { t } = useI18n();
const tableRef = ref();
const route = useRoute();
const validPriorities = ref([]);
jon marked this conversation as resolved
Review

Se puede simplificar con menos lineas y variables

Se puede simplificar con menos lineas y variables
const defaultTag = ref();
const defaultPriority = ref();
const itemFilter = {
include: [
{
@ -134,7 +136,6 @@ const columns = computed(() => [
fields: ['id', 'name'],
},
},
create: true,
visible: false,
},
{
@ -302,13 +303,17 @@ const columns = computed(() => [
],
},
]);
onBeforeMount(async () => {
const { data } = await axios.get('ItemConfigs');
defaultTag.value = data[0].defaultTag;
jon marked this conversation as resolved Outdated

se puede simplificar el uso de on-fetch

se puede simplificar el uso de on-fetch

OK, propuesta para simplificar @on-fetch="([{ validPriorities: data }]) => (validPriorities = data)"

OK, propuesta para simplificar @on-fetch="([{ validPriorities: data }]) => (validPriorities = data)"
defaultPriority.value = data[0].defaultPriority;
data.forEach((priority) => {
validPriorities.value = priority.validPriorities;
});
});
</script>
<template>
<FetchData
url="ItemConfigs"
@on-fetch="([{ validPriorities: data }]) => (validPriorities = data)"
auto-load
/>
<VnSearchbar
data-key="ItemList"
:label="t('item.searchbar.label')"
@ -320,6 +325,7 @@ const columns = computed(() => [
</template>
</RightMenu>
<VnTable
v-if="defaultTag"
jsegarra marked this conversation as resolved Outdated

No hay traduccion

No hay traduccion
ref="tableRef"
data-key="ItemList"
url="Items/filter"
@ -329,8 +335,8 @@ const columns = computed(() => [
onDataSaved: ({ id }) => tableRef.redirect(`${id}/basic-data`),
formInitialData: {
editorFk: entityId,
tag: 56,
priority: 2,
tag: defaultTag,
priority: defaultPriority,
},
}"
:order="['isActive DESC', 'name', 'id']"

View File

@ -3,12 +3,10 @@ describe('Item botanical', () => {
beforeEach(() => {
cy.viewport(1920, 1080);
cy.login('developer');
cy.visit(`/#/item/list`);
cy.typeSearchbar('1{enter}');
cy.visit(`/#/item/1/botanical`);
jon marked this conversation as resolved Outdated
Outdated
Review

Pots ficar item/1/botanical i ja no cal posar cy.get('[href="#/item/1/botanical"]').click();

Pots ficar `item/1/botanical` i ja no cal posar cy.get('[href="#/item/1/botanical"]').click();
});
it('should modify the botanical', () => {
cy.get('[href="#/item/1/botanical"]').click();
cy.dataCy('AddGenusSelectDialog').type('Abies');
cy.get('.q-menu .q-item').contains('Abies').click();
cy.dataCy('AddSpeciesSelectDialog').type('dealbata');
@ -18,7 +16,6 @@ describe('Item botanical', () => {
});
it('should create a new Genus', () => {
cy.get('[href="#/item/1/botanical"]').click();
cy.dataCy('Genus_icon').click();
cy.dataCy('Latin genus name_input').type('Test');
cy.dataCy('FormModelPopup_save').click();
@ -26,7 +23,6 @@ describe('Item botanical', () => {
});
it('should create a new specie', () => {
cy.get('[href="#/item/1/botanical"]').click();
cy.dataCy('Species_icon').click();
cy.dataCy('Latin species name_input').type('Test specie');
cy.dataCy('FormModelPopup_save').click();

View File

@ -3,8 +3,7 @@ describe('Item summary', () => {
beforeEach(() => {
cy.viewport(1920, 1080);
cy.login('developer');
cy.visit(`/#/item/list`);
cy.typeSearchbar('1{enter}');
cy.visit(`/#/item/1/summary`);
jon marked this conversation as resolved Outdated
Outdated
Review

Aci igual pots ficar item/1/summary

Aci igual pots ficar item/1/summary
});
it('should clone the item', () => {

View File

@ -3,12 +3,10 @@ describe('Item tax', () => {
beforeEach(() => {
cy.viewport(1920, 1080);
cy.login('developer');
cy.visit(`/#/item/list`);
cy.typeSearchbar('1{enter}');
cy.visit(`/#/item/1/tax`);
jon marked this conversation as resolved Outdated
Outdated
Review

aci item/1/tax

aci item/1/tax
});
it('should modify the tax for Spain', () => {
cy.get('[href="#/item/1/tax"]').click();
cy.dataCy('Class_select').eq(1).type('General VAT{enter}');
cy.dataCy('crudModelDefaultSaveBtn').click();
cy.checkNotification('Data saved');