verdnatura/salix-front
verdnatura
/
salix-front
2
3
Fork 1
Code Issues Pull Requests 82 Releases Wiki Activity

#8220 created items e2e #1039

Merged
jon merged 26 commits from 8220-ItemsE2E into dev 2025-01-07 12:50:36 +00:00
Conversation 1 Commits 26 Files Changed 15 +5 -95
1 changed files with 5 additions and 95 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit fc5578cb18 - Show all commits

100
src/pages/Item/ItemList.vue
View File

@ -26,10 +26,6 @@ const { t } = useI18n();
const tableRef = ref();
const route = useRoute();
const validPriorities = ref([]);
jon marked this conversation as resolved
jsegarra commented 2024-12-20 09:23:58 +00:00
Review
Copy Link

Se puede simplificar con menos lineas y variables

Se puede simplificar con menos lineas y variables
const itemConfigs = (data) => {
const dataRow = data[0];
validPriorities.value = dataRow.validPriorities;
};
const itemFilter = {
include: [
{
@ -308,7 +304,11 @@ const columns = computed(() => [
]);
</script>
<template>
<FetchData url="ItemConfigs" @on-fetch="(data) => itemConfigs(data)" auto-load />
<FetchData
url="ItemConfigs"
@on-fetch="(data) => (validPriorities = data[0].validPriorities)"
jon marked this conversation as resolved Outdated
jsegarra commented 2024-12-20 09:22:14 +00:00
Outdated
Review
Copy Link

se puede simplificar el uso de on-fetch

se puede simplificar el uso de on-fetch
jsegarra commented 2024-12-27 08:39:18 +00:00
Outdated
Review
Copy Link

OK, propuesta para simplificar @on-fetch="([{ validPriorities: data }]) => (validPriorities = data)"

OK, propuesta para simplificar @on-fetch="([{ validPriorities: data }]) => (validPriorities = data)"
auto-load
/>
<VnSearchbar
data-key="ItemList"
:label="t('item.searchbar.label')"
@ -466,96 +466,6 @@ const columns = computed(() => [
</template>
</VnSelect>
</template>
<template #more-create-dialog="{ data }">
<VnInput
v-model="data.provisionalName"
:label="t('globals.description')"
:is-required="true"
/>
<VnSelect
url="Tags"
v-model="data.tag"
:label="t('globals.tag')"
:fields="['id', 'name']"
option-label="name"
option-value="id"
:is-required="true"
:sort-by="['name ASC']"
>
<template #option="scope">
<QItem v-bind="scope.itemProps">
<QItemSection>
<QItemLabel>{{ scope.opt?.name }}</QItemLabel>
<QItemLabel caption> #{{ scope.opt?.id }} </QItemLabel>
</QItemSection>
</QItem>
</template>
</VnSelect>
<VnSelect
:options="validPriorities"
v-model="data.priority"
:label="t('item.create.priority')"
:is-required="true"
/>
<VnSelect
url="ItemTypes"
v-model="data.typeFk"
:label="t('item.list.typeName')"
:fields="['id', 'code', 'name']"
option-label="name"
option-value="id"
:is-required="true"
>
<template #option="scope">
<QItem v-bind="scope.itemProps">
<QItemSection>
<QItemLabel>{{ scope.opt?.name }}</QItemLabel>
<QItemLabel caption>
{{ scope.opt?.code }} #{{ scope.opt?.id }}
</QItemLabel>
</QItemSection>
</QItem>
</template>
</VnSelect>
<VnSelect
url="Intrastats"
v-model="data.intrastatFk"
:label="t('globals.intrastat')"
:fields="['id', 'description']"
option-label="description"
option-value="id"
:is-required="true"
>
<template #option="scope">
<QItem v-bind="scope.itemProps">
<QItemSection>
<QItemLabel>{{ scope.opt?.description }}</QItemLabel>
<QItemLabel caption> #{{ scope.opt?.id }} </QItemLabel>
</QItemSection>
</QItem>
</template>
</VnSelect>
<VnSelect
url="Origins"
v-model="data.originFk"
:label="t('globals.origin')"
:fields="['id', 'code', 'name']"
option-label="code"
option-value="id"
:is-required="true"
>
<template #option="scope">
<QItem v-bind="scope.itemProps">
<QItemSection>
<QItemLabel>{{ scope.opt?.name }}</QItemLabel>
<QItemLabel caption>
{{ scope.opt?.code }} #{{ scope.opt?.id }}
</QItemLabel>
</QItemSection>
</QItem>
</template>
</VnSelect>
</template>
</VnTable>
</template>
<style lang="scss" scoped>