verdnatura/salix-front
verdnatura
/
salix-front
2
3
Fork 1
Code Issues Pull Requests 92 Releases Wiki Activity

#7283: Fix Item module #1042

Merged
jon merged 11 commits from Fix-Items-Module into dev 2024-12-09 12:29:55 +00:00
Conversation 0 Commits 11 Files Changed 39 +259 -260
jon commented 2024-12-04 08:14:55 +00:00
Member
Copy Link
No description provided.
jon added 1 commit 2024-12-04 08:14:56 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
4276cefd7a feat: requested changes in item module
jon changed title from #7283: Fix Item module to WIP: #7283: Fix Item module 2024-12-04 08:16:53 +00:00
jon added 1 commit 2024-12-05 05:26:10 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
58a18bfb69 refactor: deleted warnings and corrected itemTag
jon added 1 commit 2024-12-05 09:30:51 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
646007ea63 refactor: log error
jon changed title from WIP: #7283: Fix Item module to #7283: Fix Item module 2024-12-05 09:31:43 +00:00
jon requested review from jgallego 2024-12-05 09:31:48 +00:00
jgallego requested review from alexm 2024-12-05 10:08:30 +00:00
alexm requested changes 2024-12-05 12:42:51 +00:00
Dismissed
src/components/common/VnLog.vue Outdated
@ -370,2 +371,4 @@
}
onMounted(() => {
stateStore.rightDrawer = true;
alexm commented 2024-12-05 12:41:08 +00:00
Member
Copy Link

Diria que lo tiene q poner a true el componente que pongo el div del teleport

Diria que lo tiene q poner a true el componente que pongo el div del teleport
jon marked this conversation as resolved
src/components/ui/VnFilterPanel.vue Outdated
@ -127,7 +127,6 @@ async function search(evt) {
userParams.value = newParams;
if (!$props.showAll && !Object.values(filter).length) store.data = [];
emit('search');
alexm commented 2024-12-05 12:41:19 +00:00
Member
Copy Link

Pq se quita?

Pq se quita?
jon marked this conversation as resolved
jgallego approved these changes 2024-12-05 13:28:12 +00:00
Dismissed
jgallego left a comment
Owner
Copy Link

revisa alex

revisa alex
src/pages/Item/ItemRequestFilter.vue
@ -58,1 +60,4 @@
};
onMounted(async () => {
// Fill fieldFiltersValues with existent userParams
jgallego commented 2024-12-05 10:05:08 +00:00
Owner
Copy Link

quita los comentarios de la ia

quita los comentarios de la ia
jon marked this conversation as resolved
jon added 1 commit 2024-12-09 07:20:44 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
0c88db5931 refactor: deleted onUnmounted code
jon dismissed jgallego’s review 2024-12-09 07:20:44 +00:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

jon added 1 commit 2024-12-09 07:22:19 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
338058c1a4 Merge branch 'dev' into Fix-Items-Module
jon added 2 commits 2024-12-09 07:49:34 +00:00
jon requested review from alexm 2024-12-09 07:50:23 +00:00
alexm requested changes 2024-12-09 08:35:45 +00:00
Dismissed
alexm left a comment
Member
Copy Link

Lo demás esta ok

Lo demás esta ok
src/components/ui/VnFilterPanel.vue Outdated
@ -38,3 +38,3 @@
hiddenTags: {
type: Array,
default: () => ['filter', 'or', 'and'],
default: () => ['filter', 'search', 'or', 'and'],
alexm commented 2024-12-09 08:35:00 +00:00
Member
Copy Link

Esto es de hiddenTags, mantener sin

Esto es de hiddenTags, mantener sin
jon added 1 commit 2024-12-09 10:27:37 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
92b05db9d2 refactor: deleted useless hidden tag
jon requested review from alexm 2024-12-09 10:28:19 +00:00
jon added 1 commit 2024-12-09 12:01:10 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
e4837b45be Merge branch 'dev' into Fix-Items-Module
alexm approved these changes 2024-12-09 12:14:29 +00:00
Dismissed
jon added 2 commits 2024-12-09 12:24:44 +00:00
jon dismissed alexm’s review 2024-12-09 12:24:44 +00:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

alexm approved these changes 2024-12-09 12:26:56 +00:00
jgallego approved these changes 2024-12-09 12:29:11 +00:00
jon merged commit 91afc3ddab into dev 2024-12-09 12:29:55 +00:00
jon deleted branch Fix-Items-Module 2024-12-09 12:29:55 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
alexm
jgallego
Labels
Clear labels   
bug

Something is not working

  
CR / Tests passed

CR / Tests passed

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
invalid

Something is wrong

  
Missing Tests

Missing Tests

  
wontfix

This won't be fixed

No Label
bug
CR / Tests passed
duplicate
enhancement
invalid
Missing Tests
wontfix
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix-front#1042
No description provided.
Delete Branch "Fix-Items-Module"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?