8197-VnCardMain #1044

Merged
alexm merged 31 commits from 8197-VnCardMain into beta 2024-12-24 10:29:04 +00:00
Member

Solo se han migrado los modulos de Account y de Ticket
Los demas se haran en #8316 y #8322

Se ha hecho codigo retrocompatible para que no fallen mientras no esten migradas

❗ Solo se han migrado los modulos de Account y de Ticket Los demas se haran en #8316 y #8322 Se ha hecho codigo retrocompatible para que no fallen mientras no esten migradas
alexm added 3 commits 2024-12-04 08:45:06 +00:00
alexm added 1 commit 2024-12-04 08:45:13 +00:00
gitea/salix-front/pipeline/pr-master This commit looks good Details
0c4d6c782e
Merge branch 'master' into 8197-VnCardMain
alexm reviewed 2024-12-04 08:46:05 +00:00
@ -49,10 +49,16 @@ export const useArrayDataStore = defineStore('arrayDataStore', () => {
});
}
function resetPagination(key) {
Author
Member

He visto que se repetia varias veces el patron y lo he hecho una funcion

He visto que se repetia varias veces el patron y lo he hecho una funcion
jorgep marked this conversation as resolved
alexm added 2 commits 2024-12-04 08:49:57 +00:00
alexm added 1 commit 2024-12-09 10:21:29 +00:00
gitea/salix-front/pipeline/pr-master There was a failure building this commit Details
1d86b29129
feat: refs #8197 vnTableFilter
alexm added 1 commit 2024-12-09 13:15:40 +00:00
gitea/salix-front/pipeline/pr-master There was a failure building this commit Details
2ae0d90e32
chore: refs #8197 replace name
alexm added 1 commit 2024-12-12 10:03:37 +00:00
gitea/salix-front/pipeline/pr-master There was a failure building this commit Details
3984327b51
feat: refs #8197 working rightMenu
alexm added 1 commit 2024-12-16 06:32:33 +00:00
alexm added 1 commit 2024-12-16 08:41:57 +00:00
gitea/salix-front/pipeline/pr-master There was a failure building this commit Details
5d744ca456
feat: refs #8197 better leftMenu and VnCardMain improvements
alexm added 1 commit 2024-12-16 08:47:52 +00:00
gitea/salix-front/pipeline/pr-master There was a failure building this commit Details
18fd41b82b
refactor: refs #8197 adapt AccountAlias
alexm added 2 commits 2024-12-16 11:27:21 +00:00
alexm added 1 commit 2024-12-16 12:34:07 +00:00
gitea/salix-front/pipeline/pr-master There was a failure building this commit Details
gitea/salix-front/pipeline/pr-beta There was a failure building this commit Details
dc665d43fe
feat: refs #8197 default leftMenu
alexm changed target branch from master to beta 2024-12-16 12:55:11 +00:00
alexm added 11 commits 2024-12-16 12:55:44 +00:00
gitea/salix-front/pipeline/pr-master This commit looks good Details
eb91b9c109
fix: fix front
gitea/salix-front/pipeline/pr-master This commit looks good Details
c61934e127
Merge branch 'master' into hotfix-irpfDaysOnWard
gitea/salix-front/pipeline/pr-master This commit looks good Details
2283e65402
fix: clean
gitea/salix-front/pipeline/pr-master This commit looks good Details
842a3775f1
fix: clean
gitea/salix-front/pipeline/pr-master This commit looks good Details
5b0e36fa4e
fix: change number
gitea/salix-front/pipeline/pr-master This commit looks good Details
dc9dad69a2
Merge branch 'master' into hotfix-irpfDaysOnWard
gitea/salix-front/pipeline/pr-master This commit looks good Details
7ce92cc64b
Merge branch 'master' into hotfix-irpfDaysOnWard
gitea/salix-front/pipeline/head This commit looks good Details
98674e528c
Merge pull request 'fix: fix front' (!1061) from hotfix-irpfDaysOnWard into master
Reviewed-on: #1061
Reviewed-by: Alex Moreno <alexm@verdnatura.es>
alexm added 1 commit 2024-12-17 08:05:29 +00:00
gitea/salix-front/pipeline/pr-beta There was a failure building this commit Details
586d5eff3e
chore: refs #8197 unnecessary file
alexm added 3 commits 2024-12-17 11:47:22 +00:00
gitea/salix-front/pipeline/pr-8197-VnCardMain Build queued... Details
dc83d50e96
refactor: refs #8197 backward compatible
gitea/salix-front/pipeline/pr-8197-VnCardMain Build started... Details
d1970f5227
Merge branch '8197-VnCardMain' into 8197-VnCardMain_backwardCompatibility
jorgep reviewed 2024-12-17 13:25:25 +00:00
@ -17,0 +26,4 @@
hasContent.value = teleportRef.value.innerHTML.trim() !== '';
};
observer = new MutationObserver(checkContent);
Member

El hook update o alguno de esos no sirve? Entiendo que no, pero por si acaso pregunto

El hook update o alguno de esos no sirve? Entiendo que no, pero por si acaso pregunto
alexm marked this conversation as resolved
jorgep reviewed 2024-12-17 13:26:51 +00:00
@ -15,2 +15,4 @@
() => (stateStore.leftDrawer = useQuasar().screen.gt.xs ? $props.leftDrawer : false)
);
const targetId = 'left-panel';
Member

Para que quieres una variable que solo se usa en 1 sitio?

Para que quieres una variable que solo se usa en 1 sitio?
Author
Member

Antes de poner lo del ref la usaba 2 veces, lo quito

Antes de poner lo del ref la usaba 2 veces, lo quito
alexm marked this conversation as resolved
jorgep reviewed 2024-12-17 13:27:46 +00:00
@ -20,3 +38,3 @@
<QDrawer v-model="stateStore.leftDrawer" show-if-above :width="256">
<QScrollArea class="fit text-grey-8">
<LeftMenu />
<div :id="targetId" ref="teleportRef"></div>
Member

template en lugar de div es posible?

template en lugar de div es posible?
Author
Member

Al ser para un teleport siempre lo he visto con div, lo pruebo

Al ser para un teleport siempre lo he visto con div, lo pruebo
Author
Member

No puede ser template, deja de funcionar

No puede ser template, deja de funcionar
alexm marked this conversation as resolved
jorgep reviewed 2024-12-17 14:20:20 +00:00
jorgep reviewed 2024-12-17 14:29:28 +00:00
@ -161,2 +141,2 @@
order="id DESC"
:disable-option="{ card: true }"
<VnCardMain
:section="dataKey"
Member

Que esta prop tenga el valor por defecto de la prop datakey

Que esta prop tenga el valor por defecto de la prop datakey
Author
Member

Me gusta como piensas

Me gusta como piensas
alexm marked this conversation as resolved
jorgep reviewed 2024-12-17 14:30:33 +00:00
@ -66,2 +46,2 @@
}"
order="id DESC"
<VnCardMain
:section="dataKey"
Member

Lo mismo que el AccountAcls

Lo mismo que el AccountAcls
alexm marked this conversation as resolved
jorgep reviewed 2024-12-17 14:30:42 +00:00
@ -122,2 +106,2 @@
:filter="filter"
order="id DESC"
<VnCardMain
:section="dataKey"
Member

Lo mismo que AccountAcls

Lo mismo que AccountAcls
alexm marked this conversation as resolved
jorgep reviewed 2024-12-17 14:35:03 +00:00
@ -102,2 +88,2 @@
order="id ASC"
:disable-option="{ card: true }"
<VnCardMain
:section="dataKey"
Member

Lo mismo que AccountAcls

Lo mismo que AccountAcls
alexm marked this conversation as resolved
jorgep reviewed 2024-12-17 14:35:46 +00:00
@ -44,3 +44,3 @@
module="Role"
@on-fetch="setData"
data-key="accountData"
data-key="Role"
Member

RoleId

RoleId
Author
Member

No hace falta poner roleId, dado que el dataKey del list es AccountRoleList
Siendo Role ya va guay

No hace falta poner roleId, dado que el dataKey del list es AccountRoleList Siendo Role ya va guay
alexm marked this conversation as resolved
jorgep reviewed 2024-12-17 14:36:03 +00:00
@ -31,3 +31,3 @@
:filter="filter"
@on-fetch="(data) => (role = data)"
data-key="RoleSummary"
data-key="Role"
Member

RoleId

RoleId
alexm marked this conversation as resolved
jorgep reviewed 2024-12-17 14:39:21 +00:00
@ -1,4 +1,7 @@
import { RouterView } from 'vue-router';
import accountCard from './account/accountCard';
Member

Consultaría a Juan si le parece bien separarlo en varios ficheros. Por mí bien

Consultaría a Juan si le parece bien separarlo en varios ficheros. Por mí bien
Author
Member

Entiendo que lo verán guay sino se hace un monstruo de archivo y de todas maneras como estaba ya estaba separado

Entiendo que lo verán guay sino se hace un monstruo de archivo y de todas maneras como estaba ya estaba separado
alexm marked this conversation as resolved
jorgep requested changes 2024-12-17 14:40:51 +00:00
Dismissed
jorgep left a comment
Member

.

.
alexm added 1 commit 2024-12-18 11:04:25 +00:00
gitea/salix-front/pipeline/pr-beta There was a failure building this commit Details
6fa4269eae
Merge branch 'beta' into 8197-VnCardMain
alexm added 1 commit 2024-12-18 11:09:28 +00:00
gitea/salix-front/pipeline/pr-beta There was a failure building this commit Details
66d0c2d5bb
Merge branch 'beta' of https://gitea.verdnatura.es/verdnatura/salix-front into 8197-VnCardMain
alexm added 3 commits 2024-12-18 12:04:37 +00:00
alexm added 1 commit 2024-12-18 12:16:51 +00:00
gitea/salix-front/pipeline/pr-beta This commit looks good Details
8c3c318099
test(VnTable): refs #8197 mock useFilterParams
alexm added 1 commit 2024-12-18 12:43:05 +00:00
alexm added 2 commits 2024-12-18 13:22:26 +00:00
alexm requested review from jorgep 2024-12-18 13:23:00 +00:00
jorgep reviewed 2024-12-18 14:35:08 +00:00
jorgep reviewed 2024-12-18 14:38:55 +00:00
@ -0,0 +58,4 @@
<Teleport to="#left-panel" v-if="stateStore.isHeaderMounted()">
<component :is="descriptor" />
<QSeparator />
<LeftMenu source="card" />
Member

No me acaba de gustar poner leftMenu en 2 sitios. No se le puede pasar el source en el meta o algo así? Como veo que este problema ya existía antes okey... Pero yo crearía tarea o algo...

No me acaba de gustar poner leftMenu en 2 sitios. No se le puede pasar el source en el meta o algo así? Como veo que este problema ya existía antes okey... Pero yo crearía tarea o algo...
Author
Member

Con el refactor que he hecho ya no hará falta poner el source pq te buscara de abajo a arriba. Me lo apunto en la tarea

Con el refactor que he hecho ya no hará falta poner el source pq te buscara de abajo a arriba. Me lo apunto en la tarea
jorgep marked this conversation as resolved
Member

Los nombres VnSection y VnModule me suenan a lo mismo... En lugar de VnModule, VnAside... o LeftMenu y cambiar este a LeftMenuModules / LeftMenuItems. Pero creo que yo optaría por VnAside y que lo usen LeftMenu y RightMenu. Como minimo LeftMenu que parece que es lo que te hace falta.

Los nombres VnSection y VnModule me suenan a lo mismo... En lugar de VnModule, VnAside... o LeftMenu y cambiar este a LeftMenuModules / LeftMenuItems. Pero creo que yo optaría por VnAside y que lo usen LeftMenu y RightMenu. Como minimo LeftMenu que parece que es lo que te hace falta.
jorgep reviewed 2024-12-18 14:55:47 +00:00
@ -28,3 +26,4 @@
const roles = ref();
const validationsStore = useValidator();
const { models } = validationsStore;
const dataKey = 'AccountAcls';
Member

Quitar y poner directamente en la prop, solo se usa 1 vez

Quitar y poner directamente en la prop, solo se usa 1 vez
Member

Quitar

Quitar
alexm marked this conversation as resolved
jorgep reviewed 2024-12-18 14:57:01 +00:00
@ -8,3 +7,3 @@
const tableRef = ref();
const { t } = useI18n();
const stateStore = useStateStore();
const dataKey = 'AccountAliasList';
Member

quitar, solo se usa 1 vez.

quitar, solo se usa 1 vez.
alexm marked this conversation as resolved
jorgep reviewed 2024-12-18 14:57:16 +00:00
@ -13,3 +11,4 @@
const filter = {
include: { relation: 'role', scope: { fields: ['id', 'name'] } },
};
const dataKey = 'AccountList';
Member

quitar, solo se usa 1 vez.

quitar, solo se usa 1 vez.
alexm marked this conversation as resolved
jorgep reviewed 2024-12-18 14:57:26 +00:00
@ -16,2 +18,4 @@
});
const tableRef = ref();
const url = 'VnRoles';
const dataKey = 'AccountRoleList';
Member

quitar, solo se usa 1 vez.

quitar, solo se usa 1 vez.
alexm marked this conversation as resolved
jorgep reviewed 2024-12-18 14:58:26 +00:00
@ -10,3 +12,4 @@
const quasar = useQuasar();
onMounted(async () => {
stateStore.rightDrawer = true;
Member

En vista móvil se quedará abierto también.

En vista móvil se quedará abierto también.
Author
Member

Diria que es lo correcto pq hasta que no eliges video, no muestra nada

Diria que es lo correcto pq hasta que no eliges video, no muestra nada
jorgep marked this conversation as resolved
jorgep requested changes 2024-12-18 15:04:52 +00:00
Dismissed
@ -54,1 +56,4 @@
}
return {
state,
Member

Se te ha colado al hacer pruebas o necesitas que se vea la store entera?

Se te ha colado al hacer pruebas o necesitas que se vea la store entera?
Author
Member

Si, lo quito

Si, lo quito
alexm marked this conversation as resolved
alexm added 1 commit 2024-12-23 16:56:34 +00:00
gitea/salix-front/pipeline/pr-beta This commit looks good Details
dd36b35bf7
fix: refs #8197 staticParams and redirect
Author
Member

Los nombres VnSection y VnModule me suenan a lo mismo... En lugar de VnModule, VnAside... o LeftMenu y cambiar este a LeftMenuModules / LeftMenuItems. Pero creo que yo optaría por VnAside y que lo usen LeftMenu y RightMenu. Como minimo LeftMenu que parece que es lo que te hace falta.

Los nombres han sido validados con Javi, VnSection para secciones y VnModule pq es el modulo entero

> Los nombres VnSection y VnModule me suenan a lo mismo... En lugar de VnModule, VnAside... o LeftMenu y cambiar este a LeftMenuModules / LeftMenuItems. Pero creo que yo optaría por VnAside y que lo usen LeftMenu y RightMenu. Como minimo LeftMenu que parece que es lo que te hace falta. Los nombres han sido validados con Javi, VnSection para secciones y VnModule pq es el modulo entero
alexm added 1 commit 2024-12-23 17:16:59 +00:00
gitea/salix-front/pipeline/pr-beta This commit looks good Details
gitea/salix-front/pipeline/pr-dev There was a failure building this commit Details
cfb35d23b4
perf: refs #8197 perf
alexm requested review from jorgep 2024-12-23 17:17:07 +00:00
jorgep requested changes 2024-12-24 10:12:12 +00:00
Dismissed
jorgep left a comment
Member

Quitar variable de datakey

Quitar variable de datakey
jorgep approved these changes 2024-12-24 10:17:35 +00:00
alexm merged commit cd4d5d011e into beta 2024-12-24 10:29:04 +00:00
Sign in to join this conversation.
No reviewers
No Milestone
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix-front#1044
No description provided.