6157-actionClaim #106

Merged
carlossa merged 22 commits from 6157-actionClaim into dev 2023-11-24 07:46:30 +00:00
Member
No description provided.
carlossa added 10 commits 2023-11-03 12:41:28 +00:00
carlossa added 1 commit 2023-11-07 11:42:39 +00:00
gitea/salix-front/pipeline/head This commit looks good Details
6db52e00ea
refs #6157 test ui
carlossa added 1 commit 2023-11-07 11:43:10 +00:00
gitea/salix-front/pipeline/head This commit looks good Details
35eae2f9a5
remove consolelog
carlossa requested review from alexm 2023-11-07 11:43:43 +00:00
carlossa added the
CR / Tests passed
label 2023-11-07 11:43:49 +00:00
carlossa changed title from WIP: 6157-actionClaim to 6157-actionClaim 2023-11-07 11:43:55 +00:00
carlossa added 1 commit 2023-11-07 11:44:01 +00:00
gitea/salix-front/pipeline/head This commit looks good Details
b89f5aadf1
Merge branch 'dev' into 6157-actionClaim
carlossa added 2 commits 2023-11-07 11:50:54 +00:00
alexm requested changes 2023-11-07 13:10:57 +00:00
@ -0,0 +27,4 @@
const destinationTypes = ref([]);
const destinations = ref([]);
const totalClaimed = ref(null);
const maxResponsibility = computed(() => 5);
Member

Si es un numero li pots possar const maxResponsibility = 5;

Si es un numero li pots possar const maxResponsibility = 5;
Member

Si que puedes,
Sin embargo, te diría que ese 5, quizás moverlo a un const DEFAULT_MAX_RESPONSABILITY = 5.

Ya me dices

Si que puedes, Sin embargo, te diría que ese 5, quizás moverlo a un const DEFAULT_MAX_RESPONSABILITY = 5. Ya me dices
carlossa marked this conversation as resolved
@ -0,0 +45,4 @@
{
name: 'destination',
label: t('Destination'),
field: (row) => getDestination(row.claimDestinationFk),
Member

Pq no pots possar row.claimDestinationFk ?

Pq no pots possar row.claimDestinationFk ?
carlossa marked this conversation as resolved
@ -0,0 +90,4 @@
},
]);
watchEffect(() => {
Member

? si lo que fas es sumar no seria mes facil sumar en el onmouted y quan afegixes o borres una linea?

? si lo que fas es sumar no seria mes facil sumar en el onmouted y quan afegixes o borres una linea?
carlossa marked this conversation as resolved
@ -0,0 +103,4 @@
return destinationTypes.value.find((type) => type.id == destinationId);
}
async function deleteSale(sale) {
Member

Esta funcio no se crida mai

Esta funcio no se crida mai
carlossa marked this conversation as resolved
@ -0,0 +457,4 @@
.claim-action {
.q-table {
.q-select .q-field__input {
display: none !important;
Member

Com?

Com?
carlossa marked this conversation as resolved
@ -0,0 +482,4 @@
height: min-content;
}
}
.totalClaim {
Member

Aço si ja esta en els descriptors, en els summarys te que haver alguna clase ja feta (si no fesla)

Aço si ja esta en els descriptors, en els summarys te que haver alguna clase ja feta (si no fesla)
carlossa marked this conversation as resolved
@ -0,0 +15,4 @@
});
it('should change destination', () => {
const rowData = [true, null, null, 'Bueno', null, null, null, null, null, null];
Member

Crec q els ultims nulls no fan falta

Crec q els ultims nulls no fan falta
carlossa marked this conversation as resolved
@ -0,0 +20,4 @@
});
it('should regularize', () => {
cy.get('[title="Regularize"]').click();
Member

Aci deuries comprovar que fa lo que esperes

Aci deuries comprovar que fa lo que esperes
carlossa marked this conversation as resolved
@ -0,0 +22,4 @@
it('should regularize', () => {
cy.get('[title="Regularize"]').click();
});
});
Member

Te falta per fer tests a un boto no?
I borrar per a netejar les fixtures

Te falta per fer tests a un boto no? I borrar per a netejar les fixtures
carlossa marked this conversation as resolved
alexm requested review from jsegarra 2023-11-07 13:11:05 +00:00
jsegarra reviewed 2023-11-08 07:00:15 +00:00
@ -269,3 +269,3 @@
<SkeletonTable v-if="!formData" />
<Teleport to="#st-actions" v-if="stateStore?.isSubToolbarShown()">
<QBtnGroup push class="q-gutter-x-sm">
<QBtnGroup push style="column-gap: 10px">
Member

Este estilo, es el que corregimos que permitía separar los botones pero tenerlos pegados al margen?
Si es así, quizás, ese estilo, puede ser usado en un futuro o recurrente en otros componentes, por lo que la propiedad column-gap la movería a una clase

Este estilo, es el que corregimos que permitía separar los botones pero tenerlos pegados al margen? Si es así, quizás, ese estilo, puede ser usado en un futuro o recurrente en otros componentes, por lo que la propiedad column-gap la movería a una clase
carlossa marked this conversation as resolved
carlossa added 1 commit 2023-11-09 12:52:46 +00:00
carlossa added 2 commits 2023-11-17 13:06:39 +00:00
carlossa added 1 commit 2023-11-20 17:13:21 +00:00
gitea/salix-front/pipeline/head This commit looks good Details
1320db7bf0
refs #6157 e2e + front
carlossa added 1 commit 2023-11-23 14:50:34 +00:00
gitea/salix-front/pipeline/head This commit looks good Details
d03092f41d
refs #6157 arrayData
carlossa requested review from alexm 2023-11-24 06:44:08 +00:00
alexm requested changes 2023-11-24 06:50:58 +00:00
@ -31,3 +36,2 @@
const { t } = useI18n();
const entity = ref();
defineExpose({ fetch });
Member

Esta tb borrala

Esta tb borrala
carlossa marked this conversation as resolved
@ -52,3 +62,1 @@
entity.value = null;
await fetch();
});
async function fetch() {}
Member

Borrala si no se gasta ni fa res

Borrala si no se gasta ni fa res
carlossa marked this conversation as resolved
@ -68,6 +68,7 @@ const arrayData = useArrayData(props.dataKey, {
limit: props.limit,
order: props.order,
userParams: props.userParams,
skip: 0,
Member

Prova a no possarla no recorde pq la possarem

Prova a no possarla no recorde pq la possarem
carlossa marked this conversation as resolved
@ -25,1 +21,4 @@
pending: 'positive',
managed: 'warning',
Member

Els introoooooooooooos, tens prettier?

Els introoooooooooooos, tens prettier?
carlossa marked this conversation as resolved
carlossa added 1 commit 2023-11-24 07:10:37 +00:00
gitea/salix-front/pipeline/head This commit looks good Details
c3d9085a57
refs #6157 minorFix
carlossa requested review from alexm 2023-11-24 07:14:40 +00:00
alexm approved these changes 2023-11-24 07:24:01 +00:00
Dismissed
jsegarra refused to review 2023-11-24 07:36:57 +00:00
jsegarra requested review from jsegarra 2023-11-24 07:37:06 +00:00
jsegarra approved these changes 2023-11-24 07:37:31 +00:00
Dismissed
@ -0,0 +108,4 @@
claimActionsForm.value.reload();
}
async function updateDestinations(claimDestinationFk) {
Member

Lo revisamos!!

**Lo revisamos!!**
carlossa marked this conversation as resolved
@ -0,0 +118,4 @@
}
}
async function updateDestination(claimDestinationFk, row) {
Member

Y esto también!!

Y esto también!!
carlossa marked this conversation as resolved
@ -0,0 +134,4 @@
if (claim.value.responsibility >= Math.ceil(maxResponsibility.value) / 2) {
dialogGreuge.value = true;
} else {
quasar.notify({
Member

Lo que le pasas a notify podría ser una constante, no? Porque lo hacemos en la línea 148, 166, 195

Lo que le pasas a notify podría ser una constante, no? Porque lo hacemos en la línea 148, 166, 195
carlossa marked this conversation as resolved
@ -0,0 +258,4 @@
label-always
color="primary"
markers
:marker-labels="[
Member

Si, los labels cambian, tienes que venir hasta el HTML?
Quizás, mejor definirlo en el apartado de

Si, los labels cambian, tienes que venir hasta el HTML? Quizás, mejor definirlo en el apartado de <script setup>
carlossa marked this conversation as resolved
@ -0,0 +262,4 @@
{ value: 1, label: t('claim.summary.company') },
{ value: 5, label: t('claim.summary.person') },
]"
:min="1"
Member

Podemos definir este valor como constante?
Tipo
DEFAULT_MIN_SLIDER =1
DEFAULT_MAX_SLIDER =5

Podemos definir este valor como constante? Tipo DEFAULT_MIN_SLIDER =1 DEFAULT_MAX_SLIDER =5
carlossa marked this conversation as resolved
@ -22,11 +22,6 @@ const $props = defineProps({
const entityId = computed(() => {
Member

esto no se usa, no?

esto no se usa, no?
carlossa marked this conversation as resolved
@ -69,6 +69,7 @@ function stateColor(code) {
}
const data = ref(useCardDescription());
const setData = (entity) => {
if (!entity) return;
Member

Revisamos linea 65!

**Revisamos linea 65!**
carlossa marked this conversation as resolved
jsegarra approved these changes 2023-11-24 07:37:43 +00:00
Dismissed
carlossa added 1 commit 2023-11-24 07:41:13 +00:00
gitea/salix-front/pipeline/head This commit looks good Details
98fa68bb80
refs 6157 markerlabel
carlossa dismissed jsegarra’s review 2023-11-24 07:41:13 +00:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

carlossa dismissed alexm’s review 2023-11-24 07:41:13 +00:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

carlossa dismissed jsegarra’s review 2023-11-24 07:41:13 +00:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

alexm approved these changes 2023-11-24 07:45:25 +00:00
carlossa merged commit 247f935334 into dev 2023-11-24 07:46:30 +00:00
carlossa deleted branch 6157-actionClaim 2023-11-24 07:46:30 +00:00
Sign in to join this conversation.
No reviewers
No Milestone
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix-front#106
No description provided.