verdnatura/salix-front
verdnatura
/
salix-front
2
2
Fork 1
Code Issues Pull Requests 85 Releases Wiki Activity

Hotfix: fixed filter when searching by id #1063

Merged
jon merged 6 commits from Hotfix-TicketFilter into master 2024-12-11 13:35:56 +00:00
Conversation 0 Commits 6 Files Changed 2 +16 -15
jon commented 2024-12-10 13:07:13 +00:00
Member
Copy Link
No description provided.
jon added 1 commit 2024-12-10 13:07:13 +00:00
gitea/salix-front/pipeline/pr-master There was a failure building this commit Details
a6f970cec8 fix: fixed filter when searching by id
jon added 1 commit 2024-12-11 05:17:01 +00:00
gitea/salix-front/pipeline/pr-master This commit looks good Details
2cdc8916cc fix: conflicts
jon added 1 commit 2024-12-11 12:38:13 +00:00
jon added 1 commit 2024-12-11 12:39:07 +00:00
gitea/salix-front/pipeline/pr-master This commit looks good Details
2262ef9594 Merge branch 'master' into Hotfix-TicketFilter
jon changed title from WIP: Hotfix: fixed filter when searching by id to Hotfix: fixed filter when searching by id 2024-12-11 12:40:01 +00:00
jon requested review from alexm 2024-12-11 12:56:56 +00:00
alexm reviewed 2024-12-11 12:59:03 +00:00
src/components/ui/VnSearchbar.vue Outdated
@ -114,3 +106,1 @@
if (props.whereFilter) {
filter.filter = {
where: props.whereFilter(searchText.value),
if (!(searchText.value && searchText.value !== '')) {
alexm commented 2024-12-11 12:59:03 +00:00
Member
Copy Link

if (!searchText.value)

if (!searchText.value)
alexm approved these changes 2024-12-11 13:02:04 +00:00
Dismissed
jon added 2 commits 2024-12-11 13:04:04 +00:00
jon dismissed alexm’s review 2024-12-11 13:04:04 +00:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

jon requested review from alexm 2024-12-11 13:05:10 +00:00
alexm approved these changes 2024-12-11 13:13:15 +00:00
jon merged commit 36c447772f into master 2024-12-11 13:35:56 +00:00
jon deleted branch Hotfix-TicketFilter 2024-12-11 13:35:56 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
alexm
Labels
Clear labels   
bug

Something is not working

  
CR / Tests passed

CR / Tests passed

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
invalid

Something is wrong

  
Missing Tests

Missing Tests

  
wontfix

This won't be fixed

No Label
bug
CR / Tests passed
duplicate
enhancement
invalid
Missing Tests
wontfix
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix-front#1063
No description provided.
Delete Branch "Hotfix-TicketFilter"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?