verdnatura/salix-front
verdnatura
/
salix-front
1
2
Fork 1
Code Issues Pull Requests 59 Releases Wiki Activity

4797-workerNotificationManager #107

Merged
alexm merged 9 commits from 4797-workerNotificationManager into dev 2023-11-10 09:39:53 +00:00
Conversation 0 Commits 9 Files Changed 12 +224 -298
alexm commented 2023-11-09 10:04:37 +00:00
Member
Copy Link
No description provided.
alexm added 7 commits 2023-11-09 10:04:38 +00:00
gitea/salix-front/pipeline/head This commit looks good Details
cc13e3935e refs #4797 feat(workerNotificationManager): use crudModel
gitea/salix-front/pipeline/head There was a failure building this commit Details
4de39452ca refs #4797 feat(workerNotification): add cards
gitea/salix-front/pipeline/head There was a failure building this commit Details
5350765469 refs #4797 style(workerNotificationManager)
gitea/salix-front/pipeline/head There was a failure building this commit Details
0b3a957944 refs #4797 fix: remove clientCreate
gitea/salix-front/pipeline/head This commit looks good Details
b82f5d210f refs #4797 test: workerNotification front
gitea/salix-front/pipeline/head This commit looks good Details
31c9876fb0 refs #4797 test: workerNotification e2e
alexm added 1 commit 2023-11-09 10:04:52 +00:00
gitea/salix-front/pipeline/head This commit looks good Details
9993344d70 Merge branch 'dev' into 4797-workerNotificationManager
alexm requested review from jgallego 2023-11-09 10:05:44 +00:00
alexm requested review from jsegarra 2023-11-09 10:05:54 +00:00
jgallego approved these changes 2023-11-09 16:05:09 +00:00
Dismissed
jsegarra reviewed 2023-11-10 06:24:34 +00:00
.vscode/settings.json
@ -15,2 +15,3 @@
"editor.defaultFormatter": "esbenp.prettier-vscode"
}
},
"cSpell.words": ["axios"]
jsegarra commented 2023-11-10 06:24:34 +00:00
Member
Copy Link

Este archivo seguro que hay que subirlo?

Este archivo seguro que hay que subirlo?
alexm commented 2023-11-10 06:40:58 +00:00
Author
Member
Copy Link

Creo que se puede poner a nivel de usuario.
Pero por si alguien mas lo usa. Que todos tengamos que darle la primera vez a que no te lo marque

Creo que se puede poner a nivel de usuario. Pero por si alguien mas lo usa. Que todos tengamos que darle la primera vez a que no te lo marque
alexm commented 2023-11-10 06:40:58 +00:00
Author
Member
Copy Link

Creo que se puede poner a nivel de usuario.
Pero por si alguien mas lo usa. Que todos tengamos que darle la primera vez a que no te lo marque

Creo que se puede poner a nivel de usuario. Pero por si alguien mas lo usa. Que todos tengamos que darle la primera vez a que no te lo marque
alexm marked this conversation as resolved
jsegarra approved these changes 2023-11-10 06:45:23 +00:00
Dismissed
src/pages/Worker/Card/WorkerNotificationsManager.vue
@ -118,1 +64,3 @@
:key="notification.notificationFk"
<CrudModel
auto-load
data-key="NotificationSubscriptions"
jsegarra commented 2023-11-10 06:27:46 +00:00
Member
Copy Link

NotificationSubscriptions aparece 4 veces en este fichero, como verias de hacer una const para que sólo esté 1 vez?

NotificationSubscriptions aparece 4 veces en este fichero, como verias de hacer una const para que sólo esté 1 vez?
alexm marked this conversation as resolved
alexm added 1 commit 2023-11-10 07:09:24 +00:00
gitea/salix-front/pipeline/head This commit looks good Details
54276b2460 refs #4797 refactor(workerNotification): const url_key
alexm dismissed jgallego’s review 2023-11-10 07:09:25 +00:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

alexm dismissed jsegarra’s review 2023-11-10 07:09:25 +00:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

jsegarra approved these changes 2023-11-10 07:18:22 +00:00
jgallego approved these changes 2023-11-10 09:35:00 +00:00
alexm merged commit 222a970a26 into dev 2023-11-10 09:39:53 +00:00
alexm deleted branch 4797-workerNotificationManager 2023-11-10 09:39:54 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
jsegarra
jgallego
Labels
Clear labels   
bug

Something is not working

  
CR / Tests passed

CR / Tests passed

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
invalid

Something is wrong

  
Missing Tests

Missing Tests

  
wontfix

This won't be fixed

No Label
bug
CR / Tests passed
duplicate
enhancement
invalid
Missing Tests
wontfix
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix-front#107
No description provided.
Delete Branch "4797-workerNotificationManager"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?