verdnatura/salix-front
verdnatura
/
salix-front
2
2
Fork 1
Code Issues Pull Requests 82 Releases Wiki Activity

#8201: Fix descriptor icons error #1080

Merged
jon merged 12 commits from 8201-DescriptorIcons into dev 2024-12-27 09:55:46 +00:00
Conversation 0 Commits 12 Files Changed 6 +19 -25
jon commented 2024-12-13 07:05:45 +00:00
Member
Copy Link
No description provided.
jon added 2 commits 2024-12-13 07:05:46 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
1a0789b77f refactor: refs #8201 deleted log
jon requested review from jsegarra 2024-12-13 07:28:00 +00:00
jon added 1 commit 2024-12-13 13:20:24 +00:00
jon added 2 commits 2024-12-17 05:27:11 +00:00
jon added 1 commit 2024-12-18 09:04:30 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
410052d6ec refactor: refs #8201 deleted logs
jsegarra reviewed 2024-12-20 09:16:36 +00:00
src/pages/Account/Card/AccountDescriptor.vue Outdated
@ -95,3 +93,4 @@
v-if="hasAccount"
flat
round
size="sm"
jsegarra commented 2024-12-20 09:16:36 +00:00
Member
Copy Link

El tamaño es diferente, cambiar los sm por xs

El tamaño es diferente, cambiar los sm por xs
jon marked this conversation as resolved
jsegarra requested changes 2024-12-20 09:19:44 +00:00
Dismissed
src/pages/Account/Card/AccountDescriptor.vue Outdated
@ -78,2 +77,2 @@
<template #actions="{ entity }">
<QCardActions class="q-gutter-x-md">
<template #icons="{ entity }">
<QCardActions v-if="accountData" class="q-gutter-x-md">
jsegarra commented 2024-12-20 09:17:56 +00:00
Member
Copy Link

en el archivo solo hay una ocurrencia de accountData

en el archivo solo hay una ocurrencia de accountData
jon marked this conversation as resolved
jon added 1 commit 2024-12-27 08:18:38 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
1ff54d7423 refactor: refs #8201 deleted condition
jon added 1 commit 2024-12-27 08:20:38 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
ceb470fc0f Merge branch 'dev' into 8201-DescriptorIcons
jon requested review from jsegarra 2024-12-27 08:23:13 +00:00
jsegarra requested changes 2024-12-27 09:06:40 +00:00
Dismissed
src/pages/Supplier/Card/SupplierBasicData.vue Outdated
@ -22,6 +28,7 @@ const companySizes = [
model="supplier"
auto-load
:clear-store-on-unmount="false"
@on-data-saved="onSave"
jsegarra commented 2024-12-27 09:06:39 +00:00
Member
Copy Link

El nombre de la función debería ser onSaved o para una sola linea integrarla en la propia definición del evento de FormModel

El nombre de la función debería ser onSaved o para una sola linea integrarla en la propia definición del evento de FormModel
jsegarra marked this conversation as resolved
jon added 2 commits 2024-12-27 09:36:13 +00:00
jon added 1 commit 2024-12-27 09:39:08 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
c7f358115f Merge branch 'dev' into 8201-DescriptorIcons
jsegarra approved these changes 2024-12-27 09:48:50 +00:00
jon added 1 commit 2024-12-27 09:55:04 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
fad3e49e2f Merge branch 'dev' into 8201-DescriptorIcons
jon merged commit 93047ab179 into dev 2024-12-27 09:55:46 +00:00
jon deleted branch 8201-DescriptorIcons 2024-12-27 09:55:46 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
jsegarra
Labels
Clear labels   
bug

Something is not working

  
CR / Tests passed

CR / Tests passed

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
invalid

Something is wrong

  
Missing Tests

Missing Tests

  
wontfix

This won't be fixed

No Label
bug
CR / Tests passed
duplicate
enhancement
invalid
Missing Tests
wontfix
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix-front#1080
No description provided.
Delete Branch "8201-DescriptorIcons"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?