feat: refs #7235 update invoice out global form to fetch config based on serial type #1082

Merged
jgallego merged 2 commits from 7235-InvoiceOutBySerial into dev 2024-12-18 08:09:32 +00:00
Owner
No description provided.
jgallego added 1 commit 2024-12-13 10:14:25 +00:00
jgallego requested review from jsegarra 2024-12-13 10:18:39 +00:00
jsegarra reviewed 2024-12-13 22:09:54 +00:00
@ -79,3 +79,4 @@
this.formInitialData.invoiceDate = this.minInvoicingDate;
formData.invoiceDate = this.minInvoicingDate;
} catch (err) {
console.error('Error fetching invoice out global initial data');
Member

@alexm Hace poco hiciste una PR en el que eliminabas todos los try/catch.
Puedes verificar que este caso debe existir o se ha colado?

@alexm Hace poco hiciste una PR en el que eliminabas todos los try/catch. Puedes verificar que este caso debe existir o se ha colado?
Member

Si puede que alguno se haya quedado, si se quita mejor

Si puede que alguno se haya quedado, si se quita mejor
jsegarra reviewed 2024-12-13 22:11:57 +00:00
@ -66,3 +65,2 @@
try {
this.formInitialData.companyFk = companyFk;
const params = { companyFk: companyFk };
const userInfo = await useUserConfig().fetch();
Member

Si de userInfo, solo usas 1 parámetro, casi que podrías hacer const {companyFk}, no afecta dejarlo asi

Si de userInfo, solo usas 1 parámetro, casi que podrías hacer const {companyFk}, no afecta dejarlo asi
jgallego requested review from alexm 2024-12-16 12:20:36 +00:00
jgallego removed review request for jsegarra 2024-12-16 12:20:36 +00:00
alexm approved these changes 2024-12-17 08:18:42 +00:00
jgallego added 1 commit 2024-12-18 08:08:19 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
ac4e0f9b07
Merge branch 'dev' into 7235-InvoiceOutBySerial
jgallego merged commit 1e779ea0be into dev 2024-12-18 08:09:32 +00:00
jgallego deleted branch 7235-InvoiceOutBySerial 2024-12-18 08:09:32 +00:00
Sign in to join this conversation.
No reviewers
No Milestone
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix-front#1082
No description provided.