feat: refs #7957 open in new tab #1086

Merged
jorgep merged 28 commits from 7957-monitorChanges into dev 2025-01-07 14:38:56 +00:00
Member
No description provided.
jorgep added 1 commit 2024-12-13 13:16:47 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
cb0422d83f
feat: refs #7957 open in new tab
jorgep added 1 commit 2024-12-13 15:27:25 +00:00
jorgep added 1 commit 2024-12-13 16:20:33 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
0cce5b93cd
refactor: refs #7957 remove blank
Author
Member

@alexm Igual se podría explorar la opción de llamar directamente a updateStateParams.... ya que realmente se quiere abrir otra ventana, pero habría que sacar a una fn la actualizacion de parametros del la store de la fn fetch lo he probado rapidamente y no iba fino, si le dedico mas tiempo se puede hacer, pero si te parece bien el enfoque actual lo dejo así.

@alexm Igual se podría explorar la opción de llamar directamente a updateStateParams.... ya que realmente se quiere abrir otra ventana, pero habría que sacar a una fn la actualizacion de parametros del la store de la fn fetch lo he probado rapidamente y no iba fino, si le dedico mas tiempo se puede hacer, pero si te parece bien el enfoque actual lo dejo así.
jorgep added the
CR / Tests passed
label 2024-12-13 16:45:22 +00:00
jorgep requested review from alexm 2024-12-13 16:45:25 +00:00
jorgep added 1 commit 2024-12-16 09:16:22 +00:00
jorgep added 1 commit 2024-12-16 09:21:27 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
a6815f4e3d
fix: refs #7957 rollback
jorgep added 1 commit 2024-12-16 09:22:06 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
6e655b37a1
fix: refs #7957 rollback
alexm requested changes 2024-12-16 11:39:08 +00:00
Dismissed
@ -66,3 +67,3 @@
}
async function fetch({ append = false, updateRouter = true }) {
async function fetch({ append = false, updateRouter = true, newTab = false }) {
Member

Y separar el fetch en 2 partes? esq se esta haciendo un monstruo de función

Y separar el fetch en 2 partes? esq se esta haciendo un monstruo de función
Author
Member

Dime que tal lo ves así.

Dime que tal lo ves así.
@ -256,3 +259,3 @@
}
function updateStateParams() {
function updateStateParams(newTab) {
Member

Igual que aquí separaria la parte de generar la funcion de lo demas

Igual que aquí separaria la parte de generar la funcion de lo demas
jorgep added 2 commits 2024-12-16 15:02:49 +00:00
jorgep added 3 commits 2024-12-16 15:11:58 +00:00
jorgep reviewed 2024-12-16 15:12:13 +00:00
@ -148,3 +144,1 @@
!$attrs.readonly &&
$props.clearable
"
:style="{
Author
Member

Así siempre tiene el mismo ancho

Así siempre tiene el mismo ancho
jorgep reviewed 2024-12-16 15:14:33 +00:00
@ -133,3 +158,3 @@
data-cy="vnSearchBar"
borderless
>
<template #prepend>
Author
Member

No reconcee ctrl + click o shift + click en un link. No sé porque, con un QInput nativo tampoco funciona.

No reconcee ctrl + click o shift + click en un link. No sé porque, con un QInput nativo tampoco funciona.
jorgep added 1 commit 2024-12-16 16:02:50 +00:00
jorgep requested review from alexm 2024-12-16 16:19:35 +00:00
jorgep reviewed 2024-12-16 16:21:56 +00:00
@ -175,0 +209,4 @@
align-items: center;
border-radius: 4px;
padding: 0 5px;
background-color: var(--vn-search-color);
Author
Member

Antes cogia los colores de la clase &--standout, si no, no tiene color.

Antes cogia los colores de la clase &--standout, si no, no tiene color.
jorgep requested review from jgallego 2024-12-16 16:22:05 +00:00
jorgep reviewed 2024-12-16 16:25:06 +00:00
@ -85,1 +87,4 @@
let store = arrayData.store;
const to = computed(() => {
const { params } = arrayData.getCurrentFilter();
params.search = searchText.value || undefined;
Author
Member

Por defecto vn-input pone null y esto es un parámetro valido de búsqueda, Para que no se añada hay declararlo como undefined.

Por defecto vn-input pone null y esto es un parámetro valido de búsqueda, Para que no se añada hay declararlo como undefined.
jorgep added 1 commit 2024-12-16 16:25:59 +00:00
jorgep added 1 commit 2024-12-16 16:26:09 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
6db44f158e
fix: refs #7957 rollback
jorgep added 1 commit 2024-12-16 16:42:32 +00:00
jgallego approved these changes 2024-12-17 05:54:33 +00:00
Dismissed
alexm requested changes 2024-12-17 08:22:28 +00:00
Dismissed
@ -84,2 +86,4 @@
let arrayData = useArrayData(props.dataKey, arrayDataProps);
let store = arrayData.store;
const to = computed(() => {
const { params } = arrayData.getCurrentFilter();
Member

Has mirado si store.currentFilter te valia? Ahi en teoria estan los params sin tratar

Has mirado si store.currentFilter te valia? Ahi en teoria estan los params sin tratar
jorgep marked this conversation as resolved
jorgep added 1 commit 2024-12-17 09:16:36 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
b1ad357bda
feat: refs #7957 simplify fn to
jorgep dismissed jgallego’s review 2024-12-17 09:16:36 +00:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

jorgep reviewed 2024-12-17 09:20:21 +00:00
@ -91,3 +73,1 @@
if (store?.order && typeof store?.order == 'string') store.order = [store.order];
if (store.order?.length) params.filter.order = [...store.order];
else delete params.filter.order;
const { params, limit } = getCurrentFilter();
Author
Member

Visto que yo no lo utilizo en el searchbar lo quito, o lo dejo igualmente?

Visto que yo no lo utilizo en el searchbar lo quito, o lo dejo igualmente?
jorgep added 1 commit 2024-12-17 09:44:08 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
efeb32fb28
fix: refs #7957 vn-searchbar test
jorgep requested review from alexm 2024-12-17 09:44:15 +00:00
jorgep added 1 commit 2024-12-17 09:44:37 +00:00
alexm approved these changes 2024-12-19 12:09:22 +00:00
Dismissed
jorgep added 1 commit 2024-12-19 12:16:06 +00:00
jorgep dismissed alexm’s review 2024-12-19 12:16:06 +00:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

jorgep requested review from alexm 2024-12-19 12:16:28 +00:00
jorgep added 1 commit 2024-12-19 12:42:53 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
de87acd5cc
fix: refs #7957 add missing closing brace
jorgep added 1 commit 2025-01-07 11:16:44 +00:00
jorgep added 1 commit 2025-01-07 11:22:25 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
7b9731a4c8
fix: refs #7957 css
jorgep added 2 commits 2025-01-07 11:26:10 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
73c133c62b
fix: refs #7957 css
jorgep added 1 commit 2025-01-07 12:21:26 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
f04aeec21d
fix: refs #7957 update data-cy
Member

Sale como descentrado no?
image

Sale como descentrado no? ![image](/attachments/c3d8989e-c4b5-4e46-984e-61d2dcab7987)
1.3 KiB
alexm requested changes 2025-01-07 12:47:18 +00:00
Dismissed
alexm left a comment
Member

Ver foto, si ya estaba asi nada. pero me da la sensacion q en dev no sale descentrado

Ver foto, si ya estaba asi nada. pero me da la sensacion q en dev no sale descentrado
jorgep added 1 commit 2025-01-07 13:11:49 +00:00
jorgep added 1 commit 2025-01-07 13:31:44 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
8f418dcb4b
style: refs #7957 update VnSearchbar padding for improved layout
Author
Member

Sale como descentrado no?
image

Antes era un slot nativo, se alineaba solo. Solucionado con css, de hecho mejor.

image

> Sale como descentrado no? > ![image](/attachments/c3d8989e-c4b5-4e46-984e-61d2dcab7987) Antes era un slot nativo, se alineaba solo. Solucionado con css, de hecho mejor. ![image](/attachments/4773574f-1073-4252-87d5-e94918a7d811)
jorgep requested review from alexm 2025-01-07 13:33:38 +00:00
alexm approved these changes 2025-01-07 13:37:26 +00:00
Member

Sale como descentrado no?
image

Antes era un slot nativo, se alineaba solo. Solucionado con css, de hecho mejor.

image

💯

> > Sale como descentrado no? > > ![image](/attachments/c3d8989e-c4b5-4e46-984e-61d2dcab7987) > > Antes era un slot nativo, se alineaba solo. Solucionado con css, de hecho mejor. > > ![image](/attachments/4773574f-1073-4252-87d5-e94918a7d811) 💯
jorgep added 1 commit 2025-01-07 14:35:55 +00:00
jorgep merged commit c0d909b3e8 into dev 2025-01-07 14:38:56 +00:00
jorgep deleted branch 7957-monitorChanges 2025-01-07 14:38:56 +00:00
Sign in to join this conversation.
No reviewers
No Milestone
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix-front#1086
No description provided.