verdnatura/salix-front
verdnatura
/
salix-front
2
2
Fork 1
Code Issues Pull Requests 84 Releases Wiki Activity

feat: refs #8293 addZoneToClaimList #1088

Merged
jtubau merged 6 commits from 8293-addZoneToClaimList into dev 2024-12-23 14:15:53 +00:00
Conversation 2 Commits 6 Files Changed 2 +26 -19
jtubau commented 2024-12-16 07:47:25 +00:00
Member
Copy Link
No description provided.
jtubau added 2 commits 2024-12-16 07:47:26 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
dadf3206e0 feat: refs #8293 add zone filter
jtubau requested review from jsegarra 2024-12-16 07:47:48 +00:00
jtubau requested review from alexm 2024-12-16 14:48:03 +00:00
jtubau commented 2024-12-16 14:48:19 +00:00
Author
Member
Copy Link

@jgallego eliminar a Segarra de revisión

@jgallego eliminar a Segarra de revisión
jgallego removed review request for jsegarra 2024-12-17 05:54:43 +00:00
alexm reviewed 2024-12-17 08:23:09 +00:00
src/pages/Claim/ClaimFilter.vue Outdated
@ -132,0 +134,4 @@
v-model="params.zoneFk"
@update:model-value="searchFn()"
url="Zones"
option-value="id"
alexm commented 2024-12-17 08:23:09 +00:00
Member
Copy Link

id y name son los valores por defecto, no hace falta ponerlos

dd33dfc766/src/components/common/VnSelect.vue (L30)

id y name son los valores por defecto, no hace falta ponerlos https://gitea.verdnatura.es/verdnatura/salix-front/src/commit/dd33dfc76615f773178c62616d38e813e39eef1c/src/components/common/VnSelect.vue#L30
alexm reviewed 2024-12-17 08:24:21 +00:00
src/pages/Claim/ClaimFilter.vue Outdated
@ -132,0 +140,4 @@
outlined
rounded
dense
></VnSelect>
alexm commented 2024-12-17 08:24:21 +00:00
Member
Copy Link

En vue (en html tambien) si usas un componente y no quieres añadir nada dentro puedes usar />
De tal modo que quedaria

<VnSelect
...
/>

En vez de

<VnSelect
...
>
</VnSelect>
En vue (en html tambien) si usas un componente y no quieres añadir nada dentro puedes usar `/>` De tal modo que quedaria ``` <VnSelect ... /> ``` En vez de ``` <VnSelect ... > </VnSelect> ```
alexm requested changes 2024-12-17 08:27:39 +00:00
Dismissed
src/pages/Claim/ClaimFilter.vue Outdated
@ -132,0 +132,4 @@
<VnSelect
:label="t('claim.zone')"
v-model="params.zoneFk"
@update:model-value="searchFn()"
alexm commented 2024-12-17 08:27:36 +00:00
Member
Copy Link

En VnSelect ya no hace falta usar @update:model-value="searchFn()", se usaba cuando usabamos QSelect nativo supongo que se quedarian de cuando se hizo un remplazar de todos.

Prueba a quitar todos los @update:model-value="searchFn()" de este archivo y comprobar si siguen filtrando igual de bien.

En VnSelect ya no hace falta usar `@update:model-value="searchFn()"`, se usaba cuando usabamos `QSelect` nativo supongo que se quedarian de cuando se hizo un remplazar de todos. Prueba a quitar todos los ` @update:model-value="searchFn()"` de este archivo y comprobar si siguen filtrando igual de bien.
jtubau added 1 commit 2024-12-18 06:43:05 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
152bb7009a Merge branch 'dev' into 8293-addZoneToClaimList
jtubau added 1 commit 2024-12-18 07:00:01 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
4b35d4b41e refactor: refs #8293 remove redundant attributes
jtubau requested review from alexm 2024-12-18 07:00:41 +00:00
jtubau commented 2024-12-23 07:01:13 +00:00
Author
Member
Copy Link

@jgallego eliminar a Alex de revisión

@jgallego eliminar a Alex de revisión
jtubau requested review from jsegarra 2024-12-23 07:05:30 +00:00
jsegarra approved these changes 2024-12-23 08:41:26 +00:00
Dismissed
jtubau added 1 commit 2024-12-23 08:45:58 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
28e37a9389 Merge branch 'dev' into 8293-addZoneToClaimList
jtubau dismissed jsegarra’s review 2024-12-23 08:45:58 +00:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

jsegarra requested review from jsegarra 2024-12-23 09:05:33 +00:00
jgallego removed review request for alexm 2024-12-23 10:24:17 +00:00
jgallego dismissed alexm’s review 2024-12-23 10:24:19 +00:00
jsegarra approved these changes 2024-12-23 10:39:21 +00:00
jsegarra added 1 commit 2024-12-23 10:39:27 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
b0291b7b41 Merge branch 'dev' into 8293-addZoneToClaimList
jtubau merged commit cbdfe2b2ec into dev 2024-12-23 14:15:53 +00:00
jtubau deleted branch 8293-addZoneToClaimList 2024-12-23 14:15:53 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
jsegarra
Labels
Clear labels   
bug

Something is not working

  
CR / Tests passed

CR / Tests passed

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
invalid

Something is wrong

  
Missing Tests

Missing Tests

  
wontfix

This won't be fixed

No Label
bug
CR / Tests passed
duplicate
enhancement
invalid
Missing Tests
wontfix
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
4 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix-front#1088
No description provided.
Delete Branch "8293-addZoneToClaimList"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?