test: refs #7052 add unit tests for EditTableCellValueForm component #1104

Merged
jgallego merged 6 commits from 7052-testEditTableCellValueForm into dev 2024-12-30 13:37:11 +00:00
Owner
No description provided.
jgallego added 1 commit 2024-12-18 08:06:49 +00:00
gitea/salix-front/pipeline/pr-dev There was a failure building this commit Details
1193eaa073
test: refs #7052 add unit tests for EditTableCellValueForm component
jgallego requested review from alexm 2024-12-18 08:06:59 +00:00
jgallego requested review from jsegarra 2024-12-23 16:25:29 +00:00
jgallego removed review request for alexm 2024-12-23 16:25:31 +00:00
jsegarra requested changes 2024-12-24 10:37:36 +00:00
Dismissed
@ -0,0 +42,4 @@
const payload = axios.post.mock.calls[0][1];
expect(axios.post).toHaveBeenCalledWith(editUrl, expect.any(Object));
expect(payload.field).toEqual('fieldA');
Member

ya que has declarado el valor en selectedField.field, úsalo para que el valor literal solamente esté 1 vez

ya que has declarado el valor en selectedField.field, úsalo para que el valor literal solamente esté 1 vez
jsegarra marked this conversation as resolved
@ -0,0 +43,4 @@
expect(axios.post).toHaveBeenCalledWith(editUrl, expect.any(Object));
expect(payload.field).toEqual('fieldA');
expect(payload.newValue).toEqual('Test Value');
Member

Es lo mismo que poner newValue, no?

Es lo mismo que poner newValue, no?
jsegarra marked this conversation as resolved
@ -0,0 +46,4 @@
expect(payload.newValue).toEqual('Test Value');
expect(payload.lines).toContainEqual(
expect.objectContaining({ id: 1, itemFk: 101 })
Member

mockRows?

mockRows?
jsegarra marked this conversation as resolved
jgallego added 2 commits 2024-12-29 09:06:04 +00:00
jgallego added 1 commit 2024-12-29 09:06:43 +00:00
gitea/salix-front/pipeline/pr-dev There was a failure building this commit Details
1e0d444e85
refactor: refs #7052 remove unnecessary console logs from EditTableCellValueForm tests
jgallego requested review from jsegarra 2024-12-29 09:07:03 +00:00
jgallego added 1 commit 2024-12-30 07:55:14 +00:00
jsegarra approved these changes 2024-12-30 08:18:50 +00:00
jgallego added 1 commit 2024-12-30 13:35:35 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
d16e2e81e4
Merge branch 'dev' into 7052-testEditTableCellValueForm
jgallego merged commit cea24f4720 into dev 2024-12-30 13:37:11 +00:00
jgallego deleted branch 7052-testEditTableCellValueForm 2024-12-30 13:37:11 +00:00
Sign in to join this conversation.
No reviewers
No Milestone
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix-front#1104
No description provided.