refs #6062 feat(arrayData): support exprBuilder #112

Merged
alexm merged 2 commits from 6062-exprBuilder into dev 2023-11-27 12:23:33 +00:00
Member
No description provided.
alexm added 1 commit 2023-11-24 12:31:21 +00:00
gitea/salix-front/pipeline/head This commit looks good Details
023cfc6ac7
refs #6062 feat(arrayData): support exprBuilder
alexm reviewed 2023-11-24 12:31:36 +00:00
@ -25,27 +25,17 @@ const pinnedModulesRef = ref();
Author
Member

Esto es pq me daba toc, estaba mal alineado

Esto es pq me daba toc, estaba mal alineado
alexm added 1 commit 2023-11-24 12:32:19 +00:00
gitea/salix-front/pipeline/head This commit looks good Details
54379b3e65
typo
alexm requested review from jsegarra 2023-11-24 12:33:01 +00:00
jsegarra requested changes 2023-11-24 13:04:07 +00:00
@ -79,3 +75,3 @@
const params = [];
for (const param in store.userParams) {
for (const param in userParams.value) {
Member

Se puede reemplazar el for por esto

Object.entries(userParams.value).filter(([k,v]) => v).reduce((acc,[label, value])=>( {...acc, [label]: value} ),{})

Se puede reemplazar el for por esto ` Object.entries(userParams.value).filter(([k,v]) => v).reduce((acc,[label, value])=>( {...acc, [label]: value} ),{}) `
Author
Member

poco legible no?

poco legible no?
@ -68,6 +72,7 @@ const arrayData = useArrayData(props.dataKey, {
limit: props.limit,
order: props.order,
userParams: props.userParams,
exprBuilder: props.exprBuilder,
Member

si coinciden todas las claves con el valor de props, quizas se puede hacer

const arrayData = useArrayData(props.dataKey, {...props} });

si coinciden todas las claves con el valor de props, quizas se puede hacer `const arrayData = useArrayData(props.dataKey, {...props} });`
Author
Member

De hecho no es un allowProperties

De hecho no es un allowProperties
alexm marked this conversation as resolved
@ -132,0 +151,4 @@
function sanitizerParams(params) {
for (const param in params) {
if (params[param] === '' || params[param] === null) {
Member

Duda, esto es para eliminar los parámetros de búsqueda que tengan valor vacío o null

Duda, esto es para eliminar los parámetros de búsqueda que tengan valor vacío o null
Author
Member

exacto

exacto
jsegarra marked this conversation as resolved
@ -0,0 +4,4 @@
* @param {Object} fields The fields object or array
* @return {Object} The fields as object
*/
function fieldsToObject(fields) {
Member

Lo miramos, porque este método se puede simplificar

Lo miramos, porque este método se puede simplificar
Author
Member

Este archivo es copy paste del de salix (lo hizo Juan)

Este archivo es copy paste del de salix (lo hizo Juan)
Member

Ah vale, me salía en verde.
Entonces, no lo tocamos?

Ah vale, me salía en verde. Entonces, no lo tocamos?
Author
Member

Yo no lo tocaria

Yo no lo tocaria
alexm marked this conversation as resolved
jsegarra added spent time 2023-11-24 13:04:55 +00:00
15 minutes
alexm requested review from juan 2023-11-27 06:37:38 +00:00
alexm requested review from jsegarra 2023-11-27 06:37:41 +00:00
juan approved these changes 2023-11-27 11:47:37 +00:00
jsegarra approved these changes 2023-11-27 11:54:45 +00:00
alexm merged commit cad5d830a0 into dev 2023-11-27 12:23:33 +00:00
alexm deleted branch 6062-exprBuilder 2023-11-27 12:23:33 +00:00
Sign in to join this conversation.
No reviewers
No Milestone
No Assignees
3 Participants
Notifications
Total Time Spent: 15 minutes
jsegarra
15 minutes
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix-front#112
No description provided.