fix: refs #7699 add icons and hint #1123

Merged
alexm merged 18 commits from 7699-refactroViewPassword into dev 2025-01-08 13:20:17 +00:00
Member
No description provided.
carlossa added 1 commit 2024-12-20 12:03:46 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
5049b05547
fix: refs #7699 add icons and hint
carlossa added 2 commits 2024-12-24 08:52:40 +00:00
carlossa requested review from jsegarra 2024-12-24 10:32:42 +00:00
carlossa changed title from WIP: fix: refs #7699 add icons and hint to fix: refs #7699 add icons and hint 2024-12-24 10:32:50 +00:00
jsegarra requested changes 2024-12-24 10:34:39 +00:00
Dismissed
jsegarra left a comment
Member

Uff 3 campos iguales que solo cambian el label? y el model?

Veo que haria falta un VnInputPassword

Uff 3 campos iguales que solo cambian el label? y el model? Veo que haria falta un VnInputPassword
carlossa added 1 commit 2024-12-26 06:29:11 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
f0364124cc
fix: refs #7699 add pwd vnInput
carlossa added 1 commit 2024-12-26 06:34:39 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
0d9ba62d37
fix: refs #7699 fix vnChangePassword, clean VnInput
carlossa requested review from jsegarra 2024-12-26 06:44:40 +00:00
carlossa added 1 commit 2024-12-26 06:44:46 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
f1d6ecd5ff
Merge branch 'dev' into 7699-refactroViewPassword
jsegarra requested changes 2024-12-26 08:59:06 +00:00
Dismissed
@ -42,9 +42,14 @@ const $props = defineProps({
type: Number,
default: null,
},
toggleVisibility: {
Member

Se podria hacer con $attrs en vez de añadir prop, no?

Se podria hacer con $attrs en vez de añadir prop, no?
carlossa marked this conversation as resolved
@ -125,3 +130,3 @@
v-model="value"
v-bind="{ ...$attrs, ...styleAttrs }"
:type="$attrs.type"
:type="toggleVisibility ? (showPassword ? 'text' : 'password') : $attrs.type"
Member

Estamos añadiendo una condición a VnInput y debería estar en un componente aparte

Estamos añadiendo una condición a VnInput y debería estar en un componente aparte
carlossa marked this conversation as resolved
@ -138,3 +143,4 @@
<slot name="prepend" />
</template>
<template #append>
<QIcon
Member

Añdimos un icono condicional a VnInput.

Propuesta, crear VnInputPassword

Añdimos un icono condicional a VnInput. Propuesta, crear VnInputPassword
carlossa marked this conversation as resolved
carlossa added 2 commits 2025-01-02 12:23:12 +00:00
carlossa added 1 commit 2025-01-03 07:18:44 +00:00
gitea/salix-front/pipeline/pr-dev There was a failure building this commit Details
60f3ea838a
fix: refs #7699 fix component
carlossa added 1 commit 2025-01-03 07:26:21 +00:00
gitea/salix-front/pipeline/pr-dev There was a failure building this commit Details
3cf4c5ed80
Merge branch 'dev' into 7699-refactroViewPassword
carlossa added 2 commits 2025-01-03 07:46:34 +00:00
carlossa added 1 commit 2025-01-03 08:35:20 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
a89fad0ae2
fix: refs #7699 fix tfront clean code
carlossa added 1 commit 2025-01-03 08:37:07 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
ae42142524
Merge branch 'dev' into 7699-refactroViewPassword
carlossa requested review from alexm 2025-01-03 09:02:32 +00:00
jsegarra requested changes 2025-01-04 09:59:04 +00:00
Dismissed
@ -166,18 +167,3 @@ const handleInsertMode = (e) => {
</QInput>
</div>
</template>
<i18n>
Member

ojo, que creo que nos hemos llevado cosas por delante, me refiero que hemos quitado código de dev, es intencional?

ojo, que creo que nos hemos llevado cosas por delante, me refiero que hemos quitado código de dev, es intencional?
carlossa marked this conversation as resolved
@ -135,3 +136,3 @@
:data-cy="$attrs.dataCy ?? $attrs.label + '_input'"
>
<template v-if="$slots.prepend" #prepend>
<template #prepend>
Member

ojo, que creo que nos hemos llevado cosas por delante, me refiero que hemos quitado código de dev, es intencional?

ojo, que creo que nos hemos llevado cosas por delante, me refiero que hemos quitado código de dev, es intencional?
Author
Member

jsegarra marked this conversation as resolved
@ -156,3 +157,3 @@
}
"
></QIcon>
/>
Member

carlossa marked this conversation as resolved
@ -0,0 +7,4 @@
type: [String, Number],
default: null,
},
toggleVisibility: {
Member

Si eliminamos la prop.modelValue, esto podría ser un attr, no?
Quedaría mas limpio, no?

Si eliminamos la prop.modelValue, esto podría ser un attr, no? Quedaría mas limpio, no?
carlossa marked this conversation as resolved
@ -0,0 +14,4 @@
});
const showPassword = ref(false);
const model = defineModel({ type: [Number, String] });
Member

Si ya tenemos defineModel porque nos hace falta la props de modelValue?

Si ya tenemos defineModel porque nos hace falta la props de modelValue?
Member

Bueno, seria al reves 😅

Bueno, seria al reves 😅
carlossa marked this conversation as resolved
@ -0,0 +23,4 @@
:type="
$props.toggleVisibility ? (showPassword ? 'text' : 'password') : $attrs.type
"
hint=""
Member

Si lo quitamos, afectaría algo?

Si lo quitamos, afectaría algo?
@ -82,7 +81,7 @@ async function onSubmit() {
<template #prepend>
Member

Es correcto que esté este icono?

Es correcto que esté este icono?
Author
Member

jsegarra marked this conversation as resolved
@ -19,6 +19,7 @@ describe('Login', () => {
it('should fail to log in using wrong password', () => {
cy.get('input[aria-label="Username"]').type('employee');
cy.get('input[aria-label="Password"]').type('wrongPassword');
cy.get('.q-field__append > .q-icon');
Member

Esta linea es para que el test no falle o que aporta? Quiero decir, sobre el elemento no se hace ninguna accion no?

Esta linea es para que el test no falle o que aporta? Quiero decir, sobre el elemento no se hace ninguna accion no?
Author
Member

Comprobar que esta por lo tanto lo pulsa

Comprobar que esta por lo tanto lo pulsa
jsegarra marked this conversation as resolved
carlossa added 2 commits 2025-01-07 10:18:26 +00:00
alexm approved these changes 2025-01-07 12:04:48 +00:00
Dismissed
jsegarra approved these changes 2025-01-07 14:56:06 +00:00
Dismissed
carlossa added 1 commit 2025-01-08 08:27:56 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
96f8cab38c
Merge branch 'dev' into 7699-refactroViewPassword
carlossa dismissed alexm’s review 2025-01-08 08:27:56 +00:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

carlossa dismissed jsegarra’s review 2025-01-08 08:27:56 +00:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

carlossa requested review from alexm 2025-01-08 08:28:11 +00:00
carlossa added 1 commit 2025-01-08 13:04:02 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
ad8f58e3e1
Merge branch 'dev' into 7699-refactroViewPassword
alexm approved these changes 2025-01-08 13:20:07 +00:00
alexm merged commit 5b415a8398 into dev 2025-01-08 13:20:17 +00:00
alexm deleted branch 7699-refactroViewPassword 2025-01-08 13:20:17 +00:00
Sign in to join this conversation.
No reviewers
No Milestone
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix-front#1123
No description provided.