feat: #7079 created VnLocation front test #1126

Merged
provira merged 6 commits from 7079-testVnLocation into dev 2024-12-24 13:08:11 +00:00
Member
No description provided.
provira added 1 commit 2024-12-23 11:14:30 +00:00
provira added 1 commit 2024-12-23 11:14:34 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
a3236b7dee
Merge branch 'dev' into 7079-testVnLocation
provira requested review from jsegarra 2024-12-23 11:14:40 +00:00
jsegarra requested changes 2024-12-23 12:51:58 +00:00
Dismissed
@ -0,0 +5,4 @@
function buildComponent(data) {
return createWrapper(VnLocation, {
global: {
stubs: [''],
Member

Que hace esta linea?
Si la eliminas que ocurre?

Que hace esta linea? Si la eliminas que ocurre?
jsegarra marked this conversation as resolved
jsegarra requested changes 2024-12-23 12:54:33 +00:00
Dismissed
jsegarra left a comment
Member

Si al montar

Si al montar
@ -0,0 +53,4 @@
it('should return the country', () => {
const location = { ...locationBase, postcode: undefined, city: undefined, province: undefined };
const vm = buildComponent(location);
const parts = vm.formatLocation(location);
Member

porque lo has llamado parts?

porque lo has llamado parts?
Member

Es significativo?

Es significativo?
Author
Member

No, el nombre se podria cambiar y no pasaria nada. De hecho seria mas correcto llamarlo algo como "resultado"

No, el nombre se podria cambiar y no pasaria nada. De hecho seria mas correcto llamarlo algo como "resultado"
Member

Otra opción, si solo vas a usar en 1 sitio el resultado de vm.formatLocation, es que lo pongas como argumento en el expect. Porque, porque vas a crear una variable de 1 uso??
Si tienes dudas, me comentas

Otra opción, si solo vas a usar en 1 sitio el resultado de vm.formatLocation, es que lo pongas como argumento en el expect. Porque, porque vas a crear una variable de 1 uso?? Si tienes dudas, me comentas
provira added 1 commit 2024-12-24 10:59:39 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
4f60544a1e
Merge branch 'dev' into 7079-testVnLocation
provira added 1 commit 2024-12-24 11:15:30 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
7d1f25563d
Merge branch 'dev' into 7079-testVnLocation
provira added 1 commit 2024-12-24 11:18:39 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
89acb338a9
refactor: refs #7079 removed useless code
provira requested review from jsegarra 2024-12-24 11:19:25 +00:00
jsegarra approved these changes 2024-12-24 12:24:16 +00:00
provira added 1 commit 2024-12-24 13:07:07 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
37f16cb762
Merge branch 'dev' into 7079-testVnLocation
provira merged commit bd5daa8368 into dev 2024-12-24 13:08:11 +00:00
provira deleted branch 7079-testVnLocation 2024-12-24 13:08:11 +00:00
Sign in to join this conversation.
No reviewers
No Milestone
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix-front#1126
No description provided.