verdnatura/salix-front
verdnatura
/
salix-front
2
2
Fork 1
Code Issues Pull Requests 94 Releases Wiki Activity

WIP: feat: update_vitest_version to 2.0.0 #1127

Draft
jsegarra wants to merge 3 commits from update_vitest_version into dev
pull from: update_vitest_version
merge into: verdnatura:dev
Conversation 2 Commits 3 Files Changed 25 +235 -577
jsegarra commented 2024-12-23 11:25:33 +00:00
Member
Copy Link

A raíz de la PR #1043 me lancé a actualizar vitest.
Hasta la 1.0.0 no hay que hacer modificaciones, pero cuando pasas a la +1.3.0 ya la cosa se complica.

He hecho los cambios hast que ahora mismo solamente fallan 2 test.

No quiero invertirtle mas tiempo del que ya le he dado para estos tests, una vez valorada la propuesta si hace falta seguimos.

Adjunto una captura con los errores
image

A raíz de la PR https://gitea.verdnatura.es/verdnatura/salix-front/pulls/1043 me lancé a actualizar vitest. Hasta la 1.0.0 no hay que hacer modificaciones, pero cuando pasas a la +1.3.0 ya la cosa se complica. He hecho los cambios hast que ahora mismo solamente fallan 2 test. No quiero invertirtle mas tiempo del que ya le he dado para estos tests, una vez valorada la propuesta si hace falta seguimos. Adjunto una captura con los errores ![image](/attachments/86c81b34-1279-4a8e-aef2-8d457324e2b8)
image.png
62 KiB
jsegarra added 1 commit 2024-12-23 11:25:33 +00:00
gitea/salix-front/pipeline/pr-dev There was a failure building this commit Details
099c613ccc feat: update_vitest_version to 2.0.0
jsegarra changed title from feat: update_vitest_version to 2.0.0 to WIP: feat: update_vitest_version to 2.0.0 2024-12-23 11:25:38 +00:00
jsegarra requested review from jgallego 2024-12-23 11:25:48 +00:00
jsegarra requested review from alexm 2024-12-23 11:25:48 +00:00
jsegarra added 1 commit 2024-12-23 11:26:58 +00:00
gitea/salix-front/pipeline/pr-dev There was a failure building this commit Details
5b0479e60c Merge branch 'dev' into update_vitest_version
jsegarra added 1 commit 2024-12-23 11:47:15 +00:00
gitea/salix-front/pipeline/pr-dev There was a failure building this commit Details
gitea/salix-front/pipeline/head There was a failure building this commit Details
fcb2e3cc74 feat: organize imports
jsegarra commented 2024-12-23 11:49:44 +00:00
Author
Member
Copy Link

image

![image](/attachments/f0cb8f83-3893-497b-8daa-93858068aa3e)
image.png
62 KiB
jgallego approved these changes 2024-12-23 13:29:06 +00:00
jgallego left a comment
Owner
Copy Link

Recuerda excluir los test que fallan i crear un redmine para arreglarlos o si cuesta menos de una hora arreglalos directamente.

Recuerda excluir los test que fallan i crear un redmine para arreglarlos o si cuesta menos de una hora arreglalos directamente.
alexm commented 2024-12-23 17:30:23 +00:00
Member
Copy Link

Com son test de arrayData que es algo critic intentaria que estigueren operatius a antes de fusionarho

Com son test de arrayData que es algo critic intentaria que estigueren operatius a antes de fusionarho
Some checks failed
gitea/salix-front/pipeline/pr-dev There was a failure building this commit
Required
Details
gitea/salix-front/pipeline/head There was a failure building this commit
Details
This pull request has changes conflicting with the target branch.
  • package.json
  • pnpm-lock.yaml
  • test/vitest/helper.js
Sign in to join this conversation.
Reviewers
No reviewers
alexm
jgallego
Labels
Clear labels   
bug

Something is not working

  
CR / Tests passed

CR / Tests passed

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
invalid

Something is wrong

  
Missing Tests

Missing Tests

  
wontfix

This won't be fixed

No Label
bug
CR / Tests passed
duplicate
enhancement
invalid
Missing Tests
wontfix
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix-front#1127
No description provided.
Delete Branch "update_vitest_version"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?