verdnatura/salix-front
verdnatura
/
salix-front
2
3
Fork 1
Code Issues Pull Requests 82 Releases Wiki Activity

#8446 - update_vitest_version to 2.0.0 #1127

Merged
jsegarra merged 18 commits from update_vitest_version into dev 2025-04-08 08:09:36 +00:00
Conversation 2 Commits 18 Files Changed 40 +1378 -2423
jsegarra commented 2024-12-23 11:25:33 +00:00
Member
Copy Link

A raíz de la PR #1043 me lancé a actualizar vitest.
Hasta la 1.0.0 no hay que hacer modificaciones, pero cuando pasas a la +1.3.0 ya la cosa se complica.

He hecho los cambios hast que ahora mismo solamente fallan 2 test.

No quiero invertirtle mas tiempo del que ya le he dado para estos tests, una vez valorada la propuesta si hace falta seguimos.

Adjunto una captura con los errores
image

A raíz de la PR https://gitea.verdnatura.es/verdnatura/salix-front/pulls/1043 me lancé a actualizar vitest. Hasta la 1.0.0 no hay que hacer modificaciones, pero cuando pasas a la +1.3.0 ya la cosa se complica. He hecho los cambios hast que ahora mismo solamente fallan 2 test. No quiero invertirtle mas tiempo del que ya le he dado para estos tests, una vez valorada la propuesta si hace falta seguimos. Adjunto una captura con los errores ![image](/attachments/86c81b34-1279-4a8e-aef2-8d457324e2b8)
image.png
62 KiB
jsegarra added 1 commit 2024-12-23 11:25:33 +00:00
gitea/salix-front/pipeline/pr-dev There was a failure building this commit Details
099c613ccc feat: update_vitest_version to 2.0.0
jsegarra changed title from feat: update_vitest_version to 2.0.0 to WIP: feat: update_vitest_version to 2.0.0 2024-12-23 11:25:38 +00:00
jsegarra requested review from jgallego 2024-12-23 11:25:48 +00:00
jsegarra requested review from alexm 2024-12-23 11:25:48 +00:00
jsegarra added 1 commit 2024-12-23 11:26:58 +00:00
gitea/salix-front/pipeline/pr-dev There was a failure building this commit Details
5b0479e60c Merge branch 'dev' into update_vitest_version
jsegarra added 1 commit 2024-12-23 11:47:15 +00:00
gitea/salix-front/pipeline/pr-dev There was a failure building this commit Details
gitea/salix-front/pipeline/head There was a failure building this commit Details
fcb2e3cc74 feat: organize imports
jsegarra commented 2024-12-23 11:49:44 +00:00
Author
Member
Copy Link

image

![image](/attachments/f0cb8f83-3893-497b-8daa-93858068aa3e)
image.png
62 KiB
jgallego approved these changes 2024-12-23 13:29:06 +00:00
Dismissed
jgallego left a comment
Owner
Copy Link

Recuerda excluir los test que fallan i crear un redmine para arreglarlos o si cuesta menos de una hora arreglalos directamente.

Recuerda excluir los test que fallan i crear un redmine para arreglarlos o si cuesta menos de una hora arreglalos directamente.
alexm commented 2024-12-23 17:30:23 +00:00
Member
Copy Link

Com son test de arrayData que es algo critic intentaria que estigueren operatius a antes de fusionarho

Com son test de arrayData que es algo critic intentaria que estigueren operatius a antes de fusionarho
jsegarra added 1 commit 2025-01-23 06:10:14 +00:00
gitea/salix-front/pipeline/pr-dev There was a failure building this commit Details
ff63a8fd11 Merge branch 'dev' into update_vitest_version
jsegarra dismissed jgallego’s review 2025-01-23 06:10:14 +00:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

jsegarra added 3 commits 2025-03-01 01:40:07 +00:00
gitea/salix-front/pipeline/pr-dev There was a failure building this commit Details
644339bd13 test: vnNotes restore
jsegarra added 5 commits 2025-04-02 23:36:36 +00:00
gitea/salix-front/pipeline/pr-dev This commit is unstable Details
c08b3648f2 test: arrayData
jsegarra changed title from WIP: feat: update_vitest_version to 2.0.0 to feat: update_vitest_version to 2.0.0 2025-04-02 23:37:34 +00:00
jsegarra changed title from feat: update_vitest_version to 2.0.0 to #8446 - update_vitest_version to 2.0.0 2025-04-02 23:38:26 +00:00
jsegarra added 1 commit 2025-04-03 09:55:30 +00:00
gitea/salix-front/pipeline/pr-dev This commit is unstable Details
cb1e1aa594 Merge branch 'dev' into update_vitest_version
alexm approved these changes 2025-04-07 09:44:18 +00:00
Dismissed
alexm added 1 commit 2025-04-07 09:44:28 +00:00
gitea/salix-front/pipeline/pr-dev This commit is unstable Details
e474e21309 Merge branch 'dev' into update_vitest_version
jsegarra scheduled this pull request to auto merge when all checks succeed 2025-04-07 09:54:17 +00:00
jsegarra added 2 commits 2025-04-07 13:35:23 +00:00
jsegarra dismissed alexm’s review 2025-04-07 13:35:24 +00:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

jsegarra added 1 commit 2025-04-07 15:43:16 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
2cb151e181 fix: update pnpm-lock.yaml
jsegarra added 1 commit 2025-04-08 07:48:20 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
d91d5351c3 Merge branch 'dev' into update_vitest_version
alexm approved these changes 2025-04-08 07:49:32 +00:00
jsegarra merged commit 3c6bed6d7e into dev 2025-04-08 08:09:36 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
alexm
Labels
Clear labels   
bug

Something is not working

  
CR / Tests passed

CR / Tests passed

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
invalid

Something is wrong

  
Missing Tests

Missing Tests

  
wontfix

This won't be fixed

No Label
bug
CR / Tests passed
duplicate
enhancement
invalid
Missing Tests
wontfix
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix-front#1127
No description provided.
Delete Branch "update_vitest_version"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?