feat: #7088 created test for FetchedTags #1162

Merged
provira merged 9 commits from 7088-testFetchedTags into dev 2025-01-09 06:04:16 +00:00
Member
No description provided.
provira added 1 commit 2025-01-02 11:04:53 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
85bf4053bb
feat: refs #7088 created test for FetchedTags
provira requested review from jsegarra 2025-01-02 11:05:18 +00:00
jsegarra requested changes 2025-01-03 15:44:03 +00:00
Dismissed
jsegarra left a comment
Member

Si un test necesita comentarios es que no está bien planteado la descripcion del caso de uso y/o los expects
Por otra parte, si pones comentarios para los expects, que lo tengan todos no?

Y si pones comentarios a un valor que tenga sentido

Si un test necesita comentarios es que no está bien planteado la descripcion del caso de uso y/o los expects Por otra parte, si pones comentarios para los expects, que lo tengan todos no? Y si pones comentarios a un valor que tenga sentido
jsegarra requested changes 2025-01-03 15:46:17 +00:00
Dismissed
jsegarra left a comment
Member

Diría que vue/test-utils no lo usamos mas allá del createWrapper

Diría que vue/test-utils no lo usamos mas allá del createWrapper
jsegarra requested changes 2025-01-03 15:49:39 +00:00
Dismissed
@ -0,0 +4,4 @@
describe('tags computed property', () => {
it('returns an object with the correct keys and values', () => {
const wrapper = mount(FetchedTags, {
Member

Es mínimo el detalle pero la variable wrapper no se usa en ningún sitio, no tiene mas sentido hacer vm?

Es mínimo el detalle pero la variable wrapper no se usa en ningún sitio, no tiene mas sentido hacer vm?
Author
Member

si, no cambia nada usar wrapper en este caso. ya esta cambiado a vm

si, no cambia nada usar wrapper en este caso. ya esta cambiado a vm
provira added 1 commit 2025-01-07 06:07:48 +00:00
gitea/salix-front/pipeline/pr-dev Build queued... Details
29614ce335
fix: refs #7088 changed wrapper to vm
provira added 1 commit 2025-01-07 06:07:57 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
09cc12667c
Merge branch 'dev' into 7088-testFetchedTags
provira requested review from jsegarra 2025-01-07 06:11:20 +00:00
provira added 1 commit 2025-01-07 08:44:25 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
7eb62ce23c
Merge branch 'dev' into 7088-testFetchedTags
jsegarra requested changes 2025-01-07 14:59:07 +00:00
Dismissed
@ -0,0 +33,4 @@
value: 'value',
},
});
expect(vm.vm.tags).toEqual({});
Member

Es mínimo el detalle pero la variable vm no se usa en ningún sitio, no tiene mas sentido hacer vm.tags?

Es mínimo el detalle pero la variable vm no se usa en ningún sitio, no tiene mas sentido hacer vm.tags?
Author
Member

solucionado

solucionado
@ -0,0 +76,4 @@
},
});
expect(vm.vm.columnStyle).toEqual({});
Member

Es mínimo el detalle pero la variable vm no se usa en ningún sitio, no tiene mas sentido hacer vm.columnStyle?

Es mínimo el detalle pero la variable vm no se usa en ningún sitio, no tiene mas sentido hacer vm.columnStyle?
Author
Member

solucionado

solucionado
provira added 1 commit 2025-01-08 05:57:00 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
f0889f158d
Merge branch 'dev' into 7088-testFetchedTags
provira added 1 commit 2025-01-08 06:39:59 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
0d3b1130f9
fix: refs #7088 changed "vm.vm" to "vm"
provira added 1 commit 2025-01-08 06:40:31 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
6499eeda01
Merge branch 'dev' into 7088-testFetchedTags
provira requested review from jsegarra 2025-01-08 06:41:22 +00:00
provira added 1 commit 2025-01-08 07:12:04 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
03c23a133b
Merge branch 'dev' into 7088-testFetchedTags
jsegarra reviewed 2025-01-08 14:44:48 +00:00
jsegarra left a comment
Member

La idea era hacer const {vm} = createWrapper

La idea era hacer const {vm} = createWrapper
jsegarra approved these changes 2025-01-08 14:44:55 +00:00
provira added 1 commit 2025-01-09 06:00:16 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
58a4ef2ca8
Merge branch 'dev' into 7088-testFetchedTags
provira merged commit 1142797114 into dev 2025-01-09 06:04:16 +00:00
provira deleted branch 7088-testFetchedTags 2025-01-09 06:04:16 +00:00
Sign in to join this conversation.
No reviewers
No Milestone
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix-front#1162
No description provided.