verdnatura/salix-front
verdnatura
/
salix-front
2
2
Fork 1
Code Issues Pull Requests 99 Releases Wiki Activity

feat: #7077 created test for VnInputTime #1163

Merged
provira merged 10 commits from 7077-testVnInputTime into dev 2025-01-16 08:24:03 +00:00
Conversation 1 Commits 10 Files Changed 1 +63
provira commented 2025-01-02 11:16:24 +00:00
Member
Copy Link
No description provided.
provira added 1 commit 2025-01-02 11:16:24 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
df1b1205cf feat: refs #7077 created test for VnInputTime
provira requested review from jsegarra 2025-01-02 11:16:29 +00:00
jsegarra requested changes 2025-01-03 15:58:24 +00:00
Dismissed
jsegarra left a comment
Member
Copy Link

Faltaría añadir un caso de uso para la linea 48. Cuando time.length > 5

Faltaría añadir un caso de uso para la linea 48. Cuando time.length > 5
jsegarra commented 2025-01-03 15:59:25 +00:00
Member
Copy Link

Me sale que en ese componente hay lineas sin usar, como por ejemplo el de la traducción
Si es correcto y ha sido un fallo por nuestra parte, puedes eliminar las dependencias que no se usen
Gracias de antemano

Me sale que en ese componente hay lineas sin usar, como por ejemplo el de la traducción Si es correcto y ha sido un fallo por nuestra parte, puedes eliminar las dependencias que no se usen Gracias de antemano
provira added 1 commit 2025-01-13 12:20:35 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
a22330b15e Merge branch 'dev' into 7077-testVnInputTime
provira added 1 commit 2025-01-14 13:49:33 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
698c20550f Merge branch 'dev' into 7077-testVnInputTime
provira added 1 commit 2025-01-15 08:55:00 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
46bfd3b115 Merge branch 'dev' into 7077-testVnInputTime
provira added 2 commits 2025-01-15 08:56:08 +00:00
provira requested review from jsegarra 2025-01-15 08:57:03 +00:00
jsegarra requested changes 2025-01-15 20:12:01 +00:00
Dismissed
src/components/common/__tests__/VnInputTime.spec.js Outdated
@ -0,0 +10,4 @@
wrapper = createWrapper(VnInputTime, {
props: {
isOutlined: true,
timeOnly: false, // Initial props values
jsegarra commented 2025-01-15 20:11:55 +00:00
Member
Copy Link

el comentario

el comentario
provira marked this conversation as resolved
provira added 1 commit 2025-01-16 06:15:39 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
ce7e529776 Merge branch 'dev' into 7077-testVnInputTime
provira added 2 commits 2025-01-16 06:18:31 +00:00
provira added 1 commit 2025-01-16 06:18:44 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
8d508c82a0 Merge branch 'dev' into 7077-testVnInputTime
provira requested review from jsegarra 2025-01-16 06:20:28 +00:00
jsegarra approved these changes 2025-01-16 06:46:12 +00:00
provira merged commit 71daac1c9d into dev 2025-01-16 08:24:03 +00:00
provira deleted branch 7077-testVnInputTime 2025-01-16 08:24:03 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
jsegarra
Labels
Clear labels   
bug

Something is not working

  
CR / Tests passed

CR / Tests passed

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
invalid

Something is wrong

  
Missing Tests

Missing Tests

  
wontfix

This won't be fixed

No Label
bug
CR / Tests passed
duplicate
enhancement
invalid
Missing Tests
wontfix
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix-front#1163
No description provided.
Delete Branch "7077-testVnInputTime"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?