verdnatura/salix-front
verdnatura
/
salix-front
2
2
Fork 1
Code Issues Pull Requests 72 Releases Wiki Activity

perf_redirectTransition #1178

Merged
alexm merged 7 commits from perf_redirectTransition into test 2025-01-09 08:16:54 +00:00
Conversation 0 Commits 7 Files Changed 1 +9 -7
alexm commented 2025-01-07 07:22:33 +00:00
Member
Copy Link

Evita que salga el list con 1 resultado antes de redirigir al card
image

Evita que salga el list con 1 resultado antes de redirigir al card ![image](/attachments/bdb4da1d-cfe7-47c6-bae6-1e1640a9afd7)
image.png
68 KiB
image.png
68 KiB
image.png
alexm added 3 commits 2025-01-07 07:22:34 +00:00
gitea/salix-front/pipeline/pr-master This commit looks good Details
ea157eaf73 build: refs #8355 add changelog
gitea/salix-front/pipeline/pr-dev This commit looks good Details
gitea/salix-front/pipeline/head This commit looks good Details
cc6ee7ce30 Merge pull request '8355-testToMaster' (!1177) from 8355-testToMaster into master 
Reviewed-on: #1177
Reviewed-by: Guillermo Bonet <guillermo@verdnatura.es>
gitea/salix-front/pipeline/pr-test There was a failure building this commit Details
76b9fbc267 perf: redirect transition list to card
alexm requested review from jsegarra 2025-01-07 07:23:08 +00:00
alexm added 1 commit 2025-01-07 07:24:44 +00:00
gitea/salix-front/pipeline/pr-test This commit looks good Details
d8c3e6bce7 perf: revert processData
alexm reviewed 2025-01-07 07:25:26 +00:00
src/composables/useArrayData.js
@ -124,8 +124,11 @@ export function useArrayData(key = useRoute().meta.moduleName, userOptions) {
const { limit } = filter;
store.hasMoreData = limit && response.data.length >= limit;
if (!append && !isDialogOpened() && updateRouter) {
alexm commented 2025-01-07 07:25:26 +00:00
Author
Member
Copy Link

Basicamente es hacer primero la parte del router, antes de procesar los datos. Y si se va a redirigir evitamos la parte de setear datos

Basicamente es hacer primero la parte del router, antes de procesar los datos. Y si se va a redirigir evitamos la parte de setear datos
jsegarra commented 2025-01-07 13:25:17 +00:00
Member
Copy Link

Estamos en el limite de condiciones de un if

Estamos en el limite de condiciones de un if
👀 1
alexm added 1 commit 2025-01-07 07:26:39 +00:00
gitea/salix-front/pipeline/pr-test This commit looks good Details
97fee8d1d0 perf: order
jsegarra reviewed 2025-01-07 13:44:49 +00:00
src/composables/useArrayData.js Outdated
@ -128,2 +127,2 @@
if (!append && !isDialogOpened()) updateRouter && updateStateParams();
if (!append && !isDialogOpened() && updateRouter) {
const res = updateStateParams(response.data);
jsegarra commented 2025-01-07 13:44:49 +00:00
Member
Copy Link

Ya tenemos un response por ahi, asi que la variable res, se puede renombrar?
Y si hacemos const redirect = updateStateParams()?.redirect?
if(redirect) return?

Es una idea, por eso lo pongo como comentario

Ya tenemos un **res**ponse por ahi, asi que la variable res, se puede renombrar? Y si hacemos const redirect = updateStateParams()?.redirect? if(redirect) return? Es una idea, por eso lo pongo como comentario
alexm commented 2025-01-09 06:57:26 +00:00
Author
Member
Copy Link

Me mola, si. Lo subo asi

Me mola, si. Lo subo asi
❤️ 1
jsegarra approved these changes 2025-01-07 13:45:09 +00:00
Dismissed
jsegarra left a comment
Member
Copy Link

No lo he probado, pero asumo que no rompe otra navegacion

No lo he probado, pero asumo que no rompe otra navegacion
alexm added 1 commit 2025-01-09 07:06:42 +00:00
gitea/salix-front/pipeline/pr-test There was a failure building this commit Details
2505061b8c perf: simplify if
alexm dismissed jsegarra’s review 2025-01-09 07:06:42 +00:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

alexm added 1 commit 2025-01-09 07:30:30 +00:00
gitea/salix-front/pipeline/pr-test Build queued... Details
b28873c67d perf: simplify if
alexm added 1 commit 2025-01-09 07:30:39 +00:00
gitea/salix-front/pipeline/pr-test This commit looks good Details
a54483f9a5 Merge branch 'test' into perf_redirectTransition
carlossa approved these changes 2025-01-09 07:32:10 +00:00
alexm added 1 commit 2025-01-09 08:00:59 +00:00
gitea/salix-front/pipeline/pr-test This commit looks good Details
f668a4bac4 Merge branch 'test' into perf_redirectTransition
alexm merged commit f45612f058 into test 2025-01-09 08:16:54 +00:00
alexm deleted branch perf_redirectTransition 2025-01-09 08:16:54 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
carlossa
Labels
Clear labels   
bug

Something is not working

  
CR / Tests passed

CR / Tests passed

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
invalid

Something is wrong

  
Missing Tests

Missing Tests

  
wontfix

This won't be fixed

No Label
bug
CR / Tests passed
duplicate
enhancement
invalid
Missing Tests
wontfix
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix-front#1178
No description provided.
Delete Branch "perf_redirectTransition"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?