verdnatura/salix-front
verdnatura
/
salix-front
2
3
Fork 1
Code Issues Pull Requests 92 Releases Wiki Activity

feat: refs #7055 created FilterItemForm test #1187

Merged
provira merged 8 commits from 7055-testFilterItemForm into dev 2025-01-14 06:03:51 +00:00
Conversation 0 Commits 8 Files Changed 1 +82
provira commented 2025-01-08 12:02:38 +00:00
Member
Copy Link
No description provided.
provira added 1 commit 2025-01-08 12:02:39 +00:00
gitea/salix-front/pipeline/pr-dev Build queued... Details
5dc14b8dc1 feat: refs #7055 created FilterItemForm test
provira added 1 commit 2025-01-08 12:02:46 +00:00
gitea/salix-front/pipeline/pr-dev There was a failure building this commit Details
149cca37ef Merge branch 'dev' into 7055-testFilterItemForm
provira added 1 commit 2025-01-09 07:25:30 +00:00
gitea/salix-front/pipeline/pr-dev Build queued... Details
b466dfe034 feat: refs #7055 added new test case
provira added 1 commit 2025-01-09 07:25:39 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
92a130b5db Merge branch 'dev' into 7055-testFilterItemForm
provira changed title from WIP: feat: refs #7055 created FilterItemForm test to feat: refs #7055 created FilterItemForm test 2025-01-09 07:25:44 +00:00
provira requested review from jsegarra 2025-01-09 07:30:51 +00:00
provira added 1 commit 2025-01-10 13:54:09 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
6a01c9b746 Merge branch 'dev' into 7055-testFilterItemForm
jsegarra requested changes 2025-01-13 07:54:10 +00:00
Dismissed
src/components/__tests__/FilterItemForm.spec.js Outdated
@ -0,0 +1,78 @@
import { createWrapper, axios } from 'app/test/vitest/helper';
import FilterItemForm from 'components/FilterItemForm.vue';
jsegarra commented 2025-01-13 07:54:08 +00:00
Member
Copy Link

src
así seguimos el standard de los test
Por ejemplo en la #1197 hemos puesto src/components

src así seguimos el standard de los test Por ejemplo en la #1197 hemos puesto src/components
provira commented 2025-01-13 11:26:10 +00:00
Author
Member
Copy Link

arreglado

arreglado
jsegarra marked this conversation as resolved
jsegarra requested changes 2025-01-13 08:40:43 +00:00
Dismissed
src/components/__tests__/FilterItemForm.spec.js
@ -0,0 +28,4 @@
});
});
it('should filter data and populate tableRows for table display', async () => {
jsegarra commented 2025-01-13 08:40:41 +00:00
Member
Copy Link

Este it, debería comprobar el filtro que se le pasa a la petición de axios.
En el siguiente it, si que se comprueba estando vacío, y aquí que tiene valores no se comprueba? Tendría que haber expect en ambos casos

Este it, debería comprobar el filtro que se le pasa a la petición de axios. En el siguiente it, si que se comprueba estando vacío, y aquí que tiene valores no se comprueba? Tendría que haber expect en ambos casos
provira commented 2025-01-13 11:26:16 +00:00
Author
Member
Copy Link

añadido

añadido
provira added 1 commit 2025-01-13 11:07:07 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
7a5de9f708 Merge branch 'dev' into 7055-testFilterItemForm
provira added 1 commit 2025-01-13 11:27:35 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
50008ce7f1 fix: refs #7055 #7055 #7055 fixed some tests
provira requested review from jsegarra 2025-01-13 11:27:48 +00:00
jsegarra reviewed 2025-01-13 22:16:55 +00:00
src/components/__tests__/FilterItemForm.spec.js
@ -0,0 +41,4 @@
where: {"name":{"like":"%bolas de madera%"}},
};
expect(axios.get).toHaveBeenCalledWith('Items/withName', {
jsegarra commented 2025-01-13 22:16:55 +00:00
Member
Copy Link

Es el mismo expect, pero creo que 2 ocurrencias se puede dar como bueno

Es el mismo expect, pero creo que 2 ocurrencias se puede dar como bueno
jsegarra approved these changes 2025-01-13 22:16:57 +00:00
provira added 1 commit 2025-01-14 05:59:54 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
34442c8577 Merge branch 'dev' into 7055-testFilterItemForm
provira merged commit b8344f3b22 into dev 2025-01-14 06:03:51 +00:00
provira deleted branch 7055-testFilterItemForm 2025-01-14 06:03:51 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
jsegarra
Labels
Clear labels   
bug

Something is not working

  
CR / Tests passed

CR / Tests passed

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
invalid

Something is wrong

  
Missing Tests

Missing Tests

  
wontfix

This won't be fixed

No Label
bug
CR / Tests passed
duplicate
enhancement
invalid
Missing Tests
wontfix
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix-front#1187
No description provided.
Delete Branch "7055-testFilterItemForm"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?