verdnatura/salix-front
verdnatura
/
salix-front
2
2
Fork 1
Code Issues Pull Requests 69 Releases Wiki Activity

perf: refs #8197 fix and imrpove filters #1234

Merged
alexm merged 6 commits from 8197-fix_filters into dev 2025-01-21 10:48:32 +00:00
Conversation 0 Commits 6 Files Changed 6 +50 -41
alexm commented 2025-01-16 12:32:31 +00:00
Member
Copy Link
No description provided.
alexm added 1 commit 2025-01-16 12:32:32 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
d95350a8eb perf: refs #8197 fix and imrpove filters
alexm reviewed 2025-01-16 12:32:49 +00:00
src/components/common/VnSection.vue
@ -53,3 +53,3 @@
const isSame = sectionValue.value == route.name;
if (!isSame && arrayData) {
arrayData.reset(['userParams', 'userFilter']);
arrayData.reset(['userParams', 'filter']);
alexm commented 2025-01-16 12:32:49 +00:00
Author
Member
Copy Link

No debe borrar los userFilers

No debe borrar los userFilers
alexm reviewed 2025-01-16 12:33:27 +00:00
src/components/common/VnSelect.vue
@ -240,1 +240,3 @@
const { data } = await arrayData.applyFilter({ filter: fetchOptions });
const { data } = await arrayData.applyFilter(
{ filter: filterOptions },
{ updateRouter: false }
alexm commented 2025-01-16 12:33:27 +00:00
Author
Member
Copy Link

Si no, entraba siempre como updateRouter

Si no, entraba siempre como updateRouter
❤️ 1
alexm requested review from jsegarra 2025-01-16 12:33:50 +00:00
jsegarra reviewed 2025-01-16 12:40:51 +00:00
src/pages/Ticket/TicketFilter.vue
@ -84,2 +85,2 @@
<VnSelect
:label="t('Salesperson')"
<VnSelectWorker
:label="t('globals.salesPerson')"
jsegarra commented 2025-01-16 12:40:51 +00:00
Member
Copy Link

Habría que reabrir la tarea de VnSelectWorker para usarlo en todas las llamadas de activeWithIneritedRole?

Habría que reabrir la tarea de VnSelectWorker para usarlo en todas las llamadas de activeWithIneritedRole?
alexm commented 2025-01-17 06:14:49 +00:00
Author
Member
Copy Link

@jon
Buscando por activeWithInheritedRole salen 25 resultados, habria que pasarlos?

@jon Buscando por activeWithInheritedRole salen 25 resultados, habria que pasarlos?
jon commented 2025-01-17 06:23:33 +00:00
Member
Copy Link

Yo reabriría la tarea y revisaría cada llamada de activeWithInheritedRole para que usara el mismo componente en caso de que no lo esté usando

Yo reabriría la tarea y revisaría cada llamada de activeWithInheritedRole para que usara el mismo componente en caso de que no lo esté usando
jsegarra commented 2025-01-17 09:08:43 +00:00
Member
Copy Link

Coincido,

  1. validar las diferencias entre Worker7search y el anterior
  2. Anotarlas en la tarea y reabrirla
  3. Hacerlo
Coincido, 1. validar las diferencias entre Worker7search y el anterior 2. Anotarlas en la tarea y reabrirla 3. Hacerlo
alexm commented 2025-01-21 06:39:21 +00:00
Author
Member
Copy Link

Pongo en esta https://redmine.verdnatura.es/issues/8336

Pongo en esta https://redmine.verdnatura.es/issues/8336
jsegarra commented 2025-01-21 08:38:24 +00:00
Member
Copy Link

entonces @alexm fusionamos esta tal cual, y los cambios ya vendrán en la tarea que has dicho, no?

entonces @alexm fusionamos esta tal cual, y los cambios ya vendrán en la tarea que has dicho, no?
jsegarra requested changes 2025-01-16 12:42:23 +00:00
Dismissed
src/composables/useFilterParams.js Outdated
@ -31,3 +31,3 @@
function setUserParams(watchedParams) {
if (!watchedParams || Object.keys(watchedParams).length == 0) return;
if (!watchedParams || Object.keys(watchedParams).length == 0) {
jsegarra commented 2025-01-16 12:42:21 +00:00
Member
Copy Link

Si le damos un valor por defecto al parámetro nos podríamos quitar 1 condición del if no?

Si le damos un valor por defecto al parámetro nos podríamos quitar 1 condición del if no?
alexm commented 2025-01-17 06:10:59 +00:00
Author
Member
Copy Link

Vooy

Vooy
jsegarra commented 2025-01-17 09:09:01 +00:00
Member
Copy Link

Genial

Genial
alexm added 1 commit 2025-01-17 06:16:32 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
94c0cccb1e perf: refs #8197 default is object
alexm requested review from jsegarra 2025-01-17 06:16:47 +00:00
alexm added 1 commit 2025-01-17 06:16:54 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
a738fe1579 Merge branch 'dev' into 8197-fix_filters
jsegarra added 1 commit 2025-01-17 09:09:14 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
179f5a684f Merge branch 'dev' into 8197-fix_filters
jsegarra approved these changes 2025-01-17 09:09:17 +00:00
Dismissed
alexm added 1 commit 2025-01-21 06:38:02 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
1feb26bd6d Merge branch 'dev' into 8197-fix_filters
alexm dismissed jsegarra’s review 2025-01-21 06:38:02 +00:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

jsegarra approved these changes 2025-01-21 06:56:49 +00:00
alexm added 1 commit 2025-01-21 10:45:44 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
a2499f11e1 Merge branch 'dev' into 8197-fix_filters
alexm merged commit 9f280c6089 into dev 2025-01-21 10:48:32 +00:00
alexm deleted branch 8197-fix_filters 2025-01-21 10:48:32 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
jsegarra
Labels
Clear labels   
bug

Something is not working

  
CR / Tests passed

CR / Tests passed

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
invalid

Something is wrong

  
Missing Tests

Missing Tests

  
wontfix

This won't be fixed

No Label
bug
CR / Tests passed
duplicate
enhancement
invalid
Missing Tests
wontfix
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix-front#1234
No description provided.
Delete Branch "8197-fix_filters"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?