verdnatura/salix-front
verdnatura
/
salix-front
2
3
Fork 1
Code Issues Pull Requests 96 Releases Wiki Activity

#8197 - advancedMenu #1248

Merged
alexm merged 8 commits from 8197-advancedMenu into dev 2025-01-23 07:27:37 +00:00
Conversation 2 Commits 8 Files Changed 23 +574 -458
alexm commented 2025-01-20 09:46:14 +00:00
Member
Copy Link
No description provided.
alexm added 3 commits 2025-01-20 09:46:14 +00:00
gitea/salix-front/pipeline/pr-dev There was a failure building this commit Details
58b8b2f7b0 fix: refs #8197 use rightMenu
alexm requested review from jsegarra 2025-01-20 09:46:56 +00:00
alexm commented 2025-01-20 09:47:48 +00:00
Author
Member
Copy Link

Faltan supplier y zona pero como aun no usan VnCardBeta no se puede. Ya lo tengo anotado y los cambiare en las respectivas ramas de pau

Faltan supplier y zona pero como aun no usan VnCardBeta no se puede. Ya lo tengo anotado y los cambiare en las respectivas ramas de pau
👍 1
jsegarra requested changes 2025-01-20 13:52:24 +00:00
Dismissed
src/components/common/VnLog.vue
@ -729,0 +689,4 @@
class="full-width"
clearable
clear-icon="close"
@keyup.enter="() => selectFilter('search')"
jsegarra commented 2025-01-20 13:42:40 +00:00
Member
Copy Link

Esta linea es diferente a la 767, y las que le siguen. Ventajas?
Dejamos solo un estilo.

Esta linea es diferente a la 767, y las que le siguen. Ventajas? Dejamos solo un estilo.
alexm commented 2025-01-20 14:04:40 +00:00
Author
Member
Copy Link

Esta asi en dev, solo he movido la linea

Esta asi en dev, solo he movido la linea
👍 1
src/pages/Claim/Card/ClaimAction.vue
@ -234,0 +244,4 @@
)
"
:label="t('confirmGreuges')"
class="q-field__native text-grey-2"
jsegarra commented 2025-01-20 13:47:13 +00:00
Member
Copy Link

q-field__native???

q-field__native???
alexm commented 2025-01-20 14:05:07 +00:00
Author
Member
Copy Link

Esta asi en dev, solo he movido la linea

Esta asi en dev, solo he movido la linea
👍 1
src/pages/Claim/Card/ClaimAction.vue
@ -234,0 +251,4 @@
name="multiplicatorValue"
min="0"
max="50"
v-model="multiplicatorValue"
jsegarra commented 2025-01-20 13:47:27 +00:00
Member
Copy Link

v-model.number?

v-model.number?
alexm commented 2025-01-20 14:05:26 +00:00
Author
Member
Copy Link

Esta asi en dev, solo he movido la linea

Incluso usa QInput

Esta asi en dev, solo he movido la linea Incluso usa `QInput`
👍 1
src/pages/Ticket/Card/TicketBoxing.vue
@ -152,0 +139,4 @@
<QItemLabel caption>{{ t('globals.created') }}</QItemLabel>
<QItemLabel>
{{
date.formatDate(expedition.created, 'YYYY-MM-DD HH:mm:ss')
jsegarra commented 2025-01-20 13:50:04 +00:00
Member
Copy Link

esta linea la veo muy repetida(en el proyecto). No teníamos un composable o filtro o util que lo hacia?

esta linea la veo muy repetida(en el proyecto). No teníamos un composable o filtro o util que lo hacia?
alexm commented 2025-01-20 14:05:33 +00:00
Author
Member
Copy Link

Esta asi en dev, solo he movido la linea

Esta asi en dev, solo he movido la linea
👍 1
src/router/modules/ticket.js
@ -169,3 +169,3 @@
meta: {
title: 'boxing',
icon: 'science',
icon: 'view_in_ar',
jsegarra commented 2025-01-20 13:52:18 +00:00
Member
Copy Link

Comentario: mucho mejor este icono

Comentario: mucho mejor este icono
alexm commented 2025-01-20 14:06:20 +00:00
Author
Member
Copy Link

Siii jaja, estaba ese icono pq fue la primera sección que estaba en lilium y no en salix y se puso como para saber q era "experimental"

Siii jaja, estaba ese icono pq fue la primera sección que estaba en lilium y no en salix y se puso como para saber q era "experimental"
😆 1
jsegarra changed title from 8197-advancedMenu to #8197 - advancedMenu 2025-01-20 13:52:32 +00:00
alexm added 1 commit 2025-01-20 14:06:23 +00:00
gitea/salix-front/pipeline/pr-dev There was a failure building this commit Details
ce0bfe12d7 Merge branch 'dev' into 8197-advancedMenu
jsegarra added 1 commit 2025-01-20 21:33:03 +00:00
gitea/salix-front/pipeline/pr-dev There was a failure building this commit Details
bbac57845a Merge branch 'dev' into 8197-advancedMenu
jsegarra approved these changes 2025-01-20 21:38:04 +00:00
Dismissed
jsegarra left a comment
Member
Copy Link

Revisa los test de front porque en 2 iteraciones no pasan

Revisa los test de front porque en 2 iteraciones no pasan
jsegarra commented 2025-01-20 21:39:29 +00:00
Member
Copy Link

@alexm Te adjunto una foto
image

@alexm Te adjunto una foto ![image](/attachments/66260d7a-15f2-4ca9-87f4-b2931d965e96)
image.png
96 KiB
alexm added 1 commit 2025-01-23 06:33:52 +00:00
alexm dismissed jsegarra’s review 2025-01-23 06:33:52 +00:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

alexm added 1 commit 2025-01-23 07:18:30 +00:00
alexm added 1 commit 2025-01-23 07:20:07 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
a0895488b4 Merge branch 'dev' into 8197-advancedMenu
alexm requested review from jsegarra 2025-01-23 07:20:11 +00:00
jsegarra approved these changes 2025-01-23 07:26:34 +00:00
alexm merged commit f9dd927292 into dev 2025-01-23 07:27:37 +00:00
alexm deleted branch 8197-advancedMenu 2025-01-23 07:27:37 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
jsegarra
Labels
Clear labels   
bug

Something is not working

  
CR / Tests passed

CR / Tests passed

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
invalid

Something is wrong

  
Missing Tests

Missing Tests

  
wontfix

This won't be fixed

No Label
bug
CR / Tests passed
duplicate
enhancement
invalid
Missing Tests
wontfix
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix-front#1248
No description provided.
Delete Branch "8197-advancedMenu"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?