verdnatura/salix-front
verdnatura
/
salix-front
2
2
Fork 1
Code Issues Pull Requests 94 Releases Wiki Activity

#7068: Created VnVisibleColumns test #1250

Merged
jon merged 7 commits from 7068-TableVisibleColumnsTest into dev 2025-01-21 12:11:45 +00:00
Conversation 0 Commits 7 Files Changed 1 +121
jon commented 2025-01-20 09:59:19 +00:00
Member
Copy Link
No description provided.
jon added 1 commit 2025-01-20 09:59:20 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
efb0162f9c feat: refs #7068 created VnVisibleColumns unit test
jon added the
CR / Tests passed
 label 2025-01-20 10:43:31 +00:00
jon added 1 commit 2025-01-20 10:43:36 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
773c917c20 Merge branch 'dev' into 7068-TableVisibleColumnsTest
jon requested review from jsegarra 2025-01-20 10:45:41 +00:00
jsegarra requested changes 2025-01-20 21:45:12 +00:00
Dismissed
src/components/VnTable/__tests__/VnVisibleColumns.spec.js
@ -0,0 +113,4 @@
],
});
mockAxiosPost.mockRestore();
jsegarra commented 2025-01-20 21:45:10 +00:00
Member
Copy Link

Está bien y aunque solo hay 1 es correcto
Pero todavia mejor si lo metemos dentro de un afterEach y usamo vi.clearAllMocks();

afterEach(() => { vi.clearAllMocks(); });

Estariamos usando el standard en todos los tests

Está bien y aunque solo hay 1 es correcto Pero todavia mejor si lo metemos dentro de un afterEach y usamo vi.clearAllMocks(); ` afterEach(() => { vi.clearAllMocks(); });` Estariamos usando el standard en todos los tests
jon added 2 commits 2025-01-21 08:07:02 +00:00
jon requested review from jsegarra 2025-01-21 08:08:00 +00:00
jsegarra requested changes 2025-01-21 08:46:46 +00:00
Dismissed
jsegarra left a comment
Member
Copy Link

Ajustar la definición de variables y expected

Ajustar la definición de variables y expected
jon added 1 commit 2025-01-21 10:05:30 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
28db925645 refactor: refs #7068 adjust variables
jon requested review from jsegarra 2025-01-21 10:06:37 +00:00
jsegarra approved these changes 2025-01-21 11:22:11 +00:00
jsegarra added 1 commit 2025-01-21 11:22:15 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
26e6ceb24d Merge branch 'dev' into 7068-TableVisibleColumnsTest
jon added 1 commit 2025-01-21 12:10:57 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
befbbf3f73 Merge branch 'dev' into 7068-TableVisibleColumnsTest
jon merged commit 9383a3b4fb into dev 2025-01-21 12:11:45 +00:00
jon deleted branch 7068-TableVisibleColumnsTest 2025-01-21 12:11:45 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
jsegarra
Labels
Clear labels   
bug

Something is not working

  
CR / Tests passed

CR / Tests passed

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
invalid

Something is wrong

  
Missing Tests

Missing Tests

  
wontfix

This won't be fixed

No Label
bug
CR / Tests passed
duplicate
enhancement
invalid
Missing Tests
wontfix
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix-front#1250
No description provided.
Delete Branch "7068-TableVisibleColumnsTest"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?