verdnatura/salix-front
verdnatura
/
salix-front
2
2
Fork 1
Code Issues Pull Requests 94 Releases Wiki Activity

feat: #7103 created test for VnSearchbar #1256

Open
provira wants to merge 10 commits from 7103-testVnSearchbar into dev
pull from: 7103-testVnSearchbar
merge into: verdnatura:dev
Conversation 0 Commits 10 Files Changed 1 +65
provira commented 2025-01-21 08:46:10 +00:00
Member
Copy Link
No description provided.
provira added 1 commit 2025-01-21 08:46:10 +00:00
provira added 1 commit 2025-01-21 08:46:14 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
df403e35e6 Merge branch 'dev' into 7103-testVnSearchbar
provira requested review from jsegarra 2025-01-21 08:46:18 +00:00
jsegarra requested changes 2025-01-21 13:05:17 +00:00
jsegarra left a comment
Member
Copy Link

En general evitar repetir valores lietrales iguales

En general evitar repetir valores lietrales iguales
src/components/ui/__tests__/VnSearchbar.spec.js Outdated
@ -0,0 +2,4 @@
import { createWrapper } from 'app/test/vitest/helper';
import VnSearchbar from 'src/components/ui/VnSearchbar.vue';
describe('VnSearchbar - Functions', () => {
jsegarra commented 2025-01-21 13:04:45 +00:00
Member
Copy Link

porque functions?

porque functions?
provira marked this conversation as resolved
src/components/ui/__tests__/VnSearchbar.spec.js Outdated
@ -0,0 +21,4 @@
it('search resets pagination and applies filter', async () => {
const resetPaginationSpy = vi.spyOn(vm.arrayData, 'resetPagination').mockImplementation(() => {});
const applyFilterSpy = vi.spyOn(vm.arrayData, 'applyFilter').mockImplementation(() => Promise.resolve());
jsegarra commented 2025-01-21 13:05:02 +00:00
Member
Copy Link

Promise.resolve(), vacio?

Promise.resolve(), vacio?
provira marked this conversation as resolved
provira added 2 commits 2025-01-21 13:41:45 +00:00
provira added 1 commit 2025-01-21 13:41:47 +00:00
gitea/salix-front/pipeline/pr-dev There was a failure building this commit Details
1f5823536f Merge branch 'dev' into 7103-testVnSearchbar
provira added 1 commit 2025-01-21 13:50:40 +00:00
gitea/salix-front/pipeline/pr-dev There was a failure building this commit Details
247701125c Merge branch 'dev' into 7103-testVnSearchbar
provira added 1 commit 2025-01-22 06:29:55 +00:00
gitea/salix-front/pipeline/pr-dev There was a failure building this commit Details
4f31e7c553 Merge branch 'dev' into 7103-testVnSearchbar
provira added 3 commits 2025-01-22 06:30:50 +00:00
provira requested review from jsegarra 2025-01-22 06:35:58 +00:00
All checks were successful
gitea/salix-front/pipeline/pr-dev This commit looks good
Required
Details
This pull request doesn't have enough approvals yet. 0 of 1 approvals granted.
You are not authorized to merge this pull request.
Sign in to join this conversation.
Reviewers
No reviewers
jsegarra
Labels
Clear labels   
bug

Something is not working

  
CR / Tests passed

CR / Tests passed

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
invalid

Something is wrong

  
Missing Tests

Missing Tests

  
wontfix

This won't be fixed

No Label
bug
CR / Tests passed
duplicate
enhancement
invalid
Missing Tests
wontfix
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix-front#1256
No description provided.
Delete Branch "7103-testVnSearchbar"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?