verdnatura/salix-front
verdnatura
/
salix-front
2
2
Fork 1
Code Issues Pull Requests 69 Releases Wiki Activity

fix(VnSection): refs #8197 check route #1263

Merged
alexm merged 4 commits from 8197-better_check_route into dev 2025-01-21 14:11:35 +00:00
Conversation 0 Commits 4 Files Changed 1 +22 -10
alexm commented 2025-01-21 12:48:48 +00:00
Member
Copy Link
No description provided.
alexm added 1 commit 2025-01-21 12:48:48 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
7bca8a4194 fix(VnSection): refs #8197 check route
jsegarra reviewed 2025-01-21 12:56:46 +00:00
src/components/common/VnSection.vue Outdated
@ -57,3 +54,1 @@
}
return isSame;
});
const isMainSection = ref();
jsegarra commented 2025-01-21 12:56:46 +00:00
Member
Copy Link

valor por defecto a false? Asumo que por el nombre es un booleano

valor por defecto a false? Asumo que por el nombre es un booleano
alexm commented 2025-01-21 13:04:56 +00:00
Author
Member
Copy Link

null me vale jajaj pero si le pongo false

null me vale jajaj pero si le pongo false
alexm marked this conversation as resolved
jsegarra reviewed 2025-01-21 12:57:28 +00:00
src/components/common/VnSection.vue Outdated
@ -72,0 +71,4 @@
const unsubscribe = router.afterEach(() => {
checkIsMain();
});
onUnmounted(() => unsubscribe());
jsegarra commented 2025-01-21 12:57:28 +00:00
Member
Copy Link

Bien, y así también serviria onUnmounted(unsubscribe); no?

Bien, y así también serviria ` onUnmounted(unsubscribe);` no?
alexm marked this conversation as resolved
alexm added 2 commits 2025-01-21 13:11:11 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
979c96c5ac perf: refs #8197 perf
jsegarra added 1 commit 2025-01-21 13:57:32 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
7d39211eeb Merge branch 'dev' into 8197-better_check_route
jsegarra approved these changes 2025-01-21 13:57:48 +00:00
alexm merged commit fe7b37fd15 into dev 2025-01-21 14:11:35 +00:00
alexm deleted branch 8197-better_check_route 2025-01-21 14:11:36 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
jsegarra
Labels
Clear labels   
bug

Something is not working

  
CR / Tests passed

CR / Tests passed

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
invalid

Something is wrong

  
Missing Tests

Missing Tests

  
wontfix

This won't be fixed

No Label
bug
CR / Tests passed
duplicate
enhancement
invalid
Missing Tests
wontfix
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix-front#1263
No description provided.
Delete Branch "8197-better_check_route"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?