feat: #8410 added new feature to module searchbar #1272

Merged
provira merged 18 commits from 8410-improveModuleSearchbar into dev 2025-01-31 10:02:50 +00:00
Member
No description provided.
provira added 1 commit 2025-01-23 11:19:03 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
6cba927ebc
feat: refs #8410 added new feature to module searchbar
provira requested review from jorgep 2025-01-23 11:19:15 +00:00
jorgep reviewed 2025-01-23 11:57:35 +00:00
@ -177,0 +185,4 @@
})
const searching = ref(false)
moduleArrays.value.find((module) => {
console.log(module.title);
Member

Quitar

Quitar
provira marked this conversation as resolved
jorgep reviewed 2025-01-23 12:00:40 +00:00
@ -174,6 +175,35 @@ function normalize(text) {
.replace(/[\u0300-\u036f]/g, '')
.toLowerCase();
}
const searchModule = () => {
Member

Estás haciendo 2 bucles, pasar a 1. Respuesta de copilot:

const searchModule = () => {
    const searching = ref(false);
    items.value.some((item) => {
        const title = getLocale(item.title).normalize('NFD').replace(/[\u0300-\u036f]/g, '').toLowerCase();
        if (title.includes(search.value.toLowerCase()) && !searching.value) {
            searching.value = true;
            router.push({ name: item.name });
            return true; // Termina el bucle al encontrar el primer resultado
        }
        return false;
    });
}
Estás haciendo 2 bucles, pasar a 1. Respuesta de copilot: ``` const searchModule = () => { const searching = ref(false); items.value.some((item) => { const title = getLocale(item.title).normalize('NFD').replace(/[\u0300-\u036f]/g, '').toLowerCase(); if (title.includes(search.value.toLowerCase()) && !searching.value) { searching.value = true; router.push({ name: item.name }); return true; // Termina el bucle al encontrar el primer resultado } return false; }); } ```
provira marked this conversation as resolved
jorgep reviewed 2025-01-23 12:04:14 +00:00
@ -177,0 +197,4 @@
const globalLocale = t(label);
return globalLocale;
};
const searchingValue = ref(false);
Member

Las variables ponlas juntas y las funciones lo mismo.

Las variables ponlas juntas y las funciones lo mismo.
jorgep marked this conversation as resolved
jorgep reviewed 2025-01-23 12:05:25 +00:00
@ -177,0 +198,4 @@
return globalLocale;
};
const searchingValue = ref(false);
function searchingFunction(evt) {
Member

Solo gastas esta función en 1 sitio, es innecesaria.

Solo gastas esta función en 1 sitio, es innecesaria.
provira marked this conversation as resolved
jorgep reviewed 2025-01-23 12:07:09 +00:00
@ -177,0 +193,4 @@
})
}
const getLocale = (label) => {
Member

Solo gastas esta función en 1 sitio, es innecesaria.

Solo gastas esta función en 1 sitio, es innecesaria.
provira marked this conversation as resolved
jorgep reviewed 2025-01-23 12:08:01 +00:00
@ -189,2 +219,4 @@
dense
autofocus
@keyup.enter.stop="searchModule(search)"
@update:model-value="searchingFunction($event)"
Member

en lugar de usar una función, puedes hacer searchingVal = !!$event; que te devuelve el valor booleano. Y te ahorras líneas.

en lugar de usar una función, puedes hacer searchingVal = !!$event; que te devuelve el valor booleano. Y te ahorras líneas.
provira marked this conversation as resolved
Member

Al tabular, puedes cambiar de item y acceder a otro, sin embargo, aparece resaltado el primer item.

Al tabular, puedes cambiar de item y acceder a otro, sin embargo, aparece resaltado el primer item.
jorgep reviewed 2025-01-23 12:12:01 +00:00
@ -336,6 +368,9 @@ function normalize(text) {
.header {
color: var(--vn-label-color);
}
.searched{
Member

Sería un mejor enfoque intentar forzar el foco del item.

Sería un mejor enfoque intentar forzar el foco del item.
jorgep requested changes 2025-01-30 09:06:59 +00:00
Dismissed
jorgep left a comment
Member

.

.
provira added 1 commit 2025-01-30 11:39:50 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
983b91fbdd
Merge branch 'dev' into 8410-improveModuleSearchbar
provira added 2 commits 2025-01-30 12:06:56 +00:00
provira requested review from jorgep 2025-01-30 12:08:33 +00:00
jorgep added 2 commits 2025-01-30 12:12:25 +00:00
jorgep reviewed 2025-01-30 12:17:41 +00:00
@ -175,2 +177,4 @@
.toLowerCase();
}
const searchModule = () => {
const searching = ref(false);
Member

No es necesario que sea ref, usar variable normal.

No es necesario que sea ref, usar variable normal.
Author
Member

arreglado

arreglado
jorgep marked this conversation as resolved
provira added 2 commits 2025-01-30 12:29:17 +00:00
provira added 1 commit 2025-01-30 12:51:57 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
860f92cb42
fix: refs #8410 simplified searchModule function
jorgep reviewed 2025-01-30 12:57:27 +00:00
@ -188,3 +194,4 @@
filled
dense
autofocus
@keyup.enter.stop="search ? searchModule(search) : ''"
Member

llamar solo a la fn searchModule() @keyup.enter.stop="searchModule()"

llamar solo a la fn **searchModule()** `@keyup.enter.stop="searchModule()"`
jorgep marked this conversation as resolved
jorgep requested changes 2025-01-30 12:57:50 +00:00
Dismissed
jorgep left a comment
Member

.

.
provira added 1 commit 2025-01-30 13:00:59 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
374118133a
fix: refs #8410 removed unused condition
provira requested review from jorgep 2025-01-30 13:01:18 +00:00
provira added 1 commit 2025-01-31 04:52:22 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
6cd0df04e6
Merge branch 'dev' into 8410-improveModuleSearchbar
provira added 2 commits 2025-01-31 05:01:44 +00:00
provira added 1 commit 2025-01-31 08:18:07 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
5b2987c95e
Merge branch 'dev' into 8410-improveModuleSearchbar
jorgep reviewed 2025-01-31 08:49:30 +00:00
@ -182,16 +187,18 @@ function normalize(text) {
<template v-if="$route?.matched[1]?.name === 'Dashboard'">
<QItem class="q-pb-md">
<VnInput
ref="searchInput"
Member

si no se usa quitar

si no se usa quitar
Author
Member

quitado

quitado
jorgep requested changes 2025-01-31 08:59:01 +00:00
Dismissed
jorgep left a comment
Member

.

.
provira added 2 commits 2025-01-31 09:10:15 +00:00
provira added 1 commit 2025-01-31 09:10:24 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
4eebfd8769
Merge branch 'dev' into 8410-improveModuleSearchbar
provira requested review from jorgep 2025-01-31 09:12:25 +00:00
jorgep approved these changes 2025-01-31 09:31:02 +00:00
provira added 1 commit 2025-01-31 10:01:30 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
a09f430c60
Merge branch 'dev' into 8410-improveModuleSearchbar
provira merged commit 5ae5cec9f9 into dev 2025-01-31 10:02:50 +00:00
provira deleted branch 8410-improveModuleSearchbar 2025-01-31 10:02:50 +00:00
Sign in to join this conversation.
No reviewers
No Milestone
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix-front#1272
No description provided.