verdnatura/salix-front
verdnatura
/
salix-front
2
3
Fork 1
Code Issues Pull Requests 106 Releases Wiki Activity

feat: #8410 added new feature to module searchbar #1272

Merged
provira merged 18 commits from 8410-improveModuleSearchbar into dev 2025-01-31 10:02:50 +00:00
Conversation 1 Commits 18 Files Changed 1 +12 -27
1 changed files with 12 additions and 27 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 3e8b35e2e1 - Show all commits

39
src/components/LeftMenu.vue
View File

@ -25,6 +25,7 @@ const props = defineProps({
});
const initialized = ref(false);
const items = ref([]);
const searchingValue = ref(false);
const expansionItemElements = reactive({});
const pinnedModules = computed(() => {
const map = new Map();
@ -176,33 +177,16 @@ function normalize(text) {
.toLowerCase();
}
provira marked this conversation as resolved Outdated
jorgep commented 2025-01-23 12:00:40 +00:00
Outdated
Review
Copy Link

Estás haciendo 2 bucles, pasar a 1. Respuesta de copilot:

const searchModule = () => {
    const searching = ref(false);
    items.value.some((item) => {
        const title = getLocale(item.title).normalize('NFD').replace(/[\u0300-\u036f]/g, '').toLowerCase();
        if (title.includes(search.value.toLowerCase()) && !searching.value) {
            searching.value = true;
            router.push({ name: item.name });
            return true; // Termina el bucle al encontrar el primer resultado
        }
        return false;
    });
}
Estás haciendo 2 bucles, pasar a 1. Respuesta de copilot: ``` const searchModule = () => { const searching = ref(false); items.value.some((item) => { const title = getLocale(item.title).normalize('NFD').replace(/[\u0300-\u036f]/g, '').toLowerCase(); if (title.includes(search.value.toLowerCase()) && !searching.value) { searching.value = true; router.push({ name: item.name }); return true; // Termina el bucle al encontrar el primer resultado } return false; }); } ```
const searchModule = () => {
const moduleArrays = ref([]);
items.value.forEach((item) => {
moduleArrays.value.push({
title: getLocale(item.title).normalize('NFD').replace(/[\u0300-\u036f]/g, '').toLowerCase(),
name: item.name
});
})
const searching = ref(false)
moduleArrays.value.find((module) => {
console.log(module.title);
if (module.title.includes(search.value.toLowerCase()) && !searching.value) {
const searching = ref(false);
jorgep marked this conversation as resolved Outdated
jorgep commented 2025-01-30 12:17:41 +00:00
Outdated
Review
Copy Link

No es necesario que sea ref, usar variable normal.

No es necesario que sea ref, usar variable normal.
provira commented 2025-01-30 12:29:25 +00:00
Outdated
Review
Copy Link

arreglado

arreglado
items.value.some((item) => {
const title = normalize(t(item.title));
if (title.includes(search.value.toLowerCase()) && !searching.value) {
searching.value = true;
router.push({ name: module.name });
router.push({ name: item.name });
return true;
}
})
}
const getLocale = (label) => {
const globalLocale = t(label);
return globalLocale;
};
const searchingValue = ref(false);
function searchingFunction(evt) {
searchingValue.value = true;
if(evt === null) {
searchingValue.value = false;
}
return false;
provira marked this conversation as resolved Outdated
jorgep commented 2025-01-23 11:57:35 +00:00
Outdated
Review
Copy Link

Quitar

Quitar
});
}
jorgep commented 2025-01-31 08:49:30 +00:00
Outdated
Review
Copy Link

si no se usa quitar

si no se usa quitar
provira commented 2025-01-31 09:18:56 +00:00
Outdated
Review
Copy Link

quitado

quitado
</script>
@ -212,14 +196,15 @@ function searchingFunction(evt) {
<template v-if="$route?.matched[1]?.name === 'Dashboard'">
provira marked this conversation as resolved Outdated
jorgep commented 2025-01-23 12:07:09 +00:00
Outdated
Review
Copy Link

Solo gastas esta función en 1 sitio, es innecesaria.

Solo gastas esta función en 1 sitio, es innecesaria.
<QItem class="q-pb-md">
jorgep marked this conversation as resolved Outdated
jorgep commented 2025-01-30 12:57:27 +00:00
Outdated
Review
Copy Link

llamar solo a la fn searchModule() @keyup.enter.stop="searchModule()"

llamar solo a la fn **searchModule()** `@keyup.enter.stop="searchModule()"`
<VnInput
ref="searchInput"
v-model="search"
jorgep marked this conversation as resolved Outdated
jorgep commented 2025-01-23 12:04:14 +00:00
Outdated
Review
Copy Link

Las variables ponlas juntas y las funciones lo mismo.

Las variables ponlas juntas y las funciones lo mismo.
:label="t('Search modules')"
provira marked this conversation as resolved Outdated
jorgep commented 2025-01-23 12:05:25 +00:00
Outdated
Review
Copy Link

Solo gastas esta función en 1 sitio, es innecesaria.

Solo gastas esta función en 1 sitio, es innecesaria.
class="full-width"
filled
dense
autofocus
@keyup.enter.stop="searchModule(search)"
@update:model-value="searchingFunction($event)"
@keyup.enter.stop="searchingValue ? searchModule(search) : ''"
@update:model-value="searchingValue = !!$event"
/>
</QItem>
<QSeparator />