#8409: Added VnSelectSupplier #1274

Merged
jon merged 10 commits from 8409-VnSelectSupplier into dev 2025-01-30 14:20:07 +00:00
Member
No description provided.
jon added 1 commit 2025-01-23 13:04:20 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
ac998d33aa
feat: refs #8409 added VnSelectSupplier
jon added 1 commit 2025-01-24 11:16:12 +00:00
jon changed title from #8409: Added VnSelectSupplier to WIP: #8409: Added VnSelectSupplier 2025-01-24 11:18:50 +00:00
jon added 2 commits 2025-01-27 12:21:45 +00:00
jon added 1 commit 2025-01-27 12:26:16 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
3aa8acf02a
fix: refs #8409 deleted code due to merge
jon requested review from jsegarra 2025-01-27 12:27:59 +00:00
jon changed title from WIP: #8409: Added VnSelectSupplier to #8409: Added VnSelectSupplier 2025-01-27 12:28:02 +00:00
jsegarra requested changes 2025-01-27 22:11:32 +00:00
Dismissed
jsegarra left a comment
Member

En gneral revisar formatos de options y optionValue-optionLAbel

En gneral revisar formatos de options y optionValue-optionLAbel
@ -0,0 +3,4 @@
import VnSelect from 'components/common/VnSelect.vue';
const emit = defineEmits(['update:modelValue']);
const $props = defineProps({
Member

nos hace falta defineProps? Porque no defineModel?
Al actualziar el valor ya emite no?
Me vaso para este comentario en VnInputNumber o VnRadio

nos hace falta defineProps? Porque no defineModel? Al actualziar el valor ya emite no? Me vaso para este comentario en VnInputNumber o VnRadio
Member

Okey @jon, queda resolver esto

Okey @jon, queda resolver esto
jon marked this conversation as resolved
@ -62,4 +58,2 @@
:required="true"
map-options
>
<template #option="scope">
Member

Esto es diferente al componente, es correcto?

Esto es diferente al componente, es correcto?
jon marked this conversation as resolved
@ -90,4 +79,2 @@
:required="true"
:rules="validate('entry.supplierFk')"
>
<template #option="scope">
Member

Esto es diferente al componente, es correcto?

Esto es diferente al componente, es correcto?
jon marked this conversation as resolved
@ -65,2 +55,3 @@
option-label="name"
@update:model-value="searchFn()"
hide-selected
dense
Member

dense por defecto no?

dense por defecto no?
jon marked this conversation as resolved
@ -76,4 +69,0 @@
<QItemSection>
<QItemLabel>{{ scope.opt?.nickname }}</QItemLabel>
<QItemLabel caption>
#{{ scope.opt?.id }}
Member

Esto es diferente al componente, es correcto?

Esto es diferente al componente, es correcto?
jon marked this conversation as resolved
@ -192,2 +178,3 @@
/>
<VnInput
:label="t('invoiceIn.list.supplierRef')"
:label="t('invoicein.list.supplierRef')"
Member

bien visto

bien visto
jon marked this conversation as resolved
@ -251,4 +251,2 @@
v-model="params.supplierFk"
@update:model-value="searchFn()"
url="Suppliers"
option-value="id"
Member

el componente usa nickname para option-label

el componente usa nickname para option-label
jon marked this conversation as resolved
@ -129,4 +121,2 @@
:label="t('Autonomous')"
v-model="params.supplierFk"
:options="supplierList"
option-value="name"
Member

porque ya no usamos estos valores?

porque ya no usamos estos valores?
jon marked this conversation as resolved
@ -71,4 +55,0 @@
<QItem v-bind="itemProps">
<QItemSection>
<QItemLabel
>{{ opt.id }} - {{ opt.nickname }}
Member

Otro formato

Otro formato
jon marked this conversation as resolved
Author
Member

image

Los que tienen formato distinto es porque en el componente me he basado en la descripción de la tarea para que todos tengan el mismo template

![image](/attachments/84829aea-b194-4288-90fa-8ce242ad73d1) Los que tienen formato distinto es porque en el componente me he basado en la descripción de la tarea para que todos tengan el mismo template
jon added 1 commit 2025-01-29 10:58:25 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
613ebc0eb4
refactor: refs #8409 use defineModel instead or defineProps
jon added 1 commit 2025-01-29 10:59:53 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
8ada6bd3e3
Merge branch 'dev' into 8409-VnSelectSupplier
jon requested review from jsegarra 2025-01-29 11:06:06 +00:00
jsegarra requested changes 2025-01-29 22:01:02 +00:00
Dismissed
@ -0,0 +6,4 @@
const url = 'Suppliers';
const value = computed({
get() {
return model;
Member

pero...le estamos dando uso a la variable value?

pero...le estamos dando uso a la variable value?
jon added 2 commits 2025-01-30 12:52:30 +00:00
jon requested review from jsegarra 2025-01-30 12:53:49 +00:00
jon added 1 commit 2025-01-30 12:53:59 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
788c6e8b61
Merge branch 'dev' into 8409-VnSelectSupplier
jsegarra approved these changes 2025-01-30 14:00:32 +00:00
jon merged commit 22ae08863b into dev 2025-01-30 14:20:07 +00:00
jon deleted branch 8409-VnSelectSupplier 2025-01-30 14:20:07 +00:00
Sign in to join this conversation.
No reviewers
No Milestone
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix-front#1274
No description provided.