verdnatura/salix-front
verdnatura
/
salix-front
1
2
Fork 1
Code Issues Pull Requests 59 Releases Wiki Activity

DEP: #6172 - Transfer ticket message error #128

Closed
jsegarra wants to merge 14 commits from 6172_transfer_ticket_message_error into dev
pull from: 6172_transfer_ticket_message_error
merge into: verdnatura:dev
Conversation 3 Commits 14 Files Changed 2 +13 -17
jsegarra commented 2023-12-14 18:26:24 +00:00
Member
Copy Link
No description provided.
jsegarra added 1 commit 2023-12-15 08:57:23 +00:00
gitea/salix-front/pipeline/head There was a failure building this commit Details
e525f87ccd refs #6172 feat:enable translation when ticketIsLocked
jsegarra requested review from juan 2023-12-15 08:57:48 +00:00
jsegarra added 1 commit 2023-12-15 08:57:57 +00:00
gitea/salix-front/pipeline/head There was a failure building this commit Details
8cfd775d58 Merge branch 'dev' into 6172_transfer_ticket_message_error
jsegarra changed title from WIP: #6172 - Transfer ticket message error to #6172 - Transfer ticket message error 2023-12-15 08:58:05 +00:00
jsegarra changed title from #6172 - Transfer ticket message error to WIP: #6172 - Transfer ticket message error 2023-12-15 09:00:43 +00:00
jsegarra added 2 commits 2023-12-15 09:08:00 +00:00
jsegarra added 1 commit 2023-12-15 09:09:17 +00:00
gitea/salix-front/pipeline/head There was a failure building this commit Details
ca314c65d8 refs #6172 perf: remove message code
jsegarra changed title from WIP: #6172 - Transfer ticket message error to #6172 - Transfer ticket message error 2023-12-15 09:09:42 +00:00
jgallego requested changes 2023-12-15 10:01:56 +00:00
Dismissed
src/i18n/en/index.js Outdated
@ -71,6 +71,7 @@ export default {
statusGatewayTimeout: 'Could not contact the server',
userConfig: 'Error fetching user config',
create: 'Error during creation',
'This ticket is locked.': 'This ticket is locked',
jgallego commented 2023-12-15 10:01:53 +00:00
Owner
Copy Link

se decide que no haya claves con signos de puntuacion.

se decide que no haya claves con signos de puntuacion.
jsegarra marked this conversation as resolved
jgallego requested changes 2023-12-15 10:03:54 +00:00
Dismissed
src/boot/axios.js Outdated
@ -58,1 +54,4 @@
break;
default:
message = `errors.${dataError?.message.replace(/\.*$/, '')}`;
jgallego commented 2023-12-15 10:03:50 +00:00
Owner
Copy Link

eliminar funcion replace

eliminar funcion replace
jsegarra marked this conversation as resolved
jsegarra added 1 commit 2023-12-15 11:11:18 +00:00
gitea/salix-front/pipeline/head There was a failure building this commit Details
897d410ee6 refs #6434 perf: remove replace function 
Será efectivo el cambio cuando se modifique en salix-back
jsegarra requested review from jgallego 2023-12-15 11:13:17 +00:00
jsegarra added a new dependency 2023-12-15 11:13:30 +00:00
#113 WIP: 5895-jsdoc
jsegarra removed a dependency 2023-12-15 11:13:35 +00:00
#113 WIP: 5895-jsdoc
jsegarra added a new dependency 2023-12-15 11:52:01 +00:00
verdnatura/salix#1894 - #5878 - Remove . for This ticket is locked
jsegarra added 1 commit 2023-12-20 13:47:52 +00:00
gitea/salix-front/pipeline/head This commit looks good Details
1c9493839d refs #6172 test: fix test
juan requested changes 2023-12-22 09:25:44 +00:00
Dismissed
juan left a comment
Owner
Copy Link

El encargado de traducir los mensajes de back debe ser el back, hay que replantear la tarea

El encargado de traducir los mensajes de back debe ser el back, hay que replantear la tarea
jsegarra added 1 commit 2023-12-22 10:20:27 +00:00
gitea/salix-front/pipeline/head This commit looks good Details
1b0cfa0d86 Merge branch 'dev' into 6172_transfer_ticket_message_error
jsegarra commented 2023-12-22 12:44:14 +00:00
Author
Member
Copy Link

El encargado de traducir los mensajes de back debe ser el back, hay que replantear la tarea

La manera de enfocar esta tarea ha sido igual que en su momento para el repositorio de salix. El back devuelve un mensaje y el front lo traduce.

Lo que comentas es que antes de devolver el mensaje de error, este se traduzca?.

Diría que eso no está pasando, porque cuando se hace un throw new %Error, se envía el err como tal. Sólo se traduce cuando es un UserError o err.statusCode= 422
image

Se puede hacer que en err-handler.js, se traduzca el mensaje antes de enviarlo para cualquier statusCode.

Tanto en salix como en lilium, no se rompería nada porque si la key no existe, muestra el mensaje, correcto?

> El encargado de traducir los mensajes de back debe ser el back, hay que replantear la tarea La manera de enfocar esta tarea ha sido igual que en su momento para el repositorio de salix. El back devuelve un mensaje y el front lo traduce. Lo que comentas es que antes de devolver el mensaje de error, este se traduzca?. Diría que eso no está pasando, porque cuando se hace un throw new %Error, se envía el err como tal. Sólo se traduce cuando es un UserError o err.statusCode= 422 ![image](/attachments/ccfcedbf-947e-4cde-8ba5-8e42408d5b97) Se puede hacer que en err-handler.js, se traduzca el mensaje antes de enviarlo para cualquier statusCode. Tanto en salix como en lilium, no se rompería nada porque si la key no existe, muestra el mensaje, correcto?
jsegarra added 1 commit 2024-01-02 11:00:39 +00:00
gitea/salix-front/pipeline/head This commit looks good Details
31d000b65f refs #6172 perf: remove translation
jsegarra added 1 commit 2024-01-02 11:23:43 +00:00
gitea/salix-front/pipeline/head This commit looks good Details
8631b642eb Merge branch 'dev' into 6172_transfer_ticket_message_error
jgallego commented 2024-01-02 13:23:54 +00:00
Owner
Copy Link

El encargado de traducir los mensajes de back debe ser el back, hay que replantear la tarea

El contexto de la tarea ha cambiado, crear redmine para resolverlo

> El encargado de traducir los mensajes de back debe ser el back, hay que replantear la tarea El contexto de la tarea ha cambiado, crear redmine para resolverlo
jsegarra added 1 commit 2024-01-02 13:55:56 +00:00
gitea/salix-front/pipeline/head This commit looks good Details
44e9c5f3d9 refs #6172 perf: clean code axios.js
jsegarra added 1 commit 2024-01-03 07:08:25 +00:00
gitea/salix-front/pipeline/head This commit looks good Details
da00a3f05f Merge branch 'dev' into 6172_transfer_ticket_message_error
jsegarra changed title from #6172 - Transfer ticket message error to WIP: #6172 - Transfer ticket message error 2024-01-03 07:08:26 +00:00
jsegarra added a new dependency 2024-01-03 07:08:47 +00:00
verdnatura/salix#1908 - #6613 - Translations should be in back
jsegarra commented 2024-01-03 08:23:50 +00:00
Author
Member
Copy Link

#6613

#6613
jsegarra added 1 commit 2024-01-03 08:24:45 +00:00
gitea/salix-front/pipeline/head This commit looks good Details
387d7a33e6 Merge branch 'dev' into 6172_transfer_ticket_message_error
jsegarra changed title from WIP: #6172 - Transfer ticket message error to DEP: #6172 - Transfer ticket message error 2024-01-03 08:25:11 +00:00
jsegarra requested review from juan 2024-01-08 09:12:00 +00:00
jgallego added 1 commit 2024-01-10 08:20:32 +00:00
gitea/salix-front/pipeline/head This commit looks good Details
02272143d3 Merge branch 'dev' into 6172_transfer_ticket_message_error
jgallego refused to review 2024-01-10 08:21:52 +00:00
jgallego removed review request for juan 2024-01-10 08:21:54 +00:00
jgallego dismissed juan’s review 2024-01-10 08:22:07 +00:00
Reason:

obsoleto

jgallego dismissed jgallego’s review 2024-01-10 08:22:15 +00:00
Reason:

obsoleto

jgallego dismissed jgallego’s review 2024-01-10 08:22:34 +00:00
Reason:

obsoleto

jgallego removed a dependency 2024-01-10 08:23:54 +00:00
verdnatura/salix#1908 - #6613 - Translations should be in back
jgallego closed this pull request 2024-01-10 08:23:59 +00:00
Some checks are pending
gitea/salix-front/pipeline/head This commit looks good
Details
gitea/salix-front/pipeline/pr-*
Required

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
juan
Labels
Clear labels   
bug

Something is not working

  
CR / Tests passed

CR / Tests passed

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
invalid

Something is wrong

  
Missing Tests

Missing Tests

  
wontfix

This won't be fixed

No Label
bug
CR / Tests passed
duplicate
enhancement
invalid
Missing Tests
wontfix
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
4 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Depends on
#1894 #5878 - Remove . for This ticket is locked
verdnatura/salix
Reference: verdnatura/salix-front#128
No description provided.
Delete Branch "6172_transfer_ticket_message_error"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?